Update for the yazpp_1 namespace.
[yazproxy-moved-to-github.git] / src / yaz-proxy.cpp
index f174362..c1cc98f 100644 (file)
@@ -1,4 +1,4 @@
-/* $Id: yaz-proxy.cpp,v 1.25 2005-05-04 08:31:44 adam Exp $
+/* $Id: yaz-proxy.cpp,v 1.29 2005-06-02 06:40:46 adam Exp $
    Copyright (c) 1998-2005, Index Data.
 
 This file is part of the yaz-proxy.
@@ -51,7 +51,47 @@ Free Software Foundation, 59 Temple Place - Suite 330, Boston, MA
 #include <yaz/pquery.h>
 #include <yaz/otherinfo.h>
 #include <yaz/charneg.h>
+#include "msg-thread.h"
 
+using namespace yazpp_1;
+
+class Auth_Msg : public IMsg_Thread {
+public:
+    int m_ret;
+    void destroy();
+    IMsg_Thread *handle();
+    void result();
+    Yaz_Proxy *m_proxy;
+    Z_APDU *m_apdu;
+};
+
+IMsg_Thread *Auth_Msg::handle()
+{
+    yaz_log(YLOG_LOG, "Auth_Msg:handle begin");
+    m_ret = m_proxy->handle_authentication(m_apdu);
+    yaz_log(YLOG_LOG, "Auth_Msg:handle end");
+    return this;
+}
+
+void Yaz_Proxy::result_authentication(Z_APDU *apdu, int ret)
+{
+    if (ret == 0)
+    {
+       Z_APDU *apdu_reject = zget_APDU(odr_encode(), Z_APDU_initResponse);
+       *apdu_reject->u.initResponse->result = 0;
+       send_to_client(apdu_reject);
+       shutdown();
+    }
+    else
+       handle_incoming_Z_PDU_2(apdu);
+}
+
+void Auth_Msg::result()
+{
+    yaz_log(YLOG_LOG, "Auth_Msg:result");
+    m_proxy->result_authentication(m_apdu, m_ret);
+    delete this;
+}
 
 static const char *apdu_name(Z_APDU *apdu)
 {
@@ -104,11 +144,15 @@ static const char *gdu_name(Z_GDU *gdu)
     }
     return "Unknown request/response";
 }
+
 Yaz_Proxy::Yaz_Proxy(IYaz_PDU_Observable *the_PDU_Observable,
-                    Yaz_Proxy *parent) :
+                    IYazSocketObservable *the_socket_observable,
+                    Yaz_Proxy *parent) 
+    :
     Yaz_Z_Assoc(the_PDU_Observable), m_bw_stat(60), m_pdu_stat(60)
 {
     m_PDU_Observable = the_PDU_Observable;
+    m_socket_observable = the_socket_observable;
     m_client = 0;
     m_parent = parent;
     m_clientPool = 0;
@@ -127,7 +171,7 @@ Yaz_Proxy::Yaz_Proxy(IYaz_PDU_Observable *the_PDU_Observable,
     m_target_idletime = 600;
     m_optimize = xstrdup ("1");
     strcpy(m_session_str, "0 ");
-    m_session_no=0;
+    m_session_no = 0;
     m_bytes_sent = 0;
     m_bytes_recv = 0;
     m_bw_hold_PDU = 0;
@@ -185,6 +229,7 @@ Yaz_Proxy::Yaz_Proxy(IYaz_PDU_Observable *the_PDU_Observable,
     m_usemarcon = new Yaz_usemarcon();
     if (!m_parent)
        low_socket_open();
+    m_my_thread = 0;
 }
 
 Yaz_Proxy::~Yaz_Proxy()
@@ -220,6 +265,8 @@ Yaz_Proxy::~Yaz_Proxy()
        odr_destroy(m_s2z_odr_search);
     if (!m_parent)
        low_socket_close();
+    if (!m_parent)
+       delete m_my_thread;
     delete m_config;
 }
 
@@ -295,7 +342,8 @@ IYaz_PDU_Observer *Yaz_Proxy::sessionNotify(IYaz_PDU_Observable
                                            *the_PDU_Observable, int fd)
 {
     check_reconfigure();
-    Yaz_Proxy *new_proxy = new Yaz_Proxy(the_PDU_Observable, this);
+    Yaz_Proxy *new_proxy = new Yaz_Proxy(the_PDU_Observable,
+                                        m_socket_observable, this);
     new_proxy->m_config = 0;
     new_proxy->m_config_fname = 0;
     new_proxy->timeout(m_client_idletime);
@@ -314,6 +362,10 @@ IYaz_PDU_Observer *Yaz_Proxy::sessionNotify(IYaz_PDU_Observable
             the_PDU_Observable->getpeername());
     new_proxy->set_proxy_negotiation(m_proxy_negotiation_charset,
        m_proxy_negotiation_lang);
+    // create thread object the first time we get an incoming connection
+    if (!m_my_thread)
+       m_my_thread = new Msg_Thread(m_socket_observable);
+    new_proxy->m_my_thread = m_my_thread;
     return new_proxy;
 }
 
@@ -390,12 +442,6 @@ const char *Yaz_Proxy::load_balance(const char **url)
            max_spare = zurl_in_spare[i];
        }
     }
-    // use the one with minimum connections if spare is > 3
-    if (spare_for_min > 3)
-       return ret_min;
-    // use one with most spares (if any)
-    if (max_spare > 0)
-       return ret_spare;
     return ret_min;
 }
 
@@ -453,7 +499,6 @@ Yaz_ProxyClient *Yaz_Proxy::get_client(Z_APDU *apdu, const char *cookie,
            m_cql2rpn.set_pqf_file(cql2rpn_fname);
        if (negotiation_charset || negotiation_lang)
        {
-           yaz_log(YLOG_LOG, "set_proxy_negotiation...");
            set_proxy_negotiation(negotiation_charset,
                negotiation_lang);
        }
@@ -665,6 +710,7 @@ Yaz_ProxyClient *Yaz_Proxy::get_client(Z_APDU *apdu, const char *cookie,
     yaz_log (YLOG_DEBUG, "get_client 3 %p %p", this, c);
     return c;
 }
+
 void Yaz_Proxy::display_diagrecs(Z_DiagRec **pp, int num)
 {
     int i;
@@ -842,6 +888,74 @@ void Yaz_Proxy::convert_to_frontend_type(Z_NamePlusRecordList *p)
     }
 }
 
+void Yaz_Proxy::convert_records_charset(Z_NamePlusRecordList *p,
+                                       const char *backend_charset)
+{
+    yaz_log(YLOG_LOG, "%sconvert_to_marc", m_session_str);
+    int sel =  m_charset_converter->get_client_charset_selected();
+    const char *client_record_charset =
+       m_charset_converter->get_client_query_charset();
+    if (sel && backend_charset && client_record_charset &&
+       strcmp(backend_charset, client_record_charset))
+    {
+       int i;
+       yaz_iconv_t cd = yaz_iconv_open(client_record_charset,
+                                       backend_charset);
+       yaz_marc_t mt = yaz_marc_create();
+       yaz_marc_xml(mt, YAZ_MARC_ISO2709);
+       yaz_marc_iconv(mt, cd);
+       for (i = 0; i < p->num_records; i++)
+       {
+           Z_NamePlusRecord *npr = p->records[i];
+           if (npr->which == Z_NamePlusRecord_databaseRecord)
+           {
+               Z_External *r = npr->u.databaseRecord;
+               oident *ent = oid_getentbyoid(r->direct_reference);
+               if (!ent || ent->value == VAL_NONE)
+                   continue;
+
+               if (ent->value == VAL_SUTRS)
+               {
+                   WRBUF w = wrbuf_alloc();
+
+                   wrbuf_iconv_write(w, cd,  (char*) r->u.octet_aligned->buf,
+                                     r->u.octet_aligned->len);
+                   npr->u.databaseRecord =
+                       z_ext_record(odr_encode(), ent->value, wrbuf_buf(w),
+                                    wrbuf_len(w));
+                   wrbuf_free(w, 1);
+               }
+               else if (ent->value == VAL_TEXT_XML)
+               {
+                   ;
+               }
+               else if (r->which == Z_External_octet)
+               {
+                   int rlen;
+                   char *result;
+                   if (yaz_marc_decode_buf(mt,
+                                           (char*) r->u.octet_aligned->buf,
+                                           r->u.octet_aligned->len,
+                                           &result, &rlen))
+                   {
+                       npr->u.databaseRecord =
+                           z_ext_record(odr_encode(), ent->value, result, rlen);
+                       yaz_log(YLOG_LOG, "%sRecoding MARC record",
+                               m_session_str);
+                   }
+               }
+           }
+       }
+       if (cd)
+           yaz_iconv_close(cd);
+       yaz_marc_destroy(mt);
+    }
+    else
+    {
+       yaz_log(YLOG_LOG, "%sSkipping marc convert", m_session_str);
+    }
+}
+
 void Yaz_Proxy::convert_to_marcxml(Z_NamePlusRecordList *p,
                                   const char *backend_charset)
 {
@@ -1200,6 +1314,9 @@ int Yaz_Proxy::send_to_client(Z_APDU *apdu)
                if (m_marcxml_mode == marcxml)
                    convert_to_marcxml(p->u.databaseOrSurDiagnostics,
                                       m_backend_charset);
+               else
+                   convert_records_charset(p->u.databaseOrSurDiagnostics,
+                                           m_backend_charset);
                if (convert_xsl(p->u.databaseOrSurDiagnostics, apdu))
                    return 0;
                    
@@ -1245,6 +1362,9 @@ int Yaz_Proxy::send_to_client(Z_APDU *apdu)
            if (m_marcxml_mode == marcxml)
                convert_to_marcxml(p->u.databaseOrSurDiagnostics,
                                   m_backend_charset);
+           else
+               convert_records_charset(p->u.databaseOrSurDiagnostics,
+                                       m_backend_charset);
            if (convert_xsl(p->u.databaseOrSurDiagnostics, apdu))
                return 0;
        }
@@ -1635,11 +1755,13 @@ void Yaz_Proxy::handle_charset_lang_negotiation(Z_APDU *apdu)
 {
     if (apdu->which == Z_APDU_initRequest)
     {
+       yaz_log(YLOG_LOG, "%shandle_charset_lang_negotiation", 
+               m_session_str);
        if (m_initRequest_options &&
            !ODR_MASK_GET(m_initRequest_options, Z_Options_negotiationModel) &&
            (m_proxy_negotiation_charset || m_proxy_negotiation_lang))
        {
-           // There is not negotiation proposal from
+           // There is no negotiation proposal from
            // client's side. OK. The proxy negotiation
            // in use, only.
            Z_InitRequest *initRequest = apdu->u.initRequest;
@@ -1661,6 +1783,66 @@ void Yaz_Proxy::handle_charset_lang_negotiation(Z_APDU *apdu)
                    1);
            }
        }
+       else if (m_initRequest_options &&
+                ODR_MASK_GET(m_initRequest_options,
+                             Z_Options_negotiationModel) &&
+                m_charset_converter->get_target_query_charset())
+       {
+           yaz_log(YLOG_LOG, "%sManaged charset negotiation: charset=%s",
+                   m_session_str,
+                   m_charset_converter->get_target_query_charset());
+           Z_InitRequest *initRequest = apdu->u.initRequest;
+           Z_CharSetandLanguageNegotiation *negotiation =
+               yaz_get_charneg_record (initRequest->otherInfo);        
+           if (negotiation &&
+               negotiation->which == Z_CharSetandLanguageNegotiation_proposal)
+           {
+               NMEM nmem = nmem_create();
+               char **charsets = 0;
+               int num_charsets = 0;
+               char **langs = 0;
+               int num_langs = 0;
+               int selected = 0;
+               yaz_get_proposal_charneg (nmem, negotiation,
+                                         &charsets, &num_charsets,
+                                         &langs, &num_langs, &selected);
+               int i;
+               for (i = 0; i<num_charsets; i++)
+                   yaz_log(YLOG_LOG, "%scharset %s", m_session_str,
+                           charsets[i]);
+               for (i = 0; i<num_langs; i++)
+                   yaz_log(YLOG_LOG, "%slang %s", m_session_str,
+                           langs[i]);
+
+               const char *t_charset =
+                   m_charset_converter->get_target_query_charset();
+               // sweep through charsets and pick the first supported
+               // conversion
+               for (i = 0; i<num_charsets; i++)
+               {
+                   const char *c_charset = charsets[i];
+                   if (!odr_set_charset(odr_decode(), t_charset, c_charset))
+                       break;
+               }
+               if (i != num_charsets)
+               {
+                   // got one .. set up ODR for reverse direction
+                   const char *c_charset = charsets[i];
+                   odr_set_charset(odr_encode(), c_charset, t_charset);
+                   m_charset_converter->set_client_query_charset(c_charset);
+                   m_charset_converter->set_client_charset_selected(selected);
+               }
+               nmem_destroy(nmem);
+               ODR_MASK_CLEAR(m_initRequest_options, 
+                              Z_Options_negotiationModel);
+               yaz_del_charneg_record(&initRequest->otherInfo);
+           }
+           else
+           {
+               yaz_log(YLOG_WARN, "%sUnable to decode charset package",
+                       m_session_str);
+           }
+       }
     }
     else if (apdu->which == Z_APDU_initResponse)
     {
@@ -1708,35 +1890,42 @@ void Yaz_Proxy::handle_charset_lang_negotiation(Z_APDU *apdu)
                ODR_MASK_CLEAR(initResponse->options, Z_Options_negotiationModel);
                
                // Delete negotiation (charneg-3) entry.
-               Z_OtherInformation *p = *otherInfo;
-               for (int i=0; i<p->num_elements; i++)
+               yaz_del_charneg_record(otherInfo);
+           }
+       }
+       else
+       {
+           if (m_proxy_negotiation_charset || m_proxy_negotiation_lang)
+           {
+               yaz_log(YLOG_LOG, "%sTarget did not honor negotiation",
+                       m_session_str);
+           }
+           else if (m_charset_converter->get_client_query_charset())
+           {
+               Z_OtherInformation **otherInfo;  
+               Z_OtherInformationUnit *oi;
+               get_otherInfoAPDU(apdu, &otherInfo);
+               oi = update_otherInformation(otherInfo, 1, NULL, 0, 0);
+               if (oi)
                {
-                   if (p->list[i]->which == Z_OtherInfo_externallyDefinedInfo)
-                   {
-                       Z_External *pext =
-                           p->list[i]->information.externallyDefinedInfo;
-                       struct oident *e = oid_getentbyoid(pext->direct_reference);
-                   
-                       if (e && e->value == VAL_CHARNEG3 && e->oclass == CLASS_NEGOT &&
-                           pext->which == Z_External_charSetandLanguageNegotiation)
-                       {
-                           (p->num_elements)--;                        
-                           if(p->num_elements == 0)
-                           {
-                               *otherInfo = 0;
-                           }
-                           else
-                           {
-                               for (int j=i; j<p->num_elements;j++)
-                                   p->list[j] = p->list[j+1];
-                           }
-                       }
-                   }
-               }    
+                   ODR_MASK_SET(initResponse->options,
+                                Z_Options_negotiationModel);
+                   ODR_MASK_SET(m_initRequest_options,
+                                Z_Options_negotiationModel);
+
+                   oi->which = Z_OtherInfo_externallyDefinedInfo;    
+                   oi->information.externallyDefinedInfo =
+                       yaz_set_response_charneg(
+                           odr_encode(),
+                           m_charset_converter->get_client_query_charset(),
+                           0 /* no lang */,
+                           m_charset_converter->get_client_charset_selected());
+               }
            }
        }
     }
 }
+
 Z_Records *Yaz_Proxy::create_nonSurrogateDiagnostics(ODR odr,
                                                     int error,
                                                     const char *addinfo)
@@ -1805,7 +1994,7 @@ Z_APDU *Yaz_Proxy::handle_query_transformation(Z_APDU *apdu)
     return apdu;
 }
 
-Z_APDU *Yaz_Proxy::handle_query_charset_conversion(Z_APDU *apdu)
+Z_APDU *Yaz_Proxy::handle_target_charset_conversion(Z_APDU *apdu)
 {
     if (apdu->which == Z_APDU_searchRequest &&
        apdu->u.searchRequest->query)
@@ -2465,6 +2654,123 @@ void Yaz_Proxy::handle_incoming_HTTP(Z_HTTP_Request *hreq)
     send_http_response(400);
 }
 
+void Yaz_Proxy::handle_init(Z_APDU *apdu)
+{
+    Z_OtherInformation **oi;
+    get_otherInfoAPDU(apdu, &oi);
+
+    if (apdu->u.initRequest->implementationId)
+       yaz_log(YLOG_LOG, "%simplementationId: %s",
+               m_session_str, apdu->u.initRequest->implementationId);
+    if (apdu->u.initRequest->implementationName)
+       yaz_log(YLOG_LOG, "%simplementationName: %s",
+               m_session_str, apdu->u.initRequest->implementationName);
+    if (apdu->u.initRequest->implementationVersion)
+       yaz_log(YLOG_LOG, "%simplementationVersion: %s",
+               m_session_str, apdu->u.initRequest->implementationVersion);
+    if (m_initRequest_apdu == 0)
+    {
+       if (m_initRequest_mem)
+           nmem_destroy(m_initRequest_mem);
+       
+       m_initRequest_apdu = apdu;
+       m_initRequest_mem = odr_extract_mem(odr_decode());
+       
+       m_initRequest_preferredMessageSize = *apdu->u.initRequest->
+           preferredMessageSize;
+       *apdu->u.initRequest->preferredMessageSize = 1024*1024;
+       m_initRequest_maximumRecordSize = *apdu->u.initRequest->
+           maximumRecordSize;
+       *apdu->u.initRequest->maximumRecordSize = 1024*1024;
+       
+       // Save proposal charsets and langs.
+       if (ODR_MASK_GET(apdu->u.initRequest->options,
+                        Z_Options_negotiationModel))
+       {
+           Z_CharSetandLanguageNegotiation *charSetandLangRecord =
+               yaz_get_charneg_record(*oi);
+           
+           yaz_get_proposal_charneg(m_referenceId_mem,
+                                    charSetandLangRecord,
+                                    &m_initRequest_oi_negotiation_charsets,
+                                    &m_initRequest_oi_negotiation_num_charsets,
+                                    &m_initRequest_oi_negotiation_langs,
+                                    &m_initRequest_oi_negotiation_num_langs,
+                                    &m_initRequest_oi_negotiation_selected);
+           
+           for (int i = 0; i<m_initRequest_oi_negotiation_num_charsets; i++)
+           {
+               yaz_log(YLOG_LOG, "%scharacters set proposal: %s",
+                       m_session_str,(m_initRequest_oi_negotiation_charsets[i])?
+                       m_initRequest_oi_negotiation_charsets[i]:"none");
+           }
+           for (int i=0; i<m_initRequest_oi_negotiation_num_langs; i++)
+           {
+               yaz_log(YLOG_LOG, "%slanguages proposal: %s",
+                       m_session_str, (m_initRequest_oi_negotiation_langs[i])?
+                       m_initRequest_oi_negotiation_langs[i]:"none");
+           }
+           yaz_log(YLOG_LOG, "%sselected proposal: %d (boolean)",
+                   m_session_str, m_initRequest_oi_negotiation_selected);
+       }       
+       // save init options for the response..
+       m_initRequest_options = apdu->u.initRequest->options;
+       
+       apdu->u.initRequest->options = 
+           (Odr_bitmask *)nmem_malloc(m_initRequest_mem,
+                                      sizeof(Odr_bitmask));
+       ODR_MASK_ZERO(apdu->u.initRequest->options);
+       int i;
+       for (i = 0; i<= 24; i++)
+           ODR_MASK_SET(apdu->u.initRequest->options, i);
+       // check negotiation option
+       if (!ODR_MASK_GET(m_initRequest_options,
+                         Z_Options_negotiationModel))
+       {
+           ODR_MASK_CLEAR(apdu->u.initRequest->options,
+                          Z_Options_negotiationModel);
+       }
+       ODR_MASK_CLEAR(apdu->u.initRequest->options,
+                      Z_Options_concurrentOperations);
+       // make new version
+       m_initRequest_version = apdu->u.initRequest->protocolVersion;
+       apdu->u.initRequest->protocolVersion = 
+           (Odr_bitmask *)nmem_malloc(m_initRequest_mem,
+                                      sizeof(Odr_bitmask));
+       ODR_MASK_ZERO(apdu->u.initRequest->protocolVersion);
+       
+       for (i = 0; i<= 8; i++)
+           ODR_MASK_SET(apdu->u.initRequest->protocolVersion, i);
+    }
+    if (m_client->m_init_flag)
+    {
+       if (handle_init_response_for_invalid_session(apdu))
+           return;
+       if (m_client->m_initResponse)
+       {
+           Z_APDU *apdu2 = m_client->m_initResponse;
+           apdu2->u.initResponse->otherInfo = 0;
+           if (m_client->m_cookie && *m_client->m_cookie)
+               set_otherInformationString(apdu2, VAL_COOKIE, 1,
+                                          m_client->m_cookie);
+           apdu2->u.initResponse->referenceId =
+               apdu->u.initRequest->referenceId;
+           apdu2->u.initResponse->options = m_client->m_initResponse_options;
+           apdu2->u.initResponse->protocolVersion = 
+               m_client->m_initResponse_version;
+           
+           send_to_client(apdu2);
+           return;
+       }
+    }
+    m_client->m_init_flag = 1;
+    
+    Auth_Msg *m = new Auth_Msg;
+    m->m_apdu = apdu;
+    m->m_proxy = this;
+    m_my_thread->put(m);
+}
+
 void Yaz_Proxy::handle_incoming_Z_PDU(Z_APDU *apdu)
 {
     Z_ReferenceId **refid = get_referenceIdP(apdu);
@@ -2509,126 +2815,15 @@ void Yaz_Proxy::handle_incoming_Z_PDU(Z_APDU *apdu)
     m_client->m_server = this;
 
     if (apdu->which == Z_APDU_initRequest)
-    {
-       if (apdu->u.initRequest->implementationId)
-           yaz_log(YLOG_LOG, "%simplementationId: %s",
-                   m_session_str, apdu->u.initRequest->implementationId);
-       if (apdu->u.initRequest->implementationName)
-           yaz_log(YLOG_LOG, "%simplementationName: %s",
-                   m_session_str, apdu->u.initRequest->implementationName);
-       if (apdu->u.initRequest->implementationVersion)
-           yaz_log(YLOG_LOG, "%simplementationVersion: %s",
-                   m_session_str, apdu->u.initRequest->implementationVersion);
-       if (m_initRequest_apdu == 0)
-       {
-           if (m_initRequest_mem)
-               nmem_destroy(m_initRequest_mem);
-
-           m_initRequest_apdu = apdu;
-           m_initRequest_mem = odr_extract_mem(odr_decode());
-
-           m_initRequest_preferredMessageSize = *apdu->u.initRequest->
-               preferredMessageSize;
-           *apdu->u.initRequest->preferredMessageSize = 1024*1024;
-           m_initRequest_maximumRecordSize = *apdu->u.initRequest->
-               maximumRecordSize;
-           *apdu->u.initRequest->maximumRecordSize = 1024*1024;
-                   
-           // Save proposal charsets and langs.
-           if (ODR_MASK_GET(apdu->u.initRequest->options,
-               Z_Options_negotiationModel))
-           {
-               Z_CharSetandLanguageNegotiation *charSetandLangRecord =
-                   yaz_get_charneg_record(*oi);
-    
-               yaz_get_proposal_charneg(m_referenceId_mem,
-                   charSetandLangRecord,
-                   &m_initRequest_oi_negotiation_charsets,
-                   &m_initRequest_oi_negotiation_num_charsets,
-                   &m_initRequest_oi_negotiation_langs,
-                   &m_initRequest_oi_negotiation_num_langs,
-                   &m_initRequest_oi_negotiation_selected);
-       
-               for (int i=0; i<m_initRequest_oi_negotiation_num_charsets; i++)
-               {
-                   yaz_log(YLOG_LOG, "%scharacters set proposal: %s",
-                       m_session_str,(m_initRequest_oi_negotiation_charsets[i])?
-                       m_initRequest_oi_negotiation_charsets[i]:"none");
-               }
-               for (int i=0; i<m_initRequest_oi_negotiation_num_langs; i++)
-               {
-                   yaz_log(YLOG_LOG, "%slanguages proposal: %s",
-                       m_session_str, (m_initRequest_oi_negotiation_langs[i])?
-                       m_initRequest_oi_negotiation_langs[i]:"none");
-               }
-               yaz_log(YLOG_LOG, "%sselected proposal: %d (boolean)",
-                   m_session_str, m_initRequest_oi_negotiation_selected);
-           }   
-           // save init options for the response..
-           m_initRequest_options = apdu->u.initRequest->options;
-           
-           apdu->u.initRequest->options = 
-               (Odr_bitmask *)nmem_malloc(m_initRequest_mem,
-                                          sizeof(Odr_bitmask));
-           ODR_MASK_ZERO(apdu->u.initRequest->options);
-           int i;
-           for (i = 0; i<= 24; i++)
-               ODR_MASK_SET(apdu->u.initRequest->options, i);
-           // check negotiation option
-           if (!ODR_MASK_GET(m_initRequest_options,
-               Z_Options_negotiationModel))
-           {
-               ODR_MASK_CLEAR(apdu->u.initRequest->options,
-                   Z_Options_negotiationModel);
-           }
-           ODR_MASK_CLEAR(apdu->u.initRequest->options,
-               Z_Options_concurrentOperations);
-           // make new version
-           m_initRequest_version = apdu->u.initRequest->protocolVersion;
-           apdu->u.initRequest->protocolVersion = 
-               (Odr_bitmask *)nmem_malloc(m_initRequest_mem,
-                                          sizeof(Odr_bitmask));
-           ODR_MASK_ZERO(apdu->u.initRequest->protocolVersion);
-
-           for (i = 0; i<= 8; i++)
-               ODR_MASK_SET(apdu->u.initRequest->protocolVersion, i);
-       }
-       if (m_client->m_init_flag)
-       {
-           if (handle_init_response_for_invalid_session(apdu))
-               return;
-           if (m_client->m_initResponse)
-           {
-               Z_APDU *apdu2 = m_client->m_initResponse;
-               apdu2->u.initResponse->otherInfo = 0;
-               if (m_client->m_cookie && *m_client->m_cookie)
-                   set_otherInformationString(apdu2, VAL_COOKIE, 1,
-                                              m_client->m_cookie);
-               apdu2->u.initResponse->referenceId =
-                   apdu->u.initRequest->referenceId;
-               apdu2->u.initResponse->options = m_client->m_initResponse_options;
-               apdu2->u.initResponse->protocolVersion = 
-                   m_client->m_initResponse_version;
-               
-               send_to_client(apdu2);
-               return;
-           }
-       }
-       m_client->m_init_flag = 1;
-    }
-    
-    if (!handle_authentication(apdu))
-    {
-       Z_APDU *apdu_reject = zget_APDU(odr_encode(), Z_APDU_initResponse);
-       *apdu_reject->u.initResponse->result = 0;
-       send_to_client(apdu_reject);
-
-       shutdown();
-       return;
-    }
+       handle_init(apdu);
+    else
+       handle_incoming_Z_PDU_2(apdu);
+}
 
+void Yaz_Proxy::handle_incoming_Z_PDU_2(Z_APDU *apdu)
+{
     handle_max_record_retrieve(apdu);
-
+    
     if (apdu)
        apdu = handle_syntax_validation(apdu);
 
@@ -2636,7 +2831,7 @@ void Yaz_Proxy::handle_incoming_Z_PDU(Z_APDU *apdu)
        apdu = handle_query_transformation(apdu);
 
     if (apdu)
-       apdu = handle_query_charset_conversion(apdu);
+       apdu = handle_target_charset_conversion(apdu);
 
     if (apdu)
        apdu = handle_query_validation(apdu);
@@ -2651,11 +2846,12 @@ void Yaz_Proxy::handle_incoming_Z_PDU(Z_APDU *apdu)
        return;
     }
     // Add otherInformation entry in APDU if
-    // negotiatoin in use.
+    // negotiation is in use.
     if (apdu)
        handle_charset_lang_negotiation(apdu);
 
     // delete other info construct completely if 0 elements
+    Z_OtherInformation **oi;
     get_otherInfoAPDU(apdu, &oi);
     if (oi && *oi && (*oi)->num_elements == 0)
         *oi = 0;