Remove trailing whitespace
[phpyaz-moved-to-github.git] / php_yaz.c
index ea71892..a425175 100644 (file)
--- a/php_yaz.c
+++ b/php_yaz.c
@@ -2,12 +2,12 @@
    +----------------------------------------------------------------------+
    | PHP Version 5                                                        |
    +----------------------------------------------------------------------+
-   | Copyright (c) 1997-2004 The PHP Group                                |
+   | Copyright (c) 1997-2011 The PHP Group                                |
    +----------------------------------------------------------------------+
-   | This source file is subject to version 3.0 of the PHP license,       |
+   | This source file is subject to version 3.01 of the PHP license,       |
    | that is bundled with this package in the file LICENSE, and is        |
    | available through the world-wide-web at the following url:           |
-   | http://www.php.net/license/3_0.txt.                                  |
+   | http://www.php.net/license/3_01.txt.                                  |
    | If you did not receive a copy of the PHP license and are unable to   |
    | obtain it through the world-wide-web, please send a note to          |
    | license@php.net so we can mail you a copy immediately.               |
@@ -16,8 +16,6 @@
    +----------------------------------------------------------------------+
  */
 
-/* $Id: php_yaz.c,v 1.115 2008/02/20 10:08:15 dickmeiss Exp $ */
-
 #ifdef HAVE_CONFIG_H
 #include "config.h"
 #endif
 
 #define MAX_ASSOC 200
 
+#define GET_PARM1(a) zend_parse_parameters(1 TSRMLS_CC , "z", a)
+#define GET_PARM2(a,b) zend_parse_parameters(2 TSRMLS_CC, "zz", a, b)
+#define GET_PARM3(a,b,c) zend_parse_parameters(3 TSRMLS_CC, "zzz", a, b, c)
+#define GET_PARM4(a,b,c,d) zend_parse_parameters(4 TSRMLS_CC, "zzzz", a, b, c, d)
+
 typedef struct Yaz_AssociationInfo *Yaz_Association;
 
 struct Yaz_AssociationInfo {
@@ -74,9 +77,9 @@ struct Yaz_AssociationInfo {
 
 static Yaz_Association yaz_association_mk()
 {
-       Yaz_Association p = xmalloc (sizeof(*p));
+       Yaz_Association p = xmalloc(sizeof(*p));
 
-       p->zoom_conn = ZOOM_connection_create (0);
+       p->zoom_conn = ZOOM_connection_create(0);
        p->zoom_set = 0;
        p->zoom_scan = 0;
        p->zoom_package = 0;
@@ -91,7 +94,7 @@ static Yaz_Association yaz_association_mk()
        return p;
 }
 
-static void yaz_association_destroy (Yaz_Association p)
+static void yaz_association_destroy(Yaz_Association p)
 {
        if (!p) {
                return;
@@ -145,7 +148,7 @@ static unsigned char third_argument_force_ref[] = {
 #endif
 
 
-function_entry yaz_functions [] = {
+zend_function_entry yaz_functions [] = {
        PHP_FE(yaz_connect, NULL)
        PHP_FE(yaz_close, NULL)
        PHP_FE(yaz_search, NULL)
@@ -174,13 +177,13 @@ function_entry yaz_functions [] = {
        {NULL, NULL, NULL}
 };
 
-static void get_assoc(INTERNAL_FUNCTION_PARAMETERS, pval *id, Yaz_Association *assocp)
+static void get_assoc(INTERNAL_FUNCTION_PARAMETERS, zval *id, Yaz_Association *assocp)
 {
        Yaz_Association *as = 0;
-       
+
        *assocp = 0;
 #ifdef ZTS
-       tsrm_mutex_lock (yaz_mutex);
+       tsrm_mutex_lock(yaz_mutex);
 #endif
 
        ZEND_FETCH_RESOURCE(as, Yaz_Association *, &id, -1, "YAZ link", le_link);
@@ -189,7 +192,7 @@ static void get_assoc(INTERNAL_FUNCTION_PARAMETERS, pval *id, Yaz_Association *a
                *assocp = *as;
        } else {
 #ifdef ZTS
-               tsrm_mutex_unlock (yaz_mutex);
+               tsrm_mutex_unlock(yaz_mutex);
 #endif
                php_error_docref(NULL TSRMLS_CC, E_WARNING, "Invalid YAZ handle");
        }
@@ -206,7 +209,7 @@ static void release_assoc(Yaz_Association assoc)
 
 static const char *array_lookup_string(HashTable *ht, const char *idx)
 {
-       pval **pvalue;
+       zval **pvalue;
 
        if (ht && zend_hash_find(ht, (char *) idx, strlen(idx) + 1, (void **) &pvalue) == SUCCESS) {
                SEPARATE_ZVAL(pvalue);
@@ -218,7 +221,7 @@ static const char *array_lookup_string(HashTable *ht, const char *idx)
 
 static long *array_lookup_long(HashTable *ht, const char *idx)
 {
-       pval **pvalue;
+       zval **pvalue;
 
        if (ht && zend_hash_find(ht, (char *) idx, strlen(idx) + 1, (void **) &pvalue) == SUCCESS) {
                SEPARATE_ZVAL(pvalue);
@@ -230,7 +233,7 @@ static long *array_lookup_long(HashTable *ht, const char *idx)
 
 static long *array_lookup_bool(HashTable *ht, const char *idx)
 {
-       pval **pvalue;
+       zval **pvalue;
 
        if (ht && zend_hash_find(ht, (char *) idx, strlen(idx) + 1, (void **) &pvalue) == SUCCESS) {
                SEPARATE_ZVAL(pvalue);
@@ -273,7 +276,7 @@ static void option_set_int(Yaz_Association as, const char *name, int v)
        if (as) {
                char s[30];
 
-               sprintf (s, "%d", v);
+               sprintf(s, "%d", v);
                ZOOM_connection_option_set(as->zoom_conn, name, s);
        }
 }
@@ -306,28 +309,26 @@ PHP_FUNCTION(yaz_connect)
        const char *preferredMessageSize = 0;
        int persistent = 1;
        int piggyback = 1;
-       pval *zurl, *user = 0;
+       zval *zurl, *user = 0;
        Yaz_Association as;
        int max_links = YAZSG(max_links);
 
        otherInfo[0] = otherInfo[1] = otherInfo[2] = 0;
 
        if (ZEND_NUM_ARGS() == 1) {
-               if (zend_parse_parameters(1, "z", &zurl)
-                       == FAILURE) {
+               if (GET_PARM1(&zurl) == FAILURE) {
                        WRONG_PARAM_COUNT;
                }
        } else if (ZEND_NUM_ARGS() == 2) {
-               if (zend_parse_parameters(2, "zz", &zurl, &user)
-                       == FAILURE) {
+               if (GET_PARM2(&zurl, &user) == FAILURE) {
                        WRONG_PARAM_COUNT;
                }
-               
+
                if (Z_TYPE_PP(&user) == IS_ARRAY) {
                        long *persistent_val;
                        long *piggyback_val;
                        HashTable *ht = Z_ARRVAL_PP(&user);
-                       
+
                        sru_str = array_lookup_string(ht, "sru");
                        sru_version_str = array_lookup_string(ht, "sru_version");
                        user_str = array_lookup_string(ht, "user");
@@ -403,9 +404,9 @@ PHP_FUNCTION(yaz_connect)
                        if (i == -1) {
                                char msg[80];
 #ifdef ZTS
-                               tsrm_mutex_unlock (yaz_mutex);
+                               tsrm_mutex_unlock(yaz_mutex);
 #endif
-                               sprintf(msg, "No YAZ handles available. max_links=%d", 
+                               sprintf(msg, "No YAZ handles available. max_links=%d",
                                                max_links);
                                php_error_docref(NULL TSRMLS_CC, E_WARNING,
                                                                 "No YAZ handles available. max_links=%ld",
@@ -415,7 +416,7 @@ PHP_FUNCTION(yaz_connect)
                                yaz_association_destroy(shared_associations[i]);
                        }
                }
-               shared_associations[i] = as = yaz_association_mk ();
+               shared_associations[i] = as = yaz_association_mk();
 
                option_set(as, "proxy", proxy_str);
                option_set(as, "sru", sru_str);
@@ -449,7 +450,7 @@ PHP_FUNCTION(yaz_connect)
                as->zoom_set = 0;
        }
 #ifdef ZTS
-       tsrm_mutex_unlock (yaz_mutex);
+       tsrm_mutex_unlock(yaz_mutex);
 #endif
 
        ZEND_REGISTER_RESOURCE(return_value, &shared_associations[i], le_link);
@@ -462,12 +463,12 @@ PHP_FUNCTION(yaz_connect)
 PHP_FUNCTION(yaz_close)
 {
        Yaz_Association p;
-       pval *id;
+       zval *id;
 
        if (ZEND_NUM_ARGS() != 1) {
                WRONG_PARAM_COUNT;
        }
-       if (zend_parse_parameters(1, "z", &id) == FAILURE) {
+       if (GET_PARM1(&id) == FAILURE) {
                RETURN_FALSE;
        }
        get_assoc(INTERNAL_FUNCTION_PARAM_PASSTHRU, id, &p);
@@ -486,12 +487,11 @@ PHP_FUNCTION(yaz_close)
 PHP_FUNCTION(yaz_search)
 {
        char *query_str, *type_str;
-       pval *id, *type, *query;
+       zval *id, *type, *query;
        Yaz_Association p;
 
        if (ZEND_NUM_ARGS() == 3) {
-               if (zend_parse_parameters(3, "zzz", &id, &type, &query)
-                       == FAILURE) {
+               if (GET_PARM3(&id, &type, &query) == FAILURE) {
                        WRONG_PARAM_COUNT;
                }
        } else {
@@ -534,7 +534,7 @@ PHP_FUNCTION(yaz_search)
                        if (p->sort_criteria) {
                                ZOOM_query_sortby(q, p->sort_criteria);
                        }
-                       xfree (p->sort_criteria);
+                       xfree(p->sort_criteria);
                        p->sort_criteria = 0;
                        p->zoom_set = ZOOM_connection_search(p->zoom_conn, q);
                        RETVAL_TRUE;
@@ -543,7 +543,7 @@ PHP_FUNCTION(yaz_search)
        }
        else
        {
-               php_error_docref(NULL TSRMLS_CC, E_WARNING, 
+               php_error_docref(NULL TSRMLS_CC, E_WARNING,
                                                 "Invalid query type %s", type_str);
        }
        release_assoc(p);
@@ -554,13 +554,13 @@ PHP_FUNCTION(yaz_search)
    Retrieve records */
 PHP_FUNCTION(yaz_present)
 {
-       pval *id;
+       zval *id;
        Yaz_Association p;
 
        if (ZEND_NUM_ARGS() != 1) {
                WRONG_PARAM_COUNT;
        }
-       if (zend_parse_parameters(1, "z", id) == FAILURE) {
+       if (GET_PARM1(&id) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
 
@@ -585,7 +585,7 @@ PHP_FUNCTION(yaz_present)
    Process events. */
 PHP_FUNCTION(yaz_wait)
 {
-       pval *pval_options = 0;
+       zval *pval_options = 0;
        int event_mode = 0;
        int no = 0;
        ZOOM_connection conn_ar[MAX_ASSOC];
@@ -596,7 +596,7 @@ PHP_FUNCTION(yaz_wait)
                long *val = 0;
                long *event_bool = 0;
                HashTable *options_ht = 0;
-               if (zend_parse_parameters(1, "z", &pval_options) == FAILURE) {
+               if (GET_PARM1(&pval_options) == FAILURE) {
                        WRONG_PARAM_COUNT;
                }
                if (Z_TYPE_PP(&pval_options) != IS_ARRAY) {
@@ -649,7 +649,7 @@ PHP_FUNCTION(yaz_wait)
        }
 
        if (no) {
-               while (ZOOM_event (no, conn_ar))
+               while (ZOOM_event(no, conn_ar))
                        ;
        }
        RETURN_TRUE;
@@ -660,11 +660,10 @@ PHP_FUNCTION(yaz_wait)
    Return last error number (>0 for bib-1 diagnostic, <0 for other error, 0 for no error */
 PHP_FUNCTION(yaz_errno)
 {
-       pval *id;
+       zval *id;
        Yaz_Association p;
 
-       if (ZEND_NUM_ARGS() != 1 || 
-               zend_parse_parameters(1, "z", &id) == FAILURE) {
+       if (ZEND_NUM_ARGS() != 1 || GET_PARM1(&id) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
        get_assoc(INTERNAL_FUNCTION_PARAM_PASSTHRU, id, &p);
@@ -680,11 +679,10 @@ PHP_FUNCTION(yaz_errno)
    Return last error message */
 PHP_FUNCTION(yaz_error)
 {
-       pval *id;
+       zval *id;
        Yaz_Association p;
 
-       if (ZEND_NUM_ARGS() != 1 ||
-               zend_parse_parameters(1, "z", &id) == FAILURE) {
+       if (ZEND_NUM_ARGS() != 1 ||     GET_PARM1(&id) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
 
@@ -708,11 +706,10 @@ PHP_FUNCTION(yaz_error)
    Return additional info for last error (empty string if none) */
 PHP_FUNCTION(yaz_addinfo)
 {
-       pval *id;
+       zval *id;
        Yaz_Association p;
 
-       if (ZEND_NUM_ARGS() != 1 ||
-               zend_parse_parameters(ZEND_NUM_ARGS(), "z", &id) == FAILURE) {
+       if (ZEND_NUM_ARGS() != 1 || GET_PARM1(&id) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
 
@@ -723,7 +720,7 @@ PHP_FUNCTION(yaz_addinfo)
                return_value->value.str.len = strlen(addinfo);
                return_value->value.str.val = estrndup(addinfo, return_value->value.str.len);
                return_value->type = IS_STRING;
-       }                
+       }
        release_assoc(p);
 }
 /* }}} */
@@ -732,15 +729,15 @@ PHP_FUNCTION(yaz_addinfo)
    Return number of hits (result count) for last search */
 PHP_FUNCTION(yaz_hits)
 {
-       pval *id, *searchresult = 0;
+       zval *id, *searchresult = 0;
        Yaz_Association p;
 
        if (ZEND_NUM_ARGS() == 1) {
-               if (zend_parse_parameters(1, "z", &id) == FAILURE) {
+               if (GET_PARM1(&id) == FAILURE) {
                        WRONG_PARAM_COUNT;
                }
        } else if (ZEND_NUM_ARGS() == 2) {
-               if (zend_parse_parameters(2, "zz", &id, &searchresult) == FAILURE) {
+               if (GET_PARM2(&id, &searchresult) == FAILURE) {
                        WRONG_PARAM_COUNT;
                }
                if (array_init(searchresult) == FAILURE) {
@@ -760,7 +757,7 @@ PHP_FUNCTION(yaz_hits)
                        const char *str =
                                ZOOM_resultset_option_get(p->zoom_set, "resultSetStatus");
                        if (str)
-                               add_assoc_string(searchresult, "resultSetStatus", 
+                               add_assoc_string(searchresult, "resultSetStatus",
                                                                 (char *) str, 1);
                }
                if (searchresult)
@@ -781,7 +778,7 @@ PHP_FUNCTION(yaz_hits)
                                MAKE_STD_ZVAL(zval_element);
                                array_init(zval_element);
                                add_next_index_zval(searchresult, zval_element);
-                               
+
                                sprintf(opt_name, "searchresult.%d.id", i);
                                opt_value = ZOOM_resultset_option_get(p->zoom_set, opt_name);
                                if (opt_value)
@@ -792,7 +789,7 @@ PHP_FUNCTION(yaz_hits)
                                opt_value = ZOOM_resultset_option_get(p->zoom_set, opt_name);
                                if (opt_value)
                                        add_assoc_long(zval_element, "count", atoi(opt_value));
-                               
+
                                sprintf(opt_name, "searchresult.%d.subquery.term", i);
                                opt_value = ZOOM_resultset_option_get(p->zoom_set, opt_name);
                                if (opt_value)
@@ -831,10 +828,10 @@ static Z_GenericRecord *marc_to_grs1(const char *buf, ODR o)
        int length_starting;
        int length_implementation;
        int max_elements = 256;
-       Z_GenericRecord *r = odr_malloc (o, sizeof(*r));
-       r->elements = odr_malloc (o, sizeof(*r->elements) * max_elements);
+       Z_GenericRecord *r = odr_malloc(o, sizeof(*r));
+       r->elements = odr_malloc(o, sizeof(*r->elements) * max_elements);
        r->num_elements = 0;
-       
+
        record_length = atoi_n(buf, 5);
        if (record_length < 25) {
                return 0;
@@ -842,11 +839,11 @@ static Z_GenericRecord *marc_to_grs1(const char *buf, ODR o)
        indicator_length = atoi_n(buf + 10, 1);
        identifier_length = atoi_n(buf + 11, 1);
        base_address = atoi_n(buf + 12, 5);
-       
+
        length_data_entry = atoi_n(buf + 20, 1);
        length_starting = atoi_n(buf + 21, 1);
        length_implementation = atoi_n(buf + 22, 1);
-       
+
        for (entry_p = 24; buf[entry_p] != ISO2709_FS; ) {
                entry_p += 3 + length_data_entry + length_starting;
                if (entry_p >= record_length) {
@@ -862,10 +859,10 @@ static Z_GenericRecord *marc_to_grs1(const char *buf, ODR o)
                tag->tagOccurrence = 0;
                tag->metaData = 0;
                tag->appliedVariant = 0;
-               tag->tagValue = odr_malloc (o, sizeof(*tag->tagValue));
+               tag->tagValue = odr_malloc(o, sizeof(*tag->tagValue));
                tag->tagValue->which = Z_StringOrNumeric_string;
                tag->tagValue->u.string = odr_strdup(o, "leader");
-               
+
                tag->content = odr_malloc(o, sizeof(*tag->content));
                tag->content->which = Z_ElementData_string;
                tag->content->u.string = odr_strdupn(o, buf, 24);
@@ -879,14 +876,14 @@ static Z_GenericRecord *marc_to_grs1(const char *buf, ODR o)
                int i;
                char tag_str[4];
                int identifier_flag = 1;
-               
+
                memcpy(tag_str, buf+entry_p, 3);
                entry_p += 3;
                tag_str[3] = '\0';
-               
+
                if ((r->num_elements + 1) >= max_elements) {
                        Z_TaggedElement **tmp = r->elements;
-                       
+
                        /* double array space, throw away old buffer (nibble memory) */
                        r->elements = odr_malloc(o, sizeof(*r->elements) * (max_elements *= 2));
                        memcpy(r->elements, tmp, r->num_elements * sizeof(*tmp));
@@ -897,19 +894,19 @@ static Z_GenericRecord *marc_to_grs1(const char *buf, ODR o)
                tag->tagOccurrence = 0;
                tag->metaData = 0;
                tag->appliedVariant = 0;
-               tag->tagValue = odr_malloc (o, sizeof(*tag->tagValue));
+               tag->tagValue = odr_malloc(o, sizeof(*tag->tagValue));
                tag->tagValue->which = Z_StringOrNumeric_string;
                tag->tagValue->u.string = odr_strdup(o, tag_str);
-               
+
                tag->content = odr_malloc(o, sizeof(*tag->content));
                tag->content->which = Z_ElementData_subtree;
-               
+
                tag->content->u.subtree = odr_malloc(o, sizeof(*tag->content->u.subtree));
                tag->content->u.subtree->elements = odr_malloc(o, sizeof(*r->elements));
                tag->content->u.subtree->num_elements = 1;
-               
+
                tag = tag->content->u.subtree->elements[0] = odr_malloc(o, sizeof(**tag->content->u.subtree->elements));
-               
+
                tag->tagType = odr_malloc(o, sizeof(*tag->tagType));
                *tag->tagType = 3;
                tag->tagOccurrence = 0;
@@ -918,7 +915,7 @@ static Z_GenericRecord *marc_to_grs1(const char *buf, ODR o)
                tag->tagValue = odr_malloc(o, sizeof(*tag->tagValue));
                tag->tagValue->which = Z_StringOrNumeric_string;
                tag->content = odr_malloc(o, sizeof(*tag->content));
-               
+
                data_length = atoi_n(buf + entry_p, length_data_entry);
                entry_p += length_data_entry;
                data_offset = atoi_n(buf + entry_p, length_starting);
@@ -930,69 +927,69 @@ static Z_GenericRecord *marc_to_grs1(const char *buf, ODR o)
                        if (buf[i + indicator_length] != ISO2709_IDFS) {
                                identifier_flag = 0;
                        }
-               } else if (!memcmp (tag_str, "00", 2)) {
+               } else if (!memcmp(tag_str, "00", 2)) {
                        identifier_flag = 0;
                }
-               
+
                if (identifier_flag && indicator_length) {
                        /* indicator */
                        tag->tagValue->u.string = odr_malloc(o, indicator_length + 1);
                        memcpy(tag->tagValue->u.string, buf + i, indicator_length);
                        tag->tagValue->u.string[indicator_length] = '\0';
                        i += indicator_length;
-                       
+
                        tag->content->which = Z_ElementData_subtree;
 
                        tag->content->u.subtree = odr_malloc(o, sizeof(*tag->content->u.subtree));
                        tag->content->u.subtree->elements = odr_malloc(o, 256 * sizeof(*r->elements));
                        tag->content->u.subtree->num_elements = 0;
-                       
+
                        while (buf[i] != ISO2709_RS && buf[i] != ISO2709_FS && i < end_offset) {
                                int i0;
                                /* prepare tag */
                                Z_TaggedElement *parent_tag = tag;
-                               Z_TaggedElement *tag = odr_malloc (o, sizeof(*tag));
-                               
+                               Z_TaggedElement *tag = odr_malloc(o, sizeof(*tag));
+
                                if (parent_tag->content->u.subtree->num_elements < 256) {
                                        parent_tag->content->u.subtree->elements[
                                        parent_tag->content->u.subtree->num_elements++] = tag;
                                }
-                                                               
+
                                tag->tagType = odr_malloc(o, sizeof(*tag->tagType));
                                *tag->tagType = 3;
                                tag->tagOccurrence = 0;
                                tag->metaData = 0;
                                tag->appliedVariant = 0;
-                               tag->tagValue = odr_malloc (o, sizeof(*tag->tagValue));
+                               tag->tagValue = odr_malloc(o, sizeof(*tag->tagValue));
                                tag->tagValue->which = Z_StringOrNumeric_string;
-                               
+
                                /* sub field */
                                tag->tagValue->u.string = odr_malloc(o, identifier_length);
                                memcpy(tag->tagValue->u.string, buf + i + 1, identifier_length - 1);
                                tag->tagValue->u.string[identifier_length - 1] = '\0';
                                i += identifier_length;
-                               
+
                                /* data ... */
                                tag->content = odr_malloc(o, sizeof(*tag->content));
                                tag->content->which = Z_ElementData_string;
-                               
+
                                i0 = i;
-                               while ( buf[i] != ISO2709_RS && 
-                                               buf[i] != ISO2709_IDFS && 
+                               while ( buf[i] != ISO2709_RS &&
+                                               buf[i] != ISO2709_IDFS &&
                                                buf[i] != ISO2709_FS && i < end_offset) {
                                        i++;
                                }
-                                                               
+
                                tag->content->u.string = odr_malloc(o, i - i0 + 1);
                                memcpy(tag->content->u.string, buf + i0, i - i0);
                                tag->content->u.string[i - i0] = '\0';
                        }
                } else {
                        int i0 = i;
-                       
+
                        tag->tagValue->u.string = "@";
                        tag->content->which = Z_ElementData_string;
-                       
+
                        while (buf[i] != ISO2709_RS && buf[i] != ISO2709_FS && i < end_offset) {
                                i++;
                        }
@@ -1079,7 +1076,7 @@ static void retval_array3_grs1(zval *return_value, Z_GenericRecord *p,
                zval *zval_list;
                Z_TaggedElement *e = p->elements[i];
                char tagstr[32], *tag = 0;
-               
+
                if (e->tagValue->which == Z_StringOrNumeric_numeric)
                {
                        sprintf(tagstr, ODR_INT_PRINTF, *e->tagValue->u.numeric);
@@ -1101,7 +1098,7 @@ static void retval_array3_grs1(zval *return_value, Z_GenericRecord *p,
                        MAKE_STD_ZVAL(zval_list);
                        array_init(zval_list);
                        add_assoc_zval(return_value, tag, zval_list);
-                       
+
                        tl = nmem_malloc(nmem, sizeof(*tl));
                        tl->tag = nmem_strdup(nmem, tag);
                        tl->zval_list = zval_list;
@@ -1139,11 +1136,11 @@ static void retval_array3_grs1(zval *return_value, Z_GenericRecord *p,
                                {
                                        char ind_idx[5];
                                        char ind_val[2];
-                                       
+
                                        sprintf(ind_idx, "ind%d", i+1);
                                        ind_val[0] = tag[i];
                                        ind_val[1] = '\0';
-                                       
+
                                        add_assoc_string(zval_element, ind_idx, ind_val, 1);
                                }
                                for (i = 0; i<sub->num_elements; i++)
@@ -1157,11 +1154,11 @@ static void retval_array3_grs1(zval *return_value, Z_GenericRecord *p,
                                        }
                                        else if (e->tagValue->which == Z_StringOrNumeric_string)
                                                tag = e->tagValue->u.string, zval_element;
-                                       
+
                                        if (tag && e->content->which == Z_ElementData_string)
                                        {
                                                const char *v = cvt_string(e->content->u.string, cvt);
-                                               add_assoc_string(zval_element, (char*) tag, (char*) v, 
+                                               add_assoc_string(zval_element, (char*) tag, (char*) v,
                                                                                 1);
                                        }
                                }
@@ -1181,25 +1178,25 @@ static void retval_array2_grs1(zval *return_value, Z_GenericRecord *p,
                                                           struct cvt_handle *cvt)
 {
        int i;
-       
+
        array_init(return_value);
-       
+
        for (i = 0; i<p->num_elements; i++)
        {
                zval *zval_element;
                zval *zval_sub;
                Z_TaggedElement *e = p->elements[i];
-               
+
                MAKE_STD_ZVAL(zval_element);
                array_init(zval_element);
-               
+
                if (e->tagType)
-                       add_assoc_long(zval_element, "tagType", *e->tagType);
+                       add_assoc_long(zval_element, "tagType", (long) *e->tagType);
 
                if (e->tagValue->which == Z_StringOrNumeric_string)
                        add_assoc_string(zval_element, "tag", e->tagValue->u.string, 1);
                else if (e->tagValue->which == Z_StringOrNumeric_numeric)
-                       add_assoc_long(zval_element, "tag", *e->tagValue->u.numeric);
+                       add_assoc_long(zval_element, "tag", (long) *e->tagValue->u.numeric);
 
                switch (e->content->which) {
                case Z_ElementData_string:
@@ -1210,7 +1207,7 @@ static void retval_array2_grs1(zval *return_value, Z_GenericRecord *p,
                        }
                        break;
                case Z_ElementData_numeric:
-                       add_assoc_long(zval_element, "content",*e->content->u.numeric);
+                       add_assoc_long(zval_element, "content", (long) *e->content->u.numeric);
                        break;
                case Z_ElementData_trueOrFalse:
                        add_assoc_bool(zval_element, "content",*e->content->u.trueOrFalse);
@@ -1251,14 +1248,14 @@ static void retval_array1_grs1(zval *return_value, Z_GenericRecord *p,
                }
                *tag = '\0';
                for (i = 0; i <= level; i++) {
-                       int tag_type = 3;
+                       long tag_type = 3;
                        e = grs[i]->elements[eno[i]];
 
                        if (e->tagType) {
-                               tag_type = *e->tagType;
+                               tag_type = (long) *e->tagType;
                        }
                        taglen = strlen(tag);
-                       sprintf(tag + taglen, "(%d,", tag_type);
+                       sprintf(tag + taglen, "(%ld,", tag_type);
                        taglen = strlen(tag);
 
                        if (e->tagValue->which == Z_StringOrNumeric_string) {
@@ -1276,7 +1273,7 @@ static void retval_array1_grs1(zval *return_value, Z_GenericRecord *p,
                ALLOC_ZVAL(my_zval);
                array_init(my_zval);
                INIT_PZVAL(my_zval);
-               
+
                add_next_index_string(my_zval, tag, 1);
 
                switch (e->content->which) {
@@ -1288,7 +1285,7 @@ static void retval_array1_grs1(zval *return_value, Z_GenericRecord *p,
                                }
                                break;
                        case Z_ElementData_numeric:
-                               add_next_index_long(my_zval, *e->content->u.numeric);
+                               add_next_index_long(my_zval, (long) *e->content->u.numeric);
                                break;
                        case Z_ElementData_trueOrFalse:
                                add_next_index_long(my_zval, *e->content->u.trueOrFalse);
@@ -1319,7 +1316,7 @@ static void ext_grs1(zval *return_value, char type_args[][60],
                        cvt = cvt_open(type_args[3], type_args[2]);
                else
                        cvt = cvt_open(0, 0);
-               
+
                if (ext->which == Z_External_grs1) {
                        retval_array1_grs1(return_value, ext->u.grs1, cvt);
                } else if (ext->which == Z_External_octet) {
@@ -1342,7 +1339,7 @@ static void ext_grs1(zval *return_value, char type_args[][60],
    Return record information at given result set position */
 PHP_FUNCTION(yaz_record)
 {
-       pval *pval_id, *pval_pos, *pval_type;
+       zval *pval_id, *pval_pos, *pval_type;
        Yaz_Association p;
        int pos;
        char *type;
@@ -1350,8 +1347,7 @@ PHP_FUNCTION(yaz_record)
        if (ZEND_NUM_ARGS() != 3) {
                WRONG_PARAM_COUNT;
        }
-       if (zend_parse_parameters(3, "zzz", &pval_id, &pval_pos, &pval_type)
-               == FAILURE) {
+       if (GET_PARM3( &pval_id, &pval_pos, &pval_type) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
 
@@ -1376,7 +1372,7 @@ PHP_FUNCTION(yaz_record)
                        type = "render";
                }
                if (r) {
-                       if (!strcmp(type_args[0], "array") || 
+                       if (!strcmp(type_args[0], "array") ||
                                !strcmp(type_args[0], "array1"))
                        {
                                ext_grs1(return_value, type_args, r, retval_array1_grs1);
@@ -1395,14 +1391,14 @@ PHP_FUNCTION(yaz_record)
                                }
                                else
                                {
-                                       php_error_docref(NULL TSRMLS_CC, E_WARNING, 
+                                       php_error_docref(NULL TSRMLS_CC, E_WARNING,
                                                                         "Bad yaz_record type %s - or unable "
                                                                         "to return record with type given", type);
                                }
                        }
                }
        }
-       release_assoc (p);
+       release_assoc(p);
 }
 /* }}} */
 
@@ -1410,11 +1406,11 @@ PHP_FUNCTION(yaz_record)
    Set record syntax for retrieval */
 PHP_FUNCTION(yaz_syntax)
 {
-       pval *pval_id, *pval_syntax;
+       zval *pval_id, *pval_syntax;
        Yaz_Association p;
 
        if (ZEND_NUM_ARGS() != 2 ||
-               zend_parse_parameters(2, "zz", &pval_id, &pval_syntax) == FAILURE) {
+               GET_PARM2(&pval_id, &pval_syntax) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
 
@@ -1429,11 +1425,11 @@ PHP_FUNCTION(yaz_syntax)
    Set Element-Set-Name for retrieval */
 PHP_FUNCTION(yaz_element)
 {
-       pval *pval_id, *pval_element;
+       zval *pval_id, *pval_element;
        Yaz_Association p;
 
        if (ZEND_NUM_ARGS() != 2 ||
-               zend_parse_parameters(2, "zz", &pval_id, &pval_element) == FAILURE) {
+               GET_PARM2(&pval_id, &pval_element) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
 
@@ -1449,11 +1445,11 @@ PHP_FUNCTION(yaz_element)
    Set Schema for retrieval */
 PHP_FUNCTION(yaz_schema)
 {
-       pval *pval_id, *pval_element;
+       zval *pval_id, *pval_element;
        Yaz_Association p;
 
        if (ZEND_NUM_ARGS() != 2 ||
-               zend_parse_parameters(2, "zz", &pval_id, &pval_element) == FAILURE) {
+               GET_PARM2(&pval_id, &pval_element) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
 
@@ -1468,11 +1464,11 @@ PHP_FUNCTION(yaz_schema)
    Set Option(s) for connection */
 PHP_FUNCTION(yaz_set_option)
 {
-       pval *pval_ar, *pval_name, *pval_val, *pval_id;
+       zval *pval_ar, *pval_name, *pval_val, *pval_id;
        Yaz_Association p;
 
        if (ZEND_NUM_ARGS() == 2) {
-               if (zend_parse_parameters(2, "zz", &pval_id, &pval_ar) == FAILURE) {
+               if (GET_PARM2(&pval_id, &pval_ar) == FAILURE) {
                        WRONG_PARAM_COUNT;
                }
                if (Z_TYPE_PP(&pval_ar) != IS_ARRAY) {
@@ -1483,7 +1479,7 @@ PHP_FUNCTION(yaz_set_option)
                        HashPosition pos;
                        HashTable *ht;
                        zval **ent;
-                       
+
                        ht = Z_ARRVAL_PP(&pval_ar);
                        for(zend_hash_internal_pointer_reset_ex(ht, &pos);
                                zend_hash_get_current_data_ex(ht, (void**) &ent, &pos) == SUCCESS;
@@ -1501,18 +1497,17 @@ PHP_FUNCTION(yaz_set_option)
                                }
                                option_set(p, key, (*ent)->value.str.val);
                        }
-                       release_assoc (p);
+                       release_assoc(p);
                }
        } else if (ZEND_NUM_ARGS() == 3) {
-               if (zend_parse_parameters(3, "zzz", &pval_id, &pval_name, &pval_val)
-                       == FAILURE) {
+               if (GET_PARM3( &pval_id, &pval_name, &pval_val) == FAILURE) {
                        WRONG_PARAM_COUNT;
                }
                get_assoc (INTERNAL_FUNCTION_PARAM_PASSTHRU, pval_id, &p);
                convert_to_string_ex(&pval_name);
                convert_to_string_ex(&pval_val);
                option_set(p, pval_name->value.str.val, pval_val->value.str.val);
-               
+
                release_assoc(p);
        } else {
                WRONG_PARAM_COUNT;
@@ -1524,13 +1519,13 @@ PHP_FUNCTION(yaz_set_option)
    Set Option(s) for connection */
 PHP_FUNCTION(yaz_get_option)
 {
-       pval *pval_id, *pval_name;
+       zval *pval_id, *pval_name;
        Yaz_Association p;
 
        if (ZEND_NUM_ARGS() != 2) {
                WRONG_PARAM_COUNT;
        }
-       if (zend_parse_parameters(2, "zz", &pval_id, &pval_name) == FAILURE) {
+       if (GET_PARM2(&pval_id, &pval_name) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
 
@@ -1558,19 +1553,21 @@ PHP_FUNCTION(yaz_get_option)
    Set result set start point and number of records to request */
 PHP_FUNCTION(yaz_range)
 {
-       pval *pval_id, *pval_start, *pval_number;
+       zval *pval_id, *pval_start, *pval_number;
        Yaz_Association p;
+       int start;
 
        if (ZEND_NUM_ARGS() != 3 ||
-               zend_parse_parameters(3, "zzz", &pval_id, &pval_start, &pval_number)
-               == FAILURE) {
+               GET_PARM3( &pval_id, &pval_start, &pval_number) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
 
        get_assoc(INTERNAL_FUNCTION_PARAM_PASSTHRU, pval_id, &p);
        convert_to_long_ex(&pval_start);
        convert_to_long_ex(&pval_number);
-       option_set_int(p, "start", pval_start->value.lval - 1);
+       start = pval_start->value.lval;
+       count = pval_number->value.lval;
+       option_set_int(p, "start", start > 0 ? start - 1 : 0);
        option_set_int(p, "count", pval_number->value.lval);
        release_assoc(p);
 }
@@ -1580,11 +1577,11 @@ PHP_FUNCTION(yaz_range)
    Set result set sorting criteria */
 PHP_FUNCTION(yaz_sort)
 {
-       pval *pval_id, *pval_criteria;
+       zval *pval_id, *pval_criteria;
        Yaz_Association p;
 
        if (ZEND_NUM_ARGS() != 2 ||
-               zend_parse_parameters(2, "zz", &pval_id, &pval_criteria) == FAILURE) {
+               GET_PARM2(&pval_id, &pval_criteria) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
 
@@ -1601,7 +1598,7 @@ PHP_FUNCTION(yaz_sort)
 }
 /* }}} */
 
-const char *ill_array_lookup (void *handle, const char *name)
+const char *ill_array_lookup(void *handle, const char *name)
 {
        return array_lookup_string((HashTable *) handle, name);
 }
@@ -1610,11 +1607,11 @@ const char *ill_array_lookup (void *handle, const char *name)
    Sends Item Order request */
 PHP_FUNCTION(yaz_itemorder)
 {
-       pval *pval_id, *pval_package;
+       zval *pval_id, *pval_package;
        Yaz_Association p;
 
        if (ZEND_NUM_ARGS() != 2 ||
-               zend_parse_parameters(2, "zz", &pval_id, &pval_package) == FAILURE) {
+               GET_PARM2(&pval_id, &pval_package) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
        if (Z_TYPE_PP(&pval_package) != IS_ARRAY) {
@@ -1625,14 +1622,14 @@ PHP_FUNCTION(yaz_itemorder)
        get_assoc(INTERNAL_FUNCTION_PARAM_PASSTHRU, pval_id, &p);
        if (p) {
                ZOOM_options options = ZOOM_options_create();
-               
+
                ZOOM_options_set_callback(options,
                                                                  ill_array_lookup, Z_ARRVAL_PP(&pval_package));
                ZOOM_package_destroy(p->zoom_package);
                p->zoom_package = ZOOM_connection_package(p->zoom_conn, options);
                ZOOM_package_send(p->zoom_package, "itemorder");
                ZOOM_options_set_callback(options, 0, 0);
-               ZOOM_options_destroy (options);
+               ZOOM_options_destroy(options);
        }
        release_assoc(p);
 }
@@ -1642,19 +1639,18 @@ PHP_FUNCTION(yaz_itemorder)
    Sends Extended Services Request */
 PHP_FUNCTION(yaz_es)
 {
-       pval *pval_id, *pval_type, *pval_package;
+       zval *pval_id, *pval_type, *pval_package;
        Yaz_Association p;
-       
+
        if (ZEND_NUM_ARGS() != 3 ||
-               zend_parse_parameters(3, "zzz", &pval_id, &pval_type, 
-                                                         &pval_package) == FAILURE) {
+               GET_PARM3( &pval_id, &pval_type, &pval_package) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
        if (Z_TYPE_PP(&pval_type) != IS_STRING) {
                php_error_docref(NULL TSRMLS_CC, E_WARNING, "Expected string parameter");
                RETURN_FALSE;
        }
-       
+
        if (Z_TYPE_PP(&pval_package) != IS_ARRAY) {
                php_error_docref(NULL TSRMLS_CC, E_WARNING, "Expected array parameter");
                RETURN_FALSE;
@@ -1663,14 +1659,14 @@ PHP_FUNCTION(yaz_es)
        get_assoc(INTERNAL_FUNCTION_PARAM_PASSTHRU, pval_id, &p);
        if (p) {
                ZOOM_options options = ZOOM_options_create();
-               
+
                ZOOM_options_set_callback(options, ill_array_lookup,
                                                                  Z_ARRVAL_PP(&pval_package));
                ZOOM_package_destroy(p->zoom_package);
                p->zoom_package = ZOOM_connection_package(p->zoom_conn, options);
                ZOOM_package_send(p->zoom_package, pval_type->value.str.val);
                ZOOM_options_set_callback(options, 0, 0);
-               ZOOM_options_destroy (options);
+               ZOOM_options_destroy(options);
        }
        release_assoc(p);
 }
@@ -1680,18 +1676,17 @@ PHP_FUNCTION(yaz_es)
    Sends Scan Request */
 PHP_FUNCTION(yaz_scan)
 {
-       pval *pval_id, *pval_type, *pval_query, *pval_flags = 0;
+       zval *pval_id, *pval_type, *pval_query, *pval_flags = 0;
        HashTable *flags_ht = 0;
        Yaz_Association p;
 
        if (ZEND_NUM_ARGS() == 3) {
-               if (zend_parse_parameters(3, "zzz", &pval_id, &pval_type, &pval_query)
-                       == FAILURE) {
+               if (GET_PARM3( &pval_id, &pval_type, &pval_query) == FAILURE) {
                        WRONG_PARAM_COUNT;
                }
        } else if (ZEND_NUM_ARGS() == 4) {
-               if (zend_parse_parameters(4, "zzzz", &pval_id, &pval_type,
-                                                                 &pval_query, &pval_flags) == FAILURE) {
+               if (GET_PARM4(&pval_id, &pval_type, &pval_query, &pval_flags)
+                       == FAILURE) {
                        WRONG_PARAM_COUNT;
                }
                if (Z_TYPE_PP(&pval_flags) != IS_ARRAY) {
@@ -1713,7 +1708,7 @@ PHP_FUNCTION(yaz_scan)
                option_set(p, "number", array_lookup_string(flags_ht, "number"));
                option_set(p, "position", array_lookup_string(flags_ht, "position"));
                option_set(p, "stepSize", array_lookup_string(flags_ht, "stepsize"));
-               p->zoom_scan = ZOOM_connection_scan(p->zoom_conn, 
+               p->zoom_scan = ZOOM_connection_scan(p->zoom_conn,
                                                                                        Z_STRVAL_PP(&pval_query));
        }
        release_assoc(p);
@@ -1724,11 +1719,10 @@ PHP_FUNCTION(yaz_scan)
    Inspects Extended Services Result */
 PHP_FUNCTION(yaz_es_result)
 {
-       pval *pval_id;
+       zval *pval_id;
        Yaz_Association p;
 
-       if (ZEND_NUM_ARGS() != 1 ||
-               zend_parse_parameters(1, "z", &pval_id) == FAILURE) {
+       if (ZEND_NUM_ARGS() != 1 ||     GET_PARM1(&pval_id) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
 
@@ -1736,13 +1730,13 @@ PHP_FUNCTION(yaz_es_result)
 
        get_assoc(INTERNAL_FUNCTION_PARAM_PASSTHRU, pval_id, &p);
        if (p && p->zoom_package) {
-               const char *str = ZOOM_package_option_get(p->zoom_package, 
+               const char *str = ZOOM_package_option_get(p->zoom_package,
                                                                                                  "targetReference");
-               
+
                if (str) {
                        add_assoc_string(return_value, "targetReference", (char *) str, 1);
                }
-               str = ZOOM_package_option_get(p->zoom_package, 
+               str = ZOOM_package_option_get(p->zoom_package,
                                                                          "xmlUpdateDoc");
                if (str) {
                        add_assoc_string(return_value, "xmlUpdateDoc", (char *) str, 1);
@@ -1756,15 +1750,15 @@ PHP_FUNCTION(yaz_es_result)
    Inspects Scan Result */
 PHP_FUNCTION(yaz_scan_result)
 {
-       pval *pval_id, *pval_opt = 0;
+       zval *pval_id, *pval_opt = 0;
        Yaz_Association p;
 
        if (ZEND_NUM_ARGS() == 2) {
-               if (zend_parse_parameters(2, "zz", &pval_id, &pval_opt) == FAILURE) {
+               if (GET_PARM2(&pval_id, &pval_opt) == FAILURE) {
                        WRONG_PARAM_COUNT;
                }
        } else if (ZEND_NUM_ARGS() == 1) {
-               if (zend_parse_parameters(1, "z", &pval_id) == FAILURE) {
+               if (GET_PARM1(&pval_id) == FAILURE) {
                        WRONG_PARAM_COUNT;
                }
        } else {
@@ -1787,7 +1781,7 @@ PHP_FUNCTION(yaz_scan_result)
                int occ, len;
 #endif
                int size = ZOOM_scanset_size(p->zoom_scan);
-               
+
                for (pos = 0; pos < size; pos++) {
                        const char *term = ZOOM_scanset_term(p->zoom_scan, pos, &occ, &len);
                        zval *my_zval;
@@ -1795,7 +1789,7 @@ PHP_FUNCTION(yaz_scan_result)
                        ALLOC_ZVAL(my_zval);
                        array_init(my_zval);
                        INIT_PZVAL(my_zval);
-                       
+
                        add_next_index_string(my_zval, "term", 1);
 
                        if (term) {
@@ -1818,9 +1812,9 @@ PHP_FUNCTION(yaz_scan_result)
 
                if (pval_opt) {
                        const char *v;
-       
+
                        add_assoc_long(pval_opt, "number", size);
-                       
+
                        v = ZOOM_scanset_option_get(p->zoom_scan, "stepSize");
                        if (v) {
                                add_assoc_long(pval_opt, "stepsize", atoi(v));
@@ -1843,11 +1837,11 @@ PHP_FUNCTION(yaz_scan_result)
    Configure CCL package */
 PHP_FUNCTION(yaz_ccl_conf)
 {
-       pval *pval_id, *pval_package;
+       zval *pval_id, *pval_package;
        Yaz_Association p;
 
        if (ZEND_NUM_ARGS() != 2 ||
-               zend_parse_parameters(2, "zz", &pval_id, &pval_package) == FAILURE) {
+               GET_PARM2(&pval_id, &pval_package) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
 
@@ -1882,7 +1876,7 @@ PHP_FUNCTION(yaz_ccl_conf)
                        ccl_qual_fitem(p->bibset, (*ent)->value.str.val, key);
                }
        }
-       release_assoc (p);
+       release_assoc(p);
 }
 /* }}} */
 
@@ -1890,16 +1884,15 @@ PHP_FUNCTION(yaz_ccl_conf)
    Parse a CCL query */
 PHP_FUNCTION(yaz_ccl_parse)
 {
-       pval *pval_id, *pval_query, *pval_res = 0;
+       zval *pval_id, *pval_query, *pval_res = 0;
        Yaz_Association p;
 
-       if (ZEND_NUM_ARGS() != 3 ||
-               zend_parse_parameters(3, "zzz", &pval_id, &pval_query, &pval_res)
+       if (ZEND_NUM_ARGS() != 3 || GET_PARM3( &pval_id, &pval_query, &pval_res)
                == FAILURE) {
                WRONG_PARAM_COUNT;
        }
-       
-       pval_destructor(pval_res);
+
+       zval_dtor(pval_res);
        array_init(pval_res);
        convert_to_string_ex(&pval_query);
 
@@ -1916,14 +1909,14 @@ PHP_FUNCTION(yaz_ccl_parse)
                error_code = ccl_parser_get_error(ccl_parser, &error_pos);
                add_assoc_long(pval_res, "errorcode", error_code);
 
-               if (error_code) 
+               if (error_code)
                {
-                       add_assoc_string(pval_res, "errorstring", 
+                       add_assoc_string(pval_res, "errorstring",
                                                         (char *) ccl_err_msg(error_code), 1);
                        add_assoc_long(pval_res, "errorpos", error_pos);
                        RETVAL_FALSE;
-               } 
-               else 
+               }
+               else
                {
                        WRBUF wrbuf_pqf = wrbuf_alloc();
                        ccl_stop_words_t csw = ccl_stop_words_create();
@@ -1956,7 +1949,7 @@ PHP_FUNCTION(yaz_ccl_parse)
                                add_assoc_zval(pval_res, "stopwords", zval_stopwords);
                        }
                        ccl_pquery(wrbuf_pqf, rpn);
-                       add_assoc_stringl(pval_res, "rpn", 
+                       add_assoc_stringl(pval_res, "rpn",
                                                          wrbuf_buf(wrbuf_pqf), wrbuf_len(wrbuf_pqf), 1);
                        wrbuf_destroy(wrbuf_pqf);
                        ccl_stop_words_destroy(csw);
@@ -1974,11 +1967,11 @@ PHP_FUNCTION(yaz_ccl_parse)
    Specify the databases within a session */
 PHP_FUNCTION(yaz_database)
 {
-       pval *pval_id, *pval_database;
+       zval *pval_id, *pval_database;
        Yaz_Association p;
 
        if (ZEND_NUM_ARGS() != 2 ||
-               zend_parse_parameters(2, "zz", &pval_id, &pval_database) == FAILURE) {
+               GET_PARM2(&pval_id, &pval_database) == FAILURE) {
                WRONG_PARAM_COUNT;
        }
 
@@ -2014,7 +2007,7 @@ static void yaz_close_session(Yaz_Association *as TSRMLS_DC)
        }
 }
 
-static void yaz_close_link (zend_rsrc_list_entry *rsrc TSRMLS_DC)
+static void yaz_close_link(zend_rsrc_list_entry *rsrc TSRMLS_DC)
 {
        Yaz_Association *as = (Yaz_Association *) rsrc->ptr;
        yaz_close_session(as TSRMLS_CC);
@@ -2037,7 +2030,7 @@ PHP_INI_BEGIN()
        STD_PHP_INI_ENTRY("yaz.log_mask", NULL, PHP_INI_ALL, OnUpdateString, log_mask, zend_yaz_globals, yaz_globals)
 PHP_INI_END()
 /* }}} */
-       
+
 PHP_MINIT_FUNCTION(yaz)
 {
        int i;
@@ -2050,7 +2043,7 @@ PHP_MINIT_FUNCTION(yaz)
        ZEND_INIT_MODULE_GLOBALS(yaz, php_yaz_init_globals, NULL);
 
        REGISTER_INI_ENTRIES();
-       
+
        REGISTER_LONG_CONSTANT("ZOOM_EVENT_NONE", ZOOM_EVENT_NONE,
                                                   CONST_CS|CONST_PERSISTENT);
        REGISTER_LONG_CONSTANT("ZOOM_EVENT_CONNECT", ZOOM_EVENT_CONNECT,
@@ -2084,7 +2077,7 @@ PHP_MINIT_FUNCTION(yaz)
        else
                yaz_log_init_level(0);
 
-       le_link = zend_register_list_destructors_ex (yaz_close_link, 0, "YAZ link", module_number);
+       le_link = zend_register_list_destructors_ex(yaz_close_link, 0, "YAZ link", module_number);
 
        order_associations = 1;
        shared_associations = xmalloc(sizeof(*shared_associations) * MAX_ASSOC);
@@ -2106,7 +2099,7 @@ PHP_MSHUTDOWN_FUNCTION(yaz)
                shared_associations = 0;
        }
 #ifdef ZTS
-       tsrm_mutex_free (yaz_mutex);
+       tsrm_mutex_free(yaz_mutex);
 #endif
 
        yaz_log_init_file(0);