Better diagnostics.

[irspy-moved-to-github.git] / lib / ZOOM / IRSpy / Test / Record / Fetch.pm

diff --git a/lib/ZOOM/IRSpy/Test/Record/Fetch.pm b/lib/ZOOM/IRSpy/Test/Record/Fetch.pm
index f79d6ba..c6b489f 100644 (file)
--- a/lib/ZOOM/IRSpy/Test/Record/Fetch.pm
+++ b/lib/ZOOM/IRSpy/Test/Record/Fetch.pm
@@ -1,4 +1,4 @@
-# $Id: Fetch.pm,v 1.9 2006-10-26 17:17:27 mike Exp $
+# $Id: Fetch.pm,v 1.16 2006-11-29 11:06:29 mike Exp $
 
 # See the "Main" test package for documentation
 
@@ -28,7 +28,10 @@ sub start {
 sub completed_search {
     my($conn, $task, $udata, $event) = @_;
 
-    $conn->log("irspy_test", "Fetch test search succeeded");
+    my $n = $task->{rs}->size();
+    $conn->log("irspy_test", "Fetch test search found $n records");
+    return ZOOM::IRSpy::Status::TEST_SKIPPED if $n == 0;
+
     my @syntax = (
                    'canmarc',
                    'danmarc',
@@ -69,17 +72,25 @@ sub record {
     my $syn = $test_args->{'syntax'};
     my $rs = $task->{rs};
 
-    $conn->log("irspy_test", "Successfully retrieved a $syn record");
-    if (1) {
-        print STDERR "Hits: ", $rs->size(), "\n";
-        print STDERR "Syntax: ", $syn, "\n";
-        my $record = _fetch_record($rs, 0, $syn);
-        print STDERR $record->render();
+    my $record = _fetch_record($rs, 0, $syn);
+    my $ok = 0;
+    if ($record->error()) {
+       $conn->log("irspy_test", "retrieval of $syn record failed: ",
+                  $record->exception());
+    } else {
+       $ok = 1;
+       my $text = $record->render();
+       $conn->log("irspy_test", "Successfully retrieved a $syn record");
+       if (0) {
+           print STDERR "Hits: ", $rs->size(), "\n";
+           print STDERR "Syntax: ", $syn, "\n";
+           print STDERR $text;
+       }
     }
 
     $conn->record()->store_result('record_fetch',
                                   'syntax'   => $syn,
-                                  'ok'       => 1);
+                                  'ok'       => $ok);
 
     return ZOOM::IRSpy::Status::TASK_DONE;
 }