More visible upd links.

[git-tools-moved-to-github.git] / aptcheck / aptcheck.pl

diff --git a/aptcheck/aptcheck.pl b/aptcheck/aptcheck.pl
index 2dac01a..3121946 100755 (executable)
--- a/aptcheck/aptcheck.pl
+++ b/aptcheck/aptcheck.pl
@@ -21,14 +21,12 @@
 # 15-Aug-2011 Heikki: Adding a total in the headline, for nagiosgrapher
 # 21-May-2012 Heikki: Added a date since when a package has been pending
 # 31-May-2012 Heikki: Pointing to the new wiki
+# 01-Jan-2013 Heikki: Get hosts from nagios-us as well.
 #
 # TODO: Assumes that we release our restricted packages for all versions
 # and architectures at the same time. Gets only the highest version from
 # all, and reports anything less than this. Good enough for now.
 #
-# TODO: Get the dates from ls --full-time /var/cache/apt/archives/
-# and display next to the packages, so we can see how long they have
-# been lingering. Boldface them if older than some limit
 
 #### Init
 use strict;
@@ -37,6 +35,7 @@ my $year =`date +%Y`;
 #my $wikilink = 'http://twiki.indexdata.dk/cgi-bin/twiki/view/ID/';
 my $wikilink = 'https://twiki.indexdata.com/twiki/bin/view/ID/';
 my $restrictedpackages = "ssh -q kebab cat /home/ftp/pub/debian/dists/*/restricted/*/Packages";
+my $updlink="<i>-u</i>"; # to display after a name, liking to the upd page
 
 #### Host comments
 my %hostcomments = (
@@ -52,10 +51,15 @@ my %hostcomments = (
 # I could use a hard-coded list, but I would forget to maintain it.
 # Nagios knows most of our hosts. It even knows which are worth 
 # checking, they have a command to check apts!
+print "Getting hostlist from nagios\n" if $debug;
+my $hostlist1 = `ssh nagios grep -l Apt /etc/nagios3/indexdata-conf.d/*.cfg`
+  or die "Could not get host list from nagios (dk)";
 
-my $hostlist = `ssh nagios grep -l Apt /etc/nagios3/indexdata-conf.d/*.cfg`
-  or die "Could not get host list";
+print "Getting hostlist from nagios-us\n" if $debug;
+my $hostlist2 = `ssh nagios-us grep -l Apt /etc/nagios3/indexdata-conf.d/*.cfg`
+  or die "Could not get host list from nagios (dk)";
 
+my $hostlist = $hostlist1 . $hostlist2;
 print "Got list:\n$hostlist\n" if $debug>2;
 
 ###### Get list of packages that can be manually maintained
@@ -123,6 +127,8 @@ my %newdates;  # To be written in the new version of the file
 my $datefilename = "aptcheck.data";
 my $dateoldfilename = "aptcheck.old";
 my $thisdate = "*"; # indicates really old stuff
+my $warndate; # Older than this will be boldfaced
+
 if ( -f $datefilename ) {
   print "Reading dates from $datefilename\n" if $debug;
   open F, $datefilename or die "Could not open date file $datefilename: $!";
@@ -136,6 +142,9 @@ if ( -f $datefilename ) {
   close F;
   $thisdate = `date +%F`;
   chomp($thisdate);
+  $warndate = `date +%F -d "30 days ago"` ; ;
+  chomp($warndate);
+  print "Dates: now: '$thisdate' warn: '$warndate'\n" if $debug;
 } else {
   print "No datefile $datefilename found, starting from scratch\n";
 }
@@ -143,7 +152,8 @@ if ( -f $datefilename ) {
 
 my $table = "<table>\n";
 
-for my $hline ( split("\n",$hostlist) ) {
+#for my $hline ( split("\n",$hostlist) ) {
+for my $hline ( sort( split("\n",$hostlist) ) ) {
     next unless ( $hline =~ /\/([a-z0-9-]+)\.cfg$/ );
     my $H = $1;
     next if ($H =~ /^commands/ );
@@ -211,7 +221,12 @@ for my $hline ( split("\n",$hostlist) ) {
                     } else {
                         $newdates{$datekey} = $thisdate;
                     }
-                    $det .= "<td>" . $newdates{$datekey} . "</td>";
+                    my $dispdate = $newdates{$datekey};
+                    # if ( $dispdate lt $warndate ) {
+                    if ( 0 ) { # manual packages don't need to be highlighted
+                        $dispdate = "<b>$dispdate !</b>";
+                    }
+                    $det .= "<td>" . $dispdate . "</td>";
                     $det .= "</tr>\n";
                     my $key = "$restrname";
                     if ( !$summary{$key} ) {
@@ -264,7 +279,11 @@ for my $hline ( split("\n",$hostlist) ) {
         } else {
             $newdates{$datekey} = $thisdate;
         }
-        $det .= "<td>" . $newdates{$datekey} . "</td>";
+        my $dispdate = $newdates{$datekey};
+        if ( ( $dispdate lt $warndate ) && ( $src =~ /Security/) ) {
+            $dispdate = "<b>$dispdate !</b>";
+        }
+        $det .= "<td>" . $dispdate . "</td>";
         $det .= "</tr>\n";
 
     }
@@ -297,14 +316,18 @@ for my $hline ( split("\n",$hostlist) ) {
 $table .= "</table>\n";
 
 # Save the date file
-`mv -f $datefilename $dateoldfilename`;
-open F, ">$datefilename" or die "Could not open date file $datefilename for writing";
-for  my $k (sort(keys(%newdates)) ) {
-    print F "$k " . $newdates{$k}. "\n";
-    print "date for '$k' '" . $newdates{$k}. "'\n" if $debug;
+if ( ! $debug ) {
+    `mv -f $datefilename $dateoldfilename`;
+    open F, ">$datefilename" or die "Could not open date file $datefilename for writing";
+    for  my $k (sort(keys(%newdates)) ) {
+        print F "$k " . $newdates{$k}. "\n";
+        print "date for '$k' '" . $newdates{$k}. "'\n" if $debug;
+    }
+    close F
+      or die "Could not close date file $datefilename: $!";
+} else {
+    print "Not updating the date file, this is a debug run\n";
 }
-close F
-  or die "Could not close date file $datefilename: $!";
 
 # Page header
 my $outfile = "/tmp/aptcheck.html";
@@ -334,7 +357,7 @@ if ( $sectot ) {
     print F "<td>";
     for my $HH ( sort(keys(%sechosts)) ) {
         my $upd = $updlinks{$HH} || "#" ;
-        print F "<a href='#$HH'><b>$HH</b></a><a href='$upd'>,</a> ";
+        print F "<a href='#$HH'><b>$HH</b></a><a href='$upd'>$updlink</a> ";
     }
     print F "</td>";
     print F "<td>";
@@ -350,7 +373,7 @@ if ( $owntot ) {
     print F "<td>";
     for my $HH ( sort(keys(%ownhosts)) ) {
         my $upd = $updlinks{$HH} || "#" ;
-        print F "<a href='#$HH'><b>$HH</b></a><a href='$upd'>,</a> ";
+        print F "<a href='#$HH'><b>$HH</b></a><a href='$upd'>$updlink</a> ";
         #print F "<a href='#$HH'><b>$HH</b></a> ";
     }
     print F "</td>";
@@ -367,7 +390,7 @@ if ( $mantot ) {
     print F "<td>";
     for my $HH ( sort(keys(%manhosts)) ) {
         my $upd = $updlinks{$HH} || "#" ;
-        print F "<a href='#$HH'><b>$HH</b></a><a href='$upd'>,</a> ";
+        print F "<a href='#$HH'><b>$HH</b></a><a href='$upd'>$updlink</a> ";
         #print F "<a href='#$HH'><b>$HH</b></a> ";
     }
     print F "</td>";
@@ -384,7 +407,7 @@ if ( $normtot ) {
     print F "<td>";
     for my $HH ( sort(keys(%normhosts)) ) {
         my $upd = $updlinks{$HH} || "#" ;
-        print F "<a href='#$HH'><b>$HH</b></a><a href='$upd'>,</a> ";
+        print F "<a href='#$HH'><b>$HH</b></a><a href='$upd'>$updlink</a> ";
         #print F "<a href='#$HH'><b>$HH</b></a> ";
     }
     print F "</td>";
@@ -401,18 +424,18 @@ if ( %skiphosts ) {
     for my $HH ( sort(keys(%skiphosts)) ) {
         my $upd = $updlinks{$HH} ||
                   $wikilink . ucfirst($HH) . "Updates" . $year;
-        print F "<a href='#$HH'><b>$HH</b></a><a href='$upd'>,</a> ";
+        print F "<a href='#$HH'><b>$HH</b></a><a href='$upd'>$updlink</a> ";
         #print F "<a href='#$HH'><b>$HH</b></a> ";
     }
     print F "</td></tr>\n";
 }
-#if ( %okhosts ) {
 if ( 1 ) {
-    print F "<tr><td>Ok " . scalar(keys(%okhosts)) . "</td>\n";
+    print F "<tr><td>Ok <br/>" . scalar(keys(%okhosts)) .
+           " of " . scalar(keys(%allhosts)) . "</td>\n";
     print F "<td colspan='2'>";
     for my $HH ( sort(keys(%okhosts)) ) {
         my $upd = $updlinks{$HH} || "#" ;
-        print F "<a href='#$HH'><b>$HH</b></a><a href='$upd'>,</a> ";
+        print F "<a href='#$HH'><b>$HH</b></a><a href='$upd'>$updlink</a> ";
         #print F "<a href='#$HH'><b>$HH</b></a> ";
     }
     if ( !%okhosts ) {
@@ -422,6 +445,9 @@ if ( 1 ) {
 }
 print F "</table>\n";
 
+print F "<p/><b>" .  ( $sectot + $owntot + $mantot + $normtot ) . 
+        "</b> packages pending (<b>$sectot</b> critical) \n";
+
 # Graph 
 #my $secs = 60*60*24 * 7 * 2; # 2 weeks in secods
 #my $secs = "1m"; # one month, let nagios do the math
@@ -458,8 +484,6 @@ for my $P ( sort(keys(%summary)) ) {
 }
 print F "</table>\n";
 
-print F "<p/>Packages marked with * are from the time before started to " .
-        "track package dates \n";
 print F "<p/>Produced " . `date`.
         " on " . `hostname` . " by " . `whoami` .
         "<br/>\n";