Removed unused client states: Disconnected, Stopped, Continue.
[pazpar2-moved-to-github.git] / src / logic.c
index e8c2e88..a882ac3 100644 (file)
@@ -1,7 +1,5 @@
-/* $Id: logic.c,v 1.64 2007-09-05 08:40:12 adam Exp $
-   Copyright (c) 2006-2007, Index Data.
-
-This file is part of Pazpar2.
+/* This file is part of Pazpar2.
+   Copyright (C) 2006-2008 Index Data
 
 Pazpar2 is free software; you can redistribute it and/or modify it under
 the terms of the GNU General Public License as published by the Free
@@ -14,22 +12,28 @@ FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 for more details.
 
 You should have received a copy of the GNU General Public License
-along with Pazpar2; see the file LICENSE.  If not, write to the
-Free Software Foundation, 59 Temple Place - Suite 330, Boston, MA
-02111-1307, USA.
- */
+along with this program; if not, write to the Free Software
+Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+
+*/
 
 /** \file logic.c
     \brief high-level logic; mostly user sessions and settings
 */
 
+#if HAVE_CONFIG_H
+#include <config.h>
+#endif
+
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
+#if HAVE_SYS_TIME_H
 #include <sys/time.h>
+#endif
+#if HAVE_UNISTD_H
 #include <unistd.h>
-#include <sys/socket.h>
-#include <netdb.h>
+#endif
 #include <signal.h>
 #include <ctype.h>
 #include <assert.h>
@@ -48,16 +52,11 @@ Free Software Foundation, 59 Temple Place - Suite 330, Boston, MA
 #include <yaz/oid_db.h>
 #include <yaz/snprintf.h>
 
-#if HAVE_CONFIG_H
-#include "cconfig.h"
-#endif
-
 #define USE_TIMING 0
 #if USE_TIMING
 #include <yaz/timing.h>
 #endif
 
-#include <netinet/in.h>
 
 #include "pazpar2.h"
 #include "eventl.h"
@@ -65,7 +64,6 @@ Free Software Foundation, 59 Temple Place - Suite 330, Boston, MA
 #include "termlists.h"
 #include "reclists.h"
 #include "relevance.h"
-#include "config.h"
 #include "database.h"
 #include "client.h"
 #include "settings.h"
@@ -82,20 +80,19 @@ struct parameters global_parameters =
     "",
     "", 
     0,
-    0, /* dump_records */
-    0, /* debug_mode */
-    30,
+    0,   // dump_records
+    0,   // debug_mode
+    30,  // operations timeout 
     "81",
     "Index Data PazPar2",
     VERSION,
-    600, // 10 minutes
-    60,
+    60,   // session timeout 
     100,
     MAX_CHUNK,
     0,
     0,
-    180,
-    30
+    180, // Z39.50 session timeout
+    15   // Connect timeout
 };
 
 // Recursively traverse query structure to extract terms.
@@ -107,20 +104,20 @@ void pull_terms(NMEM nmem, struct ccl_rpn_node *n, char **termlist, int *num)
 
     switch (n->kind)
     {
-        case CCL_RPN_AND:
-        case CCL_RPN_OR:
-        case CCL_RPN_NOT:
-        case CCL_RPN_PROX:
-            pull_terms(nmem, n->u.p[0], termlist, num);
-            pull_terms(nmem, n->u.p[1], termlist, num);
-            break;
-        case CCL_RPN_TERM:
-            nmem_strsplit(nmem, " ", n->u.t.term, &words, &numwords);
-            for (i = 0; i < numwords; i++)
-                termlist[(*num)++] = words[i];
-            break;
-        default: // NOOP
-            break;
+    case CCL_RPN_AND:
+    case CCL_RPN_OR:
+    case CCL_RPN_NOT:
+    case CCL_RPN_PROX:
+        pull_terms(nmem, n->u.p[0], termlist, num);
+        pull_terms(nmem, n->u.p[1], termlist, num);
+        break;
+    case CCL_RPN_TERM:
+        nmem_strsplit(nmem, " ", n->u.t.term, &words, &numwords);
+        for (i = 0; i < numwords; i++)
+            termlist[(*num)++] = words[i];
+        break;
+    default: // NOOP
+        break;
     }
 }
 
@@ -152,109 +149,20 @@ static void add_facet(struct session *s, const char *type, const char *value)
     termlist_insert(s->termlists[i].termlist, value);
 }
 
-xmlDoc *record_to_xml(struct session_database *sdb, Z_External *rec)
+xmlDoc *record_to_xml(struct session_database *sdb, const char *rec)
 {
     struct database *db = sdb->database;
     xmlDoc *rdoc = 0;
-    const Odr_oid *oid = rec->direct_reference;
 
-    /* convert response record to XML somehow */
-    if (rec->which == Z_External_octet && oid
-        && !oid_oidcmp(oid, yaz_oid_recsyn_xml))
-    {
-        /* xml already */
-        rdoc = xmlParseMemory((char*) rec->u.octet_aligned->buf,
-                              rec->u.octet_aligned->len);
-        if (!rdoc)
-        {
-            yaz_log(YLOG_FATAL, "Non-wellformed XML received from %s",
-                    db->url);
-            return 0;
-        }
-    }
-    else if (rec->which == Z_External_OPAC)
-    {
-        if (!sdb->yaz_marc)
-        {
-            yaz_log(YLOG_WARN, "MARC decoding not configured");
-            return 0;
-        }
-        else
-        {
-            /* OPAC gets converted to XML too */
-            WRBUF wrbuf_opac = wrbuf_alloc();
-            /* MARCXML inside the OPAC XML. Charset is in effect because we
-               use the yaz_marc handle */
-            yaz_marc_xml(sdb->yaz_marc, YAZ_MARC_MARCXML);
-            yaz_opac_decode_wrbuf(sdb->yaz_marc, rec->u.opac, wrbuf_opac);
-            
-            rdoc = xmlParseMemory((char*) wrbuf_buf(wrbuf_opac),
-                                  wrbuf_len(wrbuf_opac));
-            if (!rdoc)
-            {
-                yaz_log(YLOG_WARN, "Unable to parse OPAC XML");
-                /* Was used to debug bug #1348 */
-#if 0
-                FILE *f = fopen("/tmp/opac.xml.txt", "wb");
-                if (f)
-                {
-                    fwrite(wrbuf_buf(wrbuf_opac), 1, wrbuf_len(wrbuf_opac), f);
-                    fclose(f);
-                }
-#endif
-            }
-            wrbuf_destroy(wrbuf_opac);
-        }
-    }
-    else if (oid && yaz_oid_is_iso2709(oid))
-    {
-        /* ISO2709 gets converted to MARCXML */
-        if (!sdb->yaz_marc)
-        {
-            yaz_log(YLOG_WARN, "MARC decoding not configured");
-            return 0;
-        }
-        else
-        {
-            xmlNode *res;
-            char *buf;
-            int len;
-            
-            if (rec->which != Z_External_octet)
-            {
-                yaz_log(YLOG_WARN, "Unexpected external branch, probably BER %s",
-                        db->url);
-                return 0;
-            }
-            buf = (char*) rec->u.octet_aligned->buf;
-            len = rec->u.octet_aligned->len;
-            if (yaz_marc_read_iso2709(sdb->yaz_marc, buf, len) < 0)
-            {
-                yaz_log(YLOG_WARN, "Failed to decode MARC %s", db->url);
-                return 0;
-            }
-            
-            if (yaz_marc_write_xml(sdb->yaz_marc, &res,
-                                   "http://www.loc.gov/MARC21/slim", 0, 0) < 0)
-            {
-                yaz_log(YLOG_WARN, "Failed to encode as XML %s",
-                        db->url);
-                return 0;
-            }
-            rdoc = xmlNewDoc((xmlChar *) "1.0");
-            xmlDocSetRootElement(rdoc, res);
-        }
-    }
-    else
+    rdoc = xmlParseMemory(rec, strlen(rec));
+
+    if (!rdoc)
     {
-        char oid_name_buf[OID_STR_MAX];
-        const char *oid_name = yaz_oid_to_string_buf(oid, 0, oid_name_buf);
-        yaz_log(YLOG_FATAL, 
-                "Unable to handle record of type %s from %s", 
-                oid_name, db->url);
+        yaz_log(YLOG_FATAL, "Non-wellformed XML received from %s",
+                db->url);
         return 0;
     }
-    
+
     if (global_parameters.dump_records)
     {
         FILE *lf = yaz_log_file();
@@ -269,6 +177,7 @@ xmlDoc *record_to_xml(struct session_database *sdb, Z_External *rec)
             fprintf(lf, "\n");
         }
     }
+
     return rdoc;
 }
 
@@ -276,7 +185,7 @@ xmlDoc *record_to_xml(struct session_database *sdb, Z_External *rec)
 
 // Add static values from session database settings if applicable
 static void insert_settings_parameters(struct session_database *sdb,
-        struct session *se, char **parms)
+                                       struct session *se, char **parms)
 {
     struct conf_service *service = global_parameters.server->service;
     int i;
@@ -289,7 +198,7 @@ static void insert_settings_parameters(struct session_database *sdb,
         int setting;
 
         if (md->setting == Metadata_setting_parameter &&
-                (setting = settings_offset(md->name)) > 0)
+            (setting = settings_offset(md->name)) > 0)
         {
             const char *val = session_setting_oneval(sdb, setting);
             if (val && nparms < MAX_XSLT_ARGS)
@@ -322,14 +231,14 @@ static void insert_settings_values(struct session_database *sdb, xmlDoc *doc)
         int offset;
 
         if (md->setting == Metadata_setting_postproc &&
-                (offset = settings_offset(md->name)) > 0)
+            (offset = settings_offset(md->name)) > 0)
         {
             const char *val = session_setting_oneval(sdb, offset);
             if (val)
             {
                 xmlNode *r = xmlDocGetRootElement(doc);
                 xmlNode *n = xmlNewTextChild(r, 0, (xmlChar *) "metadata",
-                        (xmlChar *) val);
+                                             (xmlChar *) val);
                 xmlSetProp(n, (xmlChar *) "type", (xmlChar *) md->name);
             }
         }
@@ -337,7 +246,7 @@ static void insert_settings_values(struct session_database *sdb, xmlDoc *doc)
 }
 
 xmlDoc *normalize_record(struct session_database *sdb, struct session *se,
-        Z_External *rec)
+                         const char *rec)
 {
     struct database_retrievalmap *m;
     xmlDoc *rdoc = record_to_xml(sdb, rec);
@@ -400,44 +309,6 @@ const char *session_setting_oneval(struct session_database *db, int offset)
     return db->settings[offset]->value;
 }
 
-
-
-// Initialize YAZ Map structures for MARC-based targets
-static int prepare_yazmarc(struct session_database *sdb)
-{
-    const char *s;
-
-    if (!sdb->settings)
-    {
-        yaz_log(YLOG_WARN, "No settings for %s", sdb->database->url);
-        return -1;
-    }
-    if ((s = session_setting_oneval(sdb, PZ_NATIVESYNTAX)) 
-        && !strncmp(s, "iso2709", 7))
-    {
-        char *encoding = "marc-8s", *e;
-        yaz_iconv_t cm;
-
-        // See if a native encoding is specified
-        if ((e = strchr(s, ';')))
-            encoding = e + 1;
-
-        sdb->yaz_marc = yaz_marc_create();
-        yaz_marc_subfield_str(sdb->yaz_marc, "\t");
-        
-        cm = yaz_iconv_open("utf-8", encoding);
-        if (!cm)
-        {
-            yaz_log(YLOG_FATAL, 
-                    "Unable to map from %s to UTF-8 for target %s", 
-                    encoding, sdb->database->url);
-            return -1;
-        }
-        yaz_marc_iconv(sdb->yaz_marc, cm);
-    }
-    return 0;
-}
-
 // Prepare XSLT stylesheets for record normalization
 // Structures are allocated on the session_wide nmem to avoid having
 // to recompute this for every search. This would lead
@@ -512,11 +383,6 @@ static int prepare_session_database(struct session *se,
                 "No settings associated with %s", sdb->database->url);
         return -1;
     }
-    if (sdb->settings[PZ_NATIVESYNTAX] && !sdb->yaz_marc)
-    {
-        if (prepare_yazmarc(sdb) < 0)
-            return -1;
-    }
     if (sdb->settings[PZ_XSLT] && !sdb->map)
     {
         if (prepare_map(se, sdb) < 0)
@@ -526,7 +392,8 @@ static int prepare_session_database(struct session *se,
 }
 
 // called if watch should be removed because http_channel is to be destroyed
-static void session_watch_cancel(void *data, struct http_channel *c)
+static void session_watch_cancel(void *data, struct http_channel *c,
+                                 void *data2)
 {
     struct session_watchentry *ent = data;
 
@@ -554,9 +421,12 @@ void session_alert_watch(struct session *s, int what)
     if (s->watchlist[what].fun)
     {
         /* our watch is no longer associated with http_channel */
+        void *data;
+        session_watchfun fun;
+
         http_remove_observer(s->watchlist[what].obs);
-        session_watchfun fun = s->watchlist[what].fun;
-        void *data = s->watchlist[what].data;
+        fun = s->watchlist[what].fun;
+        data = s->watchlist[what].data;
 
         /* reset watch before fun is invoked - in case fun wants to set
            it again */
@@ -660,7 +530,6 @@ enum pazpar2_error_code search(struct session *se,
     se->reclist = 0;
     se->num_termlists = 0;
     criteria = parse_filter(se->nmem, filter);
-    se->requestid++;
     live_channels = select_targets(se, criteria);
     if (live_channels)
     {
@@ -684,7 +553,8 @@ enum pazpar2_error_code search(struct session *se,
         else
         {
             no_working++;
-            client_prep_connection(cl);
+            if (client_prep_connection(cl))
+                client_start_search(cl);
         }
     }
 
@@ -706,17 +576,7 @@ static void session_init_databases_fun(void *context, struct database *db)
     int i;
 
     new->database = db;
-    new->yaz_marc = 0;
     
-#ifdef HAVE_ICU
-    if (global_parameters.server && global_parameters.server->icu_chn)
-        new->pct = pp2_charset_create(global_parameters.server->icu_chn);
-    else
-        new->pct = pp2_charset_create(0);
-#else // HAVE_ICU
-    new->pct = pp2_charset_create(0);
-#endif // HAVE_ICU
-
     new->map = 0;
     new->settings 
         = nmem_malloc(se->session_nmem, sizeof(struct settings *) * num);
@@ -738,10 +598,6 @@ static void session_database_destroy(struct session_database *sdb)
 
     for (m = sdb->map; m; m = m->next)
         xsltFreeStylesheet(m->stylesheet);
-    if (sdb->yaz_marc)
-        yaz_marc_destroy(sdb->yaz_marc);
-    if (sdb->pct)
-        pp2_charset_destroy(sdb->pct);
 }
 
 // Initialize session_database list -- this represents this session's view
@@ -791,10 +647,10 @@ void session_apply_setting(struct session *se, char *dbname, char *setting,
     }
     // Jakub: This breaks the filter setting.
     /*if (offset == PZ_ID)
-    {
-        yaz_log(YLOG_WARN, "No need to set pz:id setting. Ignoring");
-        return;
-    }*/
+      {
+      yaz_log(YLOG_WARN, "No need to set pz:id setting. Ignoring");
+      return;
+      }*/
     new->precedence = 0;
     new->target = dbname;
     new->name = setting;
@@ -806,23 +662,16 @@ void session_apply_setting(struct session *se, char *dbname, char *setting,
     // (happens when a search starts and client connections are prepared)
     switch (offset)
     {
-        case PZ_NATIVESYNTAX:
-            if (sdb->yaz_marc)
-            {
-                yaz_marc_destroy(sdb->yaz_marc);
-                sdb->yaz_marc = 0;
-            }
-            break;
-        case PZ_XSLT:
-            if (sdb->map)
-            {
-                struct database_retrievalmap *m;
-                // We don't worry about the map structure -- it's in nmem
-                for (m = sdb->map; m; m = m->next)
-                    xsltFreeStylesheet(m->stylesheet);
-                sdb->map = 0;
-            }
-            break;
+    case PZ_XSLT:
+        if (sdb->map)
+        {
+            struct database_retrievalmap *m;
+            // We don't worry about the map structure -- it's in nmem
+            for (m = sdb->map; m; m = m->next)
+                xsltFreeStylesheet(m->stylesheet);
+            sdb->map = 0;
+        }
+        break;
     }
 }
 
@@ -848,9 +697,9 @@ struct session *new_session(NMEM nmem)
     session->relevance = 0;
     session->total_hits = 0;
     session->total_records = 0;
+    session->number_of_warnings_unknown_elements = 0;
     session->num_termlists = 0;
     session->reclist = 0;
-    session->requestid = -1;
     session->clients = 0;
     session->expected_maxrecs = 0;
     session->session_nmem = nmem;
@@ -862,7 +711,6 @@ struct session *new_session(NMEM nmem)
         session->watchlist[i].data = 0;
         session->watchlist[i].fun = 0;
     }
-
     return session;
 }
 
@@ -933,7 +781,7 @@ struct record_cluster **show(struct session *s, struct reclist_sortparms *sp,
                              NMEM nmem_show)
 {
     struct record_cluster **recs = nmem_malloc(nmem_show, *num 
-                                       * sizeof(struct record_cluster *));
+                                               * sizeof(struct record_cluster *));
     struct reclist_sortparms *spp;
     int i;
 #if USE_TIMING    
@@ -1001,14 +849,12 @@ void statistics(struct session *se, struct statistics *stat)
             stat->num_no_connection++;
         switch (client_get_state(cl))
         {
-            case Client_Connecting: stat->num_connecting++; break;
-            case Client_Initializing: stat->num_initializing++; break;
-            case Client_Searching: stat->num_searching++; break;
-            case Client_Presenting: stat->num_presenting++; break;
-            case Client_Idle: stat->num_idle++; break;
-            case Client_Failed: stat->num_failed++; break;
-            case Client_Error: stat->num_error++; break;
-            default: break;
+        case Client_Connecting: stat->num_connecting++; break;
+        case Client_Working: stat->num_working++; break;
+        case Client_Idle: stat->num_idle++; break;
+        case Client_Failed: stat->num_failed++; break;
+        case Client_Error: stat->num_error++; break;
+        default: break;
         }
         count++;
     }
@@ -1018,7 +864,7 @@ void statistics(struct session *se, struct statistics *stat)
     stat->num_clients = count;
 }
 
-void start_http_listener(void)
+int start_http_listener(void)
 {
     char hp[128] = "";
     struct conf_server *ser = global_parameters.server;
@@ -1035,7 +881,7 @@ void start_http_listener(void)
             sprintf(hp + strlen(hp), "%d", ser->port);
         }
     }
-    http_init(hp);
+    return http_init(hp);
 }
 
 void start_proxy(void)
@@ -1084,13 +930,19 @@ static struct record_metadata *record_metadata_init(
         char * p = value;
         p = normalize7bit_generic(p, " ,/.:([");
         
-        rec_md->data.text = nmem_strdup(nmem, p);
+        rec_md->data.text.disp = nmem_strdup(nmem, p);
+        rec_md->data.text.sort = 0;
     }
-    else if (type == Metadata_type_year)
+    else if (type == Metadata_type_year || type == Metadata_type_date)
     {
         int first, last;
-        if (extract7bit_years((char *) value, &first, &last) < 0)
+        int longdate = 0;
+
+        if (type == Metadata_type_date)
+            longdate = 1;
+        if (extract7bit_dates((char *) value, &first, &last, longdate) < 0)
             return 0;
+
         rec_md->data.number.min = first;
         rec_md->data.number.max = last;
     }
@@ -1099,11 +951,11 @@ static struct record_metadata *record_metadata_init(
     return rec_md;
 }
 
-struct record *ingest_record(struct client *cl, Z_External *rec,
+struct record *ingest_record(struct client *cl, const char *rec,
                              int record_no)
 {
     xmlDoc *xdoc = normalize_record(client_get_database(cl),
-        client_get_session(cl), rec);
+                                    client_get_session(cl), rec);
     xmlNode *root, *n;
     struct record *record;
     struct record_cluster *cluster;
@@ -1112,6 +964,9 @@ struct record *ingest_record(struct client *cl, Z_External *rec,
     xmlChar *type = 0;
     xmlChar *value = 0;
     struct conf_service *service = global_parameters.server->service;
+    const char *norm_str = 0;
+    pp2_relevance_token_t prt = 0;
+    WRBUF norm_wr = 0;
 
     if (!xdoc)
         return 0;
@@ -1123,15 +978,34 @@ struct record *ingest_record(struct client *cl, Z_External *rec,
         xmlFreeDoc(xdoc);
         return 0;
     }
-
+    
     record = record_create(se->nmem, 
                            service->num_metadata, service->num_sortkeys, cl,
                            record_no);
 
-    mergekey_norm = (xmlChar *) nmem_strdup(se->nmem, (char*) mergekey);
-    xmlFree(mergekey);
-    normalize7bit_mergekey((char *) mergekey_norm, 0);
+    prt = pp2_relevance_tokenize(
+        global_parameters.server->mergekey_pct, (const char *) mergekey);
+
+
+    norm_wr = wrbuf_alloc();
+    
+    while ((norm_str = pp2_relevance_token_next(prt)))
+    {
+        if (*norm_str)
+        {
+            if (wrbuf_len(norm_wr))
+                wrbuf_puts(norm_wr, " ");
+            wrbuf_puts(norm_wr, norm_str);
+        }
+    }
+        
+    mergekey_norm = (xmlChar *)nmem_strdup(se->nmem, wrbuf_cstr(norm_wr));
+    wrbuf_destroy(norm_wr);
+
+    pp2_relevance_token_destroy(prt);
 
+    xmlFree(mergekey);
+    
     cluster = reclist_insert(se->reclist, 
                              global_parameters.server->service, 
                              record, (char *) mergekey_norm, 
@@ -1146,99 +1020,133 @@ struct record *ingest_record(struct client *cl, Z_External *rec,
         return 0;
     }
     relevance_newrec(se->relevance, cluster);
-
-
-    // now parsing XML record and adding data to cluster or record metadata
-    for (n = root->children; n; n = n->next)
-    {
-        if (type)
-            xmlFree(type);
-        if (value)
-            xmlFree(value);
-        type = value = 0;
-
-        if (n->type != XML_ELEMENT_NODE)
-            continue;
-        if (!strcmp((const char *) n->name, "metadata"))
-        {
-            struct conf_metadata *ser_md = 0;
-            struct conf_sortkey *ser_sk = 0;
-            struct record_metadata **wheretoput = 0;
-            struct record_metadata *rec_md = 0;
-            int md_field_id = -1;
-            int sk_field_id = -1;
-
-            type = xmlGetProp(n, (xmlChar *) "type");
-            value = xmlNodeListGetString(xdoc, n->children, 1);
-
-            if (!type || !value || !*value)
-                continue;
-
-            md_field_id 
-                = conf_service_metadata_field_id(service, (const char *) type);
-            if (md_field_id < 0)
-            {
-                yaz_log(YLOG_WARN, 
-                        "Ignoring unknown metadata element: %s", type);
-                continue;
-            }
-
-            ser_md = &service->metadata[md_field_id];
-
-            if (ser_md->sortkey_offset >= 0){
-                sk_field_id = ser_md->sortkey_offset;
-                ser_sk = &service->sortkeys[sk_field_id];
-            }
-
-            // non-merged metadata
-            rec_md = record_metadata_init(se->nmem, (char *) value,
-                                          ser_md->type);
-            if (!rec_md)
-            {
-                yaz_log(YLOG_WARN, "bad metadata data '%s' for element '%s'",
-                        value, type);
-                continue;
-            }
-            rec_md->next = record->metadata[md_field_id];
-            record->metadata[md_field_id] = rec_md;
-
-            // merged metadata
-            rec_md = record_metadata_init(se->nmem, (char *) value,
-                                          ser_md->type);
-            wheretoput = &cluster->metadata[md_field_id];
-
-            // and polulate with data:
-            // assign cluster or record based on merge action
-            if (ser_md->merge == Metadata_merge_unique)
-            {
-                struct record_metadata *mnode;
-                for (mnode = *wheretoput; mnode; mnode = mnode->next)
-                    if (!strcmp((const char *) mnode->data.text, 
-                                rec_md->data.text))
-                        break;
-                if (!mnode)
-                {
-                    rec_md->next = *wheretoput;
-                    *wheretoput = rec_md;
-                }
-            }
-            else if (ser_md->merge == Metadata_merge_longest)
-            {
-                if (!*wheretoput 
-                    || strlen(rec_md->data.text) 
-                       > strlen((*wheretoput)->data.text))
-                {
-                    *wheretoput = rec_md;
-                    if (ser_sk)
-                    {
-                        char *s = nmem_strdup(se->nmem, rec_md->data.text);
-                        if (!cluster->sortkeys[sk_field_id])
-                            cluster->sortkeys[sk_field_id] = 
-                                nmem_malloc(se->nmem, 
-                                            sizeof(union data_types));
-                        normalize7bit_mergekey(s,
-                             (ser_sk->type == Metadata_sortkey_skiparticle));
-                        cluster->sortkeys[sk_field_id]->text = s;
+     
+     
+     // now parsing XML record and adding data to cluster or record metadata
+     for (n = root->children; n; n = n->next)
+     {
+         if (type)
+             xmlFree(type);
+         if (value)
+             xmlFree(value);
+         type = value = 0;
+
+         if (n->type != XML_ELEMENT_NODE)
+             continue;
+         if (!strcmp((const char *) n->name, "metadata"))
+         {
+             struct conf_metadata *ser_md = 0;
+             struct conf_sortkey *ser_sk = 0;
+             struct record_metadata **wheretoput = 0;
+             struct record_metadata *rec_md = 0;
+             int md_field_id = -1;
+             int sk_field_id = -1;
+
+             type = xmlGetProp(n, (xmlChar *) "type");
+             value = xmlNodeListGetString(xdoc, n->children, 1);
+
+             if (!type || !value || !*value)
+                 continue;
+
+             md_field_id 
+                 = conf_service_metadata_field_id(service, (const char *) type);
+             if (md_field_id < 0)
+             {
+                 yaz_log(YLOG_WARN, 
+                         "Ignoring unknown metadata element: %s", type);
+                 continue;
+             }
+
+             ser_md = &service->metadata[md_field_id];
+
+             if (ser_md->sortkey_offset >= 0){
+                 sk_field_id = ser_md->sortkey_offset;
+                 ser_sk = &service->sortkeys[sk_field_id];
+             }
+
+             // non-merged metadata
+             rec_md = record_metadata_init(se->nmem, (char *) value,
+                                           ser_md->type);
+             if (!rec_md)
+             {
+                 yaz_log(YLOG_WARN, "bad metadata data '%s' for element '%s'",
+                         value, type);
+                 continue;
+             }
+             wheretoput = &record->metadata[md_field_id];
+             while (*wheretoput)
+                 wheretoput = &(*wheretoput)->next;
+             *wheretoput = rec_md;
+
+             // merged metadata
+             rec_md = record_metadata_init(se->nmem, (char *) value,
+                                           ser_md->type);
+             wheretoput = &cluster->metadata[md_field_id];
+
+             // and polulate with data:
+             // assign cluster or record based on merge action
+             if (ser_md->merge == Metadata_merge_no)
+             {
+                 while (*wheretoput)
+                     wheretoput = &(*wheretoput)->next;
+                 *wheretoput = rec_md;
+             }
+             if (ser_md->merge == Metadata_merge_unique)
+             {
+                 struct record_metadata *mnode;
+                 for (mnode = *wheretoput; mnode; mnode = mnode->next)
+                     if (!strcmp((const char *) mnode->data.text.disp, 
+                                 rec_md->data.text.disp))
+                         break;
+                 if (!mnode)
+                 {
+                     rec_md->next = *wheretoput;
+                     *wheretoput = rec_md;
+                 }
+             }
+             else if (ser_md->merge == Metadata_merge_longest)
+             {
+                 if (!*wheretoput 
+                     || strlen(rec_md->data.text.disp) 
+                     > strlen((*wheretoput)->data.text.disp))
+                 {
+                     *wheretoput = rec_md;
+                     if (ser_sk)
+                     {
+                         const char *sort_str = 0;
+                         int skip_article = 
+                             ser_sk->type == Metadata_sortkey_skiparticle;
+
+                         if (!cluster->sortkeys[sk_field_id])
+                             cluster->sortkeys[sk_field_id] = 
+                                 nmem_malloc(se->nmem, 
+                                             sizeof(union data_types));
+                         
+                         prt = pp2_relevance_tokenize(
+                             global_parameters.server->sort_pct,
+                             rec_md->data.text.disp);
+
+                         pp2_relevance_token_next(prt);
+                         
+                         sort_str = pp2_get_sort(prt, skip_article);
+                         
+                         cluster->sortkeys[sk_field_id]->text.disp = 
+                             rec_md->data.text.disp;
+                         if (!sort_str)
+                         {
+                             sort_str = rec_md->data.text.disp;
+                             yaz_log(YLOG_WARN, 
+                                     "Could not make sortkey. Bug #1858");
+                         }
+                         cluster->sortkeys[sk_field_id]->text.sort = 
+                             nmem_strdup(se->nmem, sort_str);
+#if 0
+                         yaz_log(YLOG_LOG, "text disp=%s",
+                                 cluster->sortkeys[sk_field_id]->text.disp);
+                         yaz_log(YLOG_LOG, "text sort=%s",
+                                 cluster->sortkeys[sk_field_id]->text.sort);
+#endif
+                         pp2_relevance_token_destroy(prt);
                     }
                 }
             }
@@ -1265,15 +1173,6 @@ struct record *ingest_record(struct client *cl, Z_External *rec,
                     if (this_max > (*wheretoput)->data.number.max)
                         (*wheretoput)->data.number.max = this_max;
                 }
-#ifdef GAGA
-                if (ser_sk)
-                {
-                    union data_types *sdata 
-                        = cluster->sortkeys[sk_field_id];
-                    yaz_log(YLOG_LOG, "SK range: %d-%d",
-                            sdata->number.min, sdata->number.max);
-                }
-#endif
             }
 
 
@@ -1305,9 +1204,13 @@ struct record *ingest_record(struct client *cl, Z_External *rec,
             xmlFree(value);
             type = value = 0;
         }
-        else
-            yaz_log(YLOG_WARN,
-                    "Unexpected element %s in internal record", n->name);
+         else
+         {
+             if (se->number_of_warnings_unknown_elements == 0)
+                 yaz_log(YLOG_WARN,
+                         "Unexpected element in internal record: %s", n->name);
+             se->number_of_warnings_unknown_elements++;
+         }
     }
     if (type)
         xmlFree(type);