No need for recursive mutex

[pazpar2-moved-to-github.git] / src / client.c

diff --git a/src/client.c b/src/client.c
index b5df1c1..5a73db2 100644 (file)
--- a/src/client.c
+++ b/src/client.c
@@ -136,10 +136,14 @@ enum client_state client_get_state(struct client *cl)
 
 void client_set_state(struct client *cl, enum client_state st)
 {
+    int was_active = 0;
+    if (client_is_active(cl))
+        was_active = 1;
     cl->state = st;
-    /* no need to check for all client being non-active if this one
-       already is. Note that session_active_clients also LOCKS session */
-    if (!client_is_active(cl) && cl->session)
+    /* If client is going from being active to inactive and all clients
+       are now idle we fire a watch for the session . The assumption is
+       that session is not mutex locked if client is already active */
+    if (was_active && !client_is_active(cl) && cl->session)
     {
         int no_active = session_active_clients(cl->session);
         if (no_active == 0)
@@ -400,9 +404,9 @@ int client_report_facets(struct client *cl, ZOOM_resultset rs) {
     ZOOM_facet_field *facets = ZOOM_resultset_facets(rs);
     int facet_num;
     struct session *se = client_get_session(cl);
-    yaz_log(YLOG_DEBUG, "client_report_facets %p %p", rs, cl->resultset);
-
     facet_num = ZOOM_resultset_facets_size(rs);
+    yaz_log(YLOG_DEBUG, "client_report_facets: %d", facet_num);
+
     for (facet_idx = 0; facet_idx < facet_num; facet_idx++) {
         const char *name = ZOOM_facet_field_name(facets[facet_idx]);
         size_t term_idx;
@@ -562,6 +566,7 @@ static int client_set_facets_request(struct client *cl, ZOOM_connection link) {
     int num = service->num_metadata;
     WRBUF wrbuf = wrbuf_alloc();
     int first = 1;
+    yaz_log(YLOG_DEBUG, "Facet settings, sort: %s count: %s", opt_facet_term_sort, opt_facet_term_count);
     for (index = 0; index < num; index++) {
         struct conf_metadata *conf_meta = &service->metadata[index];
         if (conf_meta->termlist) {
@@ -572,10 +577,10 @@ static int client_set_facets_request(struct client *cl, ZOOM_connection link) {
             wrbuf_printf(wrbuf, "@attr 1=%s ", conf_meta->name);
 
             if (opt_facet_term_sort && opt_facet_term_sort[0] != '\0') {
-                wrbuf_printf(wrbuf, " 2=%s ", opt_facet_term_sort);
+                wrbuf_printf(wrbuf, " @attr 2=%s ", opt_facet_term_sort);
             }
             if (opt_facet_term_count && opt_facet_term_count[0] != '\0') {
-                wrbuf_printf(wrbuf, " 3=%s ", opt_facet_term_count);
+                wrbuf_printf(wrbuf, " @attr 3=%s ", opt_facet_term_count);
             }
         }
     }
@@ -589,14 +594,16 @@ static int client_set_facets_request(struct client *cl, ZOOM_connection link) {
 
 int client_has_facet(struct client *cl, const char *name) {
     ZOOM_facet_field facet_field;
-    if (!cl || !cl->resultset || !name)
+    if (!cl || !cl->resultset || !name) {
+        yaz_log(YLOG_DEBUG, "client has facet: Missing %p %p %s", cl, (cl ? cl->resultset: 0), name);
         return 0;
+    }
     facet_field = ZOOM_resultset_get_facet_field(cl->resultset, name);
     if (facet_field) {
-        yaz_log(YLOG_DEBUG, "target has facets for %s", name);
+        yaz_log(YLOG_DEBUG, "client: has facets for %s", name);
         return 1;
     }
-    yaz_log(YLOG_DEBUG, "target: No facets for %s", name);
+    yaz_log(YLOG_DEBUG, "client: No facets for %s", name);
     return 0;
 }