-# $Id: IRSpy.pm,v 1.57 2007-01-20 09:53:20 mike Exp $
+# $Id: IRSpy.pm,v 1.63 2007-02-22 15:43:13 mike Exp $
package ZOOM::IRSpy;
sub _irspy_to_zeerex {
- my ($this, $conn) = @_;
+ my $this = shift();
+ my($conn, $save_xml) = @_;
my $irspy_doc = $conn->record()->{zeerex}->ownerDocument;
- my $save_xml = 0;
if ($save_xml) {
unlink('/tmp/irspy_orig.xml');
my($conn) = @_;
$conn->log("irspy", "rewriting XML record");
- my $rec = $this->_irspy_to_zeerex($conn);
+ my $rec = $this->_irspy_to_zeerex($conn, $ENV{IRSPY_SAVE_XML});
_really_rewrite_record($this->{conn}, $rec);
}
my $i0 = ZOOM::event(\@conn);
$this->log("irspy_event",
"ZOOM_event(", scalar(@conn), " connections) = $i0");
- last if $i0 == 0 || $i0 == -3; # no events or no connections
+ if ($i0 < 1) {
+ my %messages = (
+ 0 => "no events remain",
+ -1 => "ZOOM::event() argument not a reference",
+ -2 => "ZOOM::event() reference not an array",
+ -3 => "no connections remain",
+ -4 => "too many connections for ZOOM::event()",
+ );
+ my $message = $messages{$i0} || "ZOOM::event() returned $i0";
+ $this->log("irspy", $message);
+ last;
+ }
+
my $conn = $conn[$i0-1];
my $ev = $conn->last_event();
my $evstr = ZOOM::event_str($ev);
eval { $conn->_check() };
if ($@ &&
($ev == ZOOM::Event::RECV_DATA ||
- $ev == ZOOM::Event::RECV_APDU ||
$ev == ZOOM::Event::ZEND)) {
# An error in, say, a search response, becomes visible to
# ZOOM before the Receive Data event is sent and persists
# each report the same error. So we just ignore errors on
# "unimportant" events. ### But this doesn't work for,
# say, a Connection Refused, as the only event that shows
- # us this error is the End.
+ # us this error is the ZEND.
$conn->log("irspy_event", "ignoring error ",
"on event $ev ($evstr): $@");
next;
$finished = 0;
}
my $ev = $conn->peek_event();
- if ($ev != ZOOM::Event::ZEND) {
+ if ($ev != 0 && $ev != ZOOM::Event::ZEND) {
my $evstr = ZOOM::event_str($ev);
$this->log("irspy", "$conn has event $ev ($evstr) waiting");
$finished = 0;
}
}
- # This really shouldn't be necessary, but it's belt and braces
+ # This really shouldn't be necessary, and in practice it rarely
+ # helps, but it's belt and braces. For now, we don't do this
+ # (hence the zero in the $nruns check).
if (!$finished) {
- if (++$nruns < 3) {
+ if (++$nruns < 0) {
$this->log("irspy", "back into main loop, ${nruns}th time");
goto ROUND_AND_ROUND_WE_GO;
} else {
# This shouldn't happen emit anything either:
@conn = @{ $this->{connections} };
- while (my $i1 = ZOOM::event(\@conn)) {
+ while ((my $i1 = ZOOM::event(\@conn)) > 0) {
my $conn = $conn[$i1-1];
my $ev = $conn->last_event();
my $evstr = ZOOM::event_str($ev);
- warn "$conn still has ZOOM-C level task queued: $ev ($evstr)"
+ $this->log("irspy",
+ "$conn still has ZOOM-C level task queued: $ev ($evstr)")
if $ev != ZOOM::Event::ZEND;
}