Updated footer comment
[yazproxy-moved-to-github.git] / src / yaz-proxy.cpp
index 926d5b4..1d6e22c 100644 (file)
@@ -1,7 +1,5 @@
-/* $Id: yaz-proxy.cpp,v 1.78 2008-02-21 09:33:23 adam Exp $
-   Copyright (c) 1998-2008, Index Data.
-
-This file is part of the yazproxy.
+/* This file is part of YAZ proxy
+   Copyright (C) 1998-2009 Index Data
 
 YAZ proxy is free software; you can redistribute it and/or modify it under
 the terms of the GNU General Public License as published by the Free
@@ -14,10 +12,9 @@ FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
 for more details.
 
 You should have received a copy of the GNU General Public License
-along with YAZ proxy; see the file LICENSE.  If not, write to the
-Free Software Foundation, 59 Temple Place - Suite 330, Boston, MA
-02111-1307, USA.
- */
+along with this program; if not, write to the Free Software
+Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
+*/
 
 #ifdef WIN32
 #define HAVE_SYS_STAT_H 1
@@ -54,6 +51,12 @@ Free Software Foundation, 59 Temple Place - Suite 330, Boston, MA
 #include <yaz/oid_db.h>
 #include "msg-thread.h"
 
+#if YAZ_VERSIONL >= 0x03001D
+#define YAZ_HAS_MK_SURROGATE 1
+#else
+#define YAZ_HAS_MK_SURROGATE 0
+#endif
+
 using namespace yazpp_1;
 
 #ifdef WIN32
@@ -221,7 +224,7 @@ Yaz_Proxy::Yaz_Proxy(IPDU_Observable *the_PDU_Observable,
     m_client_idletime = 600;
     m_target_idletime = 600;
     m_max_sockets = 1024;
-    m_optimize = xstrdup ("1");
+    m_optimize = xstrdup("1");
     strcpy(m_session_str, "0 ");
     m_session_no = 0;
     m_bytes_sent = 0;
@@ -320,14 +323,14 @@ Yaz_Proxy::~Yaz_Proxy()
     if (m_stylesheet_xsp)
         xsltFreeStylesheet((xsltStylesheetPtr) m_stylesheet_xsp);
 #endif
-    xfree (m_time_tv);
-
-    xfree (m_peername);
-    xfree (m_schema);
-    xfree (m_backend_type);
-    xfree (m_backend_charset);
-    xfree (m_usemarcon_ini_stage1);
-    xfree (m_usemarcon_ini_stage2);
+    xfree(m_time_tv);
+
+    xfree(m_peername);
+    xfree(m_schema);
+    xfree(m_backend_type);
+    xfree(m_backend_charset);
+    xfree(m_usemarcon_ini_stage1);
+    xfree(m_usemarcon_ini_stage2);
     delete m_usemarcon;
     if (m_s2z_odr_init)
         odr_destroy(m_s2z_odr_init);
@@ -365,13 +368,13 @@ int Yaz_Proxy::set_config(const char *config)
 
 void Yaz_Proxy::set_default_target(const char *target)
 {
-    xfree (m_default_target);
+    xfree(m_default_target);
     m_default_target = 0;
     if (target)
-        m_default_target = (char *) xstrdup (target);
+        m_default_target = (char *) xstrdup(target);
 }
 
-void Yaz_Proxy::set_proxy_negotiation (const char *charset, const char *lang,
+void Yaz_Proxy::set_proxy_negotiation(const char *charset, const char *lang,
                                        const char *default_charset)
 {
     yaz_log(YLOG_DEBUG, "%sSet the proxy negotiation: charset to '%s', "
@@ -379,16 +382,16 @@ void Yaz_Proxy::set_proxy_negotiation (const char *charset, const char *lang,
         charset?charset:"none",
         default_charset?default_charset:"none",
         lang?lang:"none");
-    xfree (m_proxy_negotiation_charset);
-    xfree (m_proxy_negotiation_lang);
+    xfree(m_proxy_negotiation_charset);
+    xfree(m_proxy_negotiation_lang);
     m_proxy_negotiation_charset = m_proxy_negotiation_lang = 0;
     if (charset)
-        m_proxy_negotiation_charset = (char *) xstrdup (charset);
+        m_proxy_negotiation_charset = (char *) xstrdup(charset);
     if (lang)
-        m_proxy_negotiation_lang = (char *) xstrdup (lang);
+        m_proxy_negotiation_lang = (char *) xstrdup(lang);
     if (default_charset)
         m_proxy_negotiation_default_charset =
-            (char *) xstrdup (default_charset);
+            (char *) xstrdup(default_charset);
 }
 
 Yaz_ProxyConfig *Yaz_Proxy::check_reconfigure()
@@ -441,7 +444,7 @@ IPDU_Observer *Yaz_Proxy::sessionNotify(IPDU_Observable
                 (long) time(0), m_session_no, 0);
     m_session_no++;
 
-    yaz_log (YLOG_LOG, "%sNew session %s", session_str, peername);
+    yaz_log(YLOG_LOG, "%sNew session %s", session_str, peername);
 
     Yaz_Proxy *new_proxy = new Yaz_Proxy(the_PDU_Observable,
                                          m_socket_observable, this);
@@ -474,7 +477,7 @@ IPDU_Observer *Yaz_Proxy::sessionNotify(IPDU_Observable
     // create thread object the first time we get an incoming connection
     if (!m_my_thread && m_num_msg_threads > 0)
     {
-        yaz_log (YLOG_LOG, "%sStarting message thread management. number=%d",
+        yaz_log(YLOG_LOG, "%sStarting message thread management. number=%d",
                  session_str, m_num_msg_threads);
         m_my_thread = new Msg_Thread(m_socket_observable, m_num_msg_threads);
     }
@@ -561,7 +564,7 @@ int Yaz_Proxy::get_number_of_connections()
             no_connections++;
         }
     }
-    yaz_log (YLOG_LOG, "%sExisting %s connections: %d", m_session_str, m_proxyTarget,
+    yaz_log(YLOG_LOG, "%sExisting %s connections: %d", m_session_str, m_proxyTarget,
         no_connections);
     return no_connections;
 }
@@ -569,7 +572,7 @@ int Yaz_Proxy::get_number_of_connections()
 Yaz_ProxyClient *Yaz_Proxy::get_client(Z_APDU *apdu, const char *cookie,
                                        const char *proxy_host, int *http_code)
 {
-    assert (m_parent);
+    assert(m_parent);
     Yaz_Proxy *parent = m_parent;
     Yaz_ProxyClient *c = m_client;
 
@@ -651,8 +654,8 @@ Yaz_ProxyClient *Yaz_Proxy::get_client(Z_APDU *apdu, const char *cookie,
     {   // search in sessions with a cookie
         for (c = parent->m_clientPool; c; c = c->m_next)
         {
-            assert (c->m_prev);
-            assert (*c->m_prev == c);
+            assert(c->m_prev);
+            assert(*c->m_prev == c);
             if (c->m_cookie && !strcmp(cookie,c->m_cookie) &&
                 !strcmp(m_proxyTarget, c->get_hostname()))
             {
@@ -662,7 +665,7 @@ Yaz_ProxyClient *Yaz_Proxy::get_client(Z_APDU *apdu, const char *cookie,
                 // we have an initRequest we can safely do re-open
                 if (c->m_waiting && apdu->which == Z_APDU_initRequest)
                 {
-                    yaz_log (YLOG_LOG, "%s REOPEN target=%s", m_session_str,
+                    yaz_log(YLOG_LOG, "%s REOPEN target=%s", m_session_str,
                              c->get_hostname());
                     c->close();
                     c->m_init_flag = 0;
@@ -686,7 +689,7 @@ Yaz_ProxyClient *Yaz_Proxy::get_client(Z_APDU *apdu, const char *cookie,
                     c->m_server->m_client = 0;
                 c->m_server = this;
                 (parent->m_seqno)++;
-                yaz_log (YLOG_DEBUG, "get_client 1 %p %p", this, c);
+                yaz_log(YLOG_DEBUG, "get_client 1 %p %p", this, c);
                 return c;
             }
         }
@@ -706,7 +709,7 @@ Yaz_ProxyClient *Yaz_Proxy::get_client(Z_APDU *apdu, const char *cookie,
                 && !strcmp(m_proxyTarget, c->get_hostname()))
             {
                 // found it in cache
-                yaz_log (YLOG_LOG, "%sREUSE %d %s",
+                yaz_log(YLOG_LOG, "%sREUSE %d %s",
                          m_session_str, parent->m_seqno, c->get_hostname());
                 
                 c->m_seqno = parent->m_seqno;
@@ -730,7 +733,7 @@ Yaz_ProxyClient *Yaz_Proxy::get_client(Z_APDU *apdu, const char *cookie,
     {
         if (apdu->which != Z_APDU_initRequest)
         {
-            yaz_log (YLOG_LOG, "%sno init request as first PDU", m_session_str);
+            yaz_log(YLOG_LOG, "%sno init request as first PDU", m_session_str);
             *http_code = 500;
             return 0;
         }
@@ -738,7 +741,7 @@ Yaz_ProxyClient *Yaz_Proxy::get_client(Z_APDU *apdu, const char *cookie,
         int no_in_use = get_number_of_connections();
         if (no_in_use >= m_max_sockets)
         {
-            yaz_log (YLOG_LOG, "%smax sockets reached %d", m_session_str,
+            yaz_log(YLOG_LOG, "%smax sockets reached %d", m_session_str,
                 m_max_sockets);
             *http_code = 500;
             return 0;
@@ -748,10 +751,10 @@ Yaz_ProxyClient *Yaz_Proxy::get_client(Z_APDU *apdu, const char *cookie,
         int min_seq = -1;
         int no_of_clients = 0;
         if (parent->m_clientPool)
-            yaz_log (YLOG_DEBUG, "Existing sessions");
+            yaz_log(YLOG_DEBUG, "Existing sessions");
         for (c = parent->m_clientPool; c; c = c->m_next)
         {
-            yaz_log (YLOG_DEBUG, " Session %-3d wait=%d %s cookie=%s", c->m_seqno,
+            yaz_log(YLOG_DEBUG, " Session %-3d wait=%d %s cookie=%s", c->m_seqno,
                                c->m_waiting, c->get_hostname(),
                                c->m_cookie ? c->m_cookie : "");
             no_of_clients++;
@@ -766,17 +769,17 @@ Yaz_ProxyClient *Yaz_Proxy::get_client(Z_APDU *apdu, const char *cookie,
             c = c_min;
             if (c->m_waiting || strcmp(m_proxyTarget, c->get_hostname()))
             {
-                yaz_log (YLOG_LOG, "%sMAXCLIENTS %d Destroy %d",
+                yaz_log(YLOG_LOG, "%sMAXCLIENTS %d Destroy %d",
                          m_session_str, parent->m_max_clients, c->m_seqno);
                 if (c->m_server && c->m_server != this)
                     c->m_server->dec_ref();
             }
             else
             {
-                yaz_log (YLOG_LOG, "%sMAXCLIENTS %d Reuse %d %d %s",
+                yaz_log(YLOG_LOG, "%sMAXCLIENTS %d Reuse %d %d %s",
                          m_session_str, parent->m_max_clients,
                          c->m_seqno, parent->m_seqno, c->get_hostname());
-                xfree (c->m_cookie);
+                xfree(c->m_cookie);
                 c->m_cookie = 0;
                 if (cookie)
                     c->m_cookie = xstrdup(cookie);
@@ -801,7 +804,7 @@ Yaz_ProxyClient *Yaz_Proxy::get_client(Z_APDU *apdu, const char *cookie,
         else
         {
 
-            yaz_log (YLOG_LOG, "%sNEW %d %s",
+            yaz_log(YLOG_LOG, "%sNEW %d %s",
                      m_session_str, parent->m_seqno, m_proxyTarget);
             c = new Yaz_ProxyClient(m_PDU_Observable->clone(), parent);
             c->m_next = parent->m_clientPool;
@@ -811,7 +814,7 @@ Yaz_ProxyClient *Yaz_Proxy::get_client(Z_APDU *apdu, const char *cookie,
             c->m_prev = &parent->m_clientPool;
         }
 
-        xfree (c->m_cookie);
+        xfree(c->m_cookie);
         c->m_cookie = 0;
         if (cookie)
             c->m_cookie = xstrdup(cookie);
@@ -840,7 +843,7 @@ Yaz_ProxyClient *Yaz_Proxy::get_client(Z_APDU *apdu, const char *cookie,
 
         c->set_idAuthentication(apdu);
     }
-    yaz_log (YLOG_DEBUG, "get_client 3 %p %p", this, c);
+    yaz_log(YLOG_DEBUG, "get_client 3 %p %p", this, c);
     return c;
 }
 
@@ -918,7 +921,7 @@ void Yaz_Proxy::convert_xsl_delay()
             {
                 xmlChar *out_buf;
                 int out_len;
-                xmlDocDumpFormatMemory (res, &out_buf, &out_len, 1);
+                xmlDocDumpFormatMemory(res, &out_buf, &out_len, 1);
                 m_stylesheet_nprl->records[m_stylesheet_offset]->
                     u.databaseRecord =
                     z_ext_record_oid(odr_encode(), yaz_oid_recsyn_xml,
@@ -963,11 +966,11 @@ void Yaz_Proxy::convert_to_frontend_type(Z_NamePlusRecordList *p)
                 {
 #if !HAVE_USEMARCON
                     if (m_usemarcon_ini_stage1 && *m_usemarcon_ini_stage1)
-                        yaz_log (YLOG_LOG, "%sError: USEMARCON requested but not available",
+                        yaz_log(YLOG_LOG, "%sError: USEMARCON requested but not available",
                             m_session_str);
 #endif
 #if HAVE_USEMARCON
-                    yaz_log (YLOG_DEBUG, "%sUSEMARCON stage1=%s stage2=%s",
+                    yaz_log(YLOG_DEBUG, "%sUSEMARCON stage1=%s stage2=%s",
                         m_session_str,
                         m_usemarcon_ini_stage1 ? m_usemarcon_ini_stage1 : "(none)",
                         m_usemarcon_ini_stage2 ? m_usemarcon_ini_stage2 : "(none)");
@@ -1176,7 +1179,7 @@ int Yaz_Proxy::send_srw_response(Z_SRW_PDU *srw_pdu, int http_code /* = 200 */)
 
     static Z_SOAP_Handler soap_handlers[2] = {
 #if YAZ_HAVE_XSLT
-        {"http://www.loc.gov/zing/srw/", 0,
+        { (char*) "http://www.loc.gov/zing/srw/", 0,
          (Z_SOAP_fun) yaz_srw_codec},
 #endif
         {0, 0, 0}
@@ -1195,8 +1198,8 @@ int Yaz_Proxy::send_srw_response(Z_SRW_PDU *srw_pdu, int http_code /* = 200 */)
                          soap_handlers, 0, m_s2z_stylesheet);
     if (m_log_mask & PROXY_LOG_REQ_CLIENT)
     {
-        yaz_log (YLOG_LOG, "%sSending %s to client", m_session_str,
-                 gdu_name(gdu));
+        yaz_log(YLOG_LOG, "%sSending %s to client", m_session_str,
+                gdu_name(gdu));
     }
     int len;
     int r = send_GDU(gdu, &len);
@@ -1234,6 +1237,37 @@ int Yaz_Proxy::z_to_srw_diag(ODR o, Z_SRW_searchRetrieveResponse *srw_res,
     return 0;
 }
 
+#if YAZ_HAS_MK_SURROGATE
+#else
+static void yazproxy_mk_sru_surrogate(ODR o, Z_SRW_record *record, int pos,
+                          int code, const char *details)
+{
+    const char *message = yaz_diag_srw_str(code);
+    int len = 200;
+    if (message)
+        len += strlen(message);
+    if (details)
+        len += strlen(details);
+    
+    record->recordData_buf = (char *) odr_malloc(o, len);
+    
+    sprintf(record->recordData_buf, "<diagnostic "
+            "xmlns=\"http://www.loc.gov/zing/srw/diagnostic/\">\n"
+            " <uri>info:srw/diagnostic/1/%d</uri>\n", code);
+    if (details)
+        sprintf(record->recordData_buf + strlen(record->recordData_buf),
+                " <details>%s</details>\n", details);
+    if (message)
+        sprintf(record->recordData_buf + strlen(record->recordData_buf),
+                " <message>%s</message>\n", message);
+    sprintf(record->recordData_buf + strlen(record->recordData_buf),
+            "</diagnostic>\n");
+    record->recordData_len = strlen(record->recordData_buf);
+    record->recordPosition = odr_intdup(o, pos);
+    record->recordSchema = odr_strdup(o, "info:srw/schema/1/diagnostics-v1.1");
+}
+#endif
+
 int Yaz_Proxy::send_to_srw_client_ok(int hits, Z_Records *records, int start)
 {
     ODR o = odr_encode();
@@ -1253,11 +1287,15 @@ int Yaz_Proxy::send_to_srw_client_ok(int hits, Z_Records *records, int start)
             Z_NamePlusRecord *npr = records->u.databaseOrSurDiagnostics->records[i];
             if (npr->which != Z_NamePlusRecord_databaseRecord)
             {
-                srw_res->records[i].recordSchema = "diagnostic";
-                srw_res->records[i].recordPacking = m_s2z_packing;
-                srw_res->records[i].recordData_buf = "67";
-                srw_res->records[i].recordData_len = 2;
-                srw_res->records[i].recordPosition = odr_intdup(o, i+start);
+#if YAZ_HAS_MK_SURROGATE
+                yaz_mk_sru_surrogate(
+                    o, srw_res->records + i, i+start,  
+                    YAZ_SRW_RECORD_NOT_AVAILABLE_IN_THIS_SCHEMA, 0);
+#else
+                yazproxy_mk_sru_surrogate(
+                    o, srw_res->records + i, i+start,  
+                    YAZ_SRW_RECORD_NOT_AVAILABLE_IN_THIS_SCHEMA, 0);
+#endif
                 continue;
             }
             Z_External *r = npr->u.databaseRecord;
@@ -1274,11 +1312,15 @@ int Yaz_Proxy::send_to_srw_client_ok(int hits, Z_Records *records, int start)
             }
             else
             {
-                srw_res->records[i].recordSchema = "diagnostic";
-                srw_res->records[i].recordPacking = m_s2z_packing;
-                srw_res->records[i].recordData_buf = "67";
-                srw_res->records[i].recordData_len = 2;
-                srw_res->records[i].recordPosition = odr_intdup(o, i+start);
+#if YAZ_HAS_MK_SURROGATE
+                yaz_mk_sru_surrogate(
+                    o, srw_res->records + i, i+start,  
+                    YAZ_SRW_RECORD_NOT_AVAILABLE_IN_THIS_SCHEMA, 0);
+#else
+                yazproxy_mk_sru_surrogate(
+                    o, srw_res->records + i, i+start,  
+                    YAZ_SRW_RECORD_NOT_AVAILABLE_IN_THIS_SCHEMA, 0);
+#endif
             }
         }
     }
@@ -1309,12 +1351,13 @@ int Yaz_Proxy::send_srw_search_response(Z_SRW_diagnostic *diagnostics,
 int Yaz_Proxy::send_srw_explain_response(Z_SRW_diagnostic *diagnostics,
                                         int num_diagnostics)
 {
+    int http_status = 404;
     Yaz_ProxyConfig *cfg = check_reconfigure();
     if (cfg)
     {
         int len;
         char *b = cfg->get_explain_doc(odr_encode(), 0 /* target */,
-                                       m_s2z_database, &len);
+                                       m_s2z_database, &len, &http_status);
         if (b)
         {
             Z_SRW_PDU *res = yaz_srw_get(odr_encode(), Z_SRW_explain_response);
@@ -1323,14 +1366,15 @@ int Yaz_Proxy::send_srw_explain_response(Z_SRW_diagnostic *diagnostics,
             er->record.recordData_buf = b;
             er->record.recordData_len = len;
             er->record.recordPacking = m_s2z_packing;
-            er->record.recordSchema = "http://explain.z3950.org/dtd/2.0/";
+            er->record.recordSchema = odr_strdup(odr_encode(),
+                                                 "http://explain.z3950.org/dtd/2.0/");
 
             er->diagnostics = diagnostics;
             er->num_diagnostics = num_diagnostics;
             return send_srw_response(res);
         }
     }
-    return send_http_response(404);
+    return send_http_response(http_status);
 }
 
 int Yaz_Proxy::send_PDU_convert(Z_APDU *apdu)
@@ -1396,7 +1440,7 @@ int Yaz_Proxy::send_PDU_convert(Z_APDU *apdu)
     {
         int len = 0;
         if (m_log_mask & PROXY_LOG_REQ_CLIENT)
-            yaz_log (YLOG_LOG, "%sSending %s to client", m_session_str,
+            yaz_log(YLOG_LOG, "%sSending %s to client", m_session_str,
                      apdu_name(apdu));
         int r = send_Z_PDU(apdu, &len);
         m_bytes_sent += len;
@@ -1599,7 +1643,7 @@ int Yaz_ProxyClient::send_to_target(Z_APDU *apdu)
     const char *apdu_name_tmp = apdu_name(apdu);
     int r = send_Z_PDU(apdu, &len);
     if (m_root->get_log_mask() & PROXY_LOG_REQ_SERVER)
-        yaz_log (YLOG_LOG, "%sSending %s to %s %d bytes",
+        yaz_log(YLOG_LOG, "%sSending %s to %s %d bytes",
                  get_session_str(),
                  apdu_name_tmp, get_hostname(), len);
     m_bytes_sent += len;
@@ -1665,7 +1709,7 @@ Z_APDU *Yaz_Proxy::result_set_optimize(Z_APDU *apdu)
                                           pr->preferredRecordSyntax,
                                           pr->recordComposition))
             {
-                yaz_log (YLOG_LOG, "%sReturned cached records for present request",
+                yaz_log(YLOG_LOG, "%sReturned cached records for present request",
                          m_session_str);
                 Z_APDU *new_apdu = create_Z_PDU(Z_APDU_presentResponse);
                 new_apdu->u.presentResponse->referenceId = pr->referenceId;
@@ -1744,7 +1788,7 @@ Z_APDU *Yaz_Proxy::result_set_optimize(Z_APDU *apdu)
             if (m_client->m_cache.lookup (odr_encode(), &npr, 1, toget,
                                           sr->preferredRecordSyntax, comp))
             {
-                yaz_log (YLOG_LOG, "%sReturned cached records for medium set",
+                yaz_log(YLOG_LOG, "%sReturned cached records for medium set",
                          m_session_str);
                 Z_APDU *new_apdu = create_Z_PDU(Z_APDU_searchResponse);
                 new_apdu->u.searchResponse->referenceId = sr->referenceId;
@@ -1769,7 +1813,7 @@ Z_APDU *Yaz_Proxy::result_set_optimize(Z_APDU *apdu)
             {
                 // medium Set
                 // send present request (medium size)
-                yaz_log (YLOG_LOG, "%sOptimizing search for medium set",
+                yaz_log(YLOG_LOG, "%sOptimizing search for medium set",
                          m_session_str);
 
                 Z_APDU *new_apdu = create_Z_PDU(Z_APDU_presentRequest);
@@ -1787,7 +1831,7 @@ Z_APDU *Yaz_Proxy::result_set_optimize(Z_APDU *apdu)
             m_client->m_last_resultCount <= 0)
         {
             // large set. Return pseudo-search response immediately
-            yaz_log (YLOG_LOG, "%sOptimizing search for large set",
+            yaz_log(YLOG_LOG, "%sOptimizing search for large set",
                      m_session_str);
             Z_APDU *new_apdu = create_Z_PDU(Z_APDU_searchResponse);
             new_apdu->u.searchResponse->referenceId = sr->referenceId;
@@ -1815,7 +1859,7 @@ Z_APDU *Yaz_Proxy::result_set_optimize(Z_APDU *apdu)
             if (m_client->m_cache.lookup (odr_encode(), &npr, 1, toget,
                                           sr->preferredRecordSyntax, comp))
             {
-                yaz_log (YLOG_LOG, "%sReturned cached records for small set",
+                yaz_log(YLOG_LOG, "%sReturned cached records for small set",
                          m_session_str);
                 Z_APDU *new_apdu = create_Z_PDU(Z_APDU_searchResponse);
                 new_apdu->u.searchResponse->referenceId = sr->referenceId;
@@ -1838,7 +1882,7 @@ Z_APDU *Yaz_Proxy::result_set_optimize(Z_APDU *apdu)
             }
             else
             {
-                yaz_log (YLOG_LOG, "%sOptimizing search for small set",
+                yaz_log(YLOG_LOG, "%sOptimizing search for small set",
                          m_session_str);
                 Z_APDU *new_apdu = create_Z_PDU(Z_APDU_presentRequest);
                 Z_PresentRequest *pr = new_apdu->u.presentRequest;
@@ -1860,8 +1904,8 @@ Z_APDU *Yaz_Proxy::result_set_optimize(Z_APDU *apdu)
         m_client->m_cache.clear();
         m_client->m_resultSetStartPoint = 0;
 
-        xfree (m_client->m_last_resultSetId);
-        m_client->m_last_resultSetId = xstrdup (sr->resultSetName);
+        xfree(m_client->m_last_resultSetId);
+        m_client->m_last_resultSetId = xstrdup(sr->resultSetName);
 
         m_client->m_last_databases.set(sr->num_databaseNames,
                                        (const char **) sr->databaseNames);
@@ -1889,7 +1933,7 @@ void Yaz_Proxy::recv_GDU(Z_GDU *apdu, int len)
     m_bytes_recv += len;
 
     if (m_log_mask & PROXY_LOG_REQ_CLIENT)
-        yaz_log (YLOG_LOG, "%sReceiving %s from client %d bytes",
+        yaz_log(YLOG_LOG, "%sReceiving %s from client %d bytes",
                  m_session_str, gdu_name(apdu), len);
 
 #if 0
@@ -2699,7 +2743,7 @@ int Yaz_Proxy::file_access(Z_HTTP_Request *hreq)
     }
     if (m_log_mask & PROXY_LOG_REQ_CLIENT)
     {
-        yaz_log (YLOG_LOG, "%sSending file %s to client", m_session_str,
+        yaz_log(YLOG_LOG, "%sSending file %s to client", m_session_str,
                  fname);
     }
     int len;
@@ -2804,16 +2848,6 @@ void Yaz_Proxy::handle_incoming_HTTP(Z_HTTP_Request *hreq)
                 }
                 auth->u.idPass->userId = odr_strdup(m_s2z_odr_init, authorization_str);
             }
-            else
-            {
-                // Use _client_ IP as shown in the log entries...!
-                auth = (Z_IdAuthentication *) odr_malloc(m_s2z_odr_init, sizeof(Z_IdAuthentication));
-                   auth->which = Z_IdAuthentication_idPass;
-                   auth->u.idPass = (Z_IdPass *) odr_malloc(m_s2z_odr_init, sizeof(Z_IdPass));
-                   auth->u.idPass->groupId  = NULL;
-                   auth->u.idPass->password = NULL;
-                   auth->u.idPass->userId   = odr_strdup(m_s2z_odr_init, m_peername);
-            }
         }              
         
         if (srw_pdu->which == Z_SRW_searchRetrieve_request)
@@ -3360,7 +3394,7 @@ void Yaz_Proxy::releaseClient()
     }
     else if (m_client)
     {
-        yaz_log (YLOG_LOG, "%sShutdown (client to proxy) close %s",
+        yaz_log(YLOG_LOG, "%sShutdown (client to proxy) close %s",
                  m_session_str,
                  m_client->get_hostname());
         assert (m_client->m_waiting != 2);
@@ -3369,13 +3403,13 @@ void Yaz_Proxy::releaseClient()
     }
     else if (!m_parent)
     {
-        yaz_log (YLOG_LOG, "%sshutdown (client to proxy) bad state",
+        yaz_log(YLOG_LOG, "%sshutdown (client to proxy) bad state",
                  m_session_str);
         assert (m_parent);
     }
     else
     {
-        yaz_log (YLOG_LOG, "%sShutdown (client to proxy)",
+        yaz_log(YLOG_LOG, "%sShutdown (client to proxy)",
                  m_session_str);
     }
     if (m_parent)
@@ -3405,7 +3439,7 @@ const char *Yaz_ProxyClient::get_session_str()
 
 void Yaz_ProxyClient::shutdown()
 {
-    yaz_log (YLOG_LOG, "%sShutdown (proxy to target) %s", get_session_str(),
+    yaz_log(YLOG_LOG, "%sShutdown (proxy to target) %s", get_session_str(),
              get_hostname());
 
     if (m_server)
@@ -3420,7 +3454,7 @@ void Yaz_ProxyClient::shutdown()
 void Yaz_Proxy::failNotify()
 {
     inc_request_no();
-    yaz_log (YLOG_LOG, "%sConnection closed by client", get_session_str());
+    yaz_log(YLOG_LOG, "%sConnection closed by client", get_session_str());
     dec_ref();
 }
 
@@ -3440,11 +3474,12 @@ void Yaz_Proxy::send_response_fail_client(const char *addr)
             send_srw_explain_response(diagnostic, num_diagnostic);
     }            
 }
+
 void Yaz_ProxyClient::failNotify()
 {
     if (m_server)
         m_server->inc_request_no();
-    yaz_log (YLOG_LOG, "%sConnection closed by target %s",
+    yaz_log(YLOG_LOG, "%sConnection closed by target %s",
              get_session_str(), get_hostname());
 
     if (m_server)
@@ -3456,7 +3491,7 @@ void Yaz_ProxyClient::connectNotify()
 {
     const char *s = get_session_str();
     const char *h = get_hostname();
-    yaz_log (YLOG_LOG, "%sConnection accepted by %s timeout=%d", s, h,
+    yaz_log(YLOG_LOG, "%sConnection accepted by %s timeout=%d", s, h,
              m_target_idletime);
     timeout(m_target_idletime);
     if (!m_server)
@@ -3479,8 +3514,8 @@ Yaz_ProxyClient::~Yaz_ProxyClient()
     odr_destroy(m_init_odr);
     odr_destroy(m_idAuthentication_odr);
     delete m_last_query;
-    xfree (m_last_resultSetId);
-    xfree (m_cookie);
+    xfree(m_last_resultSetId);
+    xfree(m_cookie);
 }
 
 void Yaz_ProxyClient::pre_init_client()
@@ -3624,7 +3659,7 @@ void Yaz_Proxy::timeoutNotify()
         case timeout_busy:
             inc_request_no();
             m_in_queue.clear();
-            yaz_log (YLOG_LOG, "%sTimeout (client to proxy)", m_session_str);
+            yaz_log(YLOG_LOG, "%sTimeout (client to proxy)", m_session_str);
             dec_ref();
             break;
         case timeout_reduce:
@@ -3658,7 +3693,7 @@ void Yaz_ProxyClient::timeoutNotify()
     if (m_server)
         m_server->inc_request_no();
 
-    yaz_log (YLOG_LOG, "%sTimeout (proxy to target) %s", get_session_str(),
+    yaz_log(YLOG_LOG, "%sTimeout (proxy to target) %s", get_session_str(),
              get_hostname());
 
     if (m_server)
@@ -3707,8 +3742,8 @@ const char *Yaz_Proxy::option(const char *name, const char *value)
 {
     if (!strcmp (name, "optimize")) {
         if (value) {
-            xfree (m_optimize);
-            m_optimize = xstrdup (value);
+            xfree(m_optimize);
+            m_optimize = xstrdup(value);
         }
         return m_optimize;
     }
@@ -3749,7 +3784,7 @@ void Yaz_ProxyClient::recv_Z_PDU(Z_APDU *apdu, int len)
     m_pdu_recv++;
     m_waiting = 0;
     if (m_root->get_log_mask() & PROXY_LOG_REQ_SERVER)
-        yaz_log (YLOG_LOG, "%sReceiving %s from %s %d bytes", get_session_str(),
+        yaz_log(YLOG_LOG, "%sReceiving %s from %s %d bytes", get_session_str(),
                  apdu_name(apdu), get_hostname(), len);
     if (apdu->which == Z_APDU_initResponse)
     {
@@ -3907,19 +3942,19 @@ void Yaz_Proxy::base64_decode(const char *base64, char *buf, int buf_len)
         char ch = (char) (ch_ptr - base64_chars);
         switch (index)
         {
-            case 1:
-                buf[buf_pos] = ch << 2;
-                break;
-            case 2:
-                buf[buf_pos++] += (ch & 0x30) >> 4;
-                buf[buf_pos] = (ch & 0x0f) << 4;
-                break;
-            case 3:
-                buf[buf_pos++] += (ch & 0x3c) >> 2;
-                buf[buf_pos] = (ch & 0x03) << 6;
-                break;
-            case 4:
-                buf[buf_pos++] += ch;
+        case 1:
+            buf[buf_pos] = ch << 2;
+            break;
+        case 2:
+            buf[buf_pos++] += (ch & 0x30) >> 4;
+            buf[buf_pos] = (ch & 0x0f) << 4;
+            break;
+        case 3:
+            buf[buf_pos++] += (ch & 0x3c) >> 2;
+            buf[buf_pos] = (ch & 0x03) << 6;
+            break;
+        case 4:
+            buf[buf_pos++] += ch;
         }
         if (index < 4)
             index++;
@@ -3932,6 +3967,7 @@ void Yaz_Proxy::base64_decode(const char *base64, char *buf, int buf_len)
 /*
  * Local variables:
  * c-basic-offset: 4
+ * c-file-style: "Stroustrup"
  * indent-tabs-mode: nil
  * End:
  * vim: shiftwidth=4 tabstop=8 expandtab