yaz-moved-to-github.git
16 years agoVersion 3.0.10 YAZ.3.0.10
Adam Dickmeiss [Wed, 22 Aug 2007 09:09:03 +0000 (09:09 +0000)]
Version 3.0.10

16 years agoUpdated RPM spec file with some enhancements from Martin Armbrecht.
Adam Dickmeiss [Wed, 22 Aug 2007 08:58:16 +0000 (08:58 +0000)]
Updated RPM spec file with some enhancements from Martin Armbrecht.

16 years agoRevert last change regarding display_term. There still exists systems
Adam Dickmeiss [Wed, 22 Aug 2007 08:11:28 +0000 (08:11 +0000)]
Revert last change regarding display_term. There still exists systems
with old behavior.

16 years agoAlways honor display_term being set by backend handler. There is no
Adam Dickmeiss [Tue, 21 Aug 2007 13:20:51 +0000 (13:20 +0000)]
Always honor display_term being set by backend handler. There is no
need to be pre YAZ 2.0 backwards compatible.

16 years agoFixed scan continuation line not being set for displayTerm being ste
Adam Dickmeiss [Tue, 21 Aug 2007 13:19:44 +0000 (13:19 +0000)]
Fixed scan continuation line not being set for displayTerm being ste

16 years agoAdded support for SRU scan.
Adam Dickmeiss [Thu, 16 Aug 2007 10:09:36 +0000 (10:09 +0000)]
Added support for SRU scan.

16 years agoCOmment.
Mike Taylor [Wed, 15 Aug 2007 17:53:11 +0000 (17:53 +0000)]
COmment.

16 years agoFor XML ILL Request, YAZ attaches a dummy XML record as the ItemRequest
Adam Dickmeiss [Tue, 14 Aug 2007 12:22:51 +0000 (12:22 +0000)]
For XML ILL Request, YAZ attaches a dummy XML record as the ItemRequest
EXTERNAL in the targetPart structure.

16 years agoFor XML ILL Response, YAZ prints Octet aligned buf (presumably XML)
Adam Dickmeiss [Tue, 14 Aug 2007 12:21:14 +0000 (12:21 +0000)]
For XML ILL Response, YAZ prints Octet aligned buf (presumably XML)
if that is the ItemRequest EXTERNAL in the targetPart structure.

16 years agoDocument ccl2rpn setting.
Mike Taylor [Mon, 13 Aug 2007 16:58:46 +0000 (16:58 +0000)]
Document ccl2rpn setting.

16 years agoAdd entity reference-tools-ccl-qualifiers
Mike Taylor [Mon, 13 Aug 2007 16:58:27 +0000 (16:58 +0000)]
Add entity reference-tools-ccl-qualifiers
Better section title.

16 years agoBetter section title.
Mike Taylor [Mon, 13 Aug 2007 16:58:02 +0000 (16:58 +0000)]
Better section title.

16 years agoAdd entity reference-tools-ccl-qualifiers
Mike Taylor [Mon, 13 Aug 2007 16:57:40 +0000 (16:57 +0000)]
Add entity reference-tools-ccl-qualifiers

16 years agoAdd code to compile CCL qualifiers if specified using <ccl2rpn>.
Mike Taylor [Mon, 13 Aug 2007 16:46:47 +0000 (16:46 +0000)]
Add code to compile CCL qualifiers if specified using <ccl2rpn>.

16 years agoAdd ccl_transform element to struct gfs_server.
Mike Taylor [Mon, 13 Aug 2007 16:46:19 +0000 (16:46 +0000)]
Add ccl_transform element to struct gfs_server.

16 years agoIf a CCL qualifier mapping file has been specified, then incoming CCL
Mike Taylor [Mon, 13 Aug 2007 16:43:59 +0000 (16:43 +0000)]
If a CCL qualifier mapping file has been specified, then incoming CCL
queries are now transformed into Type-1 before being being handed off
to the back-end callback.  This is supported for Z39.50 searches, but
not for Scan, nor for SRU (where it's impossible to send CCL anyway).

16 years agoDescribe CCL support in GFS.
Mike Taylor [Mon, 13 Aug 2007 16:41:59 +0000 (16:41 +0000)]
Describe CCL support in GFS.

16 years agoFix minor type mismatch
Mike Taylor [Mon, 13 Aug 2007 16:23:30 +0000 (16:23 +0000)]
Fix minor type mismatch

16 years agoFixed bug #1338: GFS crashes when startRecord > number of hits.
Adam Dickmeiss [Fri, 27 Jul 2007 08:05:52 +0000 (08:05 +0000)]
Fixed bug #1338: GFS crashes when startRecord > number of hits.

16 years agoRemoevd unused definition
Adam Dickmeiss [Fri, 13 Jul 2007 09:28:43 +0000 (09:28 +0000)]
Remoevd unused definition

16 years agoAttribute spec file. Not in use yet
Adam Dickmeiss [Wed, 11 Jul 2007 08:35:57 +0000 (08:35 +0000)]
Attribute spec file. Not in use yet

16 years agoMake configure produce error if --with-pcap=yes or --with-pcap is given
Adam Dickmeiss [Tue, 10 Jul 2007 14:41:36 +0000 (14:41 +0000)]
Make configure produce error if --with-pcap=yes  or --with-pcap is given
and libpcap is not found. Added --with-pcap to configure in PRM spec.

16 years agoFor libpcap default search use AC_CHECK_LIB, AC_CHECK_HEADER. For
Adam Dickmeiss [Tue, 10 Jul 2007 14:28:37 +0000 (14:28 +0000)]
For libpcap default search use AC_CHECK_LIB, AC_CHECK_HEADER. For
manual libpcap spec, accept all values. But omit -L/-I for /usr.

16 years agoRemoved / in doc install rule to avoid double-slash (cygwin)
Adam Dickmeiss [Tue, 10 Jul 2007 09:42:46 +0000 (09:42 +0000)]
Removed / in doc install rule to avoid double-slash (cygwin)

16 years agoRemoved / in doc install rule to avoid double-slash (cygwin)
Adam Dickmeiss [Tue, 10 Jul 2007 09:40:44 +0000 (09:40 +0000)]
Removed / in doc install rule to avoid double-slash (cygwin)

16 years agoBuildRequire libpcap-devel rather than libpcap
Adam Dickmeiss [Mon, 9 Jul 2007 17:39:01 +0000 (17:39 +0000)]
BuildRequire libpcap-devel rather than libpcap

16 years agoChanged the Z39.50 ASN.1 a little: make userId in Permissions optional
Adam Dickmeiss [Wed, 4 Jul 2007 11:44:20 +0000 (11:44 +0000)]
Changed the Z39.50 ASN.1 a little: make userId in Permissions optional
and taskPackageRecords optional in Extended Service update (first version).
This is due to at least one implementation which incorrectly omits these.

16 years agoZOOM dumps BER if decoding fails and loglevel zoom is set
Adam Dickmeiss [Wed, 4 Jul 2007 11:42:14 +0000 (11:42 +0000)]
ZOOM dumps BER if decoding fails and loglevel zoom is set

16 years agoRevert
Adam Dickmeiss [Wed, 4 Jul 2007 09:21:00 +0000 (09:21 +0000)]
Revert

16 years agoInternal release
Adam Dickmeiss [Wed, 4 Jul 2007 09:20:06 +0000 (09:20 +0000)]
Internal release

16 years agoVersion 3.0.9
Adam Dickmeiss [Fri, 29 Jun 2007 08:09:28 +0000 (08:09 +0000)]
Version 3.0.9

16 years agoAdded support for the use of the older versions or Extended Service
Adam Dickmeiss [Fri, 29 Jun 2007 08:05:06 +0000 (08:05 +0000)]
Added support for the use of the older versions or Extended Service
Update in ZOOM. To faciliate this, an option "updateVersion" may be
set to the version , 1=first, 2=second, 3=third. The third version is
what ZOOM C has used so far. And that, obviously, is the default.

16 years agoBump version to 3.0.9
Adam Dickmeiss [Fri, 29 Jun 2007 08:03:02 +0000 (08:03 +0000)]
Bump version to 3.0.9

16 years agoChanged CQL to XCQL conversion, so that element for relation value in
Adam Dickmeiss [Thu, 28 Jun 2007 07:58:07 +0000 (07:58 +0000)]
Changed CQL to XCQL conversion, so that element for relation value in
modifier is 'comparison' rather than 'relation' so that it conforms to
 http://www.loc.gov/standards/sru/xml-files/xcql.xsd
When a comparison value is omitted, the st.relation in cql_node will
be NULL instead of "=". This has the effect that comparison will be
omitted in those cases.

16 years agoIgnore new programs
Adam Dickmeiss [Mon, 25 Jun 2007 18:42:05 +0000 (18:42 +0000)]
Ignore new programs

16 years agoUpstream 3.0.8
Adam Dickmeiss [Mon, 25 Jun 2007 18:41:40 +0000 (18:41 +0000)]
Upstream 3.0.8

16 years agoTowards 3.0.8
Adam Dickmeiss [Mon, 25 Jun 2007 18:41:13 +0000 (18:41 +0000)]
Towards 3.0.8

16 years agoFixed spelling
Adam Dickmeiss [Mon, 25 Jun 2007 18:34:27 +0000 (18:34 +0000)]
Fixed spelling

16 years agoFixed bug #1208: SSL appears to be broken in ZOOM. The problem occurred
Adam Dickmeiss [Mon, 25 Jun 2007 18:34:09 +0000 (18:34 +0000)]
Fixed bug #1208: SSL appears to be broken in ZOOM. The problem occurred
when cs_rcvconnect returned 1. In this case no event was not generated.
Now ZOOM_EVENT_NONE is created.

16 years agoImplemented oid_name_to_dotstring. Added test for OID API.
Adam Dickmeiss [Sun, 24 Jun 2007 19:27:11 +0000 (19:27 +0000)]
Implemented oid_name_to_dotstring. Added test for OID API.

16 years agoAllow elementSetName to be specified for ZOOM C record update.
Adam Dickmeiss [Thu, 21 Jun 2007 09:00:53 +0000 (09:00 +0000)]
Allow elementSetName to be specified for ZOOM C record update.

16 years agoAllow waitAction to be specified for ZOOM C based for Extended Services.
Adam Dickmeiss [Wed, 20 Jun 2007 12:55:29 +0000 (12:55 +0000)]
Allow waitAction to be specified for ZOOM C based for Extended Services.

16 years agoRemoved definition of docdir. It is set by automake already
Adam Dickmeiss [Sun, 17 Jun 2007 07:05:42 +0000 (07:05 +0000)]
Removed definition of docdir. It is set by automake already

16 years agoFixed NULL ptr reference caused by omitted record syntax OID. Bug
Adam Dickmeiss [Thu, 14 Jun 2007 10:44:18 +0000 (10:44 +0000)]
Fixed NULL ptr reference caused by omitted record syntax OID. Bug
introduced in YAZ 3 series.

16 years agoUpdate to libxml2 2.6.28 / libxslt 1.1.19
Adam Dickmeiss [Wed, 13 Jun 2007 08:22:31 +0000 (08:22 +0000)]
Update to libxml2 2.6.28 / libxslt 1.1.19

16 years agoMake yaz-ztest returns a certain number of hits if a "numeric" term
Adam Dickmeiss [Mon, 11 Jun 2007 08:50:57 +0000 (08:50 +0000)]
Make yaz-ztest returns a certain number of hits if a "numeric" term
is supplied. E.g. @attr 1=4 12    - returns 12 hits. A non-numeric
term make yaz-ztest return a random hit count as before.

16 years agoFixed a silly bug: displayed version info also if -l was specified.
Heikki Levanto [Fri, 8 Jun 2007 10:01:07 +0000 (10:01 +0000)]
Fixed a silly bug: displayed version info also if -l was specified.
Added the missing break statement

16 years agoBump version to 3.0.7
Adam Dickmeiss [Thu, 7 Jun 2007 08:27:57 +0000 (08:27 +0000)]
Bump version to 3.0.7

16 years agoTowards 3.0.6.
Adam Dickmeiss [Wed, 6 Jun 2007 16:42:35 +0000 (16:42 +0000)]
Towards 3.0.6.

16 years agoProper comments and info for dealing with various VS versions
Adam Dickmeiss [Wed, 6 Jun 2007 16:34:23 +0000 (16:34 +0000)]
Proper comments and info for dealing with various VS versions

16 years agoRemoved WIN32 libs not in use
Adam Dickmeiss [Wed, 6 Jun 2007 16:33:19 +0000 (16:33 +0000)]
Removed WIN32 libs not in use

16 years agoUse LONGLONG rather than ULONGLONG on Windows to support good'old
Adam Dickmeiss [Wed, 6 Jun 2007 16:32:34 +0000 (16:32 +0000)]
Use LONGLONG rather than ULONGLONG on Windows to support good'old
MSVC6.

16 years agoFix potential buffer overrun that could occur if SRU charset name
Adam Dickmeiss [Tue, 5 Jun 2007 06:52:23 +0000 (06:52 +0000)]
Fix potential buffer overrun that could occur if SRU charset name
was more than 40 characters in length.

16 years agoUsing yaz_snprintf (snprintf) rather than sprintf. No real buffer overrun
Adam Dickmeiss [Tue, 5 Jun 2007 06:42:26 +0000 (06:42 +0000)]
Using yaz_snprintf (snprintf) rather than sprintf. No real buffer overrun
since 511 < FILENAME_MAX in virtually all cases.

16 years agoUpdate usage msg
Adam Dickmeiss [Tue, 5 Jun 2007 06:40:28 +0000 (06:40 +0000)]
Update usage msg

16 years agoFix buffer overrun by one in the setting of l_prefix/l_prefix2
Adam Dickmeiss [Tue, 5 Jun 2007 06:23:07 +0000 (06:23 +0000)]
Fix buffer overrun by one in the setting of l_prefix/l_prefix2

16 years agoExercise yaz_log_init_prefix
Adam Dickmeiss [Tue, 5 Jun 2007 06:22:19 +0000 (06:22 +0000)]
Exercise yaz_log_init_prefix

16 years agoFixed potential buffer overrun in yaz_log for YLOG_ERRNO messages.
Adam Dickmeiss [Tue, 5 Jun 2007 05:58:16 +0000 (05:58 +0000)]
Fixed potential buffer overrun in yaz_log for YLOG_ERRNO messages.

16 years agoProperly null-terminate Unix-domain socket path. Thanks to Marc Espie
Adam Dickmeiss [Tue, 5 Jun 2007 05:42:07 +0000 (05:42 +0000)]
Properly null-terminate Unix-domain socket path. Thanks to Marc Espie
for spotting this.

16 years agoFix NULL ptr reference which occurred for unknown diagset receieved.
Adam Dickmeiss [Mon, 4 Jun 2007 09:18:09 +0000 (09:18 +0000)]
Fix NULL ptr reference which occurred for unknown diagset receieved.

16 years agoOrder options and usage info
Adam Dickmeiss [Sun, 3 Jun 2007 15:55:50 +0000 (15:55 +0000)]
Order options and usage info

16 years agoyaz-client now reads commands from file given by option -f if
Adam Dickmeiss [Sun, 3 Jun 2007 14:59:33 +0000 (14:59 +0000)]
yaz-client now reads commands from file given by option -f if
specified; then tries to read .yazclientrc in current directory.
Failing that, it reads .yazclientrc from user's home directory.

16 years agoAdded Deb/RPM package for yaz-illclient. Closes #1155.
Adam Dickmeiss [Sun, 3 Jun 2007 10:10:07 +0000 (10:10 +0000)]
Added Deb/RPM package for yaz-illclient. Closes #1155.

16 years agoInstall yaz-illclient in PREFIX/bin
Adam Dickmeiss [Sun, 3 Jun 2007 09:57:25 +0000 (09:57 +0000)]
Install yaz-illclient in PREFIX/bin

16 years agoAdded yaz-illclient man page.
Adam Dickmeiss [Sun, 3 Jun 2007 09:56:50 +0000 (09:56 +0000)]
Added yaz-illclient man page.

16 years agoEmbed manifest file in EXE/DLLs for YAZ. But only if USE_MANIFEST is
Adam Dickmeiss [Sun, 3 Jun 2007 09:34:43 +0000 (09:34 +0000)]
Embed manifest file in EXE/DLLs for YAZ. But only if USE_MANIFEST is
set to 1.

16 years agoFixed bug #1157: yaz-client does not read .yazclientrc from current
Adam Dickmeiss [Sun, 3 Jun 2007 08:06:31 +0000 (08:06 +0000)]
Fixed bug #1157: yaz-client does not read .yazclientrc from current
directory. yaz-client now reads ·yazclient from current directory;
failing that ~/.yazclientrc is read.

16 years ago3.0.5 for windows
Adam Dickmeiss [Sat, 2 Jun 2007 20:57:12 +0000 (20:57 +0000)]
3.0.5 for windows

16 years agoUsing informaltable rather than table for list of Object Identifiers.
Adam Dickmeiss [Thu, 31 May 2007 12:14:02 +0000 (12:14 +0000)]
Using informaltable rather than table for list of Object Identifiers.
This is to avoid truncation of the (long) table. Combine OID and Constant
into one column.

16 years agoFixed bug #1151: Doc's don't reflect new oid layout. Current backend.h
Adam Dickmeiss [Thu, 31 May 2007 09:45:14 +0000 (09:45 +0000)]
Fixed bug #1151: Doc's don't reflect new oid layout. Current backend.h
structs copied into synopsys sections and minor wording changes about
OIDs were changed.

16 years agoNo need for -lnsl for wrap
Adam Dickmeiss [Thu, 31 May 2007 08:01:30 +0000 (08:01 +0000)]
No need for -lnsl for wrap

16 years agoInternal release.
Adam Dickmeiss [Thu, 31 May 2007 07:40:25 +0000 (07:40 +0000)]
Internal release.

16 years agoAdded support for correlationInfo Note and ID for Record Update via
Adam Dickmeiss [Thu, 31 May 2007 07:38:13 +0000 (07:38 +0000)]
Added support for correlationInfo Note and ID for Record Update via
ZOOM C.

16 years agoChanged the way yaz-client encodes charset negotiation information
Adam Dickmeiss [Wed, 30 May 2007 21:56:59 +0000 (21:56 +0000)]
Changed the way yaz-client encodes charset negotiation information
to target when no negoatitionCharset is set by user using command
negcharset. In YAZ 3.0.0 and later the negotation information was
simply omitted. Now the OriginProposal is sent anway but with
proposedCharSets and proposedlanaguages omitted (both are optional).
YAZ Frontend server is also modified to deal with this: omitted
proposedCharSets in the OriginProposal will make the frontend server
return default character set for target if that is supplied by the
backend init handler (member query_charset).

16 years agoSome old changes were not committed properly
Heikki Levanto [Wed, 30 May 2007 13:59:04 +0000 (13:59 +0000)]
Some old changes were not committed properly

16 years agoPrepare for new internal deb package.
Adam Dickmeiss [Wed, 30 May 2007 08:42:01 +0000 (08:42 +0000)]
Prepare for new internal deb package.

16 years agoAdded yaz-client command querycharset which specifies character set for
Adam Dickmeiss [Wed, 30 May 2007 08:40:26 +0000 (08:40 +0000)]
Added yaz-client command querycharset which specifies character set for
query terms for Z39.50 RPN queries and Z39.50 Scan Requests
(termListAndStartPoint).

16 years agoCharset ISO5428:1984 is an alias for ISO5428-1984.
Adam Dickmeiss [Wed, 30 May 2007 08:22:03 +0000 (08:22 +0000)]
Charset ISO5428:1984 is an alias for ISO5428-1984.

16 years agoImplemented a way to perform scan in a result set using Z39.50. This
Adam Dickmeiss [Wed, 30 May 2007 08:12:16 +0000 (08:12 +0000)]
Implemented a way to perform scan in a result set using Z39.50. This
is achieved by attaching the result set name in the characterInfo
(type InternationalString) of OtherInformation in the Scan Request PDU.
The result set is identified in the otherinformation by the new OID:
 USERINFO, Z3950_PREFIX.10.1000.81.4, "Scan-Set
This allows for scan in result set and faceted search . Zebra did some
of this in the APT term using attribute type 8 and value being result
set. Using the OtherInformation approach for this is cleaner and easier
to work with in proxies and the like. This facility can be used in
yaz-client using new command setscan which takes a result set as first

16 years agoRemoved NMEM debug code
Adam Dickmeiss [Wed, 30 May 2007 08:04:28 +0000 (08:04 +0000)]
Removed NMEM debug code

16 years agocorrected typo
Marc Cromme [Fri, 25 May 2007 16:19:46 +0000 (16:19 +0000)]
corrected typo

16 years agoFunction encode_uri_char does not hex encode unreserved chars (RFC 2396
Adam Dickmeiss [Thu, 24 May 2007 10:18:36 +0000 (10:18 +0000)]
Function encode_uri_char does not hex encode unreserved chars (RFC 2396
section 2.3).

16 years agoBump version to 3.0.5-1
Adam Dickmeiss [Wed, 23 May 2007 13:16:32 +0000 (13:16 +0000)]
Bump version to 3.0.5-1

16 years agoChanged decoding of SRU XML packed records to deal with servers that
Adam Dickmeiss [Wed, 23 May 2007 13:11:11 +0000 (13:11 +0000)]
Changed decoding of SRU XML packed records to deal with servers that
have recordData with XML data with multiple root nodes. Also make
comparison for recordPacking case insensitive. Again, one server
returns "XML" where others return "xml".

16 years agoChange comment about second arg of yaz_matchstr
Adam Dickmeiss [Wed, 23 May 2007 12:58:59 +0000 (12:58 +0000)]
Change comment about second arg of yaz_matchstr

16 years agoFor SRU responses allow Content-Type application/xml as well as text/xml.
Adam Dickmeiss [Wed, 23 May 2007 11:54:46 +0000 (11:54 +0000)]
For SRU responses allow Content-Type application/xml as well as text/xml.

16 years agoGary Anderson to credits
Adam Dickmeiss [Wed, 23 May 2007 08:53:20 +0000 (08:53 +0000)]
Gary Anderson to credits

16 years agoCheck for malformed UTF-8 characters. Thanks for Gary Anderson for
Adam Dickmeiss [Wed, 23 May 2007 08:50:11 +0000 (08:50 +0000)]
Check for malformed UTF-8 characters. Thanks for Gary Anderson for
pointing this out.

16 years agoUse entity idcommon rather than common. Fix acronym entities.
Adam Dickmeiss [Tue, 22 May 2007 11:10:08 +0000 (11:10 +0000)]
Use entity idcommon rather than common. Fix acronym entities.

16 years agoTowards 3.0.4 YAZ.3.0.4
Adam Dickmeiss [Mon, 21 May 2007 12:18:25 +0000 (12:18 +0000)]
Towards 3.0.4

16 years agoFixed missing yaz_iconv reset call in odr_iconv_string in decoding phase.
Adam Dickmeiss [Mon, 21 May 2007 11:51:01 +0000 (11:51 +0000)]
Fixed missing yaz_iconv reset call in odr_iconv_string in decoding phase.

16 years agoTokenizer skips comments (# by default).
Adam Dickmeiss [Wed, 16 May 2007 10:47:49 +0000 (10:47 +0000)]
Tokenizer skips comments (# by default).

16 years agoBump to version 3.0.3
Adam Dickmeiss [Wed, 16 May 2007 10:47:14 +0000 (10:47 +0000)]
Bump to version 3.0.3

16 years agoIgnore generated std-oid-table.xml
Mike Taylor [Wed, 9 May 2007 12:17:54 +0000 (12:17 +0000)]
Ignore generated std-oid-table.xml

16 years agolibyaz3-dev should conflict with libyaz2-dev
Adam Dickmeiss [Wed, 9 May 2007 11:04:35 +0000 (11:04 +0000)]
libyaz3-dev should conflict with libyaz2-dev

16 years agolibyaz3-dev conflicts with libyaz2-dev
Adam Dickmeiss [Wed, 9 May 2007 08:10:30 +0000 (08:10 +0000)]
libyaz3-dev conflicts with libyaz2-dev

16 years agoyaz3.lib part of devel YAZ.3.0.2
Adam Dickmeiss [Tue, 8 May 2007 08:39:00 +0000 (08:39 +0000)]
yaz3.lib part of devel

16 years agoAPI version 3.0.2
Adam Dickmeiss [Tue, 8 May 2007 08:27:45 +0000 (08:27 +0000)]
API version 3.0.2

16 years agoTowards 3.0.2.
Adam Dickmeiss [Tue, 8 May 2007 08:27:13 +0000 (08:27 +0000)]
Towards 3.0.2.

16 years agoFor OIDs use Odr_oid type everywhere, i.e. do not assume Odr_oid=int.
Adam Dickmeiss [Tue, 8 May 2007 08:22:35 +0000 (08:22 +0000)]
For OIDs use Odr_oid type everywhere, i.e. do not assume Odr_oid=int.
For OID class, use oid_class consistently.