From: Adam Dickmeiss Date: Wed, 25 Oct 2006 09:58:19 +0000 (+0000) Subject: Fixed bug #707: CQL->RPN ignores lines with leading spaces. Changed X-Git-Tag: YAZ.2.1.38~9 X-Git-Url: http://git.indexdata.com/?p=yaz-moved-to-github.git;a=commitdiff_plain;h=66ab37e39c6f32575526ffa2347ededb7ebf7bd0 Fixed bug #707: CQL->RPN ignores lines with leading spaces. Changed function cql_transform_open_FILE so that white-space is allowed in the beginning of a pattern=value line. Lines with pattern but missing value (or missing =) results in an error. --- diff --git a/src/cqltransform.c b/src/cqltransform.c index 9cbe7e0..133db94 100644 --- a/src/cqltransform.c +++ b/src/cqltransform.c @@ -1,4 +1,4 @@ -/* $Id: cqltransform.c,v 1.24 2006-10-05 16:12:23 adam Exp $ +/* $Id: cqltransform.c,v 1.25 2006-10-25 09:58:19 adam Exp $ Copyright (C) 1995-2005, Index Data ApS Index Data Aps @@ -53,36 +53,48 @@ cql_transform_t cql_transform_open_FILE(FILE *f) { const char *cp_value_start; const char *cp_value_end; + const char *cp_pattern_start; const char *cp_pattern_end; const char *cp = line; - while (*cp && !strchr(" \t=\r\n#", *cp)) + + while (*cp && strchr(" \t", *cp)) + cp++; + cp_pattern_start = cp; + + while (*cp && !strchr(" \t\r\n=#", *cp)) cp++; cp_pattern_end = cp; - if (cp == line) + if (cp == cp_pattern_start) continue; - while (*cp && strchr(" \t\r\n", *cp)) + while (*cp && strchr(" \t", *cp)) cp++; if (*cp != '=') - continue; + { + *pp = 0; + cql_transform_close(ct); + return 0; + } cp++; while (*cp && strchr(" \t\r\n", *cp)) cp++; cp_value_start = cp; - if (!(cp_value_end = strchr(cp, '#'))) + cp_value_end = strchr(cp, '#'); + if (!cp_value_end) cp_value_end = strlen(line) + line; if (cp_value_end != cp_value_start && strchr(" \t\r\n", cp_value_end[-1])) cp_value_end--; *pp = (struct cql_prop_entry *) xmalloc (sizeof(**pp)); - (*pp)->pattern = (char *) xmalloc (cp_pattern_end - line + 1); - memcpy ((*pp)->pattern, line, cp_pattern_end - line); - (*pp)->pattern[cp_pattern_end-line] = 0; + (*pp)->pattern = (char *) xmalloc(cp_pattern_end-cp_pattern_start + 1); + memcpy ((*pp)->pattern, cp_pattern_start, + cp_pattern_end-cp_pattern_start); + (*pp)->pattern[cp_pattern_end-cp_pattern_start] = '\0'; - (*pp)->value = (char *) xmalloc (cp_value_end - cp_value_start + 1); + (*pp)->value = (char *) xmalloc (cp_value_end-cp_value_start + 1); if (cp_value_start != cp_value_end) memcpy ((*pp)->value, cp_value_start, cp_value_end-cp_value_start); - (*pp)->value[cp_value_end - cp_value_start] = 0; + (*pp)->value[cp_value_end - cp_value_start] = '\0'; pp = &(*pp)->next; } *pp = 0;