X-Git-Url: http://git.indexdata.com/?p=yaz-moved-to-github.git;a=blobdiff_plain;f=zoom%2Fzoomsh.c;h=fde447e4c6fc12822033114bcb4ae2ec8528b59f;hp=8469ce41430bfc99bfb0281805351f9d36c0d676;hb=5242cb5a8634bfa38b9333ff7f903e718ac6e292;hpb=ca359fadd2bc021173109ad2e84a03f5e0f6a677

diff --git a/zoom/zoomsh.c b/zoom/zoomsh.c
index 8469ce4..fde447e 100644
--- a/zoom/zoomsh.c
+++ b/zoom/zoomsh.c
@@ -1,20 +1,23 @@
 /* This file is part of the YAZ toolkit.
- * Copyright (C) 1995-2010 Index Data
+ * Copyright (C) 1995-2012 Index Data
  * See the file LICENSE for details.
  */
-
 /** \file zoomsh.c
     \brief ZOOM C command line tool (shell)
 */
+#if HAVE_CONFIG_H
+#include <config.h>
+#endif
 
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
-#include <ctype.h>
 #include <yaz/wrbuf.h>
+#include <yaz/log.h>
+#include <yaz/options.h>
 
 #if HAVE_READLINE_READLINE_H
-#include <readline/readline.h> 
+#include <readline/readline.h>
 #endif
 #if HAVE_READLINE_HISTORY_H
 #include <readline/history.h>
@@ -25,7 +28,24 @@
 
 #define MAX_CON 100
 
-static int next_token(const char **cpp, const char **t_start)
+static void process_events(ZOOM_connection *c)
+{
+    int i;
+
+    yaz_log(YLOG_DEBUG, "process_events");
+    while ((i = ZOOM_event(MAX_CON, c)) != 0)
+    {
+        int peek = ZOOM_connection_peek_event(c[i-1]);
+        int event = ZOOM_connection_last_event(c[i-1]);
+        yaz_log(YLOG_DEBUG, "no = %d peek = %d event = %d %s", i-1,
+                peek,
+                event,
+                ZOOM_get_event_str(event));
+    }
+}
+
+static int next_token_chars(const char **cpp, const char **t_start,
+                            const char *tok_chars)
 {
     int len = 0;
     const char *cp = *cpp;
@@ -46,7 +66,7 @@ static int next_token(const char **cpp, const char **t_start)
     else
     {
         *t_start = cp;
-        while (*cp && *cp != ' ' && *cp != '\r' && *cp != '\n')
+        while (*cp && !strchr(tok_chars, *cp))
         {
             cp++;
             len++;
@@ -58,6 +78,12 @@ static int next_token(const char **cpp, const char **t_start)
     return len;  /* return -1 if no token was read .. */
 }
 
+static int next_token(const char **cpp, const char **t_start)
+{
+    return next_token_chars(cpp, t_start, "\r\n ");
+}
+
+
 static WRBUF next_token_new_wrbuf(const char **cpp)
 {
     WRBUF w = 0;
@@ -81,35 +107,37 @@ static int is_command(const char *cmd_str, const char *this_str, int this_len)
     return 1;
 }
 
-static void cmd_set(ZOOM_connection *c, ZOOM_resultset *r,
-                    ZOOM_options options,
-                    const char **args)
+static int cmd_set(ZOOM_connection *c, ZOOM_resultset *r,
+                   ZOOM_options options,
+                   const char **args)
 {
-    WRBUF key, val;
+    WRBUF key;
+    const char *val_buf;
+    int val_len;
 
     if (!(key = next_token_new_wrbuf(args)))
     {
         printf("missing argument for set\n");
-        return ;
-    }
-    if ((val = next_token_new_wrbuf(args)))
-    {
-        ZOOM_options_set(options, wrbuf_cstr(key), wrbuf_cstr(val));
-        wrbuf_destroy(val);
+        return 1;
     }
+    val_len = next_token_chars(args, &val_buf, "");
+    if (val_len != -1)
+        ZOOM_options_setl(options, wrbuf_cstr(key), val_buf, val_len);
     else
         ZOOM_options_set(options, wrbuf_cstr(key), 0);
     wrbuf_destroy(key);
+    return 0;
 }
 
-static void cmd_get(ZOOM_connection *c, ZOOM_resultset *r,
-                    ZOOM_options options,
-                    const char **args)
+static int cmd_get(ZOOM_connection *c, ZOOM_resultset *r,
+                   ZOOM_options options,
+                   const char **args)
 {
     WRBUF key;
     if (!(key = next_token_new_wrbuf(args)))
     {
         printf("missing argument for get\n");
+        return 1;
     }
     else
     {
@@ -117,16 +145,27 @@ static void cmd_get(ZOOM_connection *c, ZOOM_resultset *r,
         printf("%s = %s\n", wrbuf_cstr(key), val ? val : "<null>");
         wrbuf_destroy(key);
     }
+    return 0;
 }
 
-static void cmd_rget(ZOOM_connection *c, ZOOM_resultset *r,
-                     ZOOM_options options,
+static int cmd_shell(ZOOM_connection *c, ZOOM_resultset *r,
+                     ZOOM_options options, const char **args)
+{
+    int ret = system(*args);
+    if (ret)
+         printf("system command returned %d\n", ret);
+    return 0;
+}
+
+static int cmd_rget(ZOOM_connection *c, ZOOM_resultset *r,
+                    ZOOM_options options,
                      const char **args)
 {
     WRBUF key;
     if (!(key = next_token_new_wrbuf(args)))
     {
         printf("missing argument for get\n");
+        return 1;
     }
     else
     {
@@ -136,17 +175,18 @@ static void cmd_rget(ZOOM_connection *c, ZOOM_resultset *r,
             const char *val;
             if (!r[i])
                 continue;
-            
+
             val = ZOOM_resultset_option_get(r[i], wrbuf_cstr(key));
             printf("%s = %s\n", wrbuf_cstr(key), val ? val : "<null>");
         }
         wrbuf_destroy(key);
     }
+    return 0;
 }
 
-static void cmd_close(ZOOM_connection *c, ZOOM_resultset *r,
-                      ZOOM_options options,
-                      const char **args)
+static int cmd_close(ZOOM_connection *c, ZOOM_resultset *r,
+                     ZOOM_options options,
+                     const char **args)
 {
     WRBUF host;
     int i;
@@ -170,6 +210,7 @@ static void cmd_close(ZOOM_connection *c, ZOOM_resultset *r,
     }
     if (host)
         wrbuf_destroy(host);
+    return 0;
 }
 
 static void display_records(ZOOM_connection c,
@@ -182,14 +223,14 @@ static void display_records(ZOOM_connection c,
         size_t pos = i + start;
         ZOOM_record rec = ZOOM_resultset_record(r, pos);
         const char *db = ZOOM_record_get(rec, "database", 0);
-        
+
         if (ZOOM_record_error(rec, 0, 0, 0))
         {
             const char *msg;
             const char *addinfo;
             const char *diagset;
             int error = ZOOM_record_error(rec, &msg, &addinfo, &diagset);
-            
+
             printf("%lld %s: %s (%s:%d) %s\n", (long long) pos,
                    (db ? db : "unknown"),
                    msg, diagset, error, addinfo ? addinfo : "none");
@@ -219,14 +260,15 @@ static void display_records(ZOOM_connection c,
     }
 }
 
-static void cmd_show(ZOOM_connection *c, ZOOM_resultset *r,
-                     ZOOM_options options,
-                     const char **args)
+static int cmd_show(ZOOM_connection *c, ZOOM_resultset *r,
+                    ZOOM_options options,
+                    const char **args)
 {
     int i;
     size_t start = 0, count = 1;
     const char *type = "render";
     WRBUF render_str = 0;
+    int ret = 0;
 
     {
         WRBUF tmp;
@@ -249,8 +291,7 @@ static void cmd_show(ZOOM_connection *c, ZOOM_resultset *r,
 
     for (i = 0; i < MAX_CON; i++)
         ZOOM_resultset_records(r[i], 0, start, count);
-    while (ZOOM_event(MAX_CON, c))
-        ;
+    process_events(c);
 
     for (i = 0; i < MAX_CON; i++)
     {
@@ -260,9 +301,12 @@ static void cmd_show(ZOOM_connection *c, ZOOM_resultset *r,
         if (!c[i])
             continue;
         if ((error = ZOOM_connection_error_x(c[i], &errmsg, &addinfo, &dset)))
+        {
             printf("%s error: %s (%s:%d) %s\n",
                    ZOOM_connection_option_get(c[i], "host"), errmsg,
                    dset, error, addinfo);
+            ret = 1;
+        }
         else if (r[i])
         {
             /* OK, no major errors. Display records... */
@@ -271,7 +315,7 @@ static void cmd_show(ZOOM_connection *c, ZOOM_resultset *r,
     }
     if (render_str)
         wrbuf_destroy(render_str);
-       
+    return ret;
 }
 
 static void display_facets(ZOOM_facet_field *facets, int count) {
@@ -289,43 +333,47 @@ static void display_facets(ZOOM_facet_field *facets, int count) {
     }
 }
 
-static void cmd_facets(ZOOM_connection *c, ZOOM_resultset *r,
-                     ZOOM_options options,
-                     const char **args)
+static int cmd_facets(ZOOM_connection *c, ZOOM_resultset *r,
+                      ZOOM_options options,
+                      const char **args)
 {
     int i;
-    size_t start = 0, count = 1;
-    const char *type = "render";
-    WRBUF render_str = 0;
+    int ret = 0;
 
-    if (0)
-    {
-        WRBUF tmp;
+    process_events(c);
 
-        if ((tmp = next_token_new_wrbuf(args)))
+    for (i = 0; i < MAX_CON; i++)
+    {
+        int error;
+        const char *errmsg, *addinfo, *dset;
+        /* display errors if any */
+        if (!c[i])
+            continue;
+        if ((error = ZOOM_connection_error_x(c[i], &errmsg, &addinfo, &dset)))
         {
-            start = atoi(wrbuf_cstr(tmp));
-            wrbuf_destroy(tmp);
+            printf("%s error: %s (%s:%d) %s\n",
+                   ZOOM_connection_option_get(c[i], "host"), errmsg,
+                   dset, error, addinfo);
+            ret = 1;
         }
-
-        if ((tmp = next_token_new_wrbuf(args)))
+        else if (r[i])
         {
-            count = atoi(wrbuf_cstr(tmp));
-            wrbuf_destroy(tmp);
+            int num_facets = ZOOM_resultset_facets_size(r[i]);
+            if (num_facets) {
+                ZOOM_facet_field  *facets = ZOOM_resultset_facets(r[i]);
+                display_facets(facets, num_facets);
+            }
         }
-        render_str = next_token_new_wrbuf(args);
     }
-    if (render_str)
-        type = wrbuf_cstr(render_str);
+    return ret;
+}
 
-    /*
-    for (i = 0; i < MAX_CON; i++) {
-        int num_facets = ZOOM_resultset_facet_size(r[i]);
-        ZOOM_resultset_records(r[i], 0, start, count);
-    }
-    */
-    while (ZOOM_event(MAX_CON, c))
-        ;
+static int cmd_suggestions(ZOOM_connection *c, ZOOM_resultset *r, ZOOM_options options, const char **args)
+{
+    int i;
+    int ret = 0;
+
+    process_events(c);
 
     for (i = 0; i < MAX_CON; i++)
     {
@@ -335,31 +383,39 @@ static void cmd_facets(ZOOM_connection *c, ZOOM_resultset *r,
         if (!c[i])
             continue;
         if ((error = ZOOM_connection_error_x(c[i], &errmsg, &addinfo, &dset)))
+        {
             printf("%s error: %s (%s:%d) %s\n",
                    ZOOM_connection_option_get(c[i], "host"), errmsg,
                    dset, error, addinfo);
+            ret = 1;
+        }
         else if (r[i])
         {
-            int num_facets = ZOOM_resultset_facets_size(r[i]);
-            if (num_facets) {
-                ZOOM_facet_field  *facets = ZOOM_resultset_facets(r[i]);
-                display_facets(facets, num_facets);
+            const char *suggestions = ZOOM_resultset_option_get(r[i], "suggestions");
+            if (suggestions) {
+                printf("Suggestions: \n%s\n", suggestions);
             }
         }
     }
-    if (render_str)
-        wrbuf_destroy(render_str);
-
+    return ret;
 }
 
-static void cmd_ext(ZOOM_connection *c, ZOOM_resultset *r,
-                    ZOOM_options options,
-                    const char **args)
+
+static int cmd_ext(ZOOM_connection *c, ZOOM_resultset *r,
+                   ZOOM_options options,
+                   const char **args)
 {
     ZOOM_package p[MAX_CON];
     int i;
+    int ret = 0;
     WRBUF ext_type_str = next_token_new_wrbuf(args);
-    
+
+    if (!ext_type_str)
+    {
+        printf("es: missing type "
+               "(itemorder, create, drop, commit, update, xmlupdate)\n");
+        return 1;
+    }
     for (i = 0; i<MAX_CON; i++)
     {
         if (c[i])
@@ -371,8 +427,7 @@ static void cmd_ext(ZOOM_connection *c, ZOOM_resultset *r,
             p[i] = 0;
     }
 
-    while (ZOOM_event(MAX_CON, c))
-        ;
+    process_events(c);
 
     for (i = 0; i<MAX_CON; i++)
     {
@@ -382,9 +437,12 @@ static void cmd_ext(ZOOM_connection *c, ZOOM_resultset *r,
         if (!p[i])
             continue;
         if ((error = ZOOM_connection_error_x(c[i], &errmsg, &addinfo, &dset)))
+        {
             printf("%s error: %s (%s:%d) %s\n",
                    ZOOM_connection_option_get(c[i], "host"), errmsg,
                    dset, error, addinfo);
+            ret = 1;
+        }
         else if (p[i])
         {
             const char *v;
@@ -400,23 +458,26 @@ static void cmd_ext(ZOOM_connection *c, ZOOM_resultset *r,
     }
     if (ext_type_str)
         wrbuf_destroy(ext_type_str);
+    return ret;
 }
 
-static void cmd_debug(ZOOM_connection *c, ZOOM_resultset *r,
-                      ZOOM_options options,
-                      const char **args)
+static int cmd_debug(ZOOM_connection *c, ZOOM_resultset *r,
+                     ZOOM_options options,
+                     const char **args)
 {
     yaz_log_init_level(YLOG_ALL);
+    return 0;
 }
 
-static void cmd_search(ZOOM_connection *c, ZOOM_resultset *r,
-                       ZOOM_options options,
-                       const char **args)
+static int cmd_search(ZOOM_connection *c, ZOOM_resultset *r,
+                      ZOOM_options options,
+                      const char **args)
 {
     ZOOM_query s;
     const char *query_str = *args;
     int i;
-    
+    int ret = 0;
+
     s = ZOOM_query_create();
     while (*query_str == ' ')
         query_str++;
@@ -427,7 +488,8 @@ static void cmd_search(ZOOM_connection *c, ZOOM_resultset *r,
     else if (ZOOM_query_prefix(s, query_str))
     {
         printf("Bad PQF: %s\n", query_str);
-        return;
+        ZOOM_query_destroy(s);
+        return 1;
     }
     for (i = 0; i<MAX_CON; i++)
     {
@@ -442,8 +504,7 @@ static void cmd_search(ZOOM_connection *c, ZOOM_resultset *r,
     }
     ZOOM_query_destroy(s);
 
-    while (ZOOM_event(MAX_CON, c))
-        ;
+    process_events(c);
 
     for (i = 0; i<MAX_CON; i++)
     {
@@ -453,32 +514,59 @@ static void cmd_search(ZOOM_connection *c, ZOOM_resultset *r,
         if (!c[i])
             continue;
         if ((error = ZOOM_connection_error_x(c[i], &errmsg, &addinfo, &dset)))
+        {
             printf("%s error: %s (%s:%d) %s\n",
                    ZOOM_connection_option_get(c[i], "host"), errmsg,
                    dset, error, addinfo);
+            ret = 1;
+        }
         else if (r[i])
         {
             /* OK, no major errors. Look at the result count */
             int start = ZOOM_options_get_int(options, "start", 0);
             int count = ZOOM_options_get_int(options, "count", 0);
+            int facet_num;
 
             printf("%s: %lld hits\n", ZOOM_connection_option_get(c[i], "host"),
                    (long long int) ZOOM_resultset_size(r[i]));
+
+            facet_num = ZOOM_resultset_facets_size(r[i]);
+            if (facet_num)
+            {
+                ZOOM_facet_field *facets = ZOOM_resultset_facets(r[i]);
+                int facet_idx;
+                for (facet_idx = 0; facet_idx < facet_num; facet_idx++)
+                {
+                    const char *name = ZOOM_facet_field_name(facets[facet_idx]);
+                    size_t term_idx;
+                    size_t term_num = ZOOM_facet_field_term_count(facets[facet_idx]);
+                    printf("facet: %s\n", name);
+                    for (term_idx = 0; term_idx < term_num; term_idx++ )
+                    {
+                        int freq;
+                        const char *term =
+                            ZOOM_facet_field_get_term(facets[facet_idx], term_idx, &freq);
+                        printf("term: %s %d\n", term, freq);
+                    }
+                }
+            }
             /* and display */
             display_records(c[i], r[i], start, count, "render");
         }
     }
+    return ret;
 }
 
-static void cmd_scan(ZOOM_connection *c, ZOOM_resultset *r,
-                     ZOOM_options options,
-                     const char **args)
+static int cmd_scan(ZOOM_connection *c, ZOOM_resultset *r,
+                    ZOOM_options options,
+                    const char **args)
 {
     const char *query_str = *args;
     ZOOM_query query = ZOOM_query_create();
     int i;
+    int ret = 0;
     ZOOM_scanset s[MAX_CON];
-    
+
     while (*query_str == ' ')
         query_str++;
 
@@ -489,7 +577,8 @@ static void cmd_scan(ZOOM_connection *c, ZOOM_resultset *r,
     else if (ZOOM_query_prefix(query, query_str))
     {
         printf("Bad PQF: %s\n", query_str);
-        return;
+        ZOOM_query_destroy(query);
+        return 1;
     }
 
     for (i = 0; i<MAX_CON; i++)
@@ -501,8 +590,8 @@ static void cmd_scan(ZOOM_connection *c, ZOOM_resultset *r,
     }
     ZOOM_query_destroy(query);
 
-    while (ZOOM_event(MAX_CON, c))
-        ;
+    process_events(c);
+
     for (i = 0; i<MAX_CON; i++)
     {
         int error;
@@ -511,11 +600,14 @@ static void cmd_scan(ZOOM_connection *c, ZOOM_resultset *r,
         if (!c[i])
             continue;
         if ((error = ZOOM_connection_error_x(c[i], &errmsg, &addinfo, &dset)))
+        {
             printf("%s error: %s (%s:%d) %s\n",
                    ZOOM_connection_option_get(c[i], "host"), errmsg,
                    dset, error, addinfo);
-
-        if (s[i]) {
+            ret = 1;
+        }
+        if (s[i])
+        {
             size_t p, sz = ZOOM_scanset_size(s[i]);
             for (p = 0; p < sz; p++)
             {
@@ -524,34 +616,36 @@ static void cmd_scan(ZOOM_connection *c, ZOOM_resultset *r,
                 const char *term = ZOOM_scanset_display_term(s[i], p,
                                                              &occ, &len);
                 printf("%.*s %lld\n", (int) len, term, (long long int) occ);
-            }            
+            }
             ZOOM_scanset_destroy(s[i]);
         }
     }
+    return ret;
 }
 
-static void cmd_sort(ZOOM_connection *c, ZOOM_resultset *r,
-                     ZOOM_options options,
-                     const char **args)
+static int cmd_sort(ZOOM_connection *c, ZOOM_resultset *r,
+                    ZOOM_options options,
+                    const char **args)
 {
     const char *sort_spec = *args;
     int i;
-    
+    int ret = 0;
+
     while (*sort_spec == ' ')
         sort_spec++;
-    
+
     for (i = 0; i<MAX_CON; i++)
     {
         if (r[i])
             ZOOM_resultset_sort(r[i], "yaz", sort_spec);
     }
-    while (ZOOM_event(MAX_CON, c))
-        ;
+    process_events(c);
+    return ret;
 }
 
-static void cmd_help(ZOOM_connection *c, ZOOM_resultset *r,
-                     ZOOM_options options,
-                     const char **args)
+static int cmd_help(ZOOM_connection *c, ZOOM_resultset *r,
+                    ZOOM_options options,
+                    const char **args)
 {
     printf("connect <zurl>\n");
     printf("search <pqf>\n");
@@ -563,6 +657,7 @@ static void cmd_help(ZOOM_connection *c, ZOOM_resultset *r,
     printf("ext <type>\n");
     printf("set <option> [<value>]\n");
     printf("get <option>\n");
+    printf("shell cmdline\n");
     printf("\n");
     printf("options:\n");
     printf(" start\n");
@@ -583,12 +678,16 @@ static void cmd_help(ZOOM_connection *c, ZOOM_resultset *r,
     printf(" lang\n");
     printf(" timeout\n");
     printf(" facets\n");
+    printf(" extraArgs\n");
+    printf(" suggestions\n");
+    return 0;
 }
 
-static void cmd_connect(ZOOM_connection *c, ZOOM_resultset *r,
-                        ZOOM_options options,
-                        const char **args)
+static int cmd_connect(ZOOM_connection *c, ZOOM_resultset *r,
+                       ZOOM_options options,
+                       const char **args)
 {
+    int ret = 0;
     int error;
     const char *errmsg, *addinfo, *dset;
     int j, i;
@@ -596,7 +695,7 @@ static void cmd_connect(ZOOM_connection *c, ZOOM_resultset *r,
     if (!host)
     {
         printf("missing host after connect\n");
-        return ;
+        return 1;
     }
     for (j = -1, i = 0; i<MAX_CON; i++)
     {
@@ -616,106 +715,141 @@ static void cmd_connect(ZOOM_connection *c, ZOOM_resultset *r,
         {
             printf("no more connection available\n");
             wrbuf_destroy(host);
-            return;
+            return 1;
         }
         i = j;   /* OK, use this one is available */
     }
     c[i] = ZOOM_connection_create(options);
     ZOOM_connection_connect(c[i], wrbuf_cstr(host), 0);
-        
+
     if ((error = ZOOM_connection_error_x(c[i], &errmsg, &addinfo, &dset)))
+    {
         printf("%s error: %s (%s:%d) %s\n",
                ZOOM_connection_option_get(c[i], "host"), errmsg,
                dset, error, addinfo);
+        ret = 1;
+    }
     wrbuf_destroy(host);
+    return ret;
 }
 
+/** \brief parse and execute zoomsh command
+    \param c connections
+    \param r result sets
+    \param options ZOOM options
+    \param buf command string and arguments
+    \retval 0 OK
+    \retval 1 failure to execute
+    \retval -1 EOF (no more commands or quit seen)
+*/
 static int cmd_parse(ZOOM_connection *c, ZOOM_resultset *r,
-                     ZOOM_options options, 
+                     ZOOM_options options,
                      const char **buf)
 {
     int cmd_len;
     const char *cmd_str;
+    int ret = 0;
 
     cmd_len = next_token(buf, &cmd_str);
     if (cmd_len < 0)
-        return 1;
+        return -1;
     if (is_command("quit", cmd_str, cmd_len))
-        return 0;
+        return -1;
     else if (is_command("set", cmd_str, cmd_len))
-        cmd_set(c, r, options, buf);
+        ret = cmd_set(c, r, options, buf);
     else if (is_command("get", cmd_str, cmd_len))
-        cmd_get(c, r, options, buf);
+        ret = cmd_get(c, r, options, buf);
     else if (is_command("rget", cmd_str, cmd_len))
-        cmd_rget(c, r, options, buf);
+        ret = cmd_rget(c, r, options, buf);
     else if (is_command("connect", cmd_str, cmd_len))
-        cmd_connect(c, r, options, buf);
+        ret = cmd_connect(c, r, options, buf);
     else if (is_command("open", cmd_str, cmd_len))
-        cmd_connect(c, r, options, buf);
+        ret = cmd_connect(c, r, options, buf);
     else if (is_command("search", cmd_str, cmd_len))
-        cmd_search(c, r, options, buf);
+        ret = cmd_search(c, r, options, buf);
     else if (is_command("facets", cmd_str, cmd_len))
-        cmd_facets(c, r, options, buf);
+        ret = cmd_facets(c, r, options, buf);
     else if (is_command("find", cmd_str, cmd_len))
-        cmd_search(c, r, options, buf);
+        ret = cmd_search(c, r, options, buf);
     else if (is_command("show", cmd_str, cmd_len))
-        cmd_show(c, r, options, buf);
+        ret = cmd_show(c, r, options, buf);
+    else if (is_command("suggestions", cmd_str, cmd_len))
+        ret = cmd_suggestions(c, r, options, buf);
     else if (is_command("close", cmd_str, cmd_len))
-        cmd_close(c, r, options, buf);
+        ret = cmd_close(c, r, options, buf);
     else if (is_command("help", cmd_str, cmd_len))
-        cmd_help(c, r, options, buf);
+        ret = cmd_help(c, r, options, buf);
     else if (is_command("ext", cmd_str, cmd_len))
-        cmd_ext(c, r, options, buf);
+        ret = cmd_ext(c, r, options, buf);
     else if (is_command("debug", cmd_str, cmd_len))
-        cmd_debug(c, r, options, buf);
+        ret = cmd_debug(c, r, options, buf);
     else if (is_command("scan", cmd_str, cmd_len))
-        cmd_scan(c, r, options, buf);
+        ret = cmd_scan(c, r, options, buf);
     else if (is_command("sort", cmd_str, cmd_len))
-        cmd_sort(c, r, options, buf);
+        ret = cmd_sort(c, r, options, buf);
+    else if (is_command("shell", cmd_str, cmd_len))
+        ret = cmd_shell(c, r, options, buf);
     else
+    {
         printf("unknown command %.*s\n", cmd_len, cmd_str);
-    return 2;
+        ret = 1;
+    }
+    return ret;
 }
 
-void shell(ZOOM_connection *c, ZOOM_resultset *r,
-           ZOOM_options options)
+static int shell(ZOOM_connection *c, ZOOM_resultset *r,
+                 ZOOM_options options, int exit_on_error)
 {
-    while (1)
+    int res = 0;
+    while (res == 0)
     {
-        char buf[1000];
+        char buf[100000];
         char *cp;
         const char *bp = buf;
 #if HAVE_READLINE_READLINE_H
         char* line_in;
-        line_in=readline("ZOOM>");
+        line_in = readline("ZOOM>");
         if (!line_in)
+        {
+            res = -1;
             break;
+        }
 #if HAVE_READLINE_HISTORY_H
         if (*line_in)
             add_history(line_in);
 #endif
-        if(strlen(line_in) > 999) {
+        if (strlen(line_in) > sizeof(buf)-1)
+        {
             printf("Input line too long\n");
+            res = 1;
             break;
-        };
+        }
         strcpy(buf,line_in);
         free(line_in);
-#else    
+#else
         printf("ZOOM>"); fflush(stdout);
-        if (!fgets(buf, 999, stdin))
+        if (!fgets(buf, sizeof(buf)-1, stdin))
+        {
+            res = -1;
             break;
-#endif 
+        }
+#endif
         if ((cp = strchr(buf, '\n')))
             *cp = '\0';
-        if (!cmd_parse(c, r, options, &bp))
+        res = cmd_parse(c, r, options, &bp);
+        if (res == -1)
             break;
+        if (!exit_on_error && res > 0)
+            res = 0;
     }
+    return res;
 }
 
-static void zoomsh(int argc, char **argv)
+static int zoomsh(int argc, char **argv)
 {
-    ZOOM_options options = ZOOM_options_create();
-    int i, res;
+    ZOOM_options zoom_options = ZOOM_options_create();
+    int i, res = 0; /* -1: EOF; 0 = OK, > 0 ERROR */
+    int exit_on_error = 0;
     ZOOM_connection z39_con[MAX_CON];
     ZOOM_resultset  z39_res[MAX_CON];
 
@@ -724,51 +858,51 @@ static void zoomsh(int argc, char **argv)
         z39_con[i] = 0;
         z39_res[i] = 0;
     }
-
-    for (i = 0; i<MAX_CON; i++)
-        z39_con[i] = 0;
-
-    res = 1;
-    for (i = 1; i<argc; i++)
+    while (res == 0)
     {
-        const char *bp = argv[i];
-        res = cmd_parse(z39_con, z39_res, options, &bp);
-        if (res == 0)  /* received quit */
+        int mask;
+        char *arg = 0;
+        int option_ret = options("ev:", argv, argc, &arg);
+        const char *bp = arg;
+        switch (option_ret)
+        {
+        case 0:
+            res = cmd_parse(z39_con, z39_res, zoom_options, &bp);
+            /* returns res == -1 on quit */
+            if (!exit_on_error && res > 0)
+                res = 0;  /* hide error */
+            break;
+        case YAZ_OPTIONS_EOF:
+            res = shell(z39_con, z39_res, zoom_options, exit_on_error);
+            break;
+        case 'e':
+            exit_on_error = 1;
             break;
+        case 'v':
+            mask = yaz_log_mask_str(arg);
+            yaz_log_init_level(mask);
+            break;
+        default:
+            fprintf(stderr, "zoomsh: [-e] [-v] [commands]\n");
+            res = 1;
+        }
     }
-    if (res)  /* do cmdline shell only if not quitting */
-        shell(z39_con, z39_res, options);
-    ZOOM_options_destroy(options);
 
     for (i = 0; i<MAX_CON; i++)
     {
         ZOOM_connection_destroy(z39_con[i]);
         ZOOM_resultset_destroy(z39_res[i]);
     }
+    ZOOM_options_destroy(zoom_options);
+    if (res == -1) /* quit .. which is not an error */
+        res = 0;
+    return res;
 }
 
 int main(int argc, char **argv)
 {
-    const char *maskstr = 0;
-    if (argc > 2 && !strcmp(argv[1], "-v"))
-    {
-        maskstr = argv[2];
-        argv += 2;
-        argc -= 2;
-    }
-    else if (argc > 1 && !strncmp(argv[1], "-v", 2))
-    {
-        maskstr = argv[1]+2;
-        argv++;
-        argc--;
-    }
-    if (maskstr)
-    {
-        int mask = yaz_log_mask_str(maskstr);
-        yaz_log_init_level(mask);
-    }
-    zoomsh(argc, argv);
-    exit(0);
+    int ret = zoomsh(argc, argv);
+    exit(ret);
 }
 /*
  * Local variables: