X-Git-Url: http://git.indexdata.com/?p=yaz-moved-to-github.git;a=blobdiff_plain;f=client%2Fclient.c;h=d9a98f8eb89b47c00d16093b36e7cc4e40ac29e4;hp=0cf0cadf605822900c3098782d741fbfc9c81cd1;hb=2ad2651374674c895ad59b267da6fe2d8665fabd;hpb=8356ea58313ee1f350226172cf99bfb0b7c5583c diff --git a/client/client.c b/client/client.c index 0cf0cad..d9a98f8 100644 --- a/client/client.c +++ b/client/client.c @@ -1,5 +1,5 @@ /* This file is part of the YAZ toolkit. - * Copyright (C) 1995-2009 Index Data + * Copyright (C) 1995-2010 Index Data * See the file LICENSE for details. */ /** \file client.c @@ -62,6 +62,7 @@ #include #include #include +#include #if HAVE_READLINE_READLINE_H #include @@ -104,6 +105,7 @@ static int smallSetUpperBound = 0; static int largeSetLowerBound = 1; static int mediumSetPresentNumber = 0; static Z_ElementSetNames *elementSetNames = 0; +static Z_FacetList *facet_list = 0; static Odr_int setno = 1; /* current set offset */ static enum oid_proto protocol = PROTO_Z3950; /* current app protocol */ #define RECORDSYNTAX_MAX 20 @@ -141,7 +143,7 @@ static int scan_stepSize = 0; static int scan_position = 1; static int scan_size = 20; static char cur_host[200]; -static int last_hit_count = 0; +static Odr_int last_hit_count = 0; typedef enum { QueryType_Prefix, @@ -169,28 +171,30 @@ struct eoi { char* value; } extraOtherInfos[maxOtherInfosSupported]; -void process_cmd_line(char* line); +static void process_cmd_line(char* line); #if HAVE_READLINE_READLINE_H -char **readline_completer(char *text, int start, int end); +static char **readline_completer(char *text, int start, int end); #endif static char *command_generator(const char *text, int state); -int cmd_register_tab(const char* arg); -int cmd_querycharset(const char *arg); +static int cmd_register_tab(const char* arg); +static int cmd_querycharset(const char *arg); static void close_session(void); static void marc_file_write(const char *buf, size_t sz); static void wait_and_handle_response(int one_response_only); +static Z_GDU *get_HTTP_Request_url(ODR odr, const char *url); ODR getODROutputStream(void) { return out; } -const char* query_type_as_string(QueryType q) +static const char* query_type_as_string(QueryType q) { - switch (q) { + switch (q) + { case QueryType_Prefix: return "prefix (RPN sent to server)"; case QueryType_CCL: return "CCL (CCL sent to server) "; case QueryType_CCL2RPN: return "CCL -> RPN (RPN sent to server)"; @@ -210,7 +214,7 @@ static void do_hex_dump(const char* buf, size_t len) for (i = 0; i < len ; i = i+16 ) { printf(" %4.4ld ", (long) i); - for(x=0 ; i+x 0) yaz_oi_set_string_oid(oi, out, extraOtherInfos[i].oid, @@ -286,14 +292,14 @@ int send_apdu(Z_APDU *a) return 1; } -static void print_stringn(const unsigned char *buf, size_t len) +static void print_stringn(const char *buf, size_t len) { size_t i; - for (i = 0; i= 32) || strchr("\n\r\t\f", buf[i])) printf("%c", buf[i]); else - printf("\\X%02X", buf[i]); + printf("\\X%02X", ((const unsigned char *)buf)[i]); } static void print_refid(Z_ReferenceId *id) @@ -301,7 +307,7 @@ static void print_refid(Z_ReferenceId *id) if (id) { printf("Reference Id: "); - print_stringn(id->buf, id->len); + print_stringn((const char *) id->buf, id->len); printf("\n"); } } @@ -320,7 +326,7 @@ static Z_ReferenceId *set_refid(ODR out) /* INIT SERVICE ------------------------------- */ -static void send_initRequest(const char* type_and_host) +static void send_Z3950_initRequest(const char* type_and_host) { Z_APDU *apdu = zget_APDU(out, Z_APDU_initRequest); Z_InitRequest *req = apdu->u.initRequest; @@ -345,7 +351,8 @@ static void send_initRequest(const char* type_and_host) 1, type_and_host); } - if (negotiationCharset || yazLang) { + if (negotiationCharset || yazLang) + { Z_OtherInformation **p; Z_OtherInformationUnit *p0; @@ -368,7 +375,6 @@ static void send_initRequest(const char* type_and_host) } -/* These two are used only from process_initResponse() */ static void render_initUserInfo(Z_OtherInformation *ui1); static void render_diag(Z_DiagnosticFormat *diag); @@ -377,7 +383,7 @@ static void pr_opt(const char *opt, void *clientData) printf(" %s", opt); } -static int process_initResponse(Z_InitResponse *res) +static int process_Z3950_initResponse(Z_InitResponse *res) { int ver = 0; /* save session parameters for later use */ @@ -401,16 +407,18 @@ static int process_initResponse(Z_InitResponse *res) if (res->userInformationField) { Z_External *uif = res->userInformationField; - if (uif->which == Z_External_userInfo1) { + if (uif->which == Z_External_userInfo1) render_initUserInfo(uif->u.userInfo1); - } else { + else + { printf("UserInformationfield:\n"); if (!z_External(print, (Z_External**)&uif, 0, 0)) { odr_perror(print, "Printing userinfo\n"); odr_reset(print); } - if (uif->which == Z_External_octet) { + if (uif->which == Z_External_octet) + { printf("Guessing visiblestring:\n"); printf("'%.*s'\n", uif->u.octet_aligned->len, uif->u.octet_aligned->buf); @@ -435,8 +443,8 @@ static int process_initResponse(Z_InitResponse *res) else { /* Peek at any private Init-diagnostic APDUs */ - printf("### NAUGHTY: External is '%.*s'\n", - sat->len, sat->buf); + printf("yaz-client ignoring unrecognised userInformationField: %d-octet External '%.*s'\n", + (int) sat->len, sat->len, sat->buf); } } odr_reset(print); @@ -449,8 +457,8 @@ static int process_initResponse(Z_InitResponse *res) if (ODR_MASK_GET(res->options, Z_Options_namedResultSets)) setnumber = 0; - if (ODR_MASK_GET(res->options, Z_Options_negotiationModel)) { - + if (ODR_MASK_GET(res->options, Z_Options_negotiationModel)) + { Z_CharSetandLanguageNegotiation *p = yaz_get_charneg_record(res->otherInfo); @@ -486,18 +494,21 @@ static int process_initResponse(Z_InitResponse *res) } -static void render_initUserInfo(Z_OtherInformation *ui1) { +static void render_initUserInfo(Z_OtherInformation *ui1) +{ int i; printf("Init response contains %d otherInfo unit%s:\n", ui1->num_elements, ui1->num_elements == 1 ? "" : "s"); - for (i = 0; i < ui1->num_elements; i++) { + for (i = 0; i < ui1->num_elements; i++) + { Z_OtherInformationUnit *unit = ui1->list[i]; printf(" %d: otherInfo unit contains ", i+1); if (unit->which == Z_OtherInfo_externallyDefinedInfo && unit->information.externallyDefinedInfo && unit->information.externallyDefinedInfo->which == - Z_External_diag1) { + Z_External_diag1) + { render_diag(unit->information.externallyDefinedInfo->u.diag1); } else if (unit->which != Z_OtherInfo_externallyDefinedInfo) @@ -515,14 +526,17 @@ static void render_initUserInfo(Z_OtherInformation *ui1) { /* ### should this share code with display_diagrecs()? */ -static void render_diag(Z_DiagnosticFormat *diag) { +static void render_diag(Z_DiagnosticFormat *diag) +{ int i; printf("%d diagnostic%s:\n", diag->num, diag->num == 1 ? "" : "s"); - for (i = 0; i < diag->num; i++) { + for (i = 0; i < diag->num; i++) + { Z_DiagnosticFormat_s *ds = diag->elements[i]; printf(" %d: ", i+1); - switch (ds->which) { + switch (ds->which) + { case Z_DiagnosticFormat_s_defaultDiagRec: { Z_DefaultDiagFormat *dd = ds->u.defaultDiagRec; /* ### should check `dd->diagnosticSetId' */ @@ -665,11 +679,10 @@ static int cmd_base(const char *arg) return set_base(arg); } -int session_connect(const char *arg) +static int session_connect_base(const char *arg, const char **basep) { void *add; char type_and_host[101]; - const char *basep = 0; if (conn) { cs_close(conn); @@ -681,7 +694,7 @@ int session_connect(const char *arg) session_mem = NULL; session_initResponse = 0; } - cs_get_host_args(arg, &basep); + cs_get_host_args(arg, basep); strncpy(type_and_host, arg, sizeof(type_and_host)-1); type_and_host[sizeof(type_and_host)-1] = '\0'; @@ -706,10 +719,6 @@ int session_connect(const char *arg) } #endif protocol = conn->protocol; - if (conn->protocol == PROTO_HTTP) - set_base(""); - else - set_base("Default"); printf("Connecting..."); fflush(stdout); if (cs_connect(conn, add) < 0) @@ -721,17 +730,28 @@ int session_connect(const char *arg) } printf("OK.\n"); cs_print_session_info(conn); - if (basep && *basep) - set_base (basep); if (protocol == PROTO_Z3950) { - send_initRequest(type_and_host); + send_Z3950_initRequest(type_and_host); return 2; } return 0; } -int cmd_open(const char *arg) +static int session_connect(const char *arg) +{ + int r; + const char *basep = 0; + + r = session_connect_base(arg, &basep); + if (basep && *basep) + set_base(basep); + else if (protocol == PROTO_Z3950) + set_base("Default"); + return r; +} + +static int cmd_open(const char *arg) { int r; if (arg) @@ -739,13 +759,20 @@ int cmd_open(const char *arg) strncpy(cur_host, arg, sizeof(cur_host)-1); cur_host[sizeof(cur_host)-1] = 0; } + /* TODO Make facet definition survive the open command without crashing */ + /* TODO Fix deallocation */ + facet_list = 0; + + set_base(""); r = session_connect(cur_host); if (conn && conn->protocol == PROTO_HTTP) queryType = QueryType_CQL; + + return r; } -int cmd_authentication(const char *arg) +static int cmd_authentication(const char *arg) { char **args; int r; @@ -760,13 +787,13 @@ int cmd_authentication(const char *arg) } else if (r == 1) { - auth = nmem_malloc(nmem_auth, sizeof(*auth)); + auth = (Z_IdAuthentication *) nmem_malloc(nmem_auth, sizeof(*auth)); if (!strcmp(args[0], "-")) { auth->which = Z_IdAuthentication_anonymous; auth->u.anonymous = odr_nullval(); printf("Authentication set to Anonymous\n"); - } + } else { auth->which = Z_IdAuthentication_open; @@ -776,9 +803,10 @@ int cmd_authentication(const char *arg) } else if (r == 2) { - auth = nmem_malloc(nmem_auth, sizeof(*auth)); + auth = (Z_IdAuthentication *) nmem_malloc(nmem_auth, sizeof(*auth)); auth->which = Z_IdAuthentication_idPass; - auth->u.idPass = nmem_malloc(nmem_auth, sizeof(*auth->u.idPass)); + auth->u.idPass = (Z_IdPass *) + nmem_malloc(nmem_auth, sizeof(*auth->u.idPass)); auth->u.idPass->groupId = NULL; auth->u.idPass->userId = !strcmp(args[0], "-") ? 0 : args[0]; auth->u.idPass->password = !strcmp(args[1], "-") ? 0 : args[1]; @@ -787,9 +815,10 @@ int cmd_authentication(const char *arg) } else if (r == 3) { - auth = nmem_malloc(nmem_auth, sizeof(*auth)); + auth = (Z_IdAuthentication*) nmem_malloc(nmem_auth, sizeof(*auth)); auth->which = Z_IdAuthentication_idPass; - auth->u.idPass = nmem_malloc(nmem_auth, sizeof(*auth->u.idPass)); + auth->u.idPass = (Z_IdPass *) + nmem_malloc(nmem_auth, sizeof(*auth->u.idPass)); auth->u.idPass->groupId = args[1]; auth->u.idPass->userId = args[0]; auth->u.idPass->password = args[2]; @@ -808,7 +837,7 @@ int cmd_authentication(const char *arg) /* SEARCH SERVICE ------------------------------ */ static void display_record(Z_External *r); -static void print_record(const unsigned char *buf, size_t len) +static void print_record(const char *buf, size_t len) { size_t i = len; print_stringn(buf, len); @@ -868,91 +897,72 @@ static void display_record(Z_External *r) } } } - if (oid && !oid_oidcmp(oid, yaz_oid_recsyn_soif)) - { - print_record((const unsigned char *) r->u.octet_aligned->buf, - r->u.octet_aligned->len); - marc_file_write((const char *) r->u.octet_aligned->buf, - r->u.octet_aligned->len); - } - else if (oid && r->which == Z_External_octet) + if (oid && r->which == Z_External_octet) { - const char *octet_buf = (char*)r->u.octet_aligned->buf; - if (oid && (!oid_oidcmp(oid, yaz_oid_recsyn_xml) - || !oid_oidcmp(oid, yaz_oid_recsyn_xml) - || !oid_oidcmp(oid, yaz_oid_recsyn_html))) + const char *octet_buf = (const char*)r->u.octet_aligned->buf; + size_t octet_len = r->u.octet_aligned->len; + if (!oid_oidcmp(oid, yaz_oid_recsyn_xml) + || !oid_oidcmp(oid, yaz_oid_recsyn_xml) + || !oid_oidcmp(oid, yaz_oid_recsyn_html)) { - print_record((const unsigned char *) octet_buf, - r->u.octet_aligned->len); + fwrite(octet_buf, 1, octet_len, stdout); } - else if (oid && !oid_oidcmp(oid, yaz_oid_recsyn_postscript)) + else if (yaz_oid_is_iso2709(oid)) { - int size = r->u.octet_aligned->len; - if (size > 100) - size = 100; - print_record((const unsigned char *) octet_buf, size); - } - else - { - if (oid && yaz_oid_is_iso2709(oid)) - { - const char *result; - size_t rlen; - yaz_iconv_t cd = 0; - yaz_marc_t mt = yaz_marc_create(); - const char *from = 0; + const char *result; + size_t rlen; + yaz_iconv_t cd = 0; + yaz_marc_t mt = yaz_marc_create(); + const char *from = 0; - if (marcCharset && !strcmp(marcCharset, "auto")) + if (marcCharset && !strcmp(marcCharset, "auto")) + { + if (!oid_oidcmp(oid, yaz_oid_recsyn_usmarc)) { - if (!oid_oidcmp(oid, yaz_oid_recsyn_usmarc)) - { - if (octet_buf[9] == 'a') - from = "UTF-8"; - else - from = "MARC-8"; - } + if (octet_buf[9] == 'a') + from = "UTF-8"; else - from = "ISO-8859-1"; + from = "MARC-8"; } - else if (marcCharset) - from = marcCharset; - if (outputCharset && from) + else + from = "ISO-8859-1"; + } + else if (marcCharset) + from = marcCharset; + if (outputCharset && from) + { + cd = yaz_iconv_open(outputCharset, from); + printf("convert from %s to %s", from, + outputCharset); + if (!cd) + printf(" unsupported\n"); + else { - cd = yaz_iconv_open(outputCharset, from); - printf("convert from %s to %s", from, - outputCharset); - if (!cd) - printf(" unsupported\n"); - else - { - yaz_marc_iconv(mt, cd); - printf("\n"); - } + yaz_marc_iconv(mt, cd); + printf("\n"); } + } - if (yaz_marc_decode_buf(mt, octet_buf, r->u.octet_aligned->len, - &result, &rlen)> 0) - { - if (fwrite(result, rlen, 1, stdout) != 1) - { - printf("write to stdout failed\n"); - } - } - else + if (yaz_marc_decode_buf(mt, octet_buf, octet_len, + &result, &rlen)> 0) + { + if (fwrite(result, rlen, 1, stdout) != 1) { - printf("bad MARC. Dumping as it is:\n"); - print_record((const unsigned char*) octet_buf, - r->u.octet_aligned->len); + printf("write to stdout failed\n"); } - yaz_marc_destroy(mt); - if (cd) - yaz_iconv_close(cd); } else { - print_record((const unsigned char*) octet_buf, - r->u.octet_aligned->len); + printf("bad MARC. Dumping as it is:\n"); + print_record(octet_buf, octet_len); } + yaz_marc_destroy(mt); + if (cd) + yaz_iconv_close(cd); + } + else + { + print_record(octet_buf, octet_len); } marc_file_write(octet_buf, r->u.octet_aligned->len); } @@ -963,7 +973,7 @@ static void display_record(Z_External *r) printf("Expecting single SUTRS type for SUTRS.\n"); return; } - print_record(r->u.sutrs->buf, r->u.sutrs->len); + print_record((const char *) r->u.sutrs->buf, r->u.sutrs->len); marc_file_write((const char *) r->u.sutrs->buf, r->u.sutrs->len); } else if (oid && !oid_oidcmp(oid, yaz_oid_recsyn_grs_1)) @@ -1168,7 +1178,7 @@ static void display_records(Z_Records *p) } } -static int send_deleteResultSetRequest(const char *arg) +static int send_Z3950_deleteResultSetRequest(const char *arg) { char names[8][32]; int i; @@ -1205,32 +1215,8 @@ static int send_deleteResultSetRequest(const char *arg) } #if YAZ_HAVE_XML2 -static int send_srw(Z_SRW_PDU *sr) +static int send_gdu(Z_GDU *gdu) { - const char *charset = negotiationCharset; - const char *host_port = cur_host; - Z_GDU *gdu; - char *path = 0; - - path = (char *) odr_malloc(out, 2+strlen(databaseNames[0])); - *path = '/'; - strcpy(path+1, databaseNames[0]); - - gdu = z_get_HTTP_Request_host_path(out, host_port, path); - - if (!yaz_matchstr(sru_method, "get")) - { - yaz_sru_get_encode(gdu->u.HTTP_Request, sr, out, charset); - } - else if (!yaz_matchstr(sru_method, "post")) - { - yaz_sru_post_encode(gdu->u.HTTP_Request, sr, out, charset); - } - else if (!yaz_matchstr(sru_method, "soap")) - { - yaz_sru_soap_encode(gdu->u.HTTP_Request, sr, out, charset); - } - if (z_GDU(out, &gdu, 0, 0)) { /* encode OK */ @@ -1256,6 +1242,124 @@ static int send_srw(Z_SRW_PDU *sr) } return 0; } + +static int send_srw_host_path(Z_SRW_PDU *sr, const char *host_port, + char *path) +{ + const char *charset = negotiationCharset; + Z_GDU *gdu; + + gdu = z_get_HTTP_Request_host_path(out, host_port, path); + + if (auth) + { + if (auth->which == Z_IdAuthentication_open) + { + char **darray; + int num; + nmem_strsplit(out->mem, "/", auth->u.open, &darray, &num); + if (num >= 1) + sr->username = darray[0]; + if (num >= 2) + sr->password = darray[1]; + } + else if (auth->which == Z_IdAuthentication_idPass) + { + sr->username = auth->u.idPass->userId; + sr->password = auth->u.idPass->password; + } + } + + if (!yaz_matchstr(sru_method, "get")) + { + yaz_sru_get_encode(gdu->u.HTTP_Request, sr, out, charset); + } + else if (!yaz_matchstr(sru_method, "post")) + { + yaz_sru_post_encode(gdu->u.HTTP_Request, sr, out, charset); + } + else if (!yaz_matchstr(sru_method, "soap")) + { + yaz_sru_soap_encode(gdu->u.HTTP_Request, sr, out, charset); + } + else if (!yaz_matchstr(sru_method, "solr")) + { + yaz_solr_encode(gdu->u.HTTP_Request, sr, out, charset); + } + + return send_gdu(gdu); +} + +static int send_srw(Z_SRW_PDU *sr) +{ + char *path = yaz_encode_sru_dbpath_odr(out, databaseNames[0]); + return send_srw_host_path(sr, cur_host, path); +} + +static int send_SRW_redirect(const char *uri, Z_HTTP_Response *cookie_hres) +{ + const char *username = 0; + const char *password = 0; + struct Z_HTTP_Header *h; + char *combined_cookies = 0; + int combined_cookies_len = 0; + Z_GDU *gdu = get_HTTP_Request_url(out, uri); + + gdu->u.HTTP_Request->method = odr_strdup(out, "GET"); + z_HTTP_header_add(out, &gdu->u.HTTP_Request->headers, "Accept", + "text/xml"); + + for (h = cookie_hres->headers; h; h = h->next) + { + if (!strcmp(h->name, "Set-Cookie")) + { + char *cp; + + if (!(cp = strchr(h->value, ';'))) + cp = h->value + strlen(h->value); + if (cp - h->value >= 1) + { + combined_cookies = xrealloc(combined_cookies, combined_cookies_len + cp - h->value + 3); + memcpy(combined_cookies+combined_cookies_len, h->value, cp - h->value); + combined_cookies[combined_cookies_len + cp - h->value] = '\0'; + strcat(combined_cookies,"; "); + combined_cookies_len = strlen(combined_cookies); + } + } + } + if (combined_cookies_len) + { + z_HTTP_header_add(out, &gdu->u.HTTP_Request->headers, "Cookie", combined_cookies); + xfree(combined_cookies); + } + + if (auth) + { + if (auth->which == Z_IdAuthentication_open) + { + char **darray; + int num; + nmem_strsplit(out->mem, "/", auth->u.open, &darray, &num); + if (num >= 1) + username = darray[0]; + if (num >= 2) + password = darray[1]; + } + else if (auth->which == Z_IdAuthentication_idPass) + { + username = auth->u.idPass->userId; + password = auth->u.idPass->password; + } + } + + if (username && password) + { + z_HTTP_header_add_basic_auth(out, &gdu->u.HTTP_Request->headers, + username, password); + } + + return send_gdu(gdu); +} #endif #if YAZ_HAVE_XML2 @@ -1291,7 +1395,7 @@ static int send_SRW_scanRequest(const char *arg, int pos, int num) /* regular requestse .. */ sr = yaz_srw_get_pdu(out, Z_SRW_scan_request, sru_version); - switch(queryType) + switch (queryType) { case QueryType_CQL: sr->u.scan_request->query_type = Z_SRW_query_type_cql; @@ -1330,7 +1434,7 @@ static int send_SRW_searchRequest(const char *arg) /* regular request .. */ sr = yaz_srw_get_pdu(out, Z_SRW_searchRetrieve_request, sru_version); - switch(queryType) + switch (queryType) { case QueryType_CQL: srw_sr->u.request->query_type = Z_SRW_query_type_cql; @@ -1376,7 +1480,7 @@ static void query_charset_convert(Z_RPNQuery *q) } } -static int send_searchRequest(const char *arg) +static int send_Z3950_searchRequest(const char *arg) { Z_APDU *apdu = zget_APDU(out, Z_APDU_searchRequest); Z_SearchRequest *req = apdu->u.searchRequest; @@ -1399,23 +1503,28 @@ static int send_searchRequest(const char *arg) printf("CCL ERROR: %s\n", ccl_err_msg(error)); return 0; } - } else if (myQueryType == QueryType_CQL2RPN) { + } + else if (myQueryType == QueryType_CQL2RPN) + { /* ### All this code should be wrapped in a utility function */ CQL_parser parser; struct cql_node *node; const char *addinfo; - if (cqltrans == 0) { + if (cqltrans == 0) + { printf("Can't use CQL: no translation file. Try set_cqlfile\n"); return 0; } parser = cql_parser_create(); - if ((error = cql_parser_string(parser, arg)) != 0) { + if ((error = cql_parser_string(parser, arg)) != 0) + { printf("Can't parse CQL: must be a syntax error\n"); return 0; } node = cql_parser_result(parser); if ((error = cql_transform_buf(cqltrans, node, pqfbuf, - sizeof pqfbuf)) != 0) { + sizeof pqfbuf)) != 0) + { error = cql_transform_error(cqltrans, &addinfo); printf("Can't convert CQL to PQF: %s (addinfo=%s)\n", cql_strerror(error), addinfo); @@ -1522,6 +1631,25 @@ static int send_searchRequest(const char *arg) return 2; } +static void display_term(Z_Term *term) +{ + switch (term->which) + { + case Z_Term_general: + printf(" %.*s", term->u.general->len, term->u.general->buf); + break; + case Z_Term_characterString: + printf(" %s", term->u.characterString); + break; + case Z_Term_numeric: + printf(" " ODR_INT_PRINTF, *term->u.numeric); + break; + case Z_Term_null: + printf(" null"); + break; + } +} + /* display Query Expression as part of searchResult-1 */ static void display_queryExpression(const char *lead, Z_QueryExpression *qe) { @@ -1533,25 +1661,77 @@ static void display_queryExpression(const char *lead, Z_QueryExpression *qe) if (qe->u.term->queryTerm) { Z_Term *term = qe->u.term->queryTerm; - switch (term->which) + display_term(term); + } + } +} + +static void display_facet(Z_FacetField *facet) +{ + if (facet->attributes) + { + Z_AttributeList *al = facet->attributes; + struct yaz_facet_attr attr_values; + attr_values.errcode = 0; + attr_values.limit = -1; + attr_values.useattr = 0; + attr_values.relation = "default"; + + yaz_facet_attr_get_z_attributes(al, &attr_values); + if (!attr_values.errcode) + { + int term_index; + printf(" %s (%d): \n", attr_values.useattr, /* attr_values.relation, attr_values.limit, */ facet->num_terms); + for (term_index = 0 ; term_index < facet->num_terms; term_index++) { - case Z_Term_general: - printf("%.*s", term->u.general->len, term->u.general->buf); - break; - case Z_Term_characterString: - printf("%s", term->u.characterString); - break; - case Z_Term_numeric: - printf(ODR_INT_PRINTF, *term->u.numeric); - break; - case Z_Term_null: - printf("null"); - break; + Z_FacetTerm *facetTerm = facet->terms[term_index]; + display_term(facetTerm->term); + printf(" (" NMEM_INT_PRINTF ")\n", *facetTerm->count); } } + } } +static void* display_facets(Z_FacetList *fl) +{ + int index; + printf("Facets(%d): \n", fl->num); + + for (index = 0; index < fl->num ; index++) + { + display_facet(fl->elements[index]); + } + return 0; +} + +void display_searchResult1(Z_SearchInfoReport *sr) +{ + int j; + printf("SearchResult-1:"); + for (j = 0; j < sr->num; j++) + { + if (j) + printf(","); + if (!sr->elements[j]->subqueryExpression) + printf("%d", j); + display_queryExpression("term", + sr->elements[j]->subqueryExpression); + display_queryExpression("interpretation", + sr->elements[j]->subqueryInterpretation); + display_queryExpression("recommendation", + sr->elements[j]->subqueryRecommendation); + if (sr->elements[j]->subqueryCount) + printf(" cnt=" ODR_INT_PRINTF, + *sr->elements[j]->subqueryCount); + if (sr->elements[j]->subqueryId) + printf(" id=%s ", sr->elements[j]->subqueryId); + } + printf("\n"); +} + + + /* see if we can find USR:SearchResult-1 */ static void display_searchResult(Z_OtherInformation *o) { @@ -1565,35 +1745,14 @@ static void display_searchResult(Z_OtherInformation *o) Z_External *ext = o->list[i]->information.externallyDefinedInfo; if (ext->which == Z_External_searchResult1) - { - int j; - Z_SearchInfoReport *sr = ext->u.searchResult1; - printf("SearchResult-1:"); - for (j = 0; j < sr->num; j++) - { - if (j) - printf(","); - if (!sr->elements[j]->subqueryExpression) - printf("%d", j); - display_queryExpression("term", - sr->elements[j]->subqueryExpression); - display_queryExpression("interpretation", - sr->elements[j]->subqueryInterpretation); - display_queryExpression("recommendation", - sr->elements[j]->subqueryRecommendation); - if (sr->elements[j]->subqueryCount) - printf(" cnt=" ODR_INT_PRINTF, - *sr->elements[j]->subqueryCount); - if (sr->elements[j]->subqueryId) - printf(" id=%s ", sr->elements[j]->subqueryId); - } - printf("\n"); - } + display_searchResult1(ext->u.searchResult1); + else if (ext->which == Z_External_userFacets) + display_facets(ext->u.facetList); } } } -static int process_searchResponse(Z_SearchResponse *res) +static int process_Z3950_searchResponse(Z_SearchResponse *res) { printf("Received SearchResponse.\n"); print_refid(res->referenceId); @@ -1609,7 +1768,7 @@ static int process_searchResponse(Z_SearchResponse *res) if (res->resultSetStatus) { printf("Result Set Status: "); - switch(*res->resultSetStatus) + switch (*res->resultSetStatus) { case Z_SearchResponse_subset: printf("subset"); break; @@ -1798,7 +1957,7 @@ static void print_external(int iLevel, Z_External *pExternal) } } -static int process_resourceControlRequest(Z_ResourceControlRequest *req) +static int process_Z3950_resourceControlRequest(Z_ResourceControlRequest *req) { printf("Received ResourceControlRequest.\n"); print_referenceId(1, req->referenceId); @@ -1810,7 +1969,7 @@ static int process_resourceControlRequest(Z_ResourceControlRequest *req) return 0; } -void process_ESResponse(Z_ExtendedServicesResponse *res) +static void process_Z3950_ESResponse(Z_ExtendedServicesResponse *res) { printf("Status: "); switch (*res->operationStatus) @@ -1829,7 +1988,8 @@ void process_ESResponse(Z_ExtendedServicesResponse *res) printf("unknown\n"); } if ( (*res->operationStatus != Z_ExtendedServicesResponse_failure) && - (res->num_diagnostics != 0) ) { + (res->num_diagnostics != 0) ) + { display_diagrecs(res->diagnostics, res->num_diagnostics); } print_refid (res->referenceId); @@ -1843,7 +2003,7 @@ void process_ESResponse(Z_ExtendedServicesResponse *res) if (id) { printf("Target Reference: "); - print_stringn (id->buf, id->len); + print_stringn((const char *) id->buf, id->len); printf("\n"); } if (ext->which == Z_External_update) @@ -1907,7 +2067,7 @@ void process_ESResponse(Z_ExtendedServicesResponse *res) } } -const char *get_ill_element(void *clientData, const char *element) +static const char *get_ill_element(void *clientData, const char *element) { return 0; } @@ -1963,7 +2123,7 @@ static Z_External *create_external_itemRequest(void) return r; } -static Z_External *create_external_ILL_APDU(int which) +static Z_External *create_external_ILL_APDU(void) { struct ill_get_ctl ctl; ILL_APDU *ill_apdu; @@ -2065,7 +2225,7 @@ static Z_External *create_ItemOrderExternal(const char *type, int itemno, { printf("using ILL-request\n"); r->u.itemOrder->u.esRequest->notToKeep->itemRequest = - create_external_ILL_APDU(ILL_APDU_ILL_Request); + create_external_ILL_APDU(); } else if (!strcmp(type, "xml") || !strcmp(type, "3")) { @@ -2088,8 +2248,8 @@ static Z_External *create_ItemOrderExternal(const char *type, int itemno, return r; } -static int send_itemorder(const char *type, int itemno, - const char *xml_buf, int xml_len) +static int send_Z3950_itemorder(const char *type, int itemno, + const char *xml_buf, int xml_len) { Z_APDU *apdu = zget_APDU(out, Z_APDU_extendedServicesRequest); Z_ExtendedServicesRequest *req = apdu->u.extendedServicesRequest; @@ -2132,11 +2292,11 @@ static int cmd_update0(const char *arg) return cmd_update_common(arg, 0); } -static int cmd_update_Z3950(int version, int action_no, const char *recid, +static int send_Z3950_update(int version, int action_no, const char *recid, char *rec_buf, int rec_len); #if YAZ_HAVE_XML2 -static int cmd_update_SRW(int action_no, const char *recid, +static int send_SRW_update(int action_no, const char *recid, char *rec_buf, int rec_len); #endif @@ -2191,14 +2351,14 @@ static int cmd_update_common(const char *arg, int version) #if YAZ_HAVE_XML2 if (protocol == PROTO_HTTP) - return cmd_update_SRW(action_no, recid_buf, rec_buf, rec_len); + return send_SRW_update(action_no, recid_buf, rec_buf, rec_len); #endif - return cmd_update_Z3950(version, action_no, recid_buf, rec_buf, rec_len); + return send_Z3950_update(version, action_no, recid_buf, rec_buf, rec_len); } #if YAZ_HAVE_XML2 -static int cmd_update_SRW(int action_no, const char *recid, - char *rec_buf, int rec_len) +static int send_SRW_update(int action_no, const char *recid, + char *rec_buf, int rec_len) { if (!conn) session_connect(cur_host); @@ -2209,7 +2369,7 @@ static int cmd_update_SRW(int action_no, const char *recid, Z_SRW_PDU *srw = yaz_srw_get(out, Z_SRW_update_request); Z_SRW_updateRequest *sr = srw->u.update_request; - switch(action_no) + switch (action_no) { case Z_IUOriginPartToKeep_recordInsert: sr->operation = "info:srw/action/1/create"; @@ -2235,7 +2395,7 @@ static int cmd_update_SRW(int action_no, const char *recid, } #endif -static int cmd_update_Z3950(int version, int action_no, const char *recid, +static int send_Z3950_update(int version, int action_no, const char *recid, char *rec_buf, int rec_len) { Z_APDU *apdu = zget_APDU(out, Z_APDU_extendedServicesRequest ); @@ -2437,7 +2597,7 @@ static int cmd_itemorder(const char *arg) parse_cmd_doc(&arg, out, &xml_buf, &xml_len); fflush(stdout); - send_itemorder(type, itemno, xml_buf, xml_len); + send_Z3950_itemorder(type, itemno, xml_buf, xml_len); return 2; } @@ -2507,10 +2667,134 @@ static int cmd_init(const char *arg) } if (only_z3950()) return 1; - send_initRequest(cur_host); + send_Z3950_initRequest(cur_host); return 2; } +static Z_GDU *get_HTTP_Request_url(ODR odr, const char *url) +{ + Z_GDU *p = z_get_HTTP_Request(odr); + const char *host = url; + const char *cp0 = strstr(host, "://"); + const char *cp1 = 0; + if (cp0) + cp0 = cp0+3; + else + cp0 = host; + + cp1 = strchr(cp0, '/'); + if (!cp1) + cp1 = cp0 + strlen(cp0); + + if (cp0 && cp1) + { + char *h = (char*) odr_malloc(odr, cp1 - cp0 + 1); + memcpy (h, cp0, cp1 - cp0); + h[cp1-cp0] = '\0'; + z_HTTP_header_add(odr, &p->u.HTTP_Request->headers, "Host", h); + } + p->u.HTTP_Request->path = odr_strdup(odr, *cp1 ? cp1 : "/"); + return p; +} + +static WRBUF get_url(const char *uri, WRBUF username, WRBUF password, + int *code, int show_headers) +{ + WRBUF result = 0; + ODR out = odr_createmem(ODR_ENCODE); + ODR in = odr_createmem(ODR_DECODE); + Z_GDU *gdu = get_HTTP_Request_url(out, uri); + + gdu->u.HTTP_Request->method = odr_strdup(out, "GET"); + if (username && password) + { + z_HTTP_header_add_basic_auth(out, &gdu->u.HTTP_Request->headers, + wrbuf_cstr(username), + wrbuf_cstr(password)); + } + z_HTTP_header_add(out, &gdu->u.HTTP_Request->headers, "Accept", + "text/xml"); + if (!z_GDU(out, &gdu, 0, 0)) + { + yaz_log(YLOG_WARN, "Can not encode HTTP request URL:%s", uri); + } + else + { + void *add; + COMSTACK conn = cs_create_host(uri, 1, &add); + if (cs_connect(conn, add) < 0) + yaz_log(YLOG_WARN, "Can not connect to URL:%s", uri); + else + { + int len; + char *buf = odr_getbuf(out, &len, 0); + + if (cs_put(conn, buf, len) < 0) + yaz_log(YLOG_WARN, "cs_put failed URL:%s", uri); + else + { + char *netbuffer = 0; + int netlen = 0; + int res = cs_get(conn, &netbuffer, &netlen); + if (res <= 0) + { + yaz_log(YLOG_WARN, "cs_get failed URL:%s", uri); + } + else + { + Z_GDU *gdu; + odr_setbuf(in, netbuffer, res, 0); + if (!z_GDU(in, &gdu, 0, 0) + || gdu->which != Z_GDU_HTTP_Response) + { + yaz_log(YLOG_WARN, "decode failed URL: %s", uri); + } + else + { + Z_HTTP_Response *res = gdu->u.HTTP_Response; + struct Z_HTTP_Header *h; + result = wrbuf_alloc(); + if (show_headers) + { + + wrbuf_printf(result, "HTTP %d\n", res->code); + for (h = res->headers; h; h = h->next) + wrbuf_printf(result, "%s: %s\n", + h->name, h->value); + } + *code = res->code; + wrbuf_write(result, res->content_buf, res->content_len); + } + } + xfree(netbuffer); + } + cs_close(conn); + } + } + odr_destroy(out); + odr_destroy(in); + return result; +} + + +static int cmd_url(const char *arg) +{ + int code = 0; + WRBUF res = get_url(arg, 0, 0, &code, 1); + if (res) + { + if (wrbuf_len(res) > 1200) + { + fwrite(wrbuf_buf(res), 1, 1200, stdout); + printf(".. out of %lld\n", (long long) wrbuf_len(res)); + } + else + puts(wrbuf_cstr(res)); + wrbuf_destroy(res); + } + return 0; +} + static int cmd_sru(const char *arg) { if (!*arg) @@ -2520,8 +2804,7 @@ static int cmd_sru(const char *arg) } else { - int r; - r = sscanf(arg, "%9s %9s", sru_method, sru_version); + int r = sscanf(arg, "%9s %9s", sru_method, sru_version); if (r >= 1) { if (!yaz_matchstr(sru_method, "post")) @@ -2530,11 +2813,13 @@ static int cmd_sru(const char *arg) ; else if (!yaz_matchstr(sru_method, "soap")) ; + else if (!yaz_matchstr(sru_method, "solr")) + ; else { strcpy(sru_method, "soap"); printf("Unknown SRU method: %s\n", arg); - printf("Specify one of POST, GET, SOAP\n"); + printf("Specify one of POST, GET, SOAP, SOLR\n"); } } } @@ -2570,7 +2855,7 @@ static int cmd_find(const char *arg) { if (conn) { - if (!send_searchRequest(arg)) + if (!send_Z3950_searchRequest(arg)) return 0; wait_and_handle_response(0); if (conn) @@ -2588,7 +2873,7 @@ static int cmd_find(const char *arg) } else if (conn) { - if (!send_searchRequest(arg)) + if (!send_Z3950_searchRequest(arg)) return 0; } else @@ -2600,11 +2885,43 @@ static int cmd_find(const char *arg) return 2; } +static int cmd_facets(const char *arg) +{ + int size = 0; + if (!*arg) + { + facet_list = 0; + printf("Facets cleared.\n"); + return 0; + } + size = strlen(arg); + if (only_z3950()) + { + printf("Currently only supported for Z39.50.\n"); + return 0; + } + else + { + /* TODO Wrong odr. Loosing memory */ + ODR odr = odr_createmem(ODR_ENCODE); + facet_list = yaz_pqf_parse_facet_list(odr, arg); + + if (!facet_list) + { + printf("Invalid facet list: %s", arg); + return 0; + } + return 1; + } + return 2; +} + + static int cmd_delete(const char *arg) { if (only_z3950()) return 0; - if (!send_deleteResultSetRequest(arg)) + if (!send_Z3950_deleteResultSetRequest(arg)) return 0; return 2; } @@ -2658,39 +2975,57 @@ static int cmd_setnames(const char *arg) /* PRESENT SERVICE ----------------------------- */ -static void parse_show_args(const char *arg_c, char *setstring, - Odr_int *start, Odr_int *number) +static int parse_show_args(const char *arg_c, char *setstring, + Odr_int *start, Odr_int *number) { - char arg[40]; - char *p; + char *end_ptr; + Odr_int start_position; - strncpy(arg, arg_c, sizeof(arg)-1); - arg[sizeof(arg)-1] = '\0'; + if (setnumber >= 0) + sprintf(setstring, "%d", setnumber); + else + *setstring = '\0'; - if ((p = strchr(arg, '+'))) + if (!strcmp(arg_c, "all")) { - *number = atoi(p + 1); - *p = '\0'; + *number = last_hit_count; + *start = 1; } - if (*arg) + start_position = odr_strtol(arg_c, &end_ptr, 10); + if (end_ptr == arg_c) + return 1; + *start = start_position; + if (*end_ptr == '\0') + return 1; + while (isspace(*(unsigned char *)end_ptr)) + end_ptr++; + if (*end_ptr != '+') { - if (!strcmp(arg, "all")) - { - *number = last_hit_count; - *start = 1; - } - else - *start = atoi(arg); + printf("Bad show arg: expected +. Got %s\n", end_ptr); + return 0; } - if (p && (p=strchr(p+1, '+'))) - strcpy(setstring, p+1); - else if (setnumber >= 0) - sprintf(setstring, "%d", setnumber); - else - *setstring = '\0'; + end_ptr++; + arg_c = end_ptr; + *number = odr_strtol(arg_c, &end_ptr, 10); + if (end_ptr == arg_c) + { + printf("Bad show arg: expected number after +\n"); + return 0; + } + if (*end_ptr == '\0') + return 1; + while (isspace(*(unsigned char *)end_ptr)) + end_ptr++; + if (*end_ptr != '+') + { + printf("Bad show arg: + expected. Got %s\n", end_ptr); + return 0; + } + strcpy(setstring, end_ptr+1); + return 1; } -static int send_presentRequest(const char *arg) +static int send_Z3950_presentRequest(const char *arg) { Z_APDU *apdu = zget_APDU(out, Z_APDU_presentRequest); Z_PresentRequest *req = apdu->u.presentRequest; @@ -2700,7 +3035,8 @@ static int send_presentRequest(const char *arg) req->referenceId = set_refid(out); - parse_show_args(arg, setstring, &setno, &nos); + if (!parse_show_args(arg, setstring, &setno, &nos)) + return 0; if (*setstring) req->resultSetId = setstring; @@ -2791,7 +3127,8 @@ static int send_SRW_presentRequest(const char *arg) if (!sr) return 0; - parse_show_args(arg, setstring, &setno, &nos); + if (!parse_show_args(arg, setstring, &setno, &nos)) + return 0; sr->u.request->startRecord = odr_intdup(out, setno); sr->u.request->maximumRecords = odr_intdup(out, nos); if (record_schema) @@ -2814,7 +3151,7 @@ static void close_session(void) last_hit_count = 0; } -void process_close(Z_Close *req) +static void process_Z3950_close(Z_Close *req) { Z_APDU *apdu = zget_APDU(out, Z_APDU_close); Z_Close *res = apdu->u.close; @@ -2868,13 +3205,13 @@ static int cmd_show(const char *arg) printf("Not connected yet\n"); return 0; } - if (!send_presentRequest(arg)) + if (!send_Z3950_presentRequest(arg)) return 0; } return 2; } -void exit_client(int code) +static void exit_client(int code) { file_history_save(file_history); file_history_destroy(&file_history); @@ -2882,7 +3219,7 @@ void exit_client(int code) exit(code); } -int cmd_quit(const char *arg) +static int cmd_quit(const char *arg) { printf("See you later, alligator.\n"); xmalloc_trav(""); @@ -2890,49 +3227,57 @@ int cmd_quit(const char *arg) return 0; } -int cmd_cancel(const char *arg) +static int cmd_cancel(const char *arg) { - Z_APDU *apdu = zget_APDU(out, Z_APDU_triggerResourceControlRequest); - Z_TriggerResourceControlRequest *req = - apdu->u.triggerResourceControlRequest; - bool_t rfalse = 0; - char command[16]; - - *command = '\0'; - sscanf(arg, "%15s", command); - if (only_z3950()) return 0; - if (session_initResponse && - !ODR_MASK_GET(session_initResponse->options, - Z_Options_triggerResourceCtrl)) + else { - printf("Target doesn't support cancel (trigger resource ctrl)\n"); - return 0; + Z_APDU *apdu = zget_APDU(out, Z_APDU_triggerResourceControlRequest); + Z_TriggerResourceControlRequest *req = + apdu->u.triggerResourceControlRequest; + bool_t rfalse = 0; + char command[16]; + + *command = '\0'; + sscanf(arg, "%15s", command); + + if (only_z3950()) + return 0; + if (session_initResponse && + !ODR_MASK_GET(session_initResponse->options, + Z_Options_triggerResourceCtrl)) + { + printf("Target doesn't support cancel (trigger resource ctrl)\n"); + return 0; + } + *req->requestedAction = Z_TriggerResourceControlRequest_cancel; + req->resultSetWanted = &rfalse; + req->referenceId = set_refid(out); + + send_apdu(apdu); + printf("Sent cancel request\n"); + if (!strcmp(command, "wait")) + return 2; + return 1; } - *req->requestedAction = Z_TriggerResourceControlRequest_cancel; - req->resultSetWanted = &rfalse; - req->referenceId = set_refid(out); - - send_apdu(apdu); - printf("Sent cancel request\n"); - if (!strcmp(command, "wait")) - return 2; - return 1; } - -int cmd_cancel_find(const char *arg) { +static int cmd_cancel_find(const char *arg) +{ int fres; - fres=cmd_find(arg); - if( fres > 0 ) { + if (only_z3950()) + return 0; + fres = cmd_find(arg); + if (fres > 0) + { return cmd_cancel(""); }; return fres; } -int send_scanrequest(const char *set, const char *query, - Odr_int pp, Odr_int num, const char *term) +static int send_Z3950_scanrequest(const char *set, const char *query, + Odr_int pp, Odr_int num, const char *term) { Z_APDU *apdu = zget_APDU(out, Z_APDU_scanRequest); Z_ScanRequest *req = apdu->u.scanRequest; @@ -2964,6 +3309,7 @@ int send_scanrequest(const char *set, const char *query, { YAZ_PQF_Parser pqf_parser = yaz_pqf_create(); + if (!(req->termListAndStartPoint = yaz_pqf_scan(pqf_parser, out, &req->attributeSet, query))) { @@ -3018,7 +3364,7 @@ int send_scanrequest(const char *set, const char *query, return 2; } -int send_sortrequest(const char *arg, int newset) +static int send_sortrequest(const char *arg, int newset) { Z_APDU *apdu = zget_APDU(out, Z_APDU_sortRequest); Z_SortRequest *req = apdu->u.sortRequest; @@ -3055,7 +3401,7 @@ int send_sortrequest(const char *arg, int newset) return 2; } -void display_term(Z_TermInfo *t) +static void display_term_info(Z_TermInfo *t) { if (t->displayTerm) printf("%s", t->displayTerm); @@ -3073,7 +3419,7 @@ void display_term(Z_TermInfo *t) printf("\n"); } -void process_scanResponse(Z_ScanResponse *res) +static void process_Z3950_scanResponse(Z_ScanResponse *res) { int i; Z_Entry **entries = NULL; @@ -3097,7 +3443,7 @@ void process_scanResponse(Z_ScanResponse *res) if (entries[i]->which == Z_Entry_termInfo) { printf("%c ", i + 1 == pos_term ? '*' : ' '); - display_term(entries[i]->u.termInfo); + display_term_info(entries[i]->u.termInfo); } else display_diagrecs(&entries[i]->u.surrogateDiagnostic, 1); @@ -3107,7 +3453,7 @@ void process_scanResponse(Z_ScanResponse *res) res->entries->num_nonsurrogateDiagnostics); } -void process_sortResponse(Z_SortResponse *res) +static void process_Z3950_sortResponse(Z_SortResponse *res) { printf("Received SortResponse: status="); switch (*res->sortStatus) @@ -3128,7 +3474,8 @@ void process_sortResponse(Z_SortResponse *res) res->num_diagnostics); } -void process_deleteResultSetResponse(Z_DeleteResultSetResponse *res) +static void process_Z3950_deleteResultSetResponse( + Z_DeleteResultSetResponse *res) { printf("Got deleteResultSetResponse status=" ODR_INT_PRINTF "\n", *res->deleteOperationStatus); @@ -3144,7 +3491,7 @@ void process_deleteResultSetResponse(Z_DeleteResultSetResponse *res) } } -int cmd_sort_generic(const char *arg, int newset) +static int cmd_sort_generic(const char *arg, int newset) { if (only_z3950()) return 0; @@ -3163,23 +3510,23 @@ int cmd_sort_generic(const char *arg, int newset) return 0; } -int cmd_sort(const char *arg) +static int cmd_sort(const char *arg) { return cmd_sort_generic(arg, 0); } -int cmd_sort_newset(const char *arg) +static int cmd_sort_newset(const char *arg) { return cmd_sort_generic(arg, 1); } -int cmd_scanstep(const char *arg) +static int cmd_scanstep(const char *arg) { scan_stepSize = atoi(arg); return 0; } -int cmd_scanpos(const char *arg) +static int cmd_scanpos(const char *arg) { int r = sscanf(arg, "%d", &scan_position); if (r == 0) @@ -3187,7 +3534,7 @@ int cmd_scanpos(const char *arg) return 0; } -int cmd_scansize(const char *arg) +static int cmd_scansize(const char *arg) { int r = sscanf(arg, "%d", &scan_size); if (r == 0) @@ -3237,26 +3584,26 @@ static int cmd_scan_common(const char *set, const char *arg) if (*arg) { strcpy(last_scan_query, arg); - if (send_scanrequest(set, arg, - scan_position, scan_size, 0) < 0) + if (send_Z3950_scanrequest(set, arg, + scan_position, scan_size, 0) < 0) return 0; } else { - if (send_scanrequest(set, last_scan_query, - 1, scan_size, last_scan_line) < 0) + if (send_Z3950_scanrequest(set, last_scan_query, + 1, scan_size, last_scan_line) < 0) return 0; } return 2; } } -int cmd_scan(const char *arg) +static int cmd_scan(const char *arg) { return cmd_scan_common(0, arg); } -int cmd_setscan(const char *arg) +static int cmd_setscan(const char *arg) { char setstring[100]; int nor; @@ -3268,7 +3615,7 @@ int cmd_setscan(const char *arg) return cmd_scan_common(setstring, arg + nor); } -int cmd_schema(const char *arg) +static int cmd_schema(const char *arg) { xfree(record_schema); record_schema = 0; @@ -3277,7 +3624,7 @@ int cmd_schema(const char *arg) return 1; } -int cmd_format(const char *arg) +static int cmd_format(const char *arg) { const char *cp = arg; int nor; @@ -3292,7 +3639,7 @@ int cmd_format(const char *arg) while (sscanf(cp, "%40s%n", form_str, &nor) >= 1 && nor > 0 && idx < RECORDSYNTAX_MAX) { - if (strcmp(form_str, "none") && + if (strcmp(form_str, "none") && !yaz_string_to_oid_odr(yaz_oid_std(), CLASS_RECSYN, form_str, out)) { printf("Bad format: %s\n", form_str); @@ -3305,7 +3652,7 @@ int cmd_format(const char *arg) xfree(recordsyntax_list[i]); recordsyntax_list[i] = 0; } - + cp = arg; while (sscanf(cp, "%40s%n", form_str, &nor) >= 1 && nor > 0 && idx < RECORDSYNTAX_MAX) @@ -3320,7 +3667,7 @@ int cmd_format(const char *arg) return 1; } -int cmd_elements(const char *arg) +static int cmd_elements(const char *arg) { static Z_ElementSetNames esn; static char what[100]; @@ -3337,7 +3684,7 @@ int cmd_elements(const char *arg) return 1; } -int cmd_querytype(const char *arg) +static int cmd_querytype(const char *arg) { if (!strcmp(arg, "ccl")) queryType = QueryType_CCL; @@ -3362,7 +3709,7 @@ int cmd_querytype(const char *arg) return 1; } -int cmd_refid(const char *arg) +static int cmd_refid(const char *arg) { xfree(refid); refid = NULL; @@ -3371,7 +3718,7 @@ int cmd_refid(const char *arg) return 1; } -int cmd_close(const char *arg) +static int cmd_close(const char *arg) { Z_APDU *apdu; Z_Close *req; @@ -3395,7 +3742,7 @@ int cmd_packagename(const char* arg) return 1; } -int cmd_proxy(const char* arg) +static int cmd_proxy(const char* arg) { xfree(yazProxy); yazProxy = 0; @@ -3404,7 +3751,7 @@ int cmd_proxy(const char* arg) return 1; } -int cmd_marccharset(const char *arg) +static int cmd_marccharset(const char *arg) { char l1[30]; @@ -3422,7 +3769,7 @@ int cmd_marccharset(const char *arg) return 1; } -int cmd_querycharset(const char *arg) +static int cmd_querycharset(const char *arg) { char l1[30]; @@ -3440,7 +3787,7 @@ int cmd_querycharset(const char *arg) return 1; } -int cmd_displaycharset(const char *arg) +static int cmd_displaycharset(const char *arg) { char l1[30]; @@ -3470,7 +3817,7 @@ int cmd_displaycharset(const char *arg) return 1; } -int cmd_negcharset(const char *arg) +static int cmd_negcharset(const char *arg) { char l1[30]; @@ -3500,7 +3847,7 @@ int cmd_negcharset(const char *arg) return 1; } -int cmd_charset(const char* arg) +static int cmd_charset(const char* arg) { char l1[30], l2[30], l3[30], l4[30]; @@ -3525,9 +3872,10 @@ int cmd_charset(const char* arg) return 1; } -int cmd_lang(const char* arg) +static int cmd_lang(const char* arg) { - if (*arg == '\0') { + if (*arg == '\0') + { printf("Current language is `%s'\n", yazLang ? yazLang : "none"); return 1; } @@ -3538,7 +3886,7 @@ int cmd_lang(const char* arg) return 1; } -int cmd_source(const char* arg, int echo ) +static int cmd_source(const char* arg, int echo ) { /* first should open the file and read one line at a time.. */ FILE* includeFile; @@ -3558,7 +3906,7 @@ int cmd_source(const char* arg, int echo ) return -1; } - while (fgets(line, sizeof(line), includeFile)) + while (fgets(line, sizeof(line), includeFile)) { if (strlen(line) < 2) continue; @@ -3581,20 +3929,13 @@ int cmd_source(const char* arg, int echo ) return 1; } -int cmd_source_echo(const char* arg) +static int cmd_source_echo(const char* arg) { cmd_source(arg, 1); return 1; } -int cmd_source_noecho(const char* arg) -{ - cmd_source(arg, 0); - return 1; -} - - -int cmd_subshell(const char* args) +static int cmd_subshell(const char* args) { int ret = system(strlen(args) ? args : getenv("SHELL")); printf("\n"); @@ -3605,7 +3946,7 @@ int cmd_subshell(const char* args) return 1; } -int cmd_set_berfile(const char *arg) +static int cmd_set_berfile(const char *arg) { if (ber_file && ber_file != stdout && ber_file != stderr) fclose(ber_file); @@ -3618,9 +3959,9 @@ int cmd_set_berfile(const char *arg) return 1; } -int cmd_set_apdufile(const char *arg) +static int cmd_set_apdufile(const char *arg) { - if(apdu_file && apdu_file != stderr && apdu_file != stderr) + if (apdu_file && apdu_file != stderr && apdu_file != stderr) fclose(apdu_file); if (!strcmp(arg, "")) apdu_file = 0; @@ -3637,7 +3978,7 @@ int cmd_set_apdufile(const char *arg) return 1; } -int cmd_set_cclfile(const char* arg) +static int cmd_set_cclfile(const char* arg) { FILE *inf; @@ -3654,11 +3995,12 @@ int cmd_set_cclfile(const char* arg) return 0; } -int cmd_set_cqlfile(const char* arg) +static int cmd_set_cqlfile(const char* arg) { cql_transform_t newcqltrans; - if ((newcqltrans = cql_transform_open_fname(arg)) == 0) { + if ((newcqltrans = cql_transform_open_fname(arg)) == 0) + { perror("unable to open CQL file"); return 0; } @@ -3670,19 +4012,20 @@ int cmd_set_cqlfile(const char* arg) return 0; } -int cmd_set_auto_reconnect(const char* arg) +static int cmd_set_auto_reconnect(const char* arg) { - if(strlen(arg)==0) { + if (strlen(arg)==0) auto_reconnect = ! auto_reconnect; - } else if(strcmp(arg,"on")==0) { + else if (strcmp(arg,"on")==0) auto_reconnect = 1; - } else if(strcmp(arg,"off")==0) { + else if (strcmp(arg,"off")==0) auto_reconnect = 0; - } else { + else + { printf("Error use on or off\n"); return 1; } - + if (auto_reconnect) printf("Set auto reconnect enabled.\n"); else @@ -3691,16 +4034,16 @@ int cmd_set_auto_reconnect(const char* arg) return 0; } - -int cmd_set_auto_wait(const char* arg) +static int cmd_set_auto_wait(const char* arg) { - if(strlen(arg)==0) { + if (strlen(arg)==0) auto_wait = ! auto_wait; - } else if(strcmp(arg,"on")==0) { + else if (strcmp(arg,"on")==0) auto_wait = 1; - } else if(strcmp(arg,"off")==0) { + else if (strcmp(arg,"off")==0) auto_wait = 0; - } else { + else + { printf("Error use on or off\n"); return 1; } @@ -3713,9 +4056,10 @@ int cmd_set_auto_wait(const char* arg) return 0; } -int cmd_set_marcdump(const char* arg) +static int cmd_set_marcdump(const char* arg) { - if(marc_file && marc_file != stderr) { /* don't close stdout*/ + if (marc_file && marc_file != stderr) + { /* don't close stdout*/ fclose(marc_file); } @@ -3745,7 +4089,8 @@ static void marc_file_write(const char *buf, size_t sz) /* this command takes 3 arge {name class oid} */ -int cmd_register_oid(const char* args) { +static int cmd_register_oid(const char* args) +{ static struct { char* className; oid_class oclass; @@ -3773,12 +4118,14 @@ int cmd_register_oid(const char* args) { Odr_oid oid[OID_SIZE]; if (sscanf(args, "%100[^ ] %100[^ ] %100s", - oname_str,oclass_str, oid_str) < 1) { + oname_str,oclass_str, oid_str) < 1) + { printf("Error in register command \n"); return 0; } - for (i = 0; oid_classes[i].className; i++) { + for (i = 0; oid_classes[i].className; i++) + { if (!strcmp(oid_classes[i].className, oclass_str)) { oidclass=oid_classes[i].oclass; @@ -3786,7 +4133,8 @@ int cmd_register_oid(const char* args) { } } - if(!(oid_classes[i].className)) { + if (!(oid_classes[i].className)) + { printf("Unknown oid class %s\n",oclass_str); return 0; } @@ -3801,10 +4149,10 @@ int cmd_register_oid(const char* args) { return 1; } -int cmd_push_command(const char* arg) +static int cmd_push_command(const char* arg) { #if HAVE_READLINE_HISTORY_H - if(strlen(arg)>1) + if (strlen(arg) > 1) add_history(arg); #else fprintf(stderr,"Not compiled with the readline/history module\n"); @@ -3850,7 +4198,7 @@ void source_rc_file(const char *rc_file) } } -void add_to_readline_history(void *client_data, const char *line) +static void add_to_readline_history(void *client_data, const char *line) { #if HAVE_READLINE_HISTORY_H if (strlen(line)) @@ -3870,7 +4218,7 @@ static void initialize(const char *rc_file) fprintf(stderr, "failed to allocate ODR streams\n"); exit(1); } - + setvbuf(stdout, 0, _IONBF, 0); if (apdu_file) odr_setprint(print, apdu_file); @@ -3890,16 +4238,18 @@ static void initialize(const char *rc_file) rl_attempted_completion_function = (char **(*)(const char *, int, int)) readline_completer; #endif - for(i = 0; i < maxOtherInfosSupported; ++i) { + for (i = 0; i < maxOtherInfosSupported; ++i) + { extraOtherInfos[i].oid[0] = -1; extraOtherInfos[i].value = 0; } cmd_format("usmarc"); + file_history = file_history_new(); + source_rc_file(rc_file); - file_history = file_history_new(); file_history_load(file_history); file_history_trav(file_history, 0, add_to_readline_history); } @@ -4006,66 +4356,81 @@ static void http_response(Z_HTTP_Response *hres) int ret = -1; const char *connection_head = z_HTTP_header_lookup(hres->headers, "Connection"); + if (hres->code != 200) + { + printf("HTTP Error Status=%d\n", hres->code); + } + if (!yaz_srw_check_content_type(hres)) printf("Content type does not appear to be XML\n"); else { - Z_SOAP *soap_package = 0; - ODR o = odr_createmem(ODR_DECODE); - Z_SOAP_Handler soap_handlers[3] = { - {YAZ_XMLNS_SRU_v1_1, 0, (Z_SOAP_fun) yaz_srw_codec}, - {YAZ_XMLNS_UPDATE_v0_9, 0, (Z_SOAP_fun) yaz_ucp_codec}, - {0, 0, 0} - }; - ret = z_soap_codec(o, &soap_package, - &hres->content_buf, &hres->content_len, - soap_handlers); - if (!ret && soap_package->which == Z_SOAP_generic) + if (!yaz_matchstr(sru_method, "solr")) { - Z_SRW_PDU *sr = (Z_SRW_PDU *) soap_package->u.generic->p; - if (sr->which == Z_SRW_searchRetrieve_response) + Z_SRW_PDU *sr = 0; + ODR o = odr_createmem(ODR_DECODE); + ret = yaz_solr_decode(o, hres, &sr); + + if (ret == 0 && sr->which == Z_SRW_searchRetrieve_response) handle_srw_response(sr->u.response); - else if (sr->which == Z_SRW_explain_response) - handle_srw_explain_response(sr->u.explain_response); - else if (sr->which == Z_SRW_scan_response) - handle_srw_scan_response(sr->u.scan_response); - else if (sr->which == Z_SRW_update_response) - printf("Got update response. Status: %s\n", - sr->u.update_response->operationStatus); else + { + printf("Decoding of SOLR package failed\n"); ret = -1; - } - else if (soap_package && (soap_package->which == Z_SOAP_fault - || soap_package->which == Z_SOAP_error)) - { - printf("HTTP Error Status=%d\n", hres->code); - printf("SOAP Fault code %s\n", - soap_package->u.fault->fault_code); - printf("SOAP Fault string %s\n", - soap_package->u.fault->fault_string); - if (soap_package->u.fault->details) - printf("SOAP Details %s\n", - soap_package->u.fault->details); + } + odr_destroy(o); } else { - printf("z_soap_codec failed. (no SOAP error)\n"); - ret = -1; + Z_SOAP *soap_package = 0; + ODR o = odr_createmem(ODR_DECODE); + Z_SOAP_Handler soap_handlers[3] = { + {YAZ_XMLNS_SRU_v1_1, 0, (Z_SOAP_fun) yaz_srw_codec}, + {YAZ_XMLNS_UPDATE_v0_9, 0, (Z_SOAP_fun) yaz_ucp_codec}, + {0, 0, 0} + }; + ret = z_soap_codec(o, &soap_package, + &hres->content_buf, &hres->content_len, + soap_handlers); + if (!ret && soap_package->which == Z_SOAP_generic) + { + Z_SRW_PDU *sr = (Z_SRW_PDU *) soap_package->u.generic->p; + if (sr->which == Z_SRW_searchRetrieve_response) + handle_srw_response(sr->u.response); + else if (sr->which == Z_SRW_explain_response) + handle_srw_explain_response(sr->u.explain_response); + else if (sr->which == Z_SRW_scan_response) + handle_srw_scan_response(sr->u.scan_response); + else if (sr->which == Z_SRW_update_response) + printf("Got update response. Status: %s\n", + sr->u.update_response->operationStatus); + else + { + printf("Decoding of SRW package failed\n"); + ret = -1; + } + } + else if (soap_package && (soap_package->which == Z_SOAP_fault + || soap_package->which == Z_SOAP_error)) + { + printf("SOAP Fault code %s\n", + soap_package->u.fault->fault_code); + printf("SOAP Fault string %s\n", + soap_package->u.fault->fault_string); + if (soap_package->u.fault->details) + printf("SOAP Details %s\n", + soap_package->u.fault->details); + } + else + { + printf("z_soap_codec failed. (no SOAP error)\n"); + ret = -1; + } + odr_destroy(o); } - odr_destroy(o); } if (ret) - { - if (hres->code != 200) - { - printf("HTTP Error Status=%d\n", hres->code); - } - else - { - printf("Decoding of SRW package failed\n"); - } - close_session(); - } + close_session(); /* close session on error */ else { if (!strcmp(hres->version, "1.0")) @@ -4084,9 +4449,12 @@ static void http_response(Z_HTTP_Response *hres) } #endif +#define max_HTTP_redirects 2 + static void wait_and_handle_response(int one_response_only) { int reconnect_ok = 1; + int no_redirects = 0; int res; char *netbuffer= 0; int netbufferlen = 0; @@ -4165,16 +4533,16 @@ static void wait_and_handle_response(int one_response_only) if (gdu->which == Z_GDU_Z3950) { Z_APDU *apdu = gdu->u.z3950; - switch(apdu->which) + switch (apdu->which) { case Z_APDU_initResponse: - process_initResponse(apdu->u.initResponse); + process_Z3950_initResponse(apdu->u.initResponse); break; case Z_APDU_searchResponse: - process_searchResponse(apdu->u.searchResponse); + process_Z3950_searchResponse(apdu->u.searchResponse); break; case Z_APDU_scanResponse: - process_scanResponse(apdu->u.scanResponse); + process_Z3950_scanResponse(apdu->u.scanResponse); break; case Z_APDU_presentResponse: print_refid(apdu->u.presentResponse->referenceId); @@ -4188,23 +4556,23 @@ static void wait_and_handle_response(int one_response_only) *apdu->u.presentResponse->nextResultSetPosition); break; case Z_APDU_sortResponse: - process_sortResponse(apdu->u.sortResponse); + process_Z3950_sortResponse(apdu->u.sortResponse); break; case Z_APDU_extendedServicesResponse: printf("Got extended services response\n"); - process_ESResponse(apdu->u.extendedServicesResponse); + process_Z3950_ESResponse(apdu->u.extendedServicesResponse); break; case Z_APDU_close: printf("Target has closed the association.\n"); - process_close(apdu->u.close); + process_Z3950_close(apdu->u.close); break; case Z_APDU_resourceControlRequest: - process_resourceControlRequest - (apdu->u.resourceControlRequest); + process_Z3950_resourceControlRequest( + apdu->u.resourceControlRequest); break; case Z_APDU_deleteResultSetResponse: - process_deleteResultSetResponse(apdu->u. - deleteResultSetResponse); + process_Z3950_deleteResultSetResponse( + apdu->u.deleteResultSetResponse); break; default: printf("Received unknown APDU type (%d).\n", @@ -4215,7 +4583,26 @@ static void wait_and_handle_response(int one_response_only) #if YAZ_HAVE_XML2 else if (gdu->which == Z_GDU_HTTP_Response) { - http_response(gdu->u.HTTP_Response); + Z_HTTP_Response *hres = gdu->u.HTTP_Response; + int code = hres->code; + const char *location = 0; + if ((code == 301 || code == 302) + && no_redirects < max_HTTP_redirects + && !yaz_matchstr(sru_method, "get") + && (location = z_HTTP_header_lookup(hres->headers, "Location"))) + { + const char *base_tmp; + session_connect_base(location, &base_tmp); + no_redirects++; + if (conn) + { + if (send_SRW_redirect(location, hres) == 2) + continue; + } + printf("Redirect failed\n"); + } + else + http_response(gdu->u.HTTP_Response); } #endif if (one_response_only) @@ -4241,8 +4628,7 @@ static void wait_and_handle_response(int one_response_only) xfree(netbuffer); } - -int cmd_cclparse(const char* arg) +static int cmd_cclparse(const char* arg) { int error, pos; struct ccl_rpn_node *rpn=NULL; @@ -4250,7 +4636,8 @@ int cmd_cclparse(const char* arg) rpn = ccl_find_str(bibset, arg, &error, &pos); - if (error) { + if (error) + { int ioff = 3+strlen(last_cmd)+1+pos; printf("%*s^ - ", ioff, " "); printf("%s\n", ccl_err_msg(error)); @@ -4270,8 +4657,7 @@ int cmd_cclparse(const char* arg) return 0; } - -int cmd_set_otherinfo(const char* args) +static int cmd_set_otherinfo(const char* args) { char oidstr[101], otherinfoString[101]; int otherinfoNo; @@ -4280,7 +4666,8 @@ int cmd_set_otherinfo(const char* args) sscan_res = sscanf(args, "%d %100[^ ] %100s", &otherinfoNo, oidstr, otherinfoString); - if (sscan_res > 0 && otherinfoNo >= maxOtherInfosSupported) { + if (sscan_res > 0 && otherinfoNo >= maxOtherInfosSupported) + { printf("Error otherinfo index too large (%d>=%d)\n", otherinfoNo,maxOtherInfosSupported); return 0; @@ -4295,7 +4682,8 @@ int cmd_set_otherinfo(const char* args) extraOtherInfos[otherinfoNo].value = 0; return 0; } - if (sscan_res != 3) { + if (sscan_res != 3) + { printf("Error in set_otherinfo command \n"); return 0; } @@ -4316,10 +4704,11 @@ int cmd_set_otherinfo(const char* args) return 0; } -int cmd_sleep(const char* args ) +static int cmd_sleep(const char* args ) { - int sec=atoi(args); - if( sec > 0 ) { + int sec = atoi(args); + if (sec > 0) + { #ifdef WIN32 Sleep(sec*1000); #else @@ -4330,7 +4719,7 @@ int cmd_sleep(const char* args ) return 1; } -int cmd_list_otherinfo(const char* args) +static int cmd_list_otherinfo(const char* args) { int i; @@ -4357,7 +4746,7 @@ int cmd_list_otherinfo(const char* args) } else { - for(i = 0; i < maxOtherInfosSupported; ++i) + for (i = 0; i < maxOtherInfosSupported; ++i) { if (extraOtherInfos[i].value) { @@ -4375,8 +4764,8 @@ int cmd_list_otherinfo(const char* args) return 0; } - -int cmd_list_all(const char* args) { +static int cmd_list_all(const char* args) +{ int i; /* connection options */ @@ -4391,10 +4780,12 @@ int cmd_list_all(const char* args) { printf("auto_reconnect : %s\n",auto_reconnect?"on":"off"); printf("auto_wait : %s\n",auto_wait?"on":"off"); - if (!auth) { + if (!auth) printf("Authentication : none\n"); - } else { - switch(auth->which) { + else + { + switch (auth->which) + { case Z_IdAuthentication_idPass: printf("Authentication : IdPass\n"); printf(" Login User : %s\n",auth->u.idPass->userId?auth->u.idPass->userId:""); @@ -4446,11 +4837,13 @@ int cmd_list_all(const char* args) { return 0; } -int cmd_clear_otherinfo(const char* args) +static int cmd_clear_otherinfo(const char* args) { - if(strlen(args)>0) { + if (strlen(args) > 0) + { int otherinfoNo = atoi(args); - if (otherinfoNo >= maxOtherInfosSupported) { + if (otherinfoNo >= maxOtherInfosSupported) + { printf("Error otherinfo index too large (%d>=%d)\n", otherinfoNo, maxOtherInfosSupported); return 0; @@ -4462,9 +4855,11 @@ int cmd_clear_otherinfo(const char* args) xfree(extraOtherInfos[otherinfoNo].value); extraOtherInfos[otherinfoNo].value = 0; } - } else { + } + else + { int i; - for(i = 0; i < maxOtherInfosSupported; ++i) + for (i = 0; i < maxOtherInfosSupported; ++i) { if (extraOtherInfos[i].value) { @@ -4477,17 +4872,15 @@ int cmd_clear_otherinfo(const char* args) return 0; } -int cmd_wait_response(const char *arg) +static int cmd_wait_response(const char *arg) { + int i; int wait_for = atoi(arg); - int i=0; - if( wait_for < 1 ) { + if (wait_for < 1) wait_for = 1; - }; - for( i=0 ; i < wait_for ; ++i ) { + for (i = 0 ; i < wait_for; ++i ) wait_and_handle_response(1); - }; return 0; } @@ -4506,6 +4899,7 @@ static struct { {"open", cmd_open, "('tcp'|'ssl')':[':'][/]",NULL,0,NULL}, {"quit", cmd_quit, "",NULL,0,NULL}, {"find", cmd_find, "",NULL,0,NULL}, + {"facets", cmd_facets, "",NULL,0,NULL}, {"delete", cmd_delete, "",NULL,0,NULL}, {"base", cmd_base, "",NULL,0,NULL}, {"show", cmd_show, "['+'<#recs>['+']]",NULL,0,NULL}, @@ -4578,6 +4972,7 @@ static struct { {"help", cmd_help, "", NULL,0,NULL}, {"init", cmd_init, "", NULL,0,NULL}, {"sru", cmd_sru, " ", NULL,0,NULL}, + {"url", cmd_url, "", NULL,0,NULL}, {"exit", cmd_quit, "",NULL,0,NULL}, {0,0,0,0,0,0} }; @@ -4641,7 +5036,7 @@ static int cmd_help(const char *line) return 1; } -int cmd_register_tab(const char* arg) +static int cmd_register_tab(const char* arg) { #if HAVE_READLINE_READLINE_H char command[101], tabargument[101]; @@ -4649,18 +5044,20 @@ int cmd_register_tab(const char* arg) int num_of_tabs; const char** tabslist; - if (sscanf(arg, "%100s %100s", command, tabargument) < 1) { + if (sscanf(arg, "%100s %100s", command, tabargument) < 1) + { return 0; } /* locate the amdn in the list */ - for (i = 0; cmd_array[i].cmd; i++) { - if (!strncmp(cmd_array[i].cmd, command, strlen(command))) { + for (i = 0; cmd_array[i].cmd; i++) + { + if (!strncmp(cmd_array[i].cmd, command, strlen(command))) break; - } } - if (!cmd_array[i].cmd) { + if (!cmd_array[i].cmd) + { fprintf(stderr,"Unknown command %s\n",command); return 1; } @@ -4672,9 +5069,8 @@ int cmd_register_tab(const char* arg) num_of_tabs=0; tabslist = cmd_array[i].local_tabcompletes; - for(; tabslist && *tabslist; tabslist++) { + for (; tabslist && *tabslist; tabslist++) num_of_tabs++; - } cmd_array[i].local_tabcompletes = (const char **) realloc(cmd_array[i].local_tabcompletes, @@ -4686,8 +5082,7 @@ int cmd_register_tab(const char* arg) return 1; } - -void process_cmd_line(char* line) +static void process_cmd_line(char* line) { int i, res; char word[32], arg[10240]; @@ -4710,12 +5105,12 @@ void process_cmd_line(char* line) char* p = arg; char* lastnonspace=NULL; - for(;*p; ++p) { - if(!isspace(*(unsigned char *) p)) { + for (; *p; ++p) + { + if (!isspace(*(unsigned char *) p)) lastnonspace = p; - } } - if(lastnonspace) + if (lastnonspace) *(++lastnonspace) = 0; } @@ -4733,14 +5128,15 @@ void process_cmd_line(char* line) res = 1; } - if(apdu_file) fflush(apdu_file); + if (apdu_file) + fflush(apdu_file); if (res >= 2 && auto_wait) wait_and_handle_response(0); - if(apdu_file) + if (apdu_file) fflush(apdu_file); - if(marc_file) + if (marc_file) fflush(marc_file); } @@ -4748,11 +5144,12 @@ static char *command_generator(const char *text, int state) { #if HAVE_READLINE_READLINE_H static int idx; - if (state==0) { + if (state == 0) idx = 0; - } - for( ; cmd_array[idx].cmd; ++idx) { - if (!strncmp(cmd_array[idx].cmd, text, strlen(text))) { + for (; cmd_array[idx].cmd; ++idx) + { + if (!strncmp(cmd_array[idx].cmd, text, strlen(text))) + { ++idx; /* skip this entry on the next run */ return strdup(cmd_array[idx-1].cmd); } @@ -4775,11 +5172,12 @@ static char* default_completer(const char* text, int state) /* This function only known how to complete on the first word */ -char **readline_completer(char *text, int start, int end) +static char **readline_completer(char *text, int start, int end) { completerFunctionType completerToUse; - if(start == 0) { + if (start == 0) + { #if HAVE_READLINE_RL_COMPLETION_MATCHES char** res = rl_completion_matches(text, command_generator); #else @@ -4788,10 +5186,13 @@ char **readline_completer(char *text, int start, int end) #endif rl_attempted_completion_over = 1; return res; - } else { + } + else + { char arg[10240],word[32]; - int i=0 ,res; - if ((res = sscanf(rl_line_buffer, "%31s %10239[^;]", word, arg)) <= 0) { + int i ,res; + if ((res = sscanf(rl_line_buffer, "%31s %10239[^;]", word, arg)) <= 0) + { rl_attempted_completion_over = 1; return NULL; } @@ -4800,7 +5201,7 @@ char **readline_completer(char *text, int start, int end) if (!strncmp(cmd_array[i].cmd, word, strlen(word))) break; - if(!cmd_array[i].cmd) + if (!cmd_array[i].cmd) return NULL; default_completer_list = cmd_array[i].local_tabcompletes; @@ -4810,7 +5211,8 @@ char **readline_completer(char *text, int start, int end) { /* if command completer is not defined use the default completer */ completerToUse = default_completer; } - if (completerToUse) { + if (completerToUse) + { #ifdef HAVE_READLINE_RL_COMPLETION_MATCHES char** res= rl_completion_matches(text, completerToUse); @@ -4821,7 +5223,9 @@ char **readline_completer(char *text, int start, int end) if (!cmd_array[i].complete_filenames) rl_attempted_completion_over = 1; return res; - } else { + } + else + { if (!cmd_array[i].complete_filenames) rl_attempted_completion_over = 1; return 0; @@ -4831,7 +5235,7 @@ char **readline_completer(char *text, int start, int end) #endif #ifndef WIN32 -void ctrl_c_handler(int x) +static void ctrl_c_handler(int x) { exit_client(0); } @@ -4859,7 +5263,10 @@ static void client(void) { line_in=readline(C_PROMPT); if (!line_in) + { + putchar('\n'); break; + } #if HAVE_READLINE_HISTORY_H if (*line_in) add_history(line_in);