projects
/
yaz-moved-to-github.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Use pthread_atfork to lock/unlock yaz_log system
[yaz-moved-to-github.git]
/
src
/
log.c
diff --git
a/src/log.c
b/src/log.c
index
28ffba5
..
38ecac7
100644
(file)
--- a/
src/log.c
+++ b/
src/log.c
@@
-1,5
+1,5
@@
/* This file is part of the YAZ toolkit.
/* This file is part of the YAZ toolkit.
- * Copyright (C) 1995-2011 Index Data
+ * Copyright (C) Index Data
* See the file LICENSE for details.
*/
* See the file LICENSE for details.
*/
@@
-30,8
+30,12
@@
#include <yaz/errno.h>
#include <yaz/thread_id.h>
#include <yaz/log.h>
#include <yaz/errno.h>
#include <yaz/thread_id.h>
#include <yaz/log.h>
+#include <yaz/mutex.h>
#include <yaz/snprintf.h>
#include <yaz/xmalloc.h>
#include <yaz/snprintf.h>
#include <yaz/xmalloc.h>
+#if YAZ_POSIX_THREADS
+#include <pthread.h>
+#endif
static int l_level = YLOG_DEFAULT_LEVEL;
static int l_level = YLOG_DEFAULT_LEVEL;
@@
-87,18
+91,30
@@
static struct {
{ YLOG_TID, "tid" },
{ YLOG_APP, "app" },
{ YLOG_NOTIME, "notime" },
{ YLOG_TID, "tid" },
{ YLOG_APP, "app" },
{ YLOG_NOTIME, "notime" },
- { YLOG_APP2, "app2" },
+ { YLOG_APP2, "app2" },
{ YLOG_APP3, "app3" },
{ YLOG_ALL, "all" },
{ YLOG_FLUSH, "flush" },
{ YLOG_APP3, "app3" },
{ YLOG_ALL, "all" },
{ YLOG_FLUSH, "flush" },
- { YLOG_LOGLVL, "loglevel" },
+ { YLOG_LOGLVL, "loglevel" },
{ 0, "none" },
{ 0, NULL }
/* the rest will be filled in if the user defines dynamic modules*/
{ 0, "none" },
{ 0, NULL }
/* the rest will be filled in if the user defines dynamic modules*/
-};
+};
static unsigned int next_log_bit = YLOG_LAST_BIT<<1; /* first dynamic bit */
static unsigned int next_log_bit = YLOG_LAST_BIT<<1; /* first dynamic bit */
+static YAZ_MUTEX log_mutex = 0;
+
+static void yaz_log_lock(void)
+{
+ yaz_mutex_enter(log_mutex);
+}
+
+static void yaz_log_unlock(void)
+{
+ yaz_mutex_leave(log_mutex);
+}
+
static void internal_log_init(void)
{
static int mutex_init_flag = 0; /* not yet initialized */
static void internal_log_init(void)
{
static int mutex_init_flag = 0; /* not yet initialized */
@@
-108,6
+124,11
@@
static void internal_log_init(void)
return;
mutex_init_flag = 1; /* here, 'cause nmem_mutex_create may call yaz_log */
return;
mutex_init_flag = 1; /* here, 'cause nmem_mutex_create may call yaz_log */
+ if (log_mutex == 0)
+ yaz_mutex_create(&log_mutex);
+#if YAZ_POSIX_THREADS
+ pthread_atfork(yaz_log_lock, yaz_log_unlock, yaz_log_unlock);
+#endif
env = getenv("YAZ_LOG");
if (env)
l_level = yaz_log_mask_str_x(env, l_level);
env = getenv("YAZ_LOG");
if (env)
l_level = yaz_log_mask_str_x(env, l_level);
@@
-152,7
+173,7
@@
void yaz_log_init_file(const char *fname)
else
{
yaz_log_info.type = use_none; /* NULL name; use no file at all */
else
{
yaz_log_info.type = use_none; /* NULL name; use no file at all */
- yaz_log_info.l_fname[0] = '\0';
+ yaz_log_info.l_fname[0] = '\0';
}
yaz_log_reopen();
}
}
yaz_log_reopen();
}
@@
-202,7
+223,7
@@
void yaz_log_init_level(int level)
{
l_level = level;
yaz_log_reopen(); /* make sure we set buffering right */
{
l_level = level;
yaz_log_reopen(); /* make sure we set buffering right */
- }
+ }
else
l_level = level;
else
l_level = level;
@@
-342,12
+363,14
@@
static void yaz_log_do_reopen(const char *filemode)
struct tm *tm;
#endif
struct tm *tm;
#endif
+ yaz_log_lock();
#if HAVE_LOCALTIME_R
localtime_r(&cur_time, tm);
#else
tm = localtime(&cur_time);
#endif
yaz_log_open_check(tm, 1, filemode);
#if HAVE_LOCALTIME_R
localtime_r(&cur_time, tm);
#else
tm = localtime(&cur_time);
#endif
yaz_log_open_check(tm, 1, filemode);
+ yaz_log_unlock();
}
}
@@
-366,7
+389,7
@@
static void yaz_strftime(char *dst, size_t sz,
{
strftime(dst, sz, fmt, tm);
}
{
strftime(dst, sz, fmt, tm);
}
-
+
static void yaz_log_to_file(int level, const char *log_message)
{
FILE *file;
static void yaz_log_to_file(int level, const char *log_message)
{
FILE *file;
@@
-379,13
+402,14
@@
static void yaz_log_to_file(int level, const char *log_message)
internal_log_init();
internal_log_init();
+ yaz_log_lock();
#if HAVE_LOCALTIME_R
localtime_r(&ti, tm);
#else
tm = localtime(&ti);
#endif
#if HAVE_LOCALTIME_R
localtime_r(&ti, tm);
#else
tm = localtime(&ti);
#endif
-
- yaz_log_open_check(tm, 0, "a");
+
+ yaz_log_open_check(tm, 0, "a");
file = yaz_log_file(); /* file may change in yaz_log_open_check */
if (file)
file = yaz_log_file(); /* file may change in yaz_log_open_check */
if (file)
@@
-394,15
+418,15
@@
static void yaz_log_to_file(int level, const char *log_message)
char tid[TID_LEN];
char flags[1024];
int i;
char tid[TID_LEN];
char flags[1024];
int i;
-
+
*flags = '\0';
for (i = 0; level && mask_names[i].name; i++)
if ( mask_names[i].mask & level)
{
*flags = '\0';
for (i = 0; level && mask_names[i].name; i++)
if ( mask_names[i].mask & level)
{
- if (*mask_names[i].name && mask_names[i].mask &&
+ if (*mask_names[i].name && mask_names[i].mask &&
mask_names[i].mask != YLOG_ALL)
{
mask_names[i].mask != YLOG_ALL)
{
- if (strlen(flags) + strlen(mask_names[i].name)
+ if (strlen(flags) + strlen(mask_names[i].name)
< sizeof(flags) - 4)
{
strcat(flags, "[");
< sizeof(flags) - 4)
{
strcat(flags, "[");
@@
-412,7
+436,7
@@
static void yaz_log_to_file(int level, const char *log_message)
level &= ~mask_names[i].mask;
}
}
level &= ~mask_names[i].mask;
}
}
-
+
tbuf[0] = '\0';
if (!(l_level & YLOG_NOTIME))
{
tbuf[0] = '\0';
if (!(l_level & YLOG_NOTIME))
{
@@
-436,6
+460,7
@@
static void yaz_log_to_file(int level, const char *log_message)
if (l_level & YLOG_FLUSH)
fflush(file);
}
if (l_level & YLOG_FLUSH)
fflush(file);
}
+ yaz_log_unlock();
}
void yaz_log(int level, const char *fmt, ...)
}
void yaz_log(int level, const char *fmt, ...)
@@
-479,15
+504,15
@@
void yaz_log(int level, const char *fmt, ...)
void yaz_log_time_format(const char *fmt)
{
void yaz_log_time_format(const char *fmt)
{
- if ( !fmt || !*fmt)
+ if ( !fmt || !*fmt)
{ /* no format, default to new */
l_actual_format = l_new_default_format;
{ /* no format, default to new */
l_actual_format = l_new_default_format;
- return;
+ return;
}
if (0==strcmp(fmt, "old"))
{ /* force the old format */
l_actual_format = l_old_default_format;
}
if (0==strcmp(fmt, "old"))
{ /* force the old format */
l_actual_format = l_old_default_format;
- return;
+ return;
}
/* else use custom format */
strncpy(l_custom_format, fmt, TIMEFORMAT_LEN-1);
}
/* else use custom format */
strncpy(l_custom_format, fmt, TIMEFORMAT_LEN-1);
@@
-501,7
+526,7
@@
static char *clean_name(const char *name, size_t len, char *namebuf, size_t bufl
char *p = namebuf;
char *start = namebuf;
if (buflen <= len)
char *p = namebuf;
char *start = namebuf;
if (buflen <= len)
- len = buflen-1;
+ len = buflen-1;
strncpy(namebuf, name, len);
namebuf[len] = '\0';
while ((p = strchr(start, '/')))
strncpy(namebuf, name, len);
namebuf[len] = '\0';
while ((p = strchr(start, '/')))
@@
-540,16
+565,16
@@
int yaz_log_module_level(const char *name)
char clean[255];
char *n = clean_name(name, strlen(name), clean, sizeof(clean));
internal_log_init();
char clean[255];
char *n = clean_name(name, strlen(name), clean, sizeof(clean));
internal_log_init();
-
+
for (i = 0; mask_names[i].name; i++)
if (0==strcmp(n, mask_names[i].name))
{
yaz_log(YLOG_LOGLVL, "returning log bit 0x%x for '%s' %s",
for (i = 0; mask_names[i].name; i++)
if (0==strcmp(n, mask_names[i].name))
{
yaz_log(YLOG_LOGLVL, "returning log bit 0x%x for '%s' %s",
- mask_names[i].mask, n,
+ mask_names[i].mask, n,
strcmp(n,name) ? name : "");
return mask_names[i].mask;
}
strcmp(n,name) ? name : "");
return mask_names[i].mask;
}
- yaz_log(YLOG_LOGLVL, "returning NO log bit for '%s' %s", n,
+ yaz_log(YLOG_LOGLVL, "returning NO log bit for '%s' %s", n,
strcmp(n, name) ? name : "" );
return 0;
}
strcmp(n, name) ? name : "" );
return 0;
}
@@
-579,7
+604,7
@@
int yaz_log_mask_str_x(const char *str, int level)
{
level = atoi(str);
}
{
level = atoi(str);
}
- else
+ else
{
char clean[509];
char *n = clean_name(str, (size_t) (p - str), clean, sizeof(clean));
{
char clean[509];
char *n = clean_name(str, (size_t) (p - str), clean, sizeof(clean));