Fix null ptr reference for freeReplyObject YAZ-773

[yaz-moved-to-github.git] / src / dumpber.c

diff --git a/src/dumpber.c b/src/dumpber.c
index e90ad27..a6901e7 100644 (file)
--- a/src/dumpber.c
+++ b/src/dumpber.c
@@ -1,5 +1,5 @@
 /* This file is part of the YAZ toolkit.
- * Copyright (C) 1995-2010 Index Data
+ * Copyright (C) Index Data
  * See the file LICENSE for details.
  */
 
@@ -18,20 +18,26 @@
 static int do_dumpBER(FILE *f, const char *buf, int len, int level, int offset)
 {
     int res, ll, zclass, tag, cons, lenlen, taglen;
-    const char *b = buf, *bp = buf;
-    
+    const char *b = buf;
+    char level_str[80];
+
+    if (level >= 15)
+        sprintf(level_str, "level=%-6d%*s", level, 18, "");
+    else
+        sprintf(level_str, "%*s", level * 2, "");
+
     if (!len)
         return 0;
     if (!buf[0] && !buf[1])
         return 0;
-    if ((res = ber_dectag((unsigned char*)b, &zclass, &tag, &cons, len)) <= 0)
+    if ((res = ber_dectag(b, &zclass, &tag, &cons, len)) <= 0)
         return 0;
     if (res > len)
     {
-        fprintf(stderr, "Unexpected end of buffer\n");
+        fprintf(f, "%5d: %s : Unexpected end of buffer\n", offset, level_str);
         return 0;
     }
-    fprintf(f, "%5d: %*s", offset, level * 4, "");
+    fprintf(f, "%5d: %s", offset, level_str);
     if (zclass == ODR_UNIVERSAL)
     {
         static char *nl[] =
@@ -56,10 +62,9 @@ static int do_dumpBER(FILE *f, const char *buf, int len, int level, int offset)
     b += res;
     taglen = res;
     len -= res;
-    bp = b;
-    if ((res = ber_declen((unsigned char*)b, &ll, len)) <= 0)
+    if ((res = ber_declen(b, &ll, len)) <= 0)
     {
-        fprintf(f, "\n%*sBad length\n", level*4+5, "");
+        fprintf(f, "\n%sBad length\n", level_str);
         return 0;
     }
     lenlen = res;
@@ -69,13 +74,13 @@ static int do_dumpBER(FILE *f, const char *buf, int len, int level, int offset)
         fprintf(f, " len=%d", ll);
     else
         fprintf(f, " len=?");
-    fprintf(f, "       tl=%d, ll=%d cons=%d\n", taglen, lenlen, cons);
+    fprintf(f, " tl=%d, ll=%d cons=%d\n", taglen, lenlen, cons);
     if (!cons)
     {
         if (ll < 0 || ll > len)
         {
-            fprintf(f, "%*sBad length on primitive type. ll=%d len=%d\n",
-                    level*4+5, "", ll, len);
+            fprintf(f, "%sBad length on primitive type. ll=%d len=%d\n",
+                    level_str, ll, len);
             return 0;
         }
         return ll + (b - buf);
@@ -84,8 +89,8 @@ static int do_dumpBER(FILE *f, const char *buf, int len, int level, int offset)
     {
         if (ll > len)
         {
-            fprintf(f, "%*sBad length of constructed type ll=%d len=%d.\n",
-                    level*4+5, "", ll, len);
+            fprintf(f, "%sBad length of constructed type ll=%d len=%d\n",
+                    level_str, ll, len);
             return 0;
         }
         len = ll;
@@ -97,14 +102,14 @@ static int do_dumpBER(FILE *f, const char *buf, int len, int level, int offset)
             break;
         if (!(res = do_dumpBER(f, b, len, level + 1, offset + (b - buf))))
         {
-            fprintf(f, "%*sDump of content element failed.\n", level*4+5, "");
+            fprintf(f, "%s Dump of content element failed\n", level_str);
             return 0;
         }
         b += res;
         len -= res;
         if (len < 0)
         {
-            fprintf(f, "%*sBad length\n", level*4+5, "");
+            fprintf(f, "%sBad length\n", level_str);
             return 0;
         }
     }
@@ -112,8 +117,8 @@ static int do_dumpBER(FILE *f, const char *buf, int len, int level, int offset)
     {
         if (len < 2)
         {
-            fprintf(f, "%*sBuffer too short in indefinite length.\n",
-                    level*4+5, "");
+            fprintf(f, "%sBuffer too short in indefinite length\n",
+                    level_str);
             return 0;
         }
         return (b - buf) + 2;