From ec8afe26d4ebd3b3097515c42b19a356c4481a39 Mon Sep 17 00:00:00 2001 From: Mike Taylor Date: Mon, 9 Mar 2015 17:09:58 +0000 Subject: [PATCH 1/1] Part of MKWS-58. Eliminate unnecessary state variable m_needRedraw, which is always tied to m_data. Rename m_data to m_dataToRedraw, better expressing its function. --- src/mkws-widget-main.js | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/mkws-widget-main.js b/src/mkws-widget-main.js index a73a1af..017ce65 100644 --- a/src/mkws-widget-main.js +++ b/src/mkws-widget-main.js @@ -113,8 +113,7 @@ mkws.registerWidgetType('details', function() { mkws.registerWidgetType('records', function() { var that = this; var team = this.team; - var m_data; - var m_needRedraw = false; + var m_dataToRedraw = null; var m_frozen = false; this.team.queue("searchtriggered").subscribe(function() { @@ -125,9 +124,9 @@ mkws.registerWidgetType('records', function() { function refreshRecordData() { that.node.css('opacity', 1); - if (m_needRedraw) { - for (var i = 0; i < m_data.hits.length; i++) { - var hit = m_data.hits[i]; + if (m_dataToRedraw) { + for (var i = 0; i < m_dataToRedraw.hits.length; i++) { + var hit = m_dataToRedraw.hits[i]; hit.detailLinkId = team.recordElementId(hit.recid[0]); hit.detailClick = "mkws.showDetails('" + team.name() + "', '" + hit.recid[0] + "');return false;"; hit.containerClass = "mkws-summary mkwsSummary mkws-team-" + team.name(); @@ -143,16 +142,15 @@ mkws.registerWidgetType('records', function() { } var template = team.loadTemplate(that.config.template || "records"); var summaryPartial = team.loadTemplate(that.config['summary-template'] || "summary"); - var tdata = $.extend({}, {"hits": m_data.hits}, that.config.template_vars); + var tdata = $.extend({}, {"hits": m_dataToRedraw.hits}, that.config.template_vars); that.node.html(template(tdata, {"partials":{"summary":summaryPartial}})); } - m_needRedraw = false; + m_dataToRedraw = null; } function setRecordData(data) { - m_data = data; - m_needRedraw = true; + m_dataToRedraw = data; if (!m_frozen) { refreshRecordData(); } -- 1.7.10.4