From d9069273e915794d963980f4d7222b371b196144 Mon Sep 17 00:00:00 2001 From: Mike Taylor Date: Tue, 7 Oct 2014 13:01:05 +0100 Subject: [PATCH] expandValue demoted from a member function to a private function. (It's never called outside of the widget object.) --- src/mkws-widget.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mkws-widget.js b/src/mkws-widget.js index 9a3a7f7..d57620b 100644 --- a/src/mkws-widget.js +++ b/src/mkws-widget.js @@ -66,8 +66,7 @@ function widget($, team, type, node) { return s.join(''); }; - // ### why is this a member function? It's never called from outside this file. - that.expandValue = function(val) { + function expandValue(val) { if (val.match(/^!param!/)) { var param = val.replace(/^!param!/, ''); val = mkws.getParameterByName(param); @@ -153,7 +152,7 @@ function widget($, team, type, node) { for (var i = 0; i < node.attributes.length; i++) { var a = node.attributes[i]; - var val = that.expandValue(a.value); + var val = expandValue(a.value); if (a.name === 'data-mkws-config') { // Treat as a JSON fragment configuring just this widget log(node + ": parsing config fragment '" + val + "'"); -- 1.7.10.4