From df249d500ca3cfefbc1e0fd82e3a7c1bd7f85142 Mon Sep 17 00:00:00 2001 From: Mike Taylor Date: Thu, 20 Sep 2007 10:14:37 +0000 Subject: [PATCH 1/1] _next_connection() correctly returns undef when reading past the end of the target queue when no modulo-selection is in force, rather than trying to connect to an undefined target. --- lib/ZOOM/IRSpy.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/lib/ZOOM/IRSpy.pm b/lib/ZOOM/IRSpy.pm index 8e6d3ac..3bd1aaf 100644 --- a/lib/ZOOM/IRSpy.pm +++ b/lib/ZOOM/IRSpy.pm @@ -1,4 +1,4 @@ -# $Id: IRSpy.pm,v 1.88 2007-09-18 16:57:37 mike Exp $ +# $Id: IRSpy.pm,v 1.89 2007-09-20 10:14:37 mike Exp $ package ZOOM::IRSpy; @@ -230,6 +230,7 @@ sub _next_connection { my $i = $this->{modi}; if (!defined $n) { $target = shift @{ $this->{queue} }; + return undef if !defined $target; } else { while (1) { $target = shift @{ $this->{queue} }; @@ -241,6 +242,7 @@ sub _next_connection { } } + die "oops -- target is undefined" if !defined $target; return create ZOOM::IRSpy::Connection($this, $target, async => 1, timeout => $this->{timeout}); } -- 1.7.10.4