From 9b36eb38f97816f770ae35241aa5b72be232277d Mon Sep 17 00:00:00 2001 From: Mike Taylor Date: Thu, 30 Nov 2006 12:01:23 +0000 Subject: [PATCH] Remove redundant _string2cdata() method, use xml_encode() instead. --- lib/ZOOM/IRSpy/Record.pm | 19 ++----------------- 1 file changed, 2 insertions(+), 17 deletions(-) diff --git a/lib/ZOOM/IRSpy/Record.pm b/lib/ZOOM/IRSpy/Record.pm index 9141a51..a0738c8 100644 --- a/lib/ZOOM/IRSpy/Record.pm +++ b/lib/ZOOM/IRSpy/Record.pm @@ -1,4 +1,4 @@ -# $Id: Record.pm,v 1.20 2006-11-29 18:17:16 mike Exp $ +# $Id: Record.pm,v 1.21 2006-11-30 12:01:23 mike Exp $ package ZOOM::IRSpy::Record; @@ -98,7 +98,7 @@ sub store_result { my $xml = "_string2cdata($info{$key}) . "\""; + $xml .= " $key=\"" . xml_encode($info{$key}) . "\""; } $xml .= ">" . isodate(time()) . "\n"; @@ -158,21 +158,6 @@ sub _half_decent_appendWellBalancedChunk { } -# Yes, I know that this is already implemented in IRSpy.pm. I suggest that we -# introduce a toolkit package with such subroutines... -# -sub _string2cdata { - my ($this, $buffer) = @_; - $buffer =~ s/&/&/gs; - $buffer =~ s//>/gs; - $buffer =~ s/"/"/gs; - $buffer =~ s/'/'/gs; - - return $buffer; -} - - =head1 SEE ALSO ZOOM::IRSpy -- 1.7.10.4