From 887ada2b0c58be15e4e0551fd0cee8672c9fbdb1 Mon Sep 17 00:00:00 2001 From: Mike Taylor Date: Mon, 25 Mar 2013 18:04:20 +0000 Subject: [PATCH] Do not return TEST_BAD when diagnostic is 1 (permanent system error). Fixes the second part of IR-338. This probably needs some deeper thought. There seems to be some uncertainty over whether returning TEST_BAD means "skip the rest of this test" (which is what was intended here) or "skip this and all sibling tests" (which is what's implemented). Do ANY instances of TEST_BAD intend the latter? If not, we can just change the behaviour. --- lib/ZOOM/IRSpy/Test/Search/Bib1.pm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lib/ZOOM/IRSpy/Test/Search/Bib1.pm b/lib/ZOOM/IRSpy/Test/Search/Bib1.pm index fd4d1d6..1d5c0e7 100644 --- a/lib/ZOOM/IRSpy/Test/Search/Bib1.pm +++ b/lib/ZOOM/IRSpy/Test/Search/Bib1.pm @@ -53,10 +53,11 @@ sub error { update($conn, $attr, 0); zoom_error_timeout_update($conn, $exception); - return ZOOM::IRSpy::Status::TEST_BAD - if ($exception->code() == 1 || # permanent system error - $exception->code() == 235 || # Database does not exist - $exception->code() == 109); # Database unavailable +# Commented out because TEST_BAD causes sibling tests to be skipped. +# return ZOOM::IRSpy::Status::TEST_BAD +# if ($exception->code() == 1 || # permanent system error +# $exception->code() == 235 || # Database does not exist +# $exception->code() == 109); # Database unavailable return ZOOM::IRSpy::Status::TASK_DONE; } -- 1.7.10.4