X-Git-Url: http://git.indexdata.com/?p=irspy-moved-to-github.git;a=blobdiff_plain;f=lib%2FZOOM%2FIRSpy%2FTest%2FRecord%2FFetch.pm;h=d45524c538f8d01b3ef6fcdfab2954f1e1c39404;hp=6ed0edb0596eaad99fdcea50c0684ab8d8a60795;hb=8e8489f6c6191b3335adb1f1b285d9c7ad724023;hpb=1a4c5ca7fe06c3e6b864b45ea071d500753d3ab5

diff --git a/lib/ZOOM/IRSpy/Test/Record/Fetch.pm b/lib/ZOOM/IRSpy/Test/Record/Fetch.pm
index 6ed0edb..d45524c 100644
--- a/lib/ZOOM/IRSpy/Test/Record/Fetch.pm
+++ b/lib/ZOOM/IRSpy/Test/Record/Fetch.pm
@@ -1,4 +1,4 @@
-# $Id: Fetch.pm,v 1.12 2006-11-01 09:56:50 sondberg Exp $
+# $Id: Fetch.pm,v 1.22 2007-02-13 15:04:08 mike Exp $
 
 # See the "Main" test package for documentation
 
@@ -12,6 +12,15 @@ use ZOOM::IRSpy::Test;
 our @ISA = qw(ZOOM::IRSpy::Test);
 
 
+# These queries 
+my @queries = (
+	       "\@attr 1=4 mineral",
+	       "\@attr 1=4 computer",
+	       "\@attr 1=44 mineral", # Smithsonian doesn't support AP 4!
+	       ### We can add more queries here
+	       );
+
+
 sub start {
     my $class = shift();
     my($conn) = @_;
@@ -19,16 +28,30 @@ sub start {
     # Here I want to get a use attribute from the session, which we've
     # managed to search for in the Search/Bib1 or Search/Dan1 tests.
     # But how?  So far we search for title: 1=4
-    $conn->irspy_search_pqf("\@attr 1=4 mineral", {}, {},	
+    $conn->irspy_search_pqf($queries[0], { queryindex => 0 }, {},
 			    ZOOM::Event::RECV_SEARCH, \&completed_search,
-			    exception => \&error);
+			    exception => \&completed_search);
 }
 
 
 sub completed_search {
     my($conn, $task, $udata, $event) = @_;
 
-    $conn->log("irspy_test", "Fetch test search succeeded");
+    my $n = $task->{rs}->size();
+    $conn->log("irspy_test", "Fetch test search found $n records");
+    if ($n == 0) {
+	my $qindex = $udata->{queryindex}+1;
+	my $q = $queries[$qindex];
+	return ZOOM::IRSpy::Status::TEST_SKIPPED
+	    if !defined $q;
+
+	$conn->log("irspy_test", "Trying another search ...");
+	$conn->irspy_search_pqf($queries[$qindex], { queryindex => $n }, {},
+				ZOOM::Event::RECV_SEARCH, \&completed_search,
+				exception => \&completed_search);
+	return ZOOM::IRSpy::Status::TASK_DONE;
+    }
+
     my @syntax = (
                    'canmarc',
                    'danmarc',
@@ -39,7 +62,7 @@ sub completed_search {
                    'librismarc',
                    'mab',
                    'normarc',
-                   'opac',
+#                   'opac',
                    'picamarc',
                    'rusmarc',
                    'summary',
@@ -51,13 +74,15 @@ sub completed_search {
                    'xml'
                 );
     #@syntax = qw(grs-1 sutrs usmarc xml); # simplify for debugging
-    foreach my $syntax (@syntax) {
+    foreach my $i (0 ..$#syntax) {
+	my $syntax = $syntax[$i];
 	$conn->irspy_rs_record($task->{rs}, 0,
-			       { syntax => $syntax },
+			       { syntax => $syntax,
+			         last => ($i == $#syntax) },
 			       { start => 0, count => 1,
 				 preferredRecordSyntax => $syntax },
                                 ZOOM::Event::RECV_RECORD, \&record,
-				exception => \&error);
+				exception => \&fetch_error);
     }
 
     return ZOOM::IRSpy::Status::TASK_DONE;
@@ -65,35 +90,33 @@ sub completed_search {
 
 
 sub record {
-    my($conn, $task, $test_args, $event) = @_;
-    my $syn = $test_args->{'syntax'};
+    my($conn, $task, $udata, $event) = @_;
+    my $syn = $udata->{'syntax'};
     my $rs = $task->{rs};
 
-    # Due to a bug in ZOOM-C (as of YAZ 2.1.38 of 31st October 2006),
-    # diagnostics in Present responses are not reported, so that we
-    # always end up in this callback rather than in error() where we
-    # should be.  Luckily, we can test whether the retrieval really
-    # did work by rendering the record, which will yield an undefined
-    # result if the fetch failed.
     my $record = _fetch_record($rs, 0, $syn);
-    my $text = $record->render();
-    if (defined $text) {
+    my $ok = 0;
+    if ($record->error()) {
+	$conn->log("irspy_test", "retrieval of $syn record failed: ",
+		   $record->exception());
+    } else {
+	$ok = 1;
+	my $text = $record->render();
 	$conn->log("irspy_test", "Successfully retrieved a $syn record");
 	if (0) {
 	    print STDERR "Hits: ", $rs->size(), "\n";
 	    print STDERR "Syntax: ", $syn, "\n";
 	    print STDERR $text;
 	}
-    } else {
-	$conn->log("irspy_test", "Retrieval of $syn record failed: ",
-		   "exception unavailable");
     }
 
     $conn->record()->store_result('record_fetch',
                                   'syntax'   => $syn,
-                                  'ok'       => defined $text ? 1 : 0);
+                                  'ok'       => $ok);
 
-    return ZOOM::IRSpy::Status::TASK_DONE;
+    return ($udata->{last} ?
+	    ZOOM::IRSpy::Status::TEST_GOOD :
+	    ZOOM::IRSpy::Status::TASK_DONE);
 }
 
 
@@ -109,7 +132,15 @@ sub _fetch_record {
 }
 
 
-sub error {
+sub __UNUSED_search_error {
+    my($conn, $task, $test_args, $exception) = @_;
+
+    $conn->log("irspy_test", "Initial search failed: ", $exception);
+    return ZOOM::IRSpy::Status::TEST_SKIPPED;
+}
+
+
+sub fetch_error {
     my($conn, $task, $test_args, $exception) = @_;
     my $syn = $test_args->{'syntax'};