X-Git-Url: http://git.indexdata.com/?p=irspy-moved-to-github.git;a=blobdiff_plain;f=lib%2FZOOM%2FIRSpy%2FTest%2FRecord%2FFetch.pm;h=05692456342e6592860eedf1c300bb0234736ba8;hp=b63c22e99996b438bb0f64ac39b0e66f5b7446da;hb=f09d2992d3d1d1620eb66c640b63b4387e4050e4;hpb=e0a6655b970c68a4b7d3995957d9d917d315a847

diff --git a/lib/ZOOM/IRSpy/Test/Record/Fetch.pm b/lib/ZOOM/IRSpy/Test/Record/Fetch.pm
index b63c22e..0569245 100644
--- a/lib/ZOOM/IRSpy/Test/Record/Fetch.pm
+++ b/lib/ZOOM/IRSpy/Test/Record/Fetch.pm
@@ -1,4 +1,4 @@
-# $Id: Fetch.pm,v 1.15 2006-11-14 16:18:51 mike Exp $
+# $Id: Fetch.pm,v 1.28 2007-05-01 16:31:08 mike Exp $
 
 # See the "Main" test package for documentation
 
@@ -12,6 +12,15 @@ use ZOOM::IRSpy::Test;
 our @ISA = qw(ZOOM::IRSpy::Test);
 
 
+# These queries 
+my @queries = (
+	       "\@attr 1=4 mineral",
+	       "\@attr 1=4 computer",
+	       "\@attr 1=44 mineral", # Smithsonian doesn't support AP 4!
+	       ### We can add more queries here
+	       );
+
+
 sub start {
     my $class = shift();
     my($conn) = @_;
@@ -19,9 +28,9 @@ sub start {
     # Here I want to get a use attribute from the session, which we've
     # managed to search for in the Search/Bib1 or Search/Dan1 tests.
     # But how?  So far we search for title: 1=4
-    $conn->irspy_search_pqf("\@attr 1=4 mineral", {}, {},	
-			    ZOOM::Event::RECV_SEARCH, \&completed_search,
-			    exception => \&error);
+    $conn->irspy_search_pqf($queries[0], { queryindex => 0 }, {},
+			    ZOOM::Event::ZEND, \&completed_search,
+			    exception => \&completed_search);
 }
 
 
@@ -29,8 +38,22 @@ sub completed_search {
     my($conn, $task, $udata, $event) = @_;
 
     my $n = $task->{rs}->size();
-    $conn->log("irspy_test", "Fetch test search found $n records");
-    return ZOOM::IRSpy::Status::TEST_SKIPPED if $n == 0;
+    $conn->log("irspy_test", "Fetch test search (", $task->render_query(), ") ",
+	       ref $event && $event->isa("ZOOM::Exception") ?
+	       "failed: $event" : "found $n records (event=$event)");
+    if ($n == 0) {
+	$task->{rs}->destroy();
+	my $qindex = $udata->{queryindex}+1;
+	my $q = $queries[$qindex];
+	return ZOOM::IRSpy::Status::TEST_SKIPPED
+	    if !defined $q;
+
+	$conn->log("irspy_test", "Trying another search ...");
+	$conn->irspy_search_pqf($queries[$qindex], { queryindex => $qindex }, {},
+				ZOOM::Event::ZEND, \&completed_search,
+				exception => \&completed_search);
+	return ZOOM::IRSpy::Status::TASK_DONE;
+    }
 
     my @syntax = (
                    'canmarc',
@@ -42,7 +65,7 @@ sub completed_search {
                    'librismarc',
                    'mab',
                    'normarc',
-                   'opac',
+#                   'opac',
                    'picamarc',
                    'rusmarc',
                    'summary',
@@ -54,13 +77,15 @@ sub completed_search {
                    'xml'
                 );
     #@syntax = qw(grs-1 sutrs usmarc xml); # simplify for debugging
-    foreach my $syntax (@syntax) {
+    foreach my $i (0 ..$#syntax) {
+	my $syntax = $syntax[$i];
 	$conn->irspy_rs_record($task->{rs}, 0,
-			       { syntax => $syntax },
+			       { syntax => $syntax,
+			         last => ($i == $#syntax) },
 			       { start => 0, count => 1,
 				 preferredRecordSyntax => $syntax },
-                                ZOOM::Event::RECV_RECORD, \&record,
-				exception => \&error);
+                                ZOOM::Event::ZEND, \&record,
+				exception => \&fetch_error);
     }
 
     return ZOOM::IRSpy::Status::TASK_DONE;
@@ -68,35 +93,34 @@ sub completed_search {
 
 
 sub record {
-    my($conn, $task, $test_args, $event) = @_;
-    my $syn = $test_args->{'syntax'};
+    my($conn, $task, $udata, $event) = @_;
+    my $syn = $udata->{'syntax'};
     my $rs = $task->{rs};
 
-    # Due to a bug in ZOOM-C (as of YAZ 2.1.38 of 31st October 2006),
-    # diagnostics in Present responses are not reported, so that we
-    # always end up in this callback rather than in error() where we
-    # should be.  Luckily, we can test whether the retrieval really
-    # did work by rendering the record, which will yield an undefined
-    # result if the fetch failed.
     my $record = _fetch_record($rs, 0, $syn);
-    my $text = $record->render();
-    if (defined $text) {
+    my $ok = 0;
+    if (!$record || $record->error()) {
+	$conn->log("irspy_test", "retrieval of $syn record failed: ",
+		   defined $record ? $record->exception() : "???");
+    } else {
+	$ok = 1;
+	my $text = $record->render();
 	$conn->log("irspy_test", "Successfully retrieved a $syn record");
 	if (0) {
 	    print STDERR "Hits: ", $rs->size(), "\n";
 	    print STDERR "Syntax: ", $syn, "\n";
 	    print STDERR $text;
 	}
-    } else {
-	$conn->log("irspy_test", "Retrieval of $syn record failed: ",
-		   "(exception unavailable)");
     }
 
     $conn->record()->store_result('record_fetch',
                                   'syntax'   => $syn,
-                                  'ok'       => defined $text ? 1 : 0);
+                                  'ok'       => $ok);
 
-    return ZOOM::IRSpy::Status::TASK_DONE;
+    $rs->destroy() if $udata->{last};
+    return ($udata->{last} ?
+	    ZOOM::IRSpy::Status::TEST_GOOD :
+	    ZOOM::IRSpy::Status::TASK_DONE);
 }
 
 
@@ -112,14 +136,23 @@ sub _fetch_record {
 }
 
 
-sub error {
+sub __UNUSED_search_error {
     my($conn, $task, $test_args, $exception) = @_;
-    my $syn = $test_args->{'syntax'};
+
+    $conn->log("irspy_test", "Initial search failed: ", $exception);
+    return ZOOM::IRSpy::Status::TEST_SKIPPED;
+}
+
+
+sub fetch_error {
+    my($conn, $task, $udata, $exception) = @_;
+    my $syn = $udata->{'syntax'};
 
     $conn->log("irspy_test", "Retrieval of $syn record failed: ", $exception);
     $conn->record()->store_result('record_fetch',
                                   'syntax'       => $syn,
                                   'ok'        => 0);
+    $task->{rs}->destroy() if $udata->{last};
     return ZOOM::IRSpy::Status::TASK_DONE;
 }