From dacff04b5638eac9fab76c7fbd815fc2e6aa0b42 Mon Sep 17 00:00:00 2001
From: mike <mike>
Date: Thu, 2 Nov 2006 17:07:50 +0000
Subject: [PATCH] Throw diagnostic if records() is asked for an out-of-range
 record.

---
 lib/ZOOM.pm |   12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/lib/ZOOM.pm b/lib/ZOOM.pm
index 2fa8be2..de906c4 100644
--- a/lib/ZOOM.pm
+++ b/lib/ZOOM.pm
@@ -1,4 +1,4 @@
-# $Id: ZOOM.pm,v 1.38 2006-10-10 17:02:27 mike Exp $
+# $Id: ZOOM.pm,v 1.39 2006-11-02 17:07:50 mike Exp $
 
 use strict;
 use warnings;
@@ -731,6 +731,16 @@ sub records {
     my $this = shift();
     my($start, $count, $return_records) = @_;
 
+    # If the request is out of range, ZOOM-C will currently (as of YAZ
+    # 2.1.38) no-op: it understandably refuses to build and send a
+    # known-bad APDU, but it doesn't set a diagnostic as it ought.  So
+    # for now, we do it here.
+    my $size = $this->size();
+    if ($start + $count-1 >= $size) {
+	# BIB-1 diagnostic 13 is "Present request out-of-range"
+	ZOOM::_oops(13, undef, "bib-1");
+    }
+
     my $raw = Net::Z3950::ZOOM::resultset_records($this->_rs(), $start, $count,
 						  $return_records);
     # By design, $raw may be undefined (if $return_records is true)
-- 
1.7.10.4