From 972cf430e150554a7d98feee80d45fb27f8e74ad Mon Sep 17 00:00:00 2001 From: Adam Dickmeiss Date: Fri, 28 Dec 2012 15:15:52 +0100 Subject: [PATCH] Avoid buffer overrun by "long" URLs. --- src/connection.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/connection.c b/src/connection.c index c1ff7d5..16ae64a 100644 --- a/src/connection.c +++ b/src/connection.c @@ -465,10 +465,11 @@ static int connection_connect(struct connection *con, iochan_man_t iochan_man) if (sru && *sru && !strstr(host->url, "://")) { - char http_hostport[512]; - strcpy(http_hostport, "http://"); - strcat(http_hostport, host->url); - ZOOM_connection_connect(con->link, http_hostport, 0); + WRBUF w = wrbuf_alloc(); + wrbuf_puts(w, "http://"); + wrbuf_puts(w, host->url); + ZOOM_connection_connect(con->link, wrbuf_cstr(w), 0); + wrbuf_destroy(w); } else { -- 1.7.10.4