X-Git-Url: http://git.indexdata.com/?a=blobdiff_plain;f=test%2Fspec%2Fmkws-pazpar2.js;h=fe1e746e5b001ae06212cc3c2ab15391a5668720;hb=738d2b9639224b05db381edd0e2f0c577310fb64;hp=50dfa94020092d9c7c50f1cb033f6e3f21cbcad4;hpb=4028a2d1508ac4ce5734a6842ac16423eee327b2;p=mkws-moved-to-github.git

diff --git a/test/spec/mkws-pazpar2.js b/test/spec/mkws-pazpar2.js
index 50dfa94..fe1e746 100644
--- a/test/spec/mkws-pazpar2.js
+++ b/test/spec/mkws-pazpar2.js
@@ -92,8 +92,6 @@ describe("Check MOTD before search", function () {
         expect($(".mkwsMOTDContainer").length).toBe(1);
         expect($(".mkwsMOTDContainer").text()).toMatch(/MOTD/);
     });
-
-
 });
 
 describe("Check pazpar2 search", function () {
@@ -135,15 +133,12 @@ describe("Check MOTD after search", function () {
     it("MOTD is hidden", function () {
         expect($(".mkwsMOTD").length).toBe(1);
         expect($(".mkwsMOTD").is(":hidden")).toBe(true);
-        debug("motd " + $(".mkwsMOTD") );
-        debug("motd t=" + $(".mkwsMOTD").text() );
-        debug("motd v=" + $(".mkwsMOTD").is(":visible") );
-        //expect($("div.mkwsBytarget").is(":visible")).toBe(true);
+        debug("motd t=" + $(".mkwsMOTD").text());
+        debug("motd v=" + $(".mkwsMOTD").is(":visible"));
     });
 });
 
 
-
 /*
  * This part runs in background. It should be rewritten with
  * async jasmine functions
@@ -190,11 +185,9 @@ describe("Check pazpar2 hit counter", function () {
 
         waitsFor(function () {
             hits = get_hit_counter();
-
             return hits > expected_hits;
         }, "Expect " + expected_hits + " hits", max_time * jasmine_config.second);
 
-
         runs(function () {
             debug("mkws pager found records: '" + hits + "'");
             expect($(".mkwsPager").length).toBe(1);
@@ -213,7 +206,6 @@ describe("Check Termlist", function () {
             return $("div.mkwsFacetSources").length == 1 ? true : false;
         }, "check for facet sources", 4 * jasmine_config.second);
 
-
         // everything displayed?
         runs(function () {
             var sources = $("div.mkwsFacetSources");
@@ -246,6 +238,7 @@ describe("Check Termlist", function () {
         var author_number = 2; // 2=first author
         // do not click on author with numbers, e.g.: "Bower, James M. Beeman, David, 1938-"
         // do not click on author names without a comma, e.g.: "Joe Barbara"
+        // because searching on such authors won't find anything.
         var terms = $("div.mkwsFacetAuthors div.term a");
         for (var i = 0; i < terms.length; i++) {
             var term = $(terms[i]).text();
@@ -256,7 +249,12 @@ describe("Check Termlist", function () {
                 break;
             }
         }
+        if ($("div.mkwsFacetAuthors div.term:nth-child(" + author_number + ") a").text().length == 0) {
+            debug("No good authors found. Not clicking on the bad ones");
+            return;
+        }
 
+        debug("Clicking on author (" + author_number + ") " + $("div.mkwsFacetAuthors div.term:nth-child(" + author_number + ") a").text());
         $("div.mkwsFacetAuthors div.term:nth-child(" + author_number + ") a").trigger("click");
 
         waitsFor(function () {
@@ -284,9 +282,13 @@ describe("Check Termlist", function () {
                 break;
             }
         }
+        if ($("div.mkwsFacetSources div.term:nth-child(" + source_number + ") a").text().length == 0) {
+            debug("No good source found. Not clicking on the bad ones");
+            return;
+        }
 
         $("div.mkwsFacetSources div.term:nth-child(" + source_number + ") a").trigger("click");
-        
+
         waitsFor(function () {
             if ($("div.mkwsNavi").length && $("div.mkwsNavi").text().match(/(Source|datenquelle|kilder): /i)) {
                 return true;
@@ -309,27 +311,34 @@ describe("Check Termlist", function () {
     });
 });
 
-describe("Show record", function () {
-    var record_number = 1; // the Nth record in hit list
-    it("show record author", function () {
+describe("Check record list", function () {
+    it("got a record", function () {
         // make sure we have a link.
         var linkaddr = "div.mkwsRecords div.record:nth-child(1) a";
         var waitcount = 0;
-        waitsFor(function() {
-          waitcount++;
-          debug("waiting for the link " + waitcount + " "  + $(linkaddr) + 
-              " =" + $(linkaddr).length +  " " + $(linkaddr).text() );          
-          return ( $(linkaddr).length >0  );
+
+        waitsFor(function () {
+            waitcount++;
+            debug("waiting for the link " + waitcount + " " + $(linkaddr) + " =" + $(linkaddr).length + " " + $(linkaddr).text());
+            return ($(linkaddr).length > 0);
         }, "wait until we see a link", 1 * jasmine_config.second);
-        
-        runs(function(){
-          var link =  $(linkaddr);
-          debug("== waited (" + waitcount + ") for the link..." + $(linkaddr) + 
-            " =" + $(linkaddr).length +  " " + $(linkaddr).text() );
-          expect(link.length).toBe(1);
-          link.trigger("click");
+
+        runs(function () {
+            var link = $(linkaddr);
+            debug("== waited (" + waitcount + ") for the link..." + $(linkaddr) + " =" + $(linkaddr).length + " " + $(linkaddr).text());
+            expect(link.length).toBe(1);
+            // link.trigger("click");
         });
-        
+    });
+});
+
+describe("Show record", function () {
+    var record_number = 1; // the Nth record in hit list
+    it("show record author", function () {
+        var click = $("div.mkwsRecords div.record:nth-child(" + record_number + ") a").trigger("click");
+        debug("show record click is success: " + click.length);
+        expect(click.length).toBe(1);
+
         // wait until the record pops up
         waitsFor(function () {
             var show = $("div.mkwsRecords div.record:nth-child(" + record_number + ") div");
@@ -348,14 +357,16 @@ describe("Show record", function () {
             return;
         }
 
-        var urls = $("div#mkwsRecords div.record:nth-child(" + record_number + ") div table tbody tr td a");
+        var urls = $("div.mkwsRecords div.record:nth-child(" + record_number + ") div table tbody tr td a");
         debug("number of extracted URL from record: " + urls.length);
+        // expect(urls.length).toBeGreaterThan(0); // LoC has records without links
         for (var i = 0; i < urls.length; i++) {
             var url = $(urls[i]);
-            debug("URL: " + url.attr('href'));
+            debug("URL: " + url.attr('href') + " text: " + url.text());
+
             expect(url.attr('href')).not.toBe(null);
             expect(url.attr('href')).toMatch(/^https?:\/\/[a-z0-9]+\.[0-9a-z].*\//i);
-            expect(url.attr('href')).toBe(url.text());
+            expect(url.text()).not.toBe("");
         }
     });
 });
@@ -411,9 +422,7 @@ describe("Check status client counter", function () {
             } else {
                 return false;
             }
-
         }, "wait for Active clients: 0/1", 4 * jasmine_config.second);
-
 /*
         runs(function () {
             var clients = $("div#mkwsStat span.clients");
@@ -421,9 +430,7 @@ describe("Check status client counter", function () {
             expect(clients.text()).toEqual("0/1");
         });
         */
-
     });
-
 });
 
 /* done */