X-Git-Url: http://git.indexdata.com/?a=blobdiff_plain;f=test%2Fspec%2Fmkws-pazpar2.js;h=8e7543d1487b2edaa122207a6bfffb58192360fb;hb=5bb37cdb165de8b6d607835ed9cf671628f9af41;hp=7c77122e1e1aad8c5976b94a8274fa9a7f461ee7;hpb=4565be9497ba70104b52f2a60c89d6b82f11e0fc;p=mkws-moved-to-github.git diff --git a/test/spec/mkws-pazpar2.js b/test/spec/mkws-pazpar2.js index 7c77122..8e7543d 100644 --- a/test/spec/mkws-pazpar2.js +++ b/test/spec/mkws-pazpar2.js @@ -6,14 +6,18 @@ // get references from mkws.js, lazy evaluation var debug = function (text) { - mkws.debug("Jasmine: " + text) + mkws.log("Jasmine: " + text) } - // Define empty mkws_config for simple applications that don't define it. + // Define empty jasmine_config for simple applications that don't define it. if (jasmine_config == null || typeof jasmine_config != 'object') { var jasmine_config = {}; } +var jasmine_status = { + source_click: 0 +}; + /* check config for jasmine test * * you can override the default values in the config @@ -24,7 +28,7 @@ function init_jasmine_config() { var jasmine_config_default = { search_query: "freebsd", - max_time: 16, + max_time: 17, // in seconds expected_hits: 80, // at least expected hit counter @@ -32,6 +36,7 @@ function init_jasmine_config() { // miliseconds to seconds show_record_url: true, // check for valid URL in records + check_motd: true, dummy: false }; @@ -57,7 +62,9 @@ var get_hit_counter = function () { if (RegExp.$1) { hits = parseInt(RegExp.$1); - expect(hits).toBeGreaterThan(0); + if (hits <= 0) { + debug("Oooops in get_hit_counter: " + RegExp.$1 + " '" + found + "'"); + } } //debug("Hits: " + hits); @@ -75,11 +82,12 @@ describe("Init jasmine config", function () { }); }); -describe("Check MOTD before search", function () { +//disabled +xdescribe("Check MOTD before search", function () { // Check that the MOTD has been moved into its container, and // is visible before the search. // the mkwsMOTD div was originally inside a testMOTD div, which should - // now be emtpy + // now be empty // Note that the testMOTD is a regular div, and uses #testMOTD, // since the automagic class-making does not apply to it. it("MOTD is hidden", function () { @@ -92,13 +100,11 @@ describe("Check MOTD before search", function () { expect($(".mkwsMOTDContainer").length).toBe(1); expect($(".mkwsMOTDContainer").text()).toMatch(/MOTD/); }); - - }); describe("Check pazpar2 search", function () { it("pazpar2 was successfully initialized", function () { - expect(mkws_config.error).toBe(undefined); + expect(mkws.config.error).toBe(undefined); }); it("validate HTML id's", function () { @@ -115,7 +121,7 @@ describe("Check pazpar2 search", function () { debug("set search query: " + search_query) expect($("input.mkwsQuery").val()).toMatch("^" + search_query + "$"); - if (mkws_config.use_service_proxy) { + if (mkws.config.use_service_proxy) { // wait for service proxy auth waitsFor(function () { return mkws.authenticated; @@ -133,17 +139,18 @@ describe("Check pazpar2 search", function () { describe("Check MOTD after search", function () { it("MOTD is hidden", function () { + if (!jasmine_config.check_motd) { + return; + } + expect($(".mkwsMOTD").length).toBe(1); expect($(".mkwsMOTD").is(":hidden")).toBe(true); - //debug("motd " + $(".mkwsMOTD")); debug("motd t=" + $(".mkwsMOTD").text()); debug("motd v=" + $(".mkwsMOTD").is(":visible")); - //expect($("div.mkwsBytarget").is(":visible")).toBe(true); }); }); - /* * This part runs in background. It should be rewritten with * async jasmine functions @@ -190,11 +197,9 @@ describe("Check pazpar2 hit counter", function () { waitsFor(function () { hits = get_hit_counter(); - return hits > expected_hits; }, "Expect " + expected_hits + " hits", max_time * jasmine_config.second); - runs(function () { debug("mkws pager found records: '" + hits + "'"); expect($(".mkwsPager").length).toBe(1); @@ -210,34 +215,35 @@ describe("Check Termlist", function () { expect(termlist.length).toBe(1); waitsFor(function () { - return $("div.mkwsFacetSources").length == 1 ? true : false; + return $("div.mkwsFacet[data-mkws-facet='xtargets']").length == 1 ? true : false; }, "check for facet sources", 4 * jasmine_config.second); - // everything displayed? runs(function () { - var sources = $("div.mkwsFacetSources"); + var sources = $("div.mkwsFacet[data-mkws-facet='xtargets']"); debug("Termlist sources success: " + sources.length); expect(sources.length).toBe(1); - var subjects = $("div.mkwsFacetSubjects"); + var subjects = $("div.mkwsFacet[data-mkws-facet='subject']"); expect(subjects.length).toBe(1); - var authors = $("div.mkwsFacetAuthors"); + var authors = $("div.mkwsFacet[data-mkws-facet='author']"); expect(authors.length).toBe(1); }); waitsFor(function () { - return $("div.mkwsFacetAuthors div.term").length >= 2 ? true : false; + return $("div.mkwsFacet[data-mkws-facet='author'] div.term").length >= 2 ? true : false; }, "At least one author link displayed", 4 * jasmine_config.second); runs(function () { - expect($("div.mkwsFacetAuthors div.term").length).toBeGreaterThan(1); + expect($("div.mkwsFacet[data-mkws-facet='author'] div.term").length).toBeGreaterThan(1); }); }); +}); +describe("Check Author Facets", function () { it("limit search to first author", function () { - if (mkws_config.disable_facet_authors_search) { + if (mkws.config.disable_facet_authors_search) { debug("Facets: ignore limit search for authors"); return; } @@ -246,55 +252,105 @@ describe("Check Termlist", function () { var author_number = 2; // 2=first author // do not click on author with numbers, e.g.: "Bower, James M. Beeman, David, 1938-" // do not click on author names without a comma, e.g.: "Joe Barbara" - var terms = $("div.mkwsFacetAuthors div.term a"); - for (var i = 0; i < terms.length; i++) { - var term = $(terms[i]).text(); - if (term.match(/[0-9].+[0-9]/i) || !term.match(/,/)) { - debug("ignore author facet: " + term); - author_number++; - } else { - break; + // because searching on such authors won't find anything. + runs(function () { + var terms = $("div.mkwsFacet[data-mkws-facet='author'] div.term a"); + for (var i = 0; i < terms.length; i++) { + var term = $(terms[i]).text(); + if (term.match(/[0-9].+[0-9]/i) || !term.match(/,/)) { + debug("ignore author facet: " + term); + author_number++; + } else { + break; + } + } + if ($("div.mkwsFacet[data-mkws-facet='author'] div.term:nth-child(" + author_number + ") a").text().length == 0) { + debug("No good authors found. Not clicking on the bad ones"); + return; } - } - if ($("div.mkwsFacetAuthors div.term:nth-child(" + author_number + ") a").text().length == 0) { - debug("No good authors found. Not clicking on the bad ones"); - return; - } - debug("Clicking on author (" + author_number + ") " + $("div.mkwsFacetAuthors div.term:nth-child(" + author_number + ") a").text()); - $("div.mkwsFacetAuthors div.term:nth-child(" + author_number + ") a").trigger("click"); + debug("Clicking on author (" + author_number + ") " + $("div.mkwsFacet[data-mkws-facet='author'] div.term:nth-child(" + author_number + ") a").text()); + $("div.mkwsFacet[data-mkws-facet='author'] div.term:nth-child(" + author_number + ") a").trigger("click"); + }); waitsFor(function () { - return get_hit_counter() < hits_all_targets ? true : false; - }, "Limited author search for less than " + hits_all_targets + " hits", 6 * jasmine_config.second); + var hits_single_target = get_hit_counter(); + return hits_single_target > 0 && hits_single_target < hits_all_targets ? true : false; + }, "Limited author search for less than " + hits_all_targets + " hits", 4.5 * jasmine_config.second); runs(function () { var hits_single_target = get_hit_counter(); debug("get less hits for authors: " + hits_all_targets + " > " + hits_single_target); - expect(hits_all_targets).toBeGreaterThan(hits_single_target); }); }); +}); + +describe("Check active clients author", function () { + it("check for active clients after limited author search", function () { + waitsFor(function () { + var clients = $("div.mkwsStat span.clients"); + // debug("clients: " + clients.text()); + return clients.length == 1 && clients.text().match("/[1-9]+[0-9]*$"); + }, "wait for Active clients: x/y", 5.5 * jasmine_config.second); + runs(function () { + var clients = $("div.mkwsStat span.clients"); + debug("span.clients: " + clients.text()); + expect(clients.text()).toMatch("/[1-9]+[0-9]*$"); + + // exact match of active clients (e.g. a SP misconfiguration) + if (jasmine_config.active_clients) { + debug("check for " + jasmine_config.active_clients + " active connections"); + expect(clients.text()).toMatch(" [0-9]+/" + jasmine_config.active_clients + "$"); + } + }); + }); +}); + +describe("Check Source Facets", function () { it("limit search to first source", function () { var hits_all_targets = get_hit_counter(); var source_number = 2; // 2=first source + // wait for a stat response + var waitcount = 0; // do not click on wikipedia link - no author or subject facets possible - var terms = $("div.mkwsFacetSources div.term a"); - for (var i = 0; i < terms.length; i++) { - var term = $(terms[i]).text(); - if (term.match(/wikipedia/i)) { - debug("ignore source facet: " + term); - source_number++; - } else { - break; + var link = "div.mkwsFacet[data-mkws-facet='xtargets'] div.term a"; + + // wait for a visible source link in facets + waitsFor(function () { + var terms = $(link); + return terms && terms.length > 0; + }, "wait for source facets after author search", 5 * jasmine_config.second); + + + runs(function () { + var terms = $(link); + for (var i = 0; i < terms.length; i++) { + var term = $(terms[i]).text(); + debug("check for good source: " + term); + + if (term.match(/wikipedia/i)) { + debug("ignore source facet: " + term); + source_number++; + } else { + break; + } + } + debug("Source counter: " + terms.length + ", select: " + (source_number - 1)); + + if ($("div.mkwsFacet[data-mkws-facet='xtargets'] div.term:nth-child(" + source_number + ") a").text().length == 0) { + debug("No good source found. Not clicking on the bad ones"); + return; } - } - if ($("div.mkwsFacetSources div.term:nth-child(" + source_number + ") a").text().length == 0) { - debug("No good source found. Not clicking on the bad ones"); - return; - } - $("div.mkwsFacetSources div.term:nth-child(" + source_number + ") a").trigger("click"); + debug("click on source link nth-child(): " + source_number); + $("div.mkwsFacet[data-mkws-facet='xtargets'] div.term:nth-child(" + source_number + ") a").trigger("click"); + + $(".mkwsPager").bind("DOMNodeInserted DOMNodeRemoved propertychange", function () { + waitcount++; + debug("DOM wait for stat: " + waitcount); + }); + }); waitsFor(function () { if ($("div.mkwsNavi").length && $("div.mkwsNavi").text().match(/(Source|datenquelle|kilder): /i)) { @@ -307,39 +363,57 @@ describe("Check Termlist", function () { // Note: it may happens that limited source search returns the same number of hits // as before. Thats not really an error, but unfortunate waitsFor(function () { - return get_hit_counter() <= hits_all_targets ? true : false; + var hits_single_target = get_hit_counter(); + + return waitcount >= 2 && hits_single_target > 0 && hits_single_target <= hits_all_targets ? true : false; }, "Limited source search for less than " + hits_all_targets + " hits", 5 * jasmine_config.second); runs(function () { var hits_single_target = get_hit_counter(); - debug("get less hits for sources: " + hits_all_targets + " > " + hits_single_target); + debug("get less hits for sources: " + hits_all_targets + " >= " + hits_single_target); expect(hits_all_targets).not.toBeLessThan(hits_single_target); + jasmine_status.source_click = 1; + + $(".mkwsPager").unbind("DOMNodeInserted DOMNodeRemoved propertychange"); }); }); }); + describe("Check record list", function () { + it("check for single active client", function () { + if (!jasmine_status.source_click) { + debug("skip clients check due missing source click"); + return; + } + + waitsFor(function () { + var clients = $("div.mkwsStat span.clients"); + //debug("clients: " + clients.text()); + return clients.length == 1 && clients.text().match("/1$"); + }, "wait for Active clients: x/1", 5 * jasmine_config.second); + + runs(function () { + var clients = $("div.mkwsStat span.clients"); + debug("span.clients: " + clients.text()); + expect(clients.text()).toMatch("/1$"); + }); + }); + it("got a record", function () { - // make sure we have a link. var linkaddr = "div.mkwsRecords div.record:nth-child(1) a"; - var waitcount = 0; waitsFor(function () { - waitcount++; - debug("waiting for the link " + waitcount + " " + $(linkaddr) + " =" + $(linkaddr).length + " " + $(linkaddr).text()); - return ($(linkaddr).length > 0); - }, "wait until we see a link", 1 * jasmine_config.second); + // remove + insert node: must be at least 2 + return $(linkaddr).length > 0; + }, "wait until we see a new record", 2.5 * jasmine_config.second); runs(function () { - var link = $(linkaddr); - debug("== waited (" + waitcount + ") for the link..." + $(linkaddr) + " =" + $(linkaddr).length + " " + $(linkaddr).text()); - expect(link.length).toBe(1); - // link.trigger("click"); + expect($(linkaddr).length).toBeGreaterThan(0); }); }); }); - describe("Show record", function () { var record_number = 1; // the Nth record in hit list it("show record author", function () { @@ -349,7 +423,8 @@ describe("Show record", function () { // wait until the record pops up waitsFor(function () { - var show = $("div.mkwsRecords div.record:nth-child(" + record_number + ") div"); + var show = $("div.mkwsRecords div.record:nth-child(" + record_number + ") > div.mkwsDetails"); + //debug("poprecord: " + (show ? show.length : -1) + " " + $("div.mkwsRecords div.record").text()); return show != null && show.length ? true : false; }, "wait some miliseconds to show up a record", 2 * jasmine_config.second); @@ -365,14 +440,16 @@ describe("Show record", function () { return; } - var urls = $("div#mkwsRecords div.record:nth-child(" + record_number + ") div table tbody tr td a"); + var urls = $("div.mkwsRecords div.record:nth-child(" + record_number + ") div table tbody tr td a"); debug("number of extracted URL from record: " + urls.length); + // expect(urls.length).toBeGreaterThan(0); // LoC has records without links for (var i = 0; i < urls.length; i++) { var url = $(urls[i]); - debug("URL: " + url.attr('href')); + debug("URL: " + url.attr('href') + " text: " + url.text()); + expect(url.attr('href')).not.toBe(null); - expect(url.attr('href')).toMatch(/^https?:\/\/[a-z0-9]+\.[0-9a-z].*\//i); - expect(url.attr('href')).toBe(url.text()); + expect(url.attr('href')).toMatch(/^https?:\/\/[a-z0-9\-]+\.[0-9a-z].*\//i); + expect(url.text()).not.toBe(""); } }); }); @@ -389,7 +466,7 @@ describe("Check switch menu Records/Targets", function () { $("div.mkwsSwitch").children('a').eq(1).trigger("click"); // now the target table must be visible - expect($("div.mkwsBytarget").is(":visible")).toBe(true); + expect($("div.mkwsTargets").is(":visible")).toBe(true); expect($("div.mkwsRecords").is(":visible")).toBe(false); // wait a half second, to show the target view @@ -400,7 +477,7 @@ describe("Check switch menu Records/Targets", function () { // look for table header runs(function () { - expect($("div.mkwsBytarget").html()).toMatch(/Target ID/); + expect($("div.mkwsTargets").html()).toMatch(/Target ID/); }); }); @@ -408,7 +485,7 @@ describe("Check switch menu Records/Targets", function () { $("div.mkwsSwitch").children('a').eq(0).trigger("click"); // now the target table must be visible - expect($("div.mkwsBytarget").is(":visible")).toBe(false); + expect($("div.mkwsTargets").is(":visible")).toBe(false); expect($("div.mkwsRecords").is(":visible")).toBe(true); }); }); @@ -421,26 +498,27 @@ describe("Check status client counter", function () { var time = get_time(); it("check status clients", function () { + if (!jasmine_status.source_click) { + debug("skip clients check due missing source click"); + return; + } + waitsFor(function () { - var clients = $("div#mkwsStat span.clients"); + var clients = $("div.mkwsStat span.clients"); + debug("clients: " + clients.text()); if (clients.length == 1 && clients.text().match("0/1$")) { return true; } else { return false; } - }, "wait for Active clients: 0/1", 4 * jasmine_config.second); -/* runs(function () { - var clients = $("div#mkwsStat span.clients"); + var clients = $("div.mkwsStat span.clients"); debug("span.clients: " + clients.text()); - expect(clients.text()).toEqual("0/1"); + expect(clients.text()).toMatch("0/1$"); }); - */ - }); - }); /* done */