X-Git-Url: http://git.indexdata.com/?a=blobdiff_plain;f=src%2Fsession.c;h=77e4a3e9a7d04a0487e10618300e6e284bee9c09;hb=0be537a08d164975e9584a6c89240b28343a6ec2;hp=aad56ea153a94f9c997ddff67eb40264b767bb86;hpb=4a6689b7683d1dec50e1c45c050fc90990ec4794;p=pazpar2-moved-to-github.git diff --git a/src/session.c b/src/session.c index aad56ea..77e4a3e 100644 --- a/src/session.c +++ b/src/session.c @@ -106,12 +106,12 @@ static void log_xml_doc(xmlDoc *doc) static void session_enter(struct session *s) { - yaz_mutex_enter(s->mutex); + yaz_mutex_enter(s->session_mutex); } static void session_leave(struct session *s) { - yaz_mutex_leave(s->mutex); + yaz_mutex_leave(s->session_mutex); } // Recursively traverse query structure to extract terms. @@ -462,16 +462,24 @@ static void select_targets_callback(void *context, struct session_database *db) static void session_remove_clients(struct session *se) { - struct client_list *l = se->clients; + struct client_list *l; + + session_enter(se); + l = se->clients; + se->clients = 0; + session_leave(se); + while (l) { struct client_list *l_next = l->next; + client_lock(l->client); client_set_session(l->client, 0); + client_set_database(l->client, 0); + client_unlock(l->client); client_destroy(l->client); xfree(l); l = l_next; } - se->clients = 0; } // Associates a set of clients with a session; @@ -479,7 +487,6 @@ static void session_remove_clients(struct session *se) // setting overrides static int select_targets(struct session *se, const char *filter) { - session_remove_clients(se); return session_grep_databases(se, filter, select_targets_callback); } @@ -510,6 +517,8 @@ enum pazpar2_error_code search(struct session *se, yaz_log(YLOG_DEBUG, "Search"); *addinfo = 0; + + session_remove_clients(se); session_enter(se); reclist_destroy(se->reclist); @@ -529,14 +538,14 @@ enum pazpar2_error_code search(struct session *se, for (l = se->clients; l; l = l->next) { struct client *cl = l->client; + if (maxrecs) client_set_maxrecs(cl, atoi(maxrecs)); if (startrecs) client_set_startrecs(cl, atoi(startrecs)); if (prepare_session_database(se, client_get_database(cl)) < 0) - continue; - // Parse query for target - if (client_parse_query(cl, query) < 0) + ; + else if (client_parse_query(cl, query) < 0) no_failed++; else { @@ -669,7 +678,7 @@ void destroy_session(struct session *s) reclist_destroy(s->reclist); nmem_destroy(s->nmem); service_destroy(s->service); - yaz_mutex_destroy(&s->mutex); + yaz_mutex_destroy(&s->session_mutex); wrbuf_destroy(s->wrbuf); } @@ -700,9 +709,8 @@ struct session *new_session(NMEM nmem, struct conf_service *service, session->watchlist[i].fun = 0; } session->normalize_cache = normalize_cache_create(); - session->mutex = 0; - - pazpar2_mutex_create(&session->mutex, name); + session->session_mutex = 0; + pazpar2_mutex_create(&session->session_mutex, name); return session; } @@ -1128,7 +1136,7 @@ int ingest_record(struct client *cl, const char *rec, int record_no, NMEM nmem) { struct session *se = client_get_session(cl); - int ret; + int ret = 0; struct session_database *sdb = client_get_database(cl); struct conf_service *service = se->service; xmlDoc *xdoc = normalize_record(sdb, service, rec, nmem); @@ -1155,9 +1163,15 @@ int ingest_record(struct client *cl, const char *rec, xmlFreeDoc(xdoc); return -1; } + client_unlock(cl); + pazpar2_sleep(0.01); session_enter(se); - ret = ingest_to_cluster(cl, xdoc, root, record_no, mergekey_norm); + client_lock(cl); + if (client_get_session(cl) == se) + ret = ingest_to_cluster(cl, xdoc, root, record_no, mergekey_norm); + client_unlock(cl); session_leave(se); + client_lock(cl); xmlFreeDoc(xdoc); return ret;