X-Git-Url: http://git.indexdata.com/?a=blobdiff_plain;f=src%2Fpazpar2_config.c;h=dfb4509d63f903f26360e9b367010196155a8a09;hb=f7247294488509fca6dc8e0d32f63cd8ae51b555;hp=7340512b56f842c362040a5063e2dba5136d8f09;hpb=ff90a10d56bd25ce276eab48c5cebfe7e7324f70;p=pazpar2-moved-to-github.git diff --git a/src/pazpar2_config.c b/src/pazpar2_config.c index 7340512..dfb4509 100644 --- a/src/pazpar2_config.c +++ b/src/pazpar2_config.c @@ -22,6 +22,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA #endif #include +#include #include #include @@ -68,21 +69,19 @@ static char *parse_settings(struct conf_config *config, static struct conf_targetprofiles *parse_targetprofiles(NMEM nmem, xmlNode *node); -static -struct conf_metadata * conf_metadata_assign(NMEM nmem, - struct conf_metadata * metadata, - const char *name, - enum conf_metadata_type type, - enum conf_metadata_merge merge, - enum conf_setting_type setting, - int brief, - int termlist, - int rank, - int sortkey_offset, - enum conf_metadata_mergekey mt) +static void conf_metadata_assign(NMEM nmem, + struct conf_metadata * metadata, + const char *name, + enum conf_metadata_type type, + enum conf_metadata_merge merge, + enum conf_setting_type setting, + int brief, + int termlist, + int rank, + int sortkey_offset, + enum conf_metadata_mergekey mt) { - if (!nmem || !metadata || !name) - return 0; + assert(nmem && metadata && name); metadata->name = nmem_strdup(nmem, name); @@ -100,35 +99,28 @@ struct conf_metadata * conf_metadata_assign(NMEM nmem, metadata->rank = rank; metadata->sortkey_offset = sortkey_offset; metadata->mergekey = mt; - return metadata; } -static -struct conf_sortkey * conf_sortkey_assign(NMEM nmem, - struct conf_sortkey * sortkey, - const char *name, - enum conf_sortkey_type type) +static void conf_sortkey_assign(NMEM nmem, + struct conf_sortkey * sortkey, + const char *name, + enum conf_sortkey_type type) { - if (!nmem || !sortkey || !name) - return 0; + assert(nmem && sortkey && name); sortkey->name = nmem_strdup(nmem, name); sortkey->type = type; - - return sortkey; } -struct conf_service * conf_service_create(struct conf_config *config, - int num_metadata, int num_sortkeys, - const char *service_id) +static struct conf_service *service_init(struct conf_config *config, + int num_metadata, int num_sortkeys, + const char *service_id) { struct conf_service * service = 0; NMEM nmem = nmem_create(); - //assert(nmem); - service = nmem_malloc(nmem, sizeof(struct conf_service)); service->nmem = nmem; service->next = 0; @@ -136,6 +128,13 @@ struct conf_service * conf_service_create(struct conf_config *config, service->databases = 0; service->targetprofiles = 0; service->config = config; + service->session_timeout = 60; /* default session timeout */ + service->z3950_session_timeout = 180; + service->z3950_connect_timeout = 15; + + service->relevance_pct = 0; + service->sort_pct = 0; + service->mergekey_pct = 0; service->id = service_id ? nmem_strdup(nmem, service_id) : 0; service->num_metadata = num_metadata; @@ -154,17 +153,18 @@ struct conf_service * conf_service_create(struct conf_config *config, return service; } -struct conf_metadata* conf_service_add_metadata(struct conf_service *service, - int field_id, - const char *name, - enum conf_metadata_type type, - enum conf_metadata_merge merge, - enum conf_setting_type setting, - int brief, - int termlist, - int rank, - int sortkey_offset, - enum conf_metadata_mergekey mt) +static struct conf_metadata* conf_service_add_metadata( + struct conf_service *service, + int field_id, + const char *name, + enum conf_metadata_type type, + enum conf_metadata_merge merge, + enum conf_setting_type setting, + int brief, + int termlist, + int rank, + int sortkey_offset, + enum conf_metadata_mergekey mt) { struct conf_metadata * md = 0; @@ -172,19 +172,19 @@ struct conf_metadata* conf_service_add_metadata(struct conf_service *service, || field_id < 0 || !(field_id < service->num_metadata)) return 0; - //md = &((service->metadata)[field_id]); md = service->metadata + field_id; - md = conf_metadata_assign(service->nmem, md, name, type, merge, setting, - brief, termlist, rank, sortkey_offset, - mt); + conf_metadata_assign(service->nmem, md, name, type, merge, setting, + brief, termlist, rank, sortkey_offset, + mt); return md; } -struct conf_sortkey * conf_service_add_sortkey(struct conf_service *service, - int field_id, - const char *name, - enum conf_sortkey_type type) +static struct conf_sortkey * conf_service_add_sortkey( + struct conf_service *service, + int field_id, + const char *name, + enum conf_sortkey_type type) { struct conf_sortkey * sk = 0; @@ -194,7 +194,7 @@ struct conf_sortkey * conf_service_add_sortkey(struct conf_service *service, //sk = &((service->sortkeys)[field_id]); sk = service->sortkeys + field_id; - sk = conf_sortkey_assign(service->nmem, sk, name, type); + conf_sortkey_assign(service->nmem, sk, name, type); return sk; } @@ -255,8 +255,180 @@ static void service_destroy(struct conf_service *service) } } +static int parse_metadata(struct conf_service *service, xmlNode *n, + int *md_node, int *sk_node) +{ + xmlChar *xml_name = xmlGetProp(n, (xmlChar *) "name"); + xmlChar *xml_brief = xmlGetProp(n, (xmlChar *) "brief"); + xmlChar *xml_sortkey = xmlGetProp(n, (xmlChar *) "sortkey"); + xmlChar *xml_merge = xmlGetProp(n, (xmlChar *) "merge"); + xmlChar *xml_type = xmlGetProp(n, (xmlChar *) "type"); + xmlChar *xml_termlist = xmlGetProp(n, (xmlChar *) "termlist"); + xmlChar *xml_rank = xmlGetProp(n, (xmlChar *) "rank"); + xmlChar *xml_setting = xmlGetProp(n, (xmlChar *) "setting"); + xmlChar *xml_mergekey = xmlGetProp(n, (xmlChar *) "mergekey"); + + enum conf_metadata_type type = Metadata_type_generic; + enum conf_metadata_merge merge = Metadata_merge_no; + enum conf_setting_type setting = Metadata_setting_no; + enum conf_sortkey_type sk_type = Metadata_sortkey_relevance; + enum conf_metadata_mergekey mergekey_type = Metadata_mergekey_no; + int brief = 0; + int termlist = 0; + int rank = 0; + int sortkey_offset = 0; + + // now do the parsing logic + if (!xml_name) + { + yaz_log(YLOG_FATAL, "Must specify name in metadata element"); + return -1; + } + if (xml_brief) + { + if (!strcmp((const char *) xml_brief, "yes")) + brief = 1; + else if (strcmp((const char *) xml_brief, "no")) + { + yaz_log(YLOG_FATAL, "metadata/brief must be yes or no"); + return -1; + } + } + else + brief = 0; + + if (xml_termlist) + { + if (!strcmp((const char *) xml_termlist, "yes")) + termlist = 1; + else if (strcmp((const char *) xml_termlist, "no")) + { + yaz_log(YLOG_FATAL, "metadata/termlist must be yes or no"); + return -1; + } + } + else + termlist = 0; + + if (xml_rank) + rank = atoi((const char *) xml_rank); + else + rank = 0; + + if (xml_type) + { + if (!strcmp((const char *) xml_type, "generic")) + type = Metadata_type_generic; + else if (!strcmp((const char *) xml_type, "year")) + type = Metadata_type_year; + else if (!strcmp((const char *) xml_type, "date")) + type = Metadata_type_date; + else + { + yaz_log(YLOG_FATAL, + "Unknown value for metadata/type: %s", xml_type); + return -1; + } + } + else + type = Metadata_type_generic; + + if (xml_merge) + { + if (!strcmp((const char *) xml_merge, "no")) + merge = Metadata_merge_no; + else if (!strcmp((const char *) xml_merge, "unique")) + merge = Metadata_merge_unique; + else if (!strcmp((const char *) xml_merge, "longest")) + merge = Metadata_merge_longest; + else if (!strcmp((const char *) xml_merge, "range")) + merge = Metadata_merge_range; + else if (!strcmp((const char *) xml_merge, "all")) + merge = Metadata_merge_all; + else + { + yaz_log(YLOG_FATAL, + "Unknown value for metadata/merge: %s", xml_merge); + return -1; + } + } + else + merge = Metadata_merge_no; + + if (xml_setting) + { + if (!strcmp((const char *) xml_setting, "no")) + setting = Metadata_setting_no; + else if (!strcmp((const char *) xml_setting, "postproc")) + setting = Metadata_setting_postproc; + else if (!strcmp((const char *) xml_setting, "parameter")) + setting = Metadata_setting_parameter; + else + { + yaz_log(YLOG_FATAL, + "Unknown value for medadata/setting: %s", xml_setting); + return -1; + } + } + + // add a sortkey if so specified + if (xml_sortkey && strcmp((const char *) xml_sortkey, "no")) + { + if (merge == Metadata_merge_no) + { + yaz_log(YLOG_FATAL, + "Can't specify sortkey on a non-merged field"); + return -1; + } + if (!strcmp((const char *) xml_sortkey, "numeric")) + sk_type = Metadata_sortkey_numeric; + else if (!strcmp((const char *) xml_sortkey, "skiparticle")) + sk_type = Metadata_sortkey_skiparticle; + else + { + yaz_log(YLOG_FATAL, + "Unknown sortkey in metadata element: %s", + xml_sortkey); + return -1; + } + sortkey_offset = *sk_node; + + conf_service_add_sortkey(service, *sk_node, + (const char *) xml_name, sk_type); + + (*sk_node)++; + } + else + sortkey_offset = -1; + + if (xml_mergekey && strcmp((const char *) xml_mergekey, "no")) + { + mergekey_type = Metadata_mergekey_yes; + } + + + // metadata known, assign values + conf_service_add_metadata(service, *md_node, + (const char *) xml_name, + type, merge, setting, + brief, termlist, rank, sortkey_offset, + mergekey_type); + + xmlFree(xml_name); + xmlFree(xml_brief); + xmlFree(xml_sortkey); + xmlFree(xml_merge); + xmlFree(xml_type); + xmlFree(xml_termlist); + xmlFree(xml_rank); + xmlFree(xml_setting); + (*md_node)++; + return 0; +} + static struct conf_service *service_create(struct conf_config *config, - xmlNode *node, const char *service_id) + xmlNode *node, + const char *service_id) { xmlNode *n; int md_node = 0; @@ -265,6 +437,7 @@ static struct conf_service *service_create(struct conf_config *config, struct conf_service *service = 0; int num_metadata = 0; int num_sortkeys = 0; + int got_settings = 0; // count num_metadata and num_sortkeys for (n = node->children; n; n = n->next) @@ -278,24 +451,50 @@ static struct conf_service *service_create(struct conf_config *config, xmlFree(sortkey); } - service = conf_service_create(config, - num_metadata, num_sortkeys, service_id); + service = service_init(config, num_metadata, num_sortkeys, service_id); for (n = node->children; n; n = n->next) { if (n->type != XML_ELEMENT_NODE) continue; - if (!strcmp((const char *) n->name, "settings")) + if (!strcmp((const char *) n->name, "timeout")) { - if (service->settings) + xmlChar *src = xmlGetProp(n, (xmlChar *) "session"); + if (src) { - yaz_log(YLOG_FATAL, "Can't repeat 'settings'"); - return 0; + service->session_timeout = atoi((const char *) src); + xmlFree(src); + if (service->session_timeout < 9) + { + yaz_log(YLOG_FATAL, "session timeout out of range"); + return 0; + } + } + src = xmlGetProp(n, (xmlChar *) "z3950_connect"); + if (src) + { + service->z3950_connect_timeout = atoi((const char *) src); + xmlFree(src); + if (service->z3950_session_timeout < 9) + { + yaz_log(YLOG_FATAL, "Z39.50 connect timeout out of range"); + return 0; + } + } + src = xmlGetProp(n, (xmlChar *) "z3950_session"); + if (src) + { + service->z3950_session_timeout = atoi((const char *) src); + xmlFree(src); + if (service->z3950_session_timeout < 9) + { + yaz_log(YLOG_FATAL, "Z39.50 session timeout out of range"); + return 0; + } } - service->settings = parse_settings(config, service->nmem, n); - if (!service->settings) - return 0; } + else if (!strcmp((const char *) n->name, "settings")) + got_settings++; else if (!strcmp((const char *) n->name, (const char *) "targetprofiles")) { if (service->targetprofiles) @@ -307,173 +506,52 @@ static struct conf_service *service_create(struct conf_config *config, parse_targetprofiles(service->nmem, n))) return 0; } - else if (!strcmp((const char *) n->name, (const char *) "metadata")) + else if (!strcmp((const char *) n->name, "relevance")) { - xmlChar *xml_name = xmlGetProp(n, (xmlChar *) "name"); - xmlChar *xml_brief = xmlGetProp(n, (xmlChar *) "brief"); - xmlChar *xml_sortkey = xmlGetProp(n, (xmlChar *) "sortkey"); - xmlChar *xml_merge = xmlGetProp(n, (xmlChar *) "merge"); - xmlChar *xml_type = xmlGetProp(n, (xmlChar *) "type"); - xmlChar *xml_termlist = xmlGetProp(n, (xmlChar *) "termlist"); - xmlChar *xml_rank = xmlGetProp(n, (xmlChar *) "rank"); - xmlChar *xml_setting = xmlGetProp(n, (xmlChar *) "setting"); - xmlChar *xml_mergekey = xmlGetProp(n, (xmlChar *) "mergekey"); - - enum conf_metadata_type type = Metadata_type_generic; - enum conf_metadata_merge merge = Metadata_merge_no; - enum conf_setting_type setting = Metadata_setting_no; - enum conf_sortkey_type sk_type = Metadata_sortkey_relevance; - enum conf_metadata_mergekey mergekey_type = Metadata_mergekey_no; - int brief = 0; - int termlist = 0; - int rank = 0; - int sortkey_offset = 0; - - // now do the parsing logic - if (!xml_name) + if (service->relevance_pct) { - yaz_log(YLOG_FATAL, "Must specify name in metadata element"); + yaz_log(YLOG_LOG, "relevance may not repeat in service"); return 0; } - if (xml_brief) - { - if (!strcmp((const char *) xml_brief, "yes")) - brief = 1; - else if (strcmp((const char *) xml_brief, "no")) - { - yaz_log(YLOG_FATAL, "metadata/brief must be yes or no"); - return 0; - } - } else - brief = 0; - - if (xml_termlist) { - if (!strcmp((const char *) xml_termlist, "yes")) - termlist = 1; - else if (strcmp((const char *) xml_termlist, "no")) - { - yaz_log(YLOG_FATAL, "metadata/termlist must be yes or no"); + service->relevance_pct = pp2_charset_create_xml(n); + if (!service->relevance_pct) return 0; - } } - else - termlist = 0; - - if (xml_rank) - rank = atoi((const char *) xml_rank); - else - rank = 0; - - if (xml_type) - { - if (!strcmp((const char *) xml_type, "generic")) - type = Metadata_type_generic; - else if (!strcmp((const char *) xml_type, "year")) - type = Metadata_type_year; - else if (!strcmp((const char *) xml_type, "date")) - type = Metadata_type_date; - else - { - yaz_log(YLOG_FATAL, - "Unknown value for metadata/type: %s", xml_type); - return 0; - } - } - else - type = Metadata_type_generic; - - if (xml_merge) + } + else if (!strcmp((const char *) n->name, "sort")) + { + if (service->sort_pct) { - if (!strcmp((const char *) xml_merge, "no")) - merge = Metadata_merge_no; - else if (!strcmp((const char *) xml_merge, "unique")) - merge = Metadata_merge_unique; - else if (!strcmp((const char *) xml_merge, "longest")) - merge = Metadata_merge_longest; - else if (!strcmp((const char *) xml_merge, "range")) - merge = Metadata_merge_range; - else if (!strcmp((const char *) xml_merge, "all")) - merge = Metadata_merge_all; - else - { - yaz_log(YLOG_FATAL, - "Unknown value for metadata/merge: %s", xml_merge); - return 0; - } + yaz_log(YLOG_LOG, "sort may not repeat in service"); + return 0; } else - merge = Metadata_merge_no; - - if (xml_setting) { - if (!strcmp((const char *) xml_setting, "no")) - setting = Metadata_setting_no; - else if (!strcmp((const char *) xml_setting, "postproc")) - setting = Metadata_setting_postproc; - else if (!strcmp((const char *) xml_setting, "parameter")) - setting = Metadata_setting_parameter; - else - { - yaz_log(YLOG_FATAL, - "Unknown value for medadata/setting: %s", xml_setting); + service->sort_pct = pp2_charset_create_xml(n); + if (!service->sort_pct) return 0; - } } - - // add a sortkey if so specified - if (xml_sortkey && strcmp((const char *) xml_sortkey, "no")) + } + else if (!strcmp((const char *) n->name, "mergekey")) + { + if (service->mergekey_pct) { - if (merge == Metadata_merge_no) - { - yaz_log(YLOG_FATAL, - "Can't specify sortkey on a non-merged field"); - return 0; - } - if (!strcmp((const char *) xml_sortkey, "numeric")) - sk_type = Metadata_sortkey_numeric; - else if (!strcmp((const char *) xml_sortkey, "skiparticle")) - sk_type = Metadata_sortkey_skiparticle; - else - { - yaz_log(YLOG_FATAL, - "Unknown sortkey in metadata element: %s", - xml_sortkey); - return 0; - } - sortkey_offset = sk_node; - - conf_service_add_sortkey(service, sk_node, - (const char *) xml_name, sk_type); - - sk_node++; + yaz_log(YLOG_LOG, "mergekey may not repeat in service"); + return 0; } else - sortkey_offset = -1; - - if (xml_mergekey && strcmp((const char *) xml_mergekey, "no")) { - mergekey_type = Metadata_mergekey_yes; + service->mergekey_pct = pp2_charset_create_xml(n); + if (!service->mergekey_pct) + return 0; } - - - // metadata known, assign values - conf_service_add_metadata(service, md_node, - (const char *) xml_name, - type, merge, setting, - brief, termlist, rank, sortkey_offset, - mergekey_type); - - xmlFree(xml_name); - xmlFree(xml_brief); - xmlFree(xml_sortkey); - xmlFree(xml_merge); - xmlFree(xml_type); - xmlFree(xml_termlist); - xmlFree(xml_rank); - xmlFree(xml_setting); - md_node++; + } + else if (!strcmp((const char *) n->name, (const char *) "metadata")) + { + if (parse_metadata(service, n, &md_node, &sk_node)) + return 0; } else { @@ -481,6 +559,36 @@ static struct conf_service *service_create(struct conf_config *config, return 0; } } + if (got_settings) + { + int pass; + /* metadata has been read.. Consider now settings */ + init_settings(service); + for (pass = 1; pass <= 2; pass++) + { + for (n = node->children; n; n = n->next) + { + if (n->type != XML_ELEMENT_NODE) + continue; + if (!strcmp((const char *) n->name, "settings")) + { + xmlChar *src = xmlGetProp(n, (xmlChar *) "src"); + if (src) + { + WRBUF w = wrbuf_alloc(); + conf_dir_path(config, w, (const char *) src); + settings_read_file(service, wrbuf_cstr(w), pass); + wrbuf_destroy(w); + xmlFree(src); + } + else + { + settings_read_node(service, n, pass); + } + } + } + } + } return service; } @@ -506,8 +614,67 @@ static char *parse_settings(struct conf_config *config, return r; } -static struct conf_server *parse_server(struct conf_config *config, - NMEM nmem, xmlNode *node) +static void inherit_server_settings(struct conf_server *server) +{ + struct conf_service *s; + for (s = server->service; s; s = s->next) + { + if (!s->dictionary) /* service has no config settings ? */ + { + if (server->server_settings) + { + /* inherit settings from server */ + init_settings(s); + settings_read_file(s, server->server_settings, 1); + settings_read_file(s, server->server_settings, 2); + } + else + { + yaz_log(YLOG_WARN, "service '%s' has no settings", + s->id ? s->id : "unnamed"); + init_settings(s); + } + } + + /* use relevance/sort/mergekey from server if not defined + for this service.. */ + if (!s->relevance_pct) + { + if (server->relevance_pct) + { + s->relevance_pct = server->relevance_pct; + pp2_charset_incref(s->relevance_pct); + } + else + s->relevance_pct = pp2_charset_create(0); + } + + if (!s->sort_pct) + { + if (server->sort_pct) + { + s->sort_pct = server->sort_pct; + pp2_charset_incref(s->sort_pct); + } + else + s->sort_pct = pp2_charset_create(0); + } + + if (!s->mergekey_pct) + { + if (server->mergekey_pct) + { + s->mergekey_pct = server->mergekey_pct; + pp2_charset_incref(s->mergekey_pct); + } + else + s->mergekey_pct = pp2_charset_create(0); + } + } +} + +static struct conf_server *server_create(struct conf_config *config, + NMEM nmem, xmlNode *node) { xmlNode *n; struct conf_server *server = nmem_malloc(nmem, sizeof(struct conf_server)); @@ -520,10 +687,10 @@ static struct conf_server *parse_server(struct conf_config *config, server->proxy_addr = 0; server->service = 0; server->next = 0; - server->server_settings = 0; server->relevance_pct = 0; server->sort_pct = 0; server->mergekey_pct = 0; + server->server_settings = 0; for (n = node->children; n; n = n->next) { @@ -598,45 +765,25 @@ static struct conf_server *parse_server(struct conf_config *config, } else if (!(*sp)->id && !service_id) { - yaz_log(YLOG_FATAL, "Duplicate unnamed service"); + yaz_log(YLOG_FATAL, "Duplicate unnamed service '%s'", + service_id); break; } if (*sp) /* service already exist */ + { + xmlFree(service_id); return 0; + } else { - struct conf_service *s = service_create(config, n, service_id); - if (s) - { - if (server->relevance_pct) - { - s->relevance_pct = server->relevance_pct; - pp2_charset_incref(s->relevance_pct); - } - else - s->relevance_pct = pp2_charset_create(0); - - if (server->sort_pct) - { - - s->sort_pct = server->sort_pct; - pp2_charset_incref(s->sort_pct); - } - else - s->sort_pct = pp2_charset_create(0); - - if (server->mergekey_pct) - { - s->mergekey_pct = server->mergekey_pct; - pp2_charset_incref(s->mergekey_pct); - } - else - s->mergekey_pct = pp2_charset_create(0); - *sp = s; - } + struct conf_service *s = service_create(config, n, + service_id); + xmlFree(service_id); + if (!s) + return 0; + *sp = s; } - xmlFree(service_id); } else { @@ -644,6 +791,7 @@ static struct conf_server *parse_server(struct conf_config *config, return 0; } } + inherit_server_settings(server); return server; } @@ -719,7 +867,7 @@ static int parse_config(struct conf_config *config, xmlNode *root) continue; if (!strcmp((const char *) n->name, "server")) { - struct conf_server *tmp = parse_server(config, config->nmem, n); + struct conf_server *tmp = server_create(config, config->nmem, n); if (!tmp) return -1; tmp->next = config->servers; @@ -756,7 +904,6 @@ static int config_include_one(struct conf_config *config, xmlNode **sib, if ((st.st_mode & S_IFMT) == S_IFREG) { xmlDoc *doc = xmlParseFile(path); - yaz_log(YLOG_LOG, "processing include path=%s", path); if (doc) { xmlNodePtr t = xmlDocGetRootElement(doc); @@ -863,6 +1010,7 @@ struct conf_config *config_create(const char *fname, int verbose) if (!doc) { yaz_log(YLOG_FATAL, "Failed to read %s", fname); + nmem_destroy(nmem); return 0; } @@ -935,31 +1083,26 @@ void config_destroy(struct conf_config *config) } } -void config_read_settings(struct conf_config *config) +void config_stop_listeners(struct conf_config *conf) { - struct conf_service *s = config->servers->service; - for (;s ; s = s->next) - { - init_settings(s); - if (s->settings) - settings_read(s, s->settings); - else if (config->servers->server_settings) - settings_read(s, config->servers->server_settings); - else - yaz_log(YLOG_WARN, "No settings for service"); - } + struct conf_server *ser; + for (ser = conf->servers; ser; ser = ser->next) + http_close_server(ser); } -void config_stop_listeners(struct conf_config *conf) +void config_start_databases(struct conf_config *conf) { struct conf_server *ser; for (ser = conf->servers; ser; ser = ser->next) - http_close_server(ser); + { + struct conf_service *s = ser->service; + for (;s ; s = s->next) + resolve_databases(s); + } } int config_start_listeners(struct conf_config *conf, - const char *listener_override, - const char *proxy_override) + const char *listener_override) { struct conf_server *ser; for (ser = conf->servers; ser; ser = ser->next) @@ -988,9 +1131,7 @@ int config_start_listeners(struct conf_config *conf, return -1; w = wrbuf_alloc(); - if (proxy_override) - wrbuf_puts(w, proxy_override); - else if (ser->proxy_host || ser->proxy_port) + if (ser->proxy_host || ser->proxy_port) { if (ser->proxy_host) wrbuf_puts(w, ser->proxy_host);