X-Git-Url: http://git.indexdata.com/?a=blobdiff_plain;f=src%2Fmkws-filter.js;h=7d9fac06672e02ca220922301fb8d0a6bd210805;hb=fea2b711c389ba5f31aed757622fe268b7084768;hp=02ce4223f71ad244099ef94cc138bc2a3bb6e8b9;hpb=242978c76db07a1f1f72a6f02c7b0e03bc6eb365;p=mkws-moved-to-github.git

diff --git a/src/mkws-filter.js b/src/mkws-filter.js
index 02ce422..7d9fac0 100644
--- a/src/mkws-filter.js
+++ b/src/mkws-filter.js
@@ -16,7 +16,7 @@ function filterSet(team) {
     that.visitTargets = function(callback) {
 	for (var i in m_list) {
 	    var filter = m_list[i];
-	    if (filter.id) {
+	    if (filter.type === 'target') {
 		callback(filter.id, filter.name);
 	    }
 	}
@@ -25,7 +25,7 @@ function filterSet(team) {
     that.visitFields = function(callback) {
 	for (var i in m_list) {
 	    var filter = m_list[i];
-	    if (!filter.id) {
+	    if (filter.type === 'field') {
 		callback(filter.field, filter.value);
 	    }
 	}
@@ -47,7 +47,7 @@ function filterSet(team) {
 
     that.targetFiltered = function(id) {
 	for (var i = 0; i < m_list.length; i++) {
-	    if (m_list[i].id === id ||
+	    if (m_list[i].type === 'target' ||
 		m_list[i].id === 'pz:id=' + id) {
 		return true;
 	    }
@@ -56,34 +56,6 @@ function filterSet(team) {
     };
 
     that.pp2filter = function() {
-	var OLD = that.OLD_pp2filter();
-	var NEW = that.NEW_pp2filter();
-	if (OLD !== NEW) {
-	    alert("pp2filter(): OLD[" + OLD + "] !== NEW[" + NEW + "]");
-	}
-	return OLD;
-    };
-
-    that.OLD_pp2filter = function() {
-	var res = "";
-
-	for (var i in m_list) {
-	    var filter = m_list[i];
-	    if (filter.id) {
-		if (res) res += ",";
-		if (filter.id.match(/^[a-z:]+[=~]/)) {
-		    m_team.log("filter '" + filter.id + "' already begins with SETTING OP");
-		} else {
-		    filter.id = 'pz:id=' + filter.id;
-		}
-		res += filter.id;
-	    }
-	}
-
-	return res;
-    };
-
-    that.NEW_pp2filter = function() {
 	var res = "";
 
 	that.visitTargets(function(id, name) {
@@ -102,31 +74,37 @@ function filterSet(team) {
     that.pp2limit = function(initial) {
 	var res = initial || "";
 
-	for (var i in m_list) {
-	    var filter = m_list[i];
-	    if (!filter.id) {
-		if (res) res += ",";
-		res += filter.field + "=" + filter.value.replace(/[\\|,]/g, '\\$&');
-	    }
-	}
-
+	that.visitFields(function(field, value) {
+	    if (res) res += ",";
+	    res += field + "=" + value.replace(/[\\|,]/g, '\\$&');
+	});
 	return res;
-    };
-
+    }
 
     return that;
 }
 
 
-// Factory function for filters. These can be of several types.
-function filter(id, name, field, value) {
-    var res;
+// Factory functions for filters. These can be of several types.
+function targetFilter(id, name) {
+    return {
+        type: 'target',
+        id: id,
+        name: name
+    };
+}
 
-    if (id) {
-	res = { id: id, name: name };
-    } else {
-	res = { field: field, value: value };
-    }
+function fieldFilter(field, value) {
+    return {
+        type: 'field',
+        field: field,
+        value: value
+    };
+}
 
-    return res;
+function categoryFilter(id) {
+    return {
+        type: 'category',
+        id: id,
+    };
 }