X-Git-Url: http://git.indexdata.com/?a=blobdiff_plain;f=src%2Fconnection.c;h=2da26d2a281b8e1ce85296782589112d31825bbe;hb=387e0c30975f80b60770158145f619d25265828f;hp=79eb40e5809c2e7e9785974d3b8bb42b2803b20a;hpb=4153b0ad5760dbcc7e0fb1d370f403c133b18e25;p=pazpar2-moved-to-github.git diff --git a/src/connection.c b/src/connection.c index 79eb40e..2da26d2 100644 --- a/src/connection.c +++ b/src/connection.c @@ -207,10 +207,14 @@ static void non_block_events(struct connection *co) { yaz_log(YLOG_LOG, "Error %s from %s", error, client_get_url(cl)); + client_set_diagnostic(cl, err); + client_set_state(cl, Client_Error); + } + else + { + iochan_settimeout(iochan, co->session_timeout); + client_set_state(cl, Client_Idle); } - iochan_settimeout(iochan, co->session_timeout); - client_set_diagnostic(cl, err); - client_set_state(cl, Client_Idle); yaz_cond_broadcast(co->host->cond_ready); } break; @@ -287,15 +291,11 @@ static void connection_handler(IOCHAN iochan, int event) client_set_state(cl, Client_Error); connection_destroy(co); } - else if (client_get_state(co->client) == Client_Idle) + else { yaz_log(YLOG_LOG, "idle timeout %s", client_get_url(cl)); connection_destroy(co); } - else - { - yaz_log(YLOG_LOG, "ignore timeout %s", client_get_url(cl)); - } yaz_mutex_leave(host->mutex); } else @@ -435,7 +435,7 @@ static int connection_connect(struct connection *con, iochan_man_t iochan_man) ZOOM_connection_connect(link, host->ipport, 0); con->link = link; - con->iochan = iochan_create(0, connection_handler, 0, "connection_socket"); + con->iochan = iochan_create(-1, connection_handler, 0, "connection_socket"); con->state = Conn_Connecting; iochan_settimeout(con->iochan, con->operation_timeout); iochan_setdata(con->iochan, con); @@ -471,11 +471,17 @@ int client_prep_connection(struct client *cl, if (!co) { int max_connections = 0; + int reuse_connections = 1; const char *v = session_setting_oneval(client_get_database(cl), PZ_MAX_CONNECTIONS); if (v && *v) max_connections = atoi(v); - + + v = session_setting_oneval(client_get_database(cl), + PZ_REUSE_CONNECTIONS); + if (v && *v) + reuse_connections = atoi(v); + // See if someone else has an idle connection // We should look at timestamps here to select the longest-idle connection yaz_mutex_enter(host->mutex); @@ -484,25 +490,26 @@ int client_prep_connection(struct client *cl, int num_connections = 0; for (co = host->connections; co; co = co->next) num_connections++; - for (co = host->connections; co; co = co->next) - { - if (connection_is_idle(co) && - (!co->client || client_get_state(co->client) == Client_Idle) && - !strcmp(ZOOM_connection_option_get(co->link, "user"), - session_setting_oneval(client_get_database(cl), - PZ_AUTHENTICATION))) + if (reuse_connections) { + for (co = host->connections; co; co = co->next) { - if (zproxy == 0 && co->zproxy == 0) - break; - if (zproxy && co->zproxy && !strcmp(zproxy, co->zproxy)) - break; + if (connection_is_idle(co) && + (!co->client || client_get_state(co->client) == Client_Idle) && + !strcmp(ZOOM_connection_option_get(co->link, "user"), + session_setting_oneval(client_get_database(cl), + PZ_AUTHENTICATION))) + { + if (zproxy == 0 && co->zproxy == 0) + break; + if (zproxy && co->zproxy && !strcmp(zproxy, co->zproxy)) + break; + } + } + if (co) + { + yaz_log(YLOG_LOG, "num_connections = %d (reusing)", num_connections); + break; } - } - if (co) - { - yaz_log(YLOG_LOG, "num_connections = %d (reusing)", - num_connections); - break; } if (max_connections <= 0 || num_connections < max_connections) {