X-Git-Url: http://git.indexdata.com/?a=blobdiff_plain;f=src%2Fconfig.c;h=d4fa7c1ccfa8cc7f1b8e928a817f7e9a82b8a64b;hb=f0f51e820f69d1661b94da14424b4109c16ab7bd;hp=3ceb42715b17e4020def9aa1ecf8200c5190cf77;hpb=a0ab03d89e0cafbea99f29a0d10134e4f1212785;p=pazpar2-moved-to-github.git

diff --git a/src/config.c b/src/config.c
index 3ceb427..d4fa7c1 100644
--- a/src/config.c
+++ b/src/config.c
@@ -1,4 +1,25 @@
-/* $Id: config.c,v 1.13 2007-01-15 16:56:51 quinn Exp $ */
+/* $Id: config.c,v 1.30 2007-04-23 12:33:00 marc Exp $
+   Copyright (c) 2006-2007, Index Data.
+
+This file is part of Pazpar2.
+
+Pazpar2 is free software; you can redistribute it and/or modify it under
+the terms of the GNU General Public License as published by the Free
+Software Foundation; either version 2, or (at your option) any later
+version.
+
+Pazpar2 is distributed in the hope that it will be useful, but WITHOUT ANY
+WARRANTY; without even the implied warranty of MERCHANTABILITY or
+FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
+for more details.
+
+You should have received a copy of the GNU General Public License
+along with Pazpar2; see the file LICENSE.  If not, write to the
+Free Software Foundation, 59 Temple Place - Suite 330, Boston, MA
+02111-1307, USA.
+ */
+
+/* $Id: config.c,v 1.30 2007-04-23 12:33:00 marc Exp $ */
 
 #include <string.h>
 
@@ -23,154 +44,315 @@ static char confdir[256] = ".";
 
 struct conf_config *config = 0;
 
+
+struct conf_metadata * conf_metadata_assign(NMEM nmem, 
+                                            struct conf_metadata * metadata,
+                                            const char *name,
+                                            enum conf_metadata_type type,
+                                            enum conf_metadata_merge merge,
+                                            int brief,
+                                            int termlist,
+                                            int rank,
+                                            int sortkey_offset)
+{
+    if (!nmem || !metadata || !name)
+        return 0;
+    
+    metadata->name = nmem_strdup(nmem, name);
+    metadata->type = type;
+    metadata->merge = merge;
+    metadata->brief = brief;   
+    metadata->termlist = termlist;
+    metadata->rank = rank;    
+    metadata->sortkey_offset = sortkey_offset;
+
+    return metadata;
+}
+
+
+struct conf_sortkey * conf_sortkey_assign(NMEM nmem, 
+                                          struct conf_sortkey * sortkey,
+                                          const char *name,
+                                          enum conf_sortkey_type type)
+{
+    if (!nmem || !sortkey || !name)
+        return 0;
+    
+    sortkey->name = nmem_strdup(nmem, name);
+    sortkey->type = type;
+
+    return sortkey;
+}
+
+
+struct conf_service * conf_service_create(NMEM nmem,
+                                          int num_metadata, int num_sortkeys)
+{
+    struct conf_service * service = 0;
+
+    //assert(nmem);
+    
+    service = nmem_malloc(nmem, sizeof(struct conf_service));
+
+    service->num_metadata = num_metadata;
+    service->metadata = 0;
+    if (service->num_metadata)
+      service->metadata 
+          = nmem_malloc(nmem, 
+                        sizeof(struct conf_metadata) * service->num_metadata);
+    service->num_sortkeys = num_sortkeys;
+    service->sortkeys = 0;
+    if (service->num_sortkeys)
+        service->sortkeys 
+            = nmem_malloc(nmem, 
+                          sizeof(struct conf_sortkey) * service->num_sortkeys);
+    return service; 
+}
+
+struct conf_metadata* conf_service_add_metadata(NMEM nmem, 
+                                                struct conf_service *service,
+                                                int position,
+                                                const char *name,
+                                                enum conf_metadata_type type,
+                                                enum conf_metadata_merge merge,
+                                                int brief,
+                                                int termlist,
+                                                int rank,
+                                                int sortkey_offset)
+{
+    struct conf_metadata * md = 0;
+
+    if (!service || !service->metadata || !service->num_metadata
+        || position < 0  || !(position < service->num_metadata))
+        return 0;
+
+    //md = &((service->metadata)[position]);
+    md = service->metadata + position;
+    md = conf_metadata_assign(nmem, md, name, type, merge, 
+                             brief, termlist, rank, sortkey_offset);
+    return md;
+}
+
+
+struct conf_sortkey * conf_service_add_sortkey(NMEM nmem,
+                                               struct conf_service *service,
+                                               int position,
+                                               const char *name,
+                                               enum conf_sortkey_type type)
+{
+    struct conf_sortkey * sk = 0;
+
+    if (!service || !service->sortkeys || !service->num_sortkeys
+        || position < 0  || !(position < service->num_sortkeys))
+        return 0;
+
+    //sk = &((service->sortkeys)[position]);
+    sk = service->sortkeys + position;
+    sk = conf_sortkey_assign(nmem, sk, name, type);
+
+    return sk;
+}
+
+
+int conf_service_metadata_field_id(struct conf_service *service, const char * name)
+{
+    int i = 0;
+
+    if (!service || !service->metadata || !service->num_metadata)
+        return -1;
+
+    for(i = 0; i < service->num_metadata; i++) {
+        if (!strcmp(name, (service->metadata[i]).name))
+            return i;
+    }
+   
+    return -1;
+};
+
+
+int conf_service_sortkey_field_id(struct conf_service *service, const char * name)
+{
+    int i = 0;
+
+    if (!service || !service->sortkeys || !service->num_sortkeys)
+        return -1;
+
+    for(i = 0; i < service->num_sortkeys; i++) {
+        if (!strcmp(name, (service->sortkeys[i]).name))
+            return i;
+    }
+   
+    return -1;
+};
+
+
+
 /* Code to parse configuration file */
 /* ==================================================== */
 
 static struct conf_service *parse_service(xmlNode *node)
 {
     xmlNode *n;
-    struct conf_service *r = nmem_malloc(nmem, sizeof(struct conf_service));
     int md_node = 0;
     int sk_node = 0;
 
-    r->num_sortkeys = r->num_metadata = 0;
-    // Allocate array of conf metadata and sortkey tructs, if necessary
+    struct conf_service *service = 0;
+    int num_metadata = 0;
+    int num_sortkeys = 0;
+    
+    // count num_metadata and num_sortkeys
     for (n = node->children; n; n = n->next)
-        if (n->type == XML_ELEMENT_NODE && !strcmp(n->name, "metadata"))
+        if (n->type == XML_ELEMENT_NODE && !strcmp((const char *)
+                                                   n->name, "metadata"))
         {
-            xmlChar *sortkey = xmlGetProp(n, "sortkey");
-            r->num_metadata++;
-            if (sortkey && strcmp(sortkey, "no"))
-                r->num_sortkeys++;
+            xmlChar *sortkey = xmlGetProp(n, (xmlChar *) "sortkey");
+            num_metadata++;
+            if (sortkey && strcmp((const char *) sortkey, "no"))
+                num_sortkeys++;
             xmlFree(sortkey);
         }
-    if (r->num_metadata)
-        r->metadata = nmem_malloc(nmem, sizeof(struct conf_metadata) * r->num_metadata);
-    else
-        r->metadata = 0;
-    if (r->num_sortkeys)
-        r->sortkeys = nmem_malloc(nmem, sizeof(struct conf_sortkey) * r->num_sortkeys);
-    else
-        r->sortkeys = 0;
+
+    service = conf_service_create(nmem, num_metadata, num_sortkeys);    
 
     for (n = node->children; n; n = n->next)
     {
         if (n->type != XML_ELEMENT_NODE)
             continue;
-        if (!strcmp(n->name, "metadata"))
+        if (!strcmp((const char *) n->name, (const char *) "metadata"))
         {
-            struct conf_metadata *md = &r->metadata[md_node];
-            xmlChar *name = xmlGetProp(n, "name");
-            xmlChar *brief = xmlGetProp(n, "brief");
-            xmlChar *sortkey = xmlGetProp(n, "sortkey");
-            xmlChar *merge = xmlGetProp(n, "merge");
-            xmlChar *type = xmlGetProp(n, "type");
-            xmlChar *termlist = xmlGetProp(n, "termlist");
-            xmlChar *rank = xmlGetProp(n, "rank");
-
-            if (!name)
+            xmlChar *xml_name = xmlGetProp(n, (xmlChar *) "name");
+            xmlChar *xml_brief = xmlGetProp(n, (xmlChar *) "brief");
+            xmlChar *xml_sortkey = xmlGetProp(n, (xmlChar *) "sortkey");
+            xmlChar *xml_merge = xmlGetProp(n, (xmlChar *) "merge");
+            xmlChar *xml_type = xmlGetProp(n, (xmlChar *) "type");
+            xmlChar *xml_termlist = xmlGetProp(n, (xmlChar *) "termlist");
+            xmlChar *xml_rank = xmlGetProp(n, (xmlChar *) "rank");
+
+            enum conf_metadata_type type = Metadata_type_generic;
+            enum conf_metadata_merge merge = Metadata_merge_no;
+            int brief = 0;
+            int termlist = 0;
+            int rank = 0;
+            int sortkey_offset = 0;
+            enum conf_sortkey_type sk_type = Metadata_sortkey_relevance;
+            
+            // now do the parsing logic
+            if (!xml_name)
             {
                 yaz_log(YLOG_FATAL, "Must specify name in metadata element");
                 return 0;
             }
-            md->name = nmem_strdup(nmem, name);
-            if (brief)
+            if (xml_brief)
             {
-                if (!strcmp(brief, "yes"))
-                    md->brief = 1;
-                else if (strcmp(brief, "no"))
+                if (!strcmp((const char *) xml_brief, "yes"))
+                    brief = 1;
+                 else if (strcmp((const char *) xml_brief, "no"))
                 {
                     yaz_log(YLOG_FATAL, "metadata/brief must be yes or no");
                     return 0;
                 }
             }
             else
-                md->brief = 0;
+                brief = 0;
 
-            if (termlist)
+            if (xml_termlist)
             {
-                if (!strcmp(termlist, "yes"))
-                    md->termlist = 1;
-                else if (strcmp(termlist, "no"))
+                if (!strcmp((const char *) xml_termlist, "yes"))
+                    termlist = 1;
+                else if (strcmp((const char *) xml_termlist, "no"))
                 {
                     yaz_log(YLOG_FATAL, "metadata/termlist must be yes or no");
                     return 0;
                 }
             }
             else
-                md->termlist = 0;
+                termlist = 0;
 
-            if (rank)
-                md->rank = atoi(rank);
+            if (xml_rank)
+                rank = atoi((const char *) xml_rank);
             else
-                md->rank = 0;
+                rank = 0;
 
-            if (type)
+            if (xml_type)
             {
-                if (!strcmp(type, "generic"))
-                    md->type = Metadata_type_generic;
-                else if (!strcmp(type, "year"))
-                    md->type = Metadata_type_year;
+                if (!strcmp((const char *) xml_type, "generic"))
+                    type = Metadata_type_generic;
+                else if (!strcmp((const char *) xml_type, "year"))
+                    type = Metadata_type_year;
                 else
                 {
-                    yaz_log(YLOG_FATAL, "Unknown value for metadata/type: %s", type);
+                    yaz_log(YLOG_FATAL, "Unknown value for metadata/type: %s", xml_type);
                     return 0;
                 }
             }
             else
-                md->type = Metadata_type_generic;
+                type = Metadata_type_generic;
 
-            if (merge)
+            if (xml_merge)
             {
-                if (!strcmp(merge, "no"))
-                    md->merge = Metadata_merge_no;
-                else if (!strcmp(merge, "unique"))
-                    md->merge = Metadata_merge_unique;
-                else if (!strcmp(merge, "longest"))
-                    md->merge = Metadata_merge_longest;
-                else if (!strcmp(merge, "range"))
-                    md->merge = Metadata_merge_range;
-                else if (!strcmp(merge, "all"))
-                    md->merge = Metadata_merge_all;
+                if (!strcmp((const char *) xml_merge, "no"))
+                    merge = Metadata_merge_no;
+                else if (!strcmp((const char *) xml_merge, "unique"))
+                    merge = Metadata_merge_unique;
+                else if (!strcmp((const char *) xml_merge, "longest"))
+                    merge = Metadata_merge_longest;
+                else if (!strcmp((const char *) xml_merge, "range"))
+                    merge = Metadata_merge_range;
+                else if (!strcmp((const char *) xml_merge, "all"))
+                    merge = Metadata_merge_all;
                 else
                 {
-                    yaz_log(YLOG_FATAL, "Unknown value for metadata/merge: %s", merge);
+                    yaz_log(YLOG_FATAL, 
+                            "Unknown value for metadata/merge: %s", xml_merge);
                     return 0;
                 }
             }
             else
-                md->merge = Metadata_merge_no;
+                merge = Metadata_merge_no;
 
-            if (sortkey && strcmp(sortkey, "no"))
+            // add a sortkey if so specified
+            if (xml_sortkey && strcmp((const char *) xml_sortkey, "no"))
             {
-                struct conf_sortkey *sk = &r->sortkeys[sk_node];
-                if (md->merge == Metadata_merge_no)
+                if (merge == Metadata_merge_no)
                 {
-                    yaz_log(YLOG_FATAL, "Can't specify sortkey on a non-merged field");
+                    yaz_log(YLOG_FATAL, 
+                            "Can't specify sortkey on a non-merged field");
                     return 0;
                 }
-                if (!strcmp(sortkey, "numeric"))
-                    sk->type = Metadata_sortkey_numeric;
-                else if (!strcmp(sortkey, "skiparticle"))
-                    sk->type = Metadata_sortkey_skiparticle;
+                if (!strcmp((const char *) xml_sortkey, "numeric"))
+                    sk_type = Metadata_sortkey_numeric;
+                else if (!strcmp((const char *) xml_sortkey, "skiparticle"))
+                    sk_type = Metadata_sortkey_skiparticle;
                 else
                 {
-                    yaz_log(YLOG_FATAL, "Unknown sortkey in metadata element: %s", sortkey);
+                    yaz_log(YLOG_FATAL,
+                            "Unknown sortkey in metadata element: %s", 
+                            xml_sortkey);
                     return 0;
                 }
-                sk->name = md->name;
-                md->sortkey_offset = sk_node;
+                sortkey_offset = sk_node;
+
+                conf_service_add_sortkey(nmem, service, sk_node,
+                                         (const char *) xml_name, sk_type);
+                
                 sk_node++;
             }
             else
-                md->sortkey_offset = -1;
-
-            xmlFree(name);
-            xmlFree(brief);
-            xmlFree(sortkey);
-            xmlFree(merge);
-            xmlFree(termlist);
-            xmlFree(rank);
+                sortkey_offset = -1;
+
+            // metadata known, assign values
+            conf_service_add_metadata(nmem, service, md_node,
+                                      (const char *) xml_name,
+                                      type, merge,
+                                      brief, termlist, rank, sortkey_offset);
+
+            xmlFree(xml_name);
+            xmlFree(xml_brief);
+            xmlFree(xml_sortkey);
+            xmlFree(xml_merge);
+            xmlFree(xml_type);
+            xmlFree(xml_termlist);
+            xmlFree(xml_rank);
             md_node++;
         }
         else
@@ -179,6 +361,22 @@ static struct conf_service *parse_service(xmlNode *node)
             return 0;
         }
     }
+    return service;
+}
+
+static char *parse_settings(xmlNode *node)
+{
+    xmlChar *src = xmlGetProp(node, (xmlChar *) "src");
+    char *r;
+
+    if (src)
+        r = nmem_strdup(nmem, (const char *) src);
+    else
+    {
+        yaz_log(YLOG_FATAL, "Must specify src in targetprofile");
+        return 0;
+    }
+    xmlFree(src);
     return r;
 }
 
@@ -191,36 +389,77 @@ static struct conf_server *parse_server(xmlNode *node)
     r->port = 0;
     r->proxy_host = 0;
     r->proxy_port = 0;
+    r->myurl = 0;
+    r->zproxy_host = 0;
+    r->zproxy_port = 0;
     r->service = 0;
     r->next = 0;
+    r->settings = 0;
 
     for (n = node->children; n; n = n->next)
     {
         if (n->type != XML_ELEMENT_NODE)
             continue;
-        if (!strcmp(n->name, "listen"))
+        if (!strcmp((const char *) n->name, "listen"))
         {
-            xmlChar *port = xmlGetProp(n, "port");
-            xmlChar *host = xmlGetProp(n, "host");
+            xmlChar *port = xmlGetProp(n, (xmlChar *) "port");
+            xmlChar *host = xmlGetProp(n, (xmlChar *) "host");
             if (port)
-                r->port = atoi(port);
+                r->port = atoi((const char *) port);
             if (host)
-                r->host = nmem_strdup(nmem, host);
+                r->host = nmem_strdup(nmem, (const char *) host);
             xmlFree(port);
             xmlFree(host);
         }
-        else if (!strcmp(n->name, "proxy"))
+        else if (!strcmp((const char *) n->name, "proxy"))
         {
-            xmlChar *port = xmlGetProp(n, "port");
-            xmlChar *host = xmlGetProp(n, "host");
+            xmlChar *port = xmlGetProp(n, (xmlChar *) "port");
+            xmlChar *host = xmlGetProp(n, (xmlChar *) "host");
+            xmlChar *myurl = xmlGetProp(n, (xmlChar *) "myurl");
             if (port)
-                r->proxy_port = atoi(port);
+                r->proxy_port = atoi((const char *) port);
             if (host)
-                r->proxy_host = nmem_strdup(nmem, host);
+                r->proxy_host = nmem_strdup(nmem, (const char *) host);
+            if (myurl)
+                r->myurl = nmem_strdup(nmem, (const char *) myurl);
+#ifdef GAGA
+            else
+            {
+                yaz_log(YLOG_FATAL, "Must specify @myurl for proxy");
+                return 0;
+            }
+#endif
             xmlFree(port);
             xmlFree(host);
+            xmlFree(myurl);
         }
-        else if (!strcmp(n->name, "service"))
+        else if (!strcmp((const char *) n->name, "zproxy"))
+        {
+            xmlChar *port = 0;
+            xmlChar *host = 0;
+
+            port = xmlGetProp(n, (xmlChar *) "port");
+            host = xmlGetProp(n, (xmlChar *) "host");
+
+            if (port)
+                r->zproxy_port = atoi((const char *) port);
+            if (host)
+                r->zproxy_host = nmem_strdup(nmem, (const char *) host);
+
+            xmlFree(port);
+            xmlFree(host);
+        }
+        else if (!strcmp((const char *) n->name, "settings"))
+        {
+            if (r->settings)
+            {
+                yaz_log(YLOG_FATAL, "Can't repeat 'settings'");
+                return 0;
+            }
+            if (!(r->settings = parse_settings(n)))
+                return 0;
+        }
+        else if (!strcmp((const char *) n->name, "service"))
         {
             struct conf_service *s = parse_service(n);
             if (!s)
@@ -236,148 +475,46 @@ static struct conf_server *parse_server(xmlNode *node)
     return r;
 }
 
-static xsltStylesheet *load_stylesheet(const char *fname)
+xsltStylesheet *conf_load_stylesheet(const char *fname)
 {
     char path[256];
     sprintf(path, "%s/%s", confdir, fname);
-    return xsltParseStylesheetFile(path);
+    return xsltParseStylesheetFile((xmlChar *) path);
 }
 
-static void setup_marc(struct conf_retrievalprofile *r)
+static struct conf_targetprofiles *parse_targetprofiles(xmlNode *node)
 {
-    yaz_iconv_t cm;
-    r->yaz_marc = yaz_marc_create();
-    if (!(cm = yaz_iconv_open("utf-8", r->native_encoding)))
-    {
-        yaz_log(YLOG_WARN, "Unable to support mapping from %s", r->native_encoding);
-        return;
-    }
-    yaz_marc_iconv(r->yaz_marc, cm);
-}
+    struct conf_targetprofiles *r = nmem_malloc(nmem, sizeof(*r));
+    xmlChar *type = xmlGetProp(node, (xmlChar *) "type");
+    xmlChar *src = xmlGetProp(node, (xmlChar *) "src");
 
-static struct conf_retrievalprofile *parse_retrievalprofile(xmlNode *node)
-{
-    struct conf_retrievalprofile *r = nmem_malloc(nmem, sizeof(struct conf_retrievalprofile));
-    xmlNode *n;
-    struct conf_retrievalmap **rm = &r->maplist;
-
-    r->requestsyntax = 0;
-    r->native_syntax = Nativesyn_xml;
-    r->native_format = Nativeform_na;
-    r->native_encoding = 0;
-    r->native_mapto = Nativemapto_na;
-    r->yaz_marc = 0;
-    r->maplist = 0;
-    r->next = 0;
+    memset(r, 0, sizeof(*r));
 
-    for (n = node->children; n; n = n->next)
+    if (type)
     {
-        if (n->type != XML_ELEMENT_NODE)
-            continue;
-        if (!strcmp(n->name, "requestsyntax"))
-        {
-            xmlChar *content = xmlNodeGetContent(n);
-            if (content)
-                r->requestsyntax = nmem_strdup(nmem, content);
-        }
-        else if (!strcmp(n->name, "nativesyntax"))
-        {
-            xmlChar *name = xmlGetProp(n, "name");
-            xmlChar *format = xmlGetProp(n, "format");
-            xmlChar *encoding = xmlGetProp(n, "encoding");
-            xmlChar *mapto = xmlGetProp(n, "mapto");
-            if (!name)
-            {
-                yaz_log(YLOG_WARN, "Missing name in 'nativesyntax' element");
-                return 0;
-            }
-            if (encoding)
-                r->native_encoding = encoding;
-            if (!strcmp(name, "iso2709"))
-            {
-                r->native_syntax = Nativesyn_iso2709;
-                // Set a few defaults, too
-                r->native_format = Nativeform_marc21;
-                r->native_mapto = Nativemapto_marcxml;
-                if (!r->native_encoding)
-                    r->native_encoding = "marc-8";
-                setup_marc(r);
-            }
-            else if (!strcmp(name, "xml"))
-                r->native_syntax = Nativesyn_xml;
-            else
-            {
-                yaz_log(YLOG_WARN, "Unknown native syntax name %s", name);
-                return 0;
-            }
-            if (format)
-            {
-                if (!strcmp(format, "marc21") || !strcmp(format, "usmarc"))
-                    r->native_format = Nativeform_marc21;
-                else
-                {
-                    yaz_log(YLOG_WARN, "Unknown native format name %s", format);
-                    return 0;
-                }
-            }
-            if (mapto)
-            {
-                if (!strcmp(mapto, "marcxml"))
-                    r->native_mapto = Nativemapto_marcxml;
-                else if (!strcmp(mapto, "marcxchange"))
-                    r->native_mapto = Nativemapto_marcxchange;
-                else
-                {
-                    yaz_log(YLOG_WARN, "Unknown mapto target %s", format);
-                    return 0;
-                }
-            }
-            xmlFree(name);
-            xmlFree(format);
-            xmlFree(encoding);
-            xmlFree(mapto);
-        }
-        else if (!strcmp(n->name, "map"))
-        {
-            struct conf_retrievalmap *m = nmem_malloc(nmem, sizeof(struct conf_retrievalmap));
-            xmlChar *type = xmlGetProp(n, "type");
-            xmlChar *charset = xmlGetProp(n, "charset");
-            xmlChar *format = xmlGetProp(n, "format");
-            xmlChar *stylesheet = xmlGetProp(n, "stylesheet");
-            memset(m, 0, sizeof(*m));
-            if (type)
-            {
-                if (!strcmp(type, "xslt"))
-                    m->type = Map_xslt;
-                else
-                {
-                    yaz_log(YLOG_WARN, "Unknown map type: %s", type);
-                    return 0;
-                }
-            }
-            if (charset)
-                m->charset = nmem_strdup(nmem, charset);
-            if (format)
-                m->format = nmem_strdup(nmem, format);
-            if (stylesheet)
-            {
-                if (!(m->stylesheet = load_stylesheet(stylesheet)))
-                    return 0;
-            }
-            *rm = m;
-            rm = &m->next;
-            xmlFree(type);
-            xmlFree(charset);
-            xmlFree(format);
-            xmlFree(stylesheet);
-        }
+        if (!strcmp((const char *) type, "local"))
+            r->type = Targetprofiles_local;
         else
         {
-            yaz_log(YLOG_FATAL, "Bad element in retrievalprofile: %s", n->name);
+            yaz_log(YLOG_FATAL, "Unknown targetprofile type");
             return 0;
         }
     }
+    else
+    {
+        yaz_log(YLOG_FATAL, "Must specify type for targetprofile");
+        return 0;
+    }
 
+    if (src)
+        r->src = nmem_strdup(nmem, (const char *) src);
+    else
+    {
+        yaz_log(YLOG_FATAL, "Must specify src in targetprofile");
+        return 0;
+    }
+    xmlFree(type);
+    xmlFree(src);
     return r;
 }
 
@@ -385,17 +522,15 @@ static struct conf_config *parse_config(xmlNode *root)
 {
     xmlNode *n;
     struct conf_config *r = nmem_malloc(nmem, sizeof(struct conf_config));
-    struct conf_retrievalprofile **rp = &r->retrievalprofiles;
 
     r->servers = 0;
-    r->queryprofiles = 0;
-    r->retrievalprofiles = 0;
+    r->targetprofiles = 0;
 
     for (n = root->children; n; n = n->next)
     {
         if (n->type != XML_ELEMENT_NODE)
             continue;
-        if (!strcmp(n->name, "server"))
+        if (!strcmp((const char *) n->name, "server"))
         {
             struct conf_server *tmp = parse_server(n);
             if (!tmp)
@@ -403,14 +538,16 @@ static struct conf_config *parse_config(xmlNode *root)
             tmp->next = r->servers;
             r->servers = tmp;
         }
-        else if (!strcmp(n->name, "queryprofile"))
-        {
-        }
-        else if (!strcmp(n->name, "retrievalprofile"))
+        else if (!strcmp((const char *) n->name, "targetprofiles"))
         {
-            if (!(*rp = parse_retrievalprofile(n)))
+            // It would be fun to be able to fix this sometime
+            if (r->targetprofiles)
+            {
+                yaz_log(YLOG_FATAL, "Can't repeat targetprofiles");
+                return 0;
+            }
+            if (!(r->targetprofiles = parse_targetprofiles(n)))
                 return 0;
-            rp = &(*rp)->next;
         }
         else
         {