X-Git-Url: http://git.indexdata.com/?a=blobdiff_plain;f=odr%2Fber_bit.c;h=d82e116e27537ddb35bc6a2c47276980f391d64c;hb=0442642bb213139271943552e5c1bc731ee96872;hp=e82c2d51f7285a6c8c69a59d7ec7d08b4ee52b5f;hpb=4d531a1a9131d69c3b6c27fbac42837e22cff61c;p=yaz-moved-to-github.git

diff --git a/odr/ber_bit.c b/odr/ber_bit.c
index e82c2d5..d82e116 100644
--- a/odr/ber_bit.c
+++ b/odr/ber_bit.c
@@ -3,7 +3,7 @@
  * See the file LICENSE for details.
  * Sebastian Hammer, Adam Dickmeiss
  *
- * $Id: ber_bit.c,v 1.14 2003-01-06 08:20:27 adam Exp $
+ * $Id: ber_bit.c,v 1.16 2003-05-20 19:50:12 adam Exp $
  *
  */
 #if HAVE_CONFIG_H
@@ -19,51 +19,59 @@ int ber_bitstring(ODR o, Odr_bitmask *p, int cons)
 
     switch (o->direction)
     {
-    	case ODR_DECODE:
-	    if ((res = ber_declen(o->bp, &len)) < 0)
-	    {
-	    	o->error = OPROTO;
-	    	return 0;
-	    }
-	    o->bp += res;
-	    if (cons)       /* fetch component strings */
-	    {
-	    	base = o->bp;
-	    	while (odp_more_chunks(o, base, len))
-		    if (!odr_bitstring(o, &p, 0, 0))
-		    	return 0;
-		return 1;
-	    }
-	    /* primitive bitstring */
-	    if (len < 0)
-	    {
-	    	o->error = OOTHER;
-	    	return 0;
-	    }
-	    if (len == 0)
-	    	return 1;
-	    if (len - 1 > ODR_BITMASK_SIZE)
-	    {
-	    	o->error = OOTHER;
-	    	return 0;
-	    }
-	    o->bp++;      /* silently ignore the unused-bits field */
-	    len--;
-	    memcpy(p->bits + p->top + 1, o->bp, len);
-	    p->top += len;
-	    o->bp += len;
-	    return 1;
-    	case ODR_ENCODE:
-	    if ((res = ber_enclen(o, p->top + 2, 5, 0)) < 0)
-	    	return 0;
-	    if (odr_putc(o, 0) < 0)    /* no unused bits here */
-	    	return 0;
-	    if (p->top < 0)
-	    	return 1;
-	    if (odr_write(o, p->bits, p->top + 1) < 0)
-	    	return 0;
-	    return 1;
-    	case ODR_PRINT: return 1;
-    	default: o->error = OOTHER; return 0;
+    case ODR_DECODE:
+        if ((res = ber_declen(o->bp, &len, odr_max(o))) < 0)
+        {
+            odr_seterror(o, OPROTO, 4);
+            return 0;
+        }
+        o->bp += res;
+        if (cons)       /* fetch component strings */
+        {
+            base = o->bp;
+            while (odp_more_chunks(o, base, len))
+                if (!odr_bitstring(o, &p, 0, 0))
+                    return 0;
+            return 1;
+        }
+        /* primitive bitstring */
+        if (len < 0)
+        {
+            odr_seterror(o, OOTHER, 5);
+            return 0;
+        }
+        if (len == 0)
+            return 1;
+        if (len - 1 > ODR_BITMASK_SIZE)
+        {
+            odr_seterror(o, OOTHER, 6);
+            return 0;
+        }
+        if (len > odr_max(o))
+        {
+            odr_seterror(o, OOTHER, 7);
+            return 0;
+        }
+        o->bp++;      /* silently ignore the unused-bits field */
+        len--;
+        memcpy(p->bits + p->top + 1, o->bp, len);
+        p->top += len;
+        o->bp += len;
+        return 1;
+    case ODR_ENCODE:
+        if ((res = ber_enclen(o, p->top + 2, 5, 0)) < 0)
+            return 0;
+        if (odr_putc(o, 0) < 0)    /* no unused bits here */
+            return 0;
+        if (p->top < 0)
+            return 1;
+        if (odr_write(o, p->bits, p->top + 1) < 0)
+            return 0;
+        return 1;
+    case ODR_PRINT:
+        return 1;
+    default: 
+        odr_seterror(o, OOTHER, 8);
+        return 0;
     }
 }