X-Git-Url: http://git.indexdata.com/?a=blobdiff_plain;f=odr%2Fber_any.c;h=6492398d4c2fb9995353df3b42152db413c4e7bf;hb=adc5e45a46d9ce4f73370332f6e4c2f81c1d36fe;hp=84d07a6727af00a6c9ee1babd0eaef5d87bc83e8;hpb=fb2db0abc51ed82583dc4600fd4ff035c96f7d79;p=yaz-moved-to-github.git

diff --git a/odr/ber_any.c b/odr/ber_any.c
index 84d07a6..6492398 100644
--- a/odr/ber_any.c
+++ b/odr/ber_any.c
@@ -4,7 +4,13 @@
  * Sebastian Hammer, Adam Dickmeiss
  *
  * $Log: ber_any.c,v $
- * Revision 1.4  1995-02-14 11:54:33  quinn
+ * Revision 1.6  1995-03-08 12:12:02  quinn
+ * Added better error checking.
+ *
+ * Revision 1.5  1995/02/14  20:39:54  quinn
+ * Fixed bugs in completeBER and (serious one in) ber_oid.
+ *
+ * Revision 1.4  1995/02/14  11:54:33  quinn
  * Adjustments.
  *
  * Revision 1.3  1995/02/10  18:57:24  quinn
@@ -27,8 +33,11 @@ int ber_any(ODR o, Odr_any **p)
     switch (o->direction)
     {
     	case ODR_DECODE:
-	    if ((res = completeBER(o->bp, 1000)) <= 0)        /* FIX THIS */
+	    if ((res = completeBER(o->bp, o->left)) <= 0)        /* FIX THIS */
+	    {
+	    	o->error = OPROTO;
 	    	return 0;
+	    }
 	    (*p)->buf = nalloc(o, res);
 	    memcpy((*p)->buf, o->bp, res);
 	    (*p)->len = (*p)->size = res;
@@ -37,12 +46,15 @@ int ber_any(ODR o, Odr_any **p)
 	    return 1;
     	case ODR_ENCODE:
 	    if ((*p)->len > o->left)
+	    {
+	    	o->error = OSPACE;
 	    	return 0;
+	    }
 	    memcpy(o->bp , (*p)->buf, (*p)->len);
 	    o->bp += (*p)->len;
 	    o->left -= (*p)->len;
 	    return 1;
-    	default: return 0;
+    	default: o->error = OOTHER; return 0;
     }
 }
 
@@ -54,6 +66,8 @@ int completeBER(unsigned char *buf, int len)
     int res, ll, class, tag, cons;
     unsigned char *b = buf;
     
+    if (!len)
+    	return 0;
     if (!buf[0] && !buf[1])
     	return 0;
     if ((res = ber_dectag(b, &class, &tag, &cons)) <= 0)
@@ -72,15 +86,15 @@ int completeBER(unsigned char *buf, int len)
     	return (len >= ll ? ll + (b-buf) : 0);
     if (!cons)
     	return 0;    
-    while (1)
+    /* constructed - cycle through children */
+    while (len >= 2)
     {
+	if (*b == 0 && *(b + 1) == 0)
+	    break;
 	if (!(res = completeBER(b, len)))
 	    return 0;
 	b += res;
 	len -= res;
-	if (len < 2)
-	    return 0;
-	if (*b == 0 && *(b + 1) == 0)
-	    return (b - buf) + 2;
     }
+    return (b - buf) + 2;
 }