X-Git-Url: http://git.indexdata.com/?a=blobdiff_plain;f=lib%2FZOOM%2FIRSpy%2FUtils.pm;h=53e53fc033060711888dcf04c922243958eb48c3;hb=4f36c963da80271ffea671999e41aaa04ea9a36f;hp=eeffccced7a12a29bb0fc2e363d1f393c525bf8e;hpb=70f35e9d28e4b25f763baee0602e2eac25264ebf;p=irspy-moved-to-github.git

diff --git a/lib/ZOOM/IRSpy/Utils.pm b/lib/ZOOM/IRSpy/Utils.pm
index eeffccc..53e53fc 100644
--- a/lib/ZOOM/IRSpy/Utils.pm
+++ b/lib/ZOOM/IRSpy/Utils.pm
@@ -181,6 +181,7 @@ sub cql_target {
     }
 
     return "rec.id=" . cql_quote($id);
+    #return "rec.id_raw=" . cql_quote($id);
 }
 
 
@@ -284,13 +285,14 @@ sub _irspy_identifier2target {
     confess "_irspy_identifier2target(): id is undefined"
 	if !defined $id;
 
-    my($protocol, $target) = ($id =~ /(.*?):(.*)/);
+    my($prefix, $protocol, $target) = ($id =~ /([^:]*,)?(.*?):(.*)/);
+    $prefix ||= "";
     if (uc($protocol) eq "Z39.50" || uc($protocol) eq "TCP") {
-	return "tcp:$target";
+	return "${prefix}tcp:$target";
     } elsif (uc($protocol) eq "SRU") {
-	return "sru=get,http:$target";
+	return "${prefix}sru=get,http:$target";
     } elsif (uc($protocol) eq "SRW") {
-	return "sru=srw,http:$target";
+	return "${prefix}sru=srw,http:$target";
     }
 
     warn "_irspy_identifier2target($id): unrecognised protocol '$protocol'";
@@ -812,11 +814,21 @@ sub calc_reliability_string {
 sub calc_reliability_stats {
     my($xc) = @_;
 
+    my $sixtyDaysAgo = time() - 60*24*60*60;
+    my $iso60DA = isodate($sixtyDaysAgo);
     my @allpings = $xc->findnodes("i:status/i:probe");
-    my $nall = @allpings;
+
+    my($nall, $nok) = (0, 0);
+    foreach my $node (@allpings) {
+	my $ok = $xc->findvalue('@ok', $node);
+	my $when = $node->to_literal();
+	#warn "$when cmp $iso60DA == ", ($when cmp $iso60DA), "\n";
+	next if $when lt $iso60DA;
+	$nall++;
+	$nok += !!$ok;
+    }
+
     return (0, 0, 0) if $nall == 0;
-    my @okpings = $xc->findnodes('i:status/i:probe[@ok = "1"]');
-    my $nok = @okpings;
     my $percent = int(100*$nok/$nall + 0.5);
     return ($nok, $nall, $percent);
 }
@@ -828,7 +840,7 @@ sub validate_record {
     my $rec = shift;
     my %args = @_;
 
-    my %required = map { $_ => 1 } qw/port host database/;
+    my %required = map { $_ => 1 } qw/port host database protocol/;
     my %optional = map { $_ => 1 } qw/country type hosturl contact language/;
     my %tests = ( %required, %args );
 
@@ -841,18 +853,27 @@ sub validate_record {
 
     my $id = irspy_make_identifier($protocol, $host, $port, $dbname);
 
+    if ($protocol =~ /\s+$/ || $dbname =~ /\s+$/) {
+	warn "xxx: $protocol:$host:$port:$dbname: whitespaces\n";
+    } 
+
     my @errors = $id;
 
+    if ($tests{'protocol'}) {
+	push(@errors, 'protocol number is not valid') if $protocol !~ /^(z39\.50|sru|srw|tcp)$/i;
+    }
+
     if ($tests{'port'}) {
-	push(@errors, 'This port number is not valid') if $port !~ /^\d+$/;
+	push(@errors, 'port number is not valid') if $port !~ /^\d+$/;
     }
 
     if ($tests{'host'}) {
-	push(@errors, 'This host name is not valid') if $host !~ /^[0-9a-z]+[0-9a-z\.\-]*\.[0-9a-z]+$/i;
+	push(@errors, 'host name is not valid') if $host !~ /^[0-9a-z]+[0-9a-z\.\-]*\.[0-9a-z]+$/i;
     }
 
     if ($tests{'database'}) {
-	push(@errors, 'This database name is not valid') if $dbname !~ /^[\w_\-\.]+$/i;
+	push(@errors, 'database name is not valid') if $dbname =~ m,/,i;
+	push(@errors, 'database has trailing spaces') if $dbname =~ /^\s+|\s+$/;
     }
 
     if ($tests{'hosturl'}) {